From: Anson Huang <anson.huang@nxp.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Russell King - ARM Linux <linux@armlinux.org.uk>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Sascha Hauer <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Stefan Agner <stefan.agner@toradex.com>, "oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Leo Li <leoyang.li@nxp.com>, Vinod Koul <vkoul@kernel.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Olof Johansson <olof@lixom.net>, Linux ARM <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH 1/3] reset: imx7: Support module build Date: Mon, 29 Jun 2020 10:45:07 +0000 [thread overview] Message-ID: <DB3PR0402MB3916292FC3FDE4F28AFEB5EBF56E0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CAK8P3a1pr8YbZMpSXg6o_UeDvaU=dDqfo45DudTASNcsxeg3kg@mail.gmail.com> > Subject: Re: [PATCH 1/3] reset: imx7: Support module build > > On Mon, Jun 29, 2020 at 12:25 PM Anson Huang <Anson.Huang@nxp.com> > wrote: > > > > Add module device table, module license to support module build. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > drivers/reset/Kconfig | 4 ++-- > > drivers/reset/reset-imx7.c | 4 +++- > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index > > d9efbfd..033ab60 100644 > > --- a/drivers/reset/Kconfig > > +++ b/drivers/reset/Kconfig > > @@ -65,9 +65,9 @@ config RESET_HSDK > > This enables the reset controller driver for HSDK board. > > > > config RESET_IMX7 > > - bool "i.MX7/8 Reset Driver" if COMPILE_TEST > > + tristate "i.MX7/8 Reset Driver" > > depends on HAS_IOMEM > > - default SOC_IMX7D || (ARM64 && ARCH_MXC) > > + depends on SOC_IMX7D || (ARM64 && ARCH_MXC) || > COMPILE_TEST > > select MFD_SYSCON > > You are dropping the 'default' line, so the driver is now disabled in a defconfig > build, which is not mentioned in the patch description. > > Maybe make it 'default m'? > > config RESET_IMX7 > tristate "i.MX7/8 Reset Driver" > depends on HAS_IOMEM > depends on SOC_IMX7D || (ARM64 && ARCH_MXC) || > COMPILE_TEST > default m if (SOC_IMX7D || (ARM64 && ARCH_MXC)) > select MFD_SYSCON > > > @@ -395,3 +396,4 @@ static struct platform_driver imx7_reset_driver = { > > }, > > }; > > builtin_platform_driver(imx7_reset_driver); > > +MODULE_LICENSE("GPL v2"); > > Generally speaking: when you add a MODULE_LICENSE tag, please also add > MODULE_AUTHOR and MODULE_DESCRIPTION. > OK, will add them in V2. > The 'builtin_platform_driver()' should work correctly but prevent unloading > the module. Ideally please changed to 'module_platform_driver()' and add > a .remove function for the platform_driver. > The reset driver normally won't be removed since it is necessary for drivers which need it, it is just for Android GKI support, in this case, do we need to change it to module_platform_driver()? Thanks, Anson
WARNING: multiple messages have this Message-ID (diff)
From: Anson Huang <anson.huang@nxp.com> To: Arnd Bergmann <arnd@arndb.de> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Will Deacon <will@kernel.org>, Stefan Agner <stefan.agner@toradex.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Russell King - ARM Linux <linux@armlinux.org.uk>, Bjorn Andersson <bjorn.andersson@linaro.org>, "oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>, Vinod Koul <vkoul@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, Sascha Hauer <kernel@pengutronix.de>, Catalin Marinas <catalin.marinas@arm.com>, Olof Johansson <olof@lixom.net>, Geert Uytterhoeven <geert+renesas@glider.be>, Leo Li <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH 1/3] reset: imx7: Support module build Date: Mon, 29 Jun 2020 10:45:07 +0000 [thread overview] Message-ID: <DB3PR0402MB3916292FC3FDE4F28AFEB5EBF56E0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CAK8P3a1pr8YbZMpSXg6o_UeDvaU=dDqfo45DudTASNcsxeg3kg@mail.gmail.com> > Subject: Re: [PATCH 1/3] reset: imx7: Support module build > > On Mon, Jun 29, 2020 at 12:25 PM Anson Huang <Anson.Huang@nxp.com> > wrote: > > > > Add module device table, module license to support module build. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > drivers/reset/Kconfig | 4 ++-- > > drivers/reset/reset-imx7.c | 4 +++- > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index > > d9efbfd..033ab60 100644 > > --- a/drivers/reset/Kconfig > > +++ b/drivers/reset/Kconfig > > @@ -65,9 +65,9 @@ config RESET_HSDK > > This enables the reset controller driver for HSDK board. > > > > config RESET_IMX7 > > - bool "i.MX7/8 Reset Driver" if COMPILE_TEST > > + tristate "i.MX7/8 Reset Driver" > > depends on HAS_IOMEM > > - default SOC_IMX7D || (ARM64 && ARCH_MXC) > > + depends on SOC_IMX7D || (ARM64 && ARCH_MXC) || > COMPILE_TEST > > select MFD_SYSCON > > You are dropping the 'default' line, so the driver is now disabled in a defconfig > build, which is not mentioned in the patch description. > > Maybe make it 'default m'? > > config RESET_IMX7 > tristate "i.MX7/8 Reset Driver" > depends on HAS_IOMEM > depends on SOC_IMX7D || (ARM64 && ARCH_MXC) || > COMPILE_TEST > default m if (SOC_IMX7D || (ARM64 && ARCH_MXC)) > select MFD_SYSCON > > > @@ -395,3 +396,4 @@ static struct platform_driver imx7_reset_driver = { > > }, > > }; > > builtin_platform_driver(imx7_reset_driver); > > +MODULE_LICENSE("GPL v2"); > > Generally speaking: when you add a MODULE_LICENSE tag, please also add > MODULE_AUTHOR and MODULE_DESCRIPTION. > OK, will add them in V2. > The 'builtin_platform_driver()' should work correctly but prevent unloading > the module. Ideally please changed to 'module_platform_driver()' and add > a .remove function for the platform_driver. > The reset driver normally won't be removed since it is necessary for drivers which need it, it is just for Android GKI support, in this case, do we need to change it to module_platform_driver()? Thanks, Anson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-29 21:01 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-29 10:13 [PATCH 1/3] reset: imx7: Support module build Anson Huang 2020-06-29 10:13 ` Anson Huang 2020-06-29 10:13 ` [PATCH 2/3] arm64: defconfig: Select CONFIG_RESET_IMX7 by default Anson Huang 2020-06-29 10:13 ` Anson Huang 2020-06-29 11:29 ` Arnd Bergmann 2020-06-29 11:29 ` Arnd Bergmann 2020-06-29 11:34 ` Anson Huang 2020-06-29 11:34 ` Anson Huang 2020-06-29 11:53 ` Arnd Bergmann 2020-06-29 11:53 ` Arnd Bergmann 2020-06-29 12:09 ` Anson Huang 2020-06-29 12:09 ` Anson Huang 2020-06-29 12:30 ` Arnd Bergmann 2020-06-29 12:30 ` Arnd Bergmann 2020-06-29 12:46 ` Anson Huang 2020-06-29 12:46 ` Anson Huang 2020-06-29 12:55 ` Arnd Bergmann 2020-06-29 12:55 ` Arnd Bergmann 2020-06-29 10:13 ` [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D Anson Huang 2020-06-29 10:13 ` Anson Huang 2020-06-29 11:31 ` Arnd Bergmann 2020-06-29 11:31 ` Arnd Bergmann 2020-06-29 11:36 ` Anson Huang 2020-06-29 11:36 ` Anson Huang 2020-06-29 11:47 ` Arnd Bergmann 2020-06-29 11:47 ` Arnd Bergmann 2020-06-29 11:54 ` Anson Huang 2020-06-29 11:54 ` Anson Huang 2020-06-29 12:02 ` Arnd Bergmann 2020-06-29 12:02 ` Arnd Bergmann 2020-06-29 10:41 ` [PATCH 1/3] reset: imx7: Support module build Arnd Bergmann 2020-06-29 10:41 ` Arnd Bergmann 2020-06-29 10:45 ` Anson Huang [this message] 2020-06-29 10:45 ` Anson Huang 2020-06-29 11:28 ` Arnd Bergmann 2020-06-29 11:28 ` Arnd Bergmann 2020-06-29 11:32 ` Anson Huang 2020-06-29 11:32 ` Anson Huang 2020-06-29 11:41 ` Arnd Bergmann 2020-06-29 11:41 ` Arnd Bergmann 2020-06-29 11:44 ` Anson Huang 2020-06-29 11:44 ` Anson Huang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB3PR0402MB3916292FC3FDE4F28AFEB5EBF56E0@DB3PR0402MB3916.eurprd04.prod.outlook.com \ --to=anson.huang@nxp.com \ --cc=arnd@arndb.de \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=festevam@gmail.com \ --cc=geert+renesas@glider.be \ --cc=kernel@pengutronix.de \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=oleksandr.suvorov@toradex.com \ --cc=olof@lixom.net \ --cc=p.zabel@pengutronix.de \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=stefan.agner@toradex.com \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.