RE: [PATCH V7 1/3] watchdog: imx_sc: Add i.MX system controller watchdog support

From: Anson Huang <anson.huang@nxp.com>
To: Aisheng Dong <aisheng.dong@nxp.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	Andy Gross <andy.gross@linaro.org>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"maxime.ripard@bootlin.com" <maxime.ripard@bootlin.com>,
	"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
	"marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
	"olof@lixom.net" <olof@lixom.net>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V7 1/3] watchdog: imx_sc: Add i.MX system controller watchdog support
Date: Thu, 7 Mar 2019 14:13:21 +0000	[thread overview]
Message-ID: <DB3PR0402MB391641F558061A561162136CF54C0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM0PR04MB42118452D9B975337E3BDDAD804C0@AM0PR04MB4211.eurprd04.prod.outlook.com>

Best Regards!
Anson Huang

> -----Original Message-----
> From: Aisheng Dong
> Sent: 2019年3月7日 22:00
> To: Anson Huang <anson.huang@nxp.com>; catalin.marinas@arm.com;
> will.deacon@arm.com; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; wim@linux-watchdog.org;
> linux@roeck-us.net; Andy Gross <andy.gross@linaro.org>; heiko@sntech.de;
> horms+renesas@verge.net.au; arnd@arndb.de;
> maxime.ripard@bootlin.com; jagan@amarulasolutions.com;
> bjorn.andersson@linaro.org; enric.balletbo@collabora.com;
> marc.w.gonzalez@free.fr; olof@lixom.net; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> watchdog@vger.kernel.org
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: RE: [PATCH V7 1/3] watchdog: imx_sc: Add i.MX system controller
> watchdog support
> 
> [...]
> 
> > > As I replied in another mail, it actually does not depend on SCU.
> > > Let's wait for Rob's comment on whether we could move watchdog Out
> > > of SCU node.
> >
> > Per previous discussion, the dependency here is to prevent enabling
> > this module for platform without IMX SCU, although it does NOT use SCU
> > IPC call, but the SMC call trap into ARM-Trusted-Firmware will
> > eventually call SCU API, so it still depends on IMX SCU hardware, I am
> > NOT very sure if it is correct to remove it here.
> >
> 
> Then it's ATF depends on SCU, not this virtual watchdog based on ARM SIP,
> right?

But we don't have ATF driver in Linux kernel..., I am confused, anyway, if Guenter
agrees, I can remove this dependency here.

Anson.

> 
> Regards
> Dong Aisheng
> 
> > >
> > > > +	depends on HAVE_ARM_SMCCC
> > > > +	select WATCHDOG_CORE
> > > > +	help
> > > > +	  This is the driver for the system controller watchdog
> > > > +	  on the NXP i.MX SoCs with system controller inside.
> > > > +	  If you have one of these processors and wish to have
> > > > +	  watchdog support enabled, say Y, otherwise say N.
> > > > +