All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anson Huang <anson.huang@nxp.com>
To: Aisheng Dong <aisheng.dong@nxp.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	"linux@rempel-privat.de" <linux@rempel-privat.de>,
	Peng Fan <peng.fan@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V2] dt-bindings: firmware: imx: Move system control into dt-binding headfile
Date: Thu, 23 Apr 2020 22:28:52 +0000	[thread overview]
Message-ID: <DB3PR0402MB3916489B8ADCA1F487F7A748F5D30@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM6PR04MB4966AF54A95ACF4F33634AD080D30@AM6PR04MB4966.eurprd04.prod.outlook.com>



> Subject: RE: [PATCH V2] dt-bindings: firmware: imx: Move system control into
> dt-binding headfile
> 
> > From: Anson Huang <Anson.Huang@nxp.com>
> > Sent: Thursday, April 23, 2020 11:36 PM
> >
> > i.MX8 SoCs DTS file needs system control macro definitions, so move
> > them into dt-binding headfile, then include/linux/firmware/imx/types.h
> > can be removed and those drivers using it should be changed accordingly.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 
> You seems ignored my comments in V1.
> Usually we'd better to keep original author when sending patches if no
> fundamental changes.

Here is the details, the aim of this patch is to get rid of below patch in internal tree,
I did NOT check the details of internal tree and did the patch manually and did NOT 
check how many patches I need in internal tree in order to make the build passed. After
checking it, looks like there are 3 patches, 2 are from you, and 1 from Jacky. Since these patches
need to be squashed into 1 patch, also fix minor comment in code and improve the comment,
so, should I put you as author or Jacky as author??

commit cb6603999367aeae57004638a4b8e43ee618dbec
Author: Jacky Bai <ping.bai@nxp.com>
Date:   Mon Mar 9 14:41:44 2020 +0800

    thermal: imx_sc_thermal: fix the build break caused non existent types.h

    The types.h has been move to the dt-bindings/, so correct the included
    header file to fix the build break.

WARNING: multiple messages have this Message-ID (diff)
From: Anson Huang <anson.huang@nxp.com>
To: Aisheng Dong <aisheng.dong@nxp.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	"linux@rempel-privat.de" <linux@rempel-privat.de>,
	 Peng Fan <peng.fan@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V2] dt-bindings: firmware: imx: Move system control into dt-binding headfile
Date: Thu, 23 Apr 2020 22:28:52 +0000	[thread overview]
Message-ID: <DB3PR0402MB3916489B8ADCA1F487F7A748F5D30@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM6PR04MB4966AF54A95ACF4F33634AD080D30@AM6PR04MB4966.eurprd04.prod.outlook.com>



> Subject: RE: [PATCH V2] dt-bindings: firmware: imx: Move system control into
> dt-binding headfile
> 
> > From: Anson Huang <Anson.Huang@nxp.com>
> > Sent: Thursday, April 23, 2020 11:36 PM
> >
> > i.MX8 SoCs DTS file needs system control macro definitions, so move
> > them into dt-binding headfile, then include/linux/firmware/imx/types.h
> > can be removed and those drivers using it should be changed accordingly.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 
> You seems ignored my comments in V1.
> Usually we'd better to keep original author when sending patches if no
> fundamental changes.

Here is the details, the aim of this patch is to get rid of below patch in internal tree,
I did NOT check the details of internal tree and did the patch manually and did NOT 
check how many patches I need in internal tree in order to make the build passed. After
checking it, looks like there are 3 patches, 2 are from you, and 1 from Jacky. Since these patches
need to be squashed into 1 patch, also fix minor comment in code and improve the comment,
so, should I put you as author or Jacky as author??

commit cb6603999367aeae57004638a4b8e43ee618dbec
Author: Jacky Bai <ping.bai@nxp.com>
Date:   Mon Mar 9 14:41:44 2020 +0800

    thermal: imx_sc_thermal: fix the build break caused non existent types.h

    The types.h has been move to the dt-bindings/, so correct the included
    header file to fix the build break.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-04-23 22:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 15:35 [PATCH V2] dt-bindings: firmware: imx: Move system control into dt-binding headfile Anson Huang
2020-04-23 15:35 ` Anson Huang
2020-04-23 15:56 ` Aisheng Dong
2020-04-23 15:56   ` Aisheng Dong
2020-04-23 22:28   ` Anson Huang [this message]
2020-04-23 22:28     ` Anson Huang
2020-04-24  1:48     ` Aisheng Dong
2020-04-24  1:48       ` Aisheng Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB3PR0402MB3916489B8ADCA1F487F7A748F5D30@DB3PR0402MB3916.eurprd04.prod.outlook.com \
    --to=anson.huang@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.