All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anson Huang <anson.huang@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] clk: imx: pllv3: Fix fall through build warning
Date: Wed, 1 May 2019 09:33:46 +0000	[thread overview]
Message-ID: <DB3PR0402MB3916F59134DB9CF9837B43C1F53B0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <155664820799.168659.12393223246835475198@swboyd.mtv.corp.google.com>

Hi, Stephen
	I saw Gustavo already sent out a patch to fix these two warnings, so I will NOT sent the patch again, thanks.

> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@kernel.org]
> Sent: Wednesday, May 1, 2019 2:17 AM
> To: festevam@gmail.com; kernel@pengutronix.de; linux-arm-
> kernel@lists.infradead.org; linux-clk@vger.kernel.org; linux-
> kernel@vger.kernel.org; mturquette@baylibre.com;
> s.hauer@pengutronix.de; shawnguo@kernel.org; Anson Huang
> <anson.huang@nxp.com>; Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] clk: imx: pllv3: Fix fall through build warning
> 
> Quoting Anson Huang (2019-04-29 18:55:18)
> > Fix below fall through build warning:
> >
> > drivers/clk/imx/clk-pllv3.c:453:21: warning:
> > this statement may fall through [-Wimplicit-fallthrough=]
> >
> >    pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
> >                      ^
> > drivers/clk/imx/clk-pllv3.c:454:2: note: here
> >   case IMX_PLLV3_AV:
> >   ^~~~
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> 
> Gustavo says there are two warnings. Please compile test with the right
> options, add Reported-by tags when you get bug reports from someone, and
> add a Fixes tag and then resend.
> 
> >  drivers/clk/imx/clk-pllv3.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
> > index e892b9a..fbe4fe0 100644
> > --- a/drivers/clk/imx/clk-pllv3.c
> > +++ b/drivers/clk/imx/clk-pllv3.c
> > @@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type,
> const char *name,
> >         case IMX_PLLV3_AV_IMX7:
> >                 pll->num_offset = PLL_IMX7_NUM_OFFSET;
> >                 pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
> > +               /* fall through */
> >         case IMX_PLLV3_AV:
> >                 ops = &clk_pllv3_av_ops;
> >                 break;

WARNING: multiple messages have this Message-ID (diff)
From: Anson Huang <anson.huang@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	 "shawnguo@kernel.org" <shawnguo@kernel.org>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] clk: imx: pllv3: Fix fall through build warning
Date: Wed, 1 May 2019 09:33:46 +0000	[thread overview]
Message-ID: <DB3PR0402MB3916F59134DB9CF9837B43C1F53B0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <155664820799.168659.12393223246835475198@swboyd.mtv.corp.google.com>

Hi, Stephen
	I saw Gustavo already sent out a patch to fix these two warnings, so I will NOT sent the patch again, thanks.

> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@kernel.org]
> Sent: Wednesday, May 1, 2019 2:17 AM
> To: festevam@gmail.com; kernel@pengutronix.de; linux-arm-
> kernel@lists.infradead.org; linux-clk@vger.kernel.org; linux-
> kernel@vger.kernel.org; mturquette@baylibre.com;
> s.hauer@pengutronix.de; shawnguo@kernel.org; Anson Huang
> <anson.huang@nxp.com>; Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] clk: imx: pllv3: Fix fall through build warning
> 
> Quoting Anson Huang (2019-04-29 18:55:18)
> > Fix below fall through build warning:
> >
> > drivers/clk/imx/clk-pllv3.c:453:21: warning:
> > this statement may fall through [-Wimplicit-fallthrough=]
> >
> >    pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
> >                      ^
> > drivers/clk/imx/clk-pllv3.c:454:2: note: here
> >   case IMX_PLLV3_AV:
> >   ^~~~
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> 
> Gustavo says there are two warnings. Please compile test with the right
> options, add Reported-by tags when you get bug reports from someone, and
> add a Fixes tag and then resend.
> 
> >  drivers/clk/imx/clk-pllv3.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
> > index e892b9a..fbe4fe0 100644
> > --- a/drivers/clk/imx/clk-pllv3.c
> > +++ b/drivers/clk/imx/clk-pllv3.c
> > @@ -451,6 +451,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type,
> const char *name,
> >         case IMX_PLLV3_AV_IMX7:
> >                 pll->num_offset = PLL_IMX7_NUM_OFFSET;
> >                 pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
> > +               /* fall through */
> >         case IMX_PLLV3_AV:
> >                 ops = &clk_pllv3_av_ops;
> >                 break;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-05-01  9:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30  1:55 [PATCH] clk: imx: pllv3: Fix fall through build warning Anson Huang
2019-04-30  1:55 ` Anson Huang
2019-04-30  3:01 ` Aisheng Dong
2019-04-30  3:01   ` Aisheng Dong
2019-04-30 18:16 ` Stephen Boyd
2019-04-30 18:16   ` Stephen Boyd
2019-05-01  9:33   ` Anson Huang [this message]
2019-05-01  9:33     ` Anson Huang
2019-05-01 17:03     ` Stephen Boyd
2019-05-01 17:03       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB3PR0402MB3916F59134DB9CF9837B43C1F53B0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
    --to=anson.huang@nxp.com \
    --cc=festevam@gmail.com \
    --cc=gustavo@embeddedor.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.