All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Xueming(Steven) Li" <xuemingl@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v2 1/2] eal/malloc: fix RTE malloc debug macro
Date: Sat, 9 Sep 2017 07:33:09 +0000	[thread overview]
Message-ID: <DB3PR05MB2977125DD080F84AF186BADAC6A0@DB3PR05MB297.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20170908090351.457fe42c@xeon-e3>

Thanks, updated in v3.

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Saturday, September 9, 2017 12:04 AM
> To: Xueming(Steven) Li <xuemingl@mellanox.com>
> Cc: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>;
> dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/malloc: fix RTE malloc debug macro
> 
> On Fri,  8 Sep 2017 22:50:54 +0800
> Xueming Li <xuemingl@mellanox.com> wrote:
> 
> > -				printf("rte_zmalloc didn't zero"
> > +				printf("rte_zmalloc didn't zero "
> >  				       "the allocated memory\n");
> 
> Please don't break error messages onto two lines.
> It makes it harder to use tools like grep and google searches to find where
> message is located.
> 
> Checkpatch and other tools make an exception for long lines in quoted strings.

  reply	other threads:[~2017-09-09  7:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23  2:29 [PATCH] eal/malloc: fix malloc cookie check Xueming Li
2017-08-23 13:50 ` Sergio Gonzalez Monroy
2017-09-08 14:50 ` [PATCH v2 1/2] eal/malloc: fix RTE malloc debug macro Xueming Li
2017-09-08 14:50   ` [PATCH v2 2/2] eal/malloc: fix RTE malloc element free Xueming Li
2017-09-08 16:03   ` [PATCH v2 1/2] eal/malloc: fix RTE malloc debug macro Stephen Hemminger
2017-09-09  7:33     ` Xueming(Steven) Li [this message]
2017-09-09  7:33 ` [PATCH v3 " Xueming Li
2017-09-09  7:33   ` [PATCH v3 2/2] eal/malloc: fix RTE malloc element free Xueming Li
2017-09-13 12:06     ` Sergio Gonzalez Monroy
2017-10-09 20:56       ` Thomas Monjalon
2017-09-13 12:06   ` [PATCH v3 1/2] eal/malloc: fix RTE malloc debug macro Sergio Gonzalez Monroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB3PR05MB2977125DD080F84AF186BADAC6A0@DB3PR05MB297.eurprd05.prod.outlook.com \
    --to=xuemingl@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.