All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Z.q. Hou" <zhiqiang.hou@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Leo Li <leoyang.li@nxp.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	Mingkai Hu <mingkai.hu@nxp.com>,
	"M.h. Lian" <minghuan.lian@nxp.com>
Subject: RE: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible strings
Date: Thu, 25 Oct 2018 09:27:42 +0000	[thread overview]
Message-ID: <DB5PR04MB12216556360604A225BAFC1F84F70@DB5PR04MB1221.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181017135148.GA29469@bogus>

Hi Rob,

Thanks a lot for your comments!
 
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2018年10月17日 21:52
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> linux-pci@vger.kernel.org; devicetree@vger.kernel.org; Leo Li
> <leoyang.li@nxp.com>; shawnguo@kernel.org; mark.rutland@arm.com;
> bhelgaas@google.com; Mingkai Hu <mingkai.hu@nxp.com>; M.h. Lian
> <minghuan.lian@nxp.com>
> Subject: Re: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible
> strings
> 
> On Mon, Oct 08, 2018 at 11:14:25AM +0800, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > The pcie compatible string for LS1043A was lost, so add it.
> 
> PCIe
> 
> The subject could be improved to say exactly what compatible string you are
> adding. And the subject should start with "dt-bindings: pci: ..."
>

Yes, will correct them in v2.
 
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > index 66df1e81e0b8..5eb1c202932f 100644
> > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > @@ -18,6 +18,7 @@ Required properties:
> >          "fsl,ls2088a-pcie"
> >          "fsl,ls1088a-pcie"
> >          "fsl,ls1046a-pcie"
> > +        "fsl,ls1043a-pcie"
> >          "fsl,ls1012a-pcie"
> >  - reg: base addresses and lengths of the PCIe controller register blocks.
> >  - interrupts: A list of interrupt outputs of the controller. Must
> > contain an
> > --
> > 2.17.1
> >

WARNING: multiple messages have this Message-ID (diff)
From: "Z.q. Hou" <zhiqiang.hou@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Leo Li <leoyang.li@nxp.com>, "M.h. Lian" <minghuan.lian@nxp.com>,
	Mingkai Hu <mingkai.hu@nxp.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible strings
Date: Thu, 25 Oct 2018 09:27:42 +0000	[thread overview]
Message-ID: <DB5PR04MB12216556360604A225BAFC1F84F70@DB5PR04MB1221.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181017135148.GA29469@bogus>

Hi Rob,

Thanks a lot for your comments!
 
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2018年10月17日 21:52
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> linux-pci@vger.kernel.org; devicetree@vger.kernel.org; Leo Li
> <leoyang.li@nxp.com>; shawnguo@kernel.org; mark.rutland@arm.com;
> bhelgaas@google.com; Mingkai Hu <mingkai.hu@nxp.com>; M.h. Lian
> <minghuan.lian@nxp.com>
> Subject: Re: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible
> strings
> 
> On Mon, Oct 08, 2018 at 11:14:25AM +0800, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > The pcie compatible string for LS1043A was lost, so add it.
> 
> PCIe
> 
> The subject could be improved to say exactly what compatible string you are
> adding. And the subject should start with "dt-bindings: pci: ..."
>

Yes, will correct them in v2.
 
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > index 66df1e81e0b8..5eb1c202932f 100644
> > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > @@ -18,6 +18,7 @@ Required properties:
> >          "fsl,ls2088a-pcie"
> >          "fsl,ls1088a-pcie"
> >          "fsl,ls1046a-pcie"
> > +        "fsl,ls1043a-pcie"
> >          "fsl,ls1012a-pcie"
> >  - reg: base addresses and lengths of the PCIe controller register blocks.
> >  - interrupts: A list of interrupt outputs of the controller. Must
> > contain an
> > --
> > 2.17.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: zhiqiang.hou@nxp.com (Z.q. Hou)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible strings
Date: Thu, 25 Oct 2018 09:27:42 +0000	[thread overview]
Message-ID: <DB5PR04MB12216556360604A225BAFC1F84F70@DB5PR04MB1221.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181017135148.GA29469@bogus>

Hi Rob,

Thanks a lot for your comments!
 
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2018?10?17? 21:52
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
> linux-pci at vger.kernel.org; devicetree at vger.kernel.org; Leo Li
> <leoyang.li@nxp.com>; shawnguo at kernel.org; mark.rutland at arm.com;
> bhelgaas at google.com; Mingkai Hu <mingkai.hu@nxp.com>; M.h. Lian
> <minghuan.lian@nxp.com>
> Subject: Re: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible
> strings
> 
> On Mon, Oct 08, 2018 at 11:14:25AM +0800, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > The pcie compatible string for LS1043A was lost, so add it.
> 
> PCIe
> 
> The subject could be improved to say exactly what compatible string you are
> adding. And the subject should start with "dt-bindings: pci: ..."
>

Yes, will correct them in v2.
 
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > index 66df1e81e0b8..5eb1c202932f 100644
> > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > @@ -18,6 +18,7 @@ Required properties:
> >          "fsl,ls2088a-pcie"
> >          "fsl,ls1088a-pcie"
> >          "fsl,ls1046a-pcie"
> > +        "fsl,ls1043a-pcie"
> >          "fsl,ls1012a-pcie"
> >  - reg: base addresses and lengths of the PCIe controller register blocks.
> >  - interrupts: A list of interrupt outputs of the controller. Must
> > contain an
> > --
> > 2.17.1
> >

  reply	other threads:[~2018-10-25  9:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  3:14 [PATCH 0/4] dts/layerscape-pci: removed unsuitable compatible string Zhiqiang Hou
2018-10-08  3:14 ` Zhiqiang Hou
2018-10-08  3:14 ` [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible strings Zhiqiang Hou
2018-10-08  3:14   ` Zhiqiang Hou
2018-10-17 13:51   ` Rob Herring
2018-10-17 13:51     ` Rob Herring
2018-10-25  9:27     ` Z.q. Hou [this message]
2018-10-25  9:27       ` Z.q. Hou
2018-10-25  9:27       ` Z.q. Hou
2018-10-08  3:14 ` [PATCH 2/4] doc/layerscape-pci: removed unsuitable compatible string Zhiqiang Hou
2018-10-08  3:14   ` Zhiqiang Hou
2018-10-17 13:53   ` Rob Herring
2018-10-17 13:53     ` Rob Herring
2018-10-25  9:28     ` Z.q. Hou
2018-10-25  9:28       ` Z.q. Hou
2018-10-25  9:28       ` Z.q. Hou
2018-11-22 11:28   ` Lorenzo Pieralisi
2018-11-22 11:28     ` Lorenzo Pieralisi
2018-11-23  6:22     ` Z.q. Hou
2018-11-23  6:22       ` Z.q. Hou
2018-11-23  6:22       ` Z.q. Hou
2018-10-08  3:14 ` [PATCH 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings Zhiqiang Hou
2018-10-08  3:14   ` Zhiqiang Hou
2018-10-08  3:14 ` [PATCH 4/4] dts/arm64/layerscape: " Zhiqiang Hou
2018-10-08  3:14   ` Zhiqiang Hou
2018-11-20 12:53 ` [PATCH 0/4] dts/layerscape-pci: removed unsuitable compatible string Lorenzo Pieralisi
2018-11-20 12:53   ` Lorenzo Pieralisi
2018-11-23  7:36   ` Shawn Guo
2018-11-23  7:36     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB5PR04MB12216556360604A225BAFC1F84F70@DB5PR04MB1221.eurprd04.prod.outlook.com \
    --to=zhiqiang.hou@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=minghuan.lian@nxp.com \
    --cc=mingkai.hu@nxp.com \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.