From: "Y.B. Lu" <yangbo.lu-3arQi8VN3Tc@public.gmane.org> To: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>, "ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>, Harninder Rai <harninder.rai-3arQi8VN3Tc@public.gmane.org>, Xiaobo Xie <xiaobo.xie-3arQi8VN3Tc@public.gmane.org> Subject: RE: [v2, 1/5] mmc: dt: add compatible into eSDHC required properties Date: Fri, 5 May 2017 03:01:04 +0000 [thread overview] Message-ID: <DB6PR0401MB2536CB3661070921AEA0C5B6F8EB0@DB6PR0401MB2536.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20170505023651.GW18578@dragon> Hi Shawn, > -----Original Message----- > From: Shawn Guo [mailto:shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org] > Sent: Friday, May 05, 2017 10:37 AM > To: Y.B. Lu > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; > ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; Rob Herring; Catalin Marinas; Harninder Rai; > Xiaobo Xie > Subject: Re: [v2, 1/5] mmc: dt: add compatible into eSDHC required > properties > > On Thu, May 04, 2017 at 06:48:56PM +0800, Yangbo Lu wrote: > > This patch is to add compatible into eSDHC required properties. > > > > Signed-off-by: Yangbo Lu <yangbo.lu-3arQi8VN3Tc@public.gmane.org> > > --- > > Changes for v2: > > - Added this patch. > > --- > > Documentation/devicetree/bindings/mmc/fsl-esdhc.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > index dedfb02..b04b248 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > @@ -7,6 +7,7 @@ This file documents differences between the core > > properties described by mmc.txt and the properties used by the sdhci- > esdhc driver. > > > > Required properties: > > + - compatible : should be "fsl,esdhc", or "fsl,<chip>-esdhc". > > I think either supported <chip> or the compatible should be listed > explicitly. > [Lu Yangbo-B47093] I think the reason we use <chip> is to avoid listing too much chips, and to avoid doc updating if new chips are added. The checkpatch script also had considered that. Currently there're about 20 platforms with "fsl,<chip>-esdhc" compatible in kernel dts. And the doc also provide an example. Example: sdhci@2e000 { compatible = "fsl,mpc8378-esdhc", "fsl,esdhc"; Should we still need to list all ? Thanks. > Shawn > > > - interrupt-parent : interrupt source phandle. > > - clock-frequency : specifies eSDHC base clock frequency. > > > > -- > > 2.1.0.27.g96db324 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: yangbo.lu@nxp.com (Y.B. Lu) To: linux-arm-kernel@lists.infradead.org Subject: [v2, 1/5] mmc: dt: add compatible into eSDHC required properties Date: Fri, 5 May 2017 03:01:04 +0000 [thread overview] Message-ID: <DB6PR0401MB2536CB3661070921AEA0C5B6F8EB0@DB6PR0401MB2536.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20170505023651.GW18578@dragon> Hi Shawn, > -----Original Message----- > From: Shawn Guo [mailto:shawnguo at kernel.org] > Sent: Friday, May 05, 2017 10:37 AM > To: Y.B. Lu > Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; > ulf.hansson at linaro.org; Rob Herring; Catalin Marinas; Harninder Rai; > Xiaobo Xie > Subject: Re: [v2, 1/5] mmc: dt: add compatible into eSDHC required > properties > > On Thu, May 04, 2017 at 06:48:56PM +0800, Yangbo Lu wrote: > > This patch is to add compatible into eSDHC required properties. > > > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > > --- > > Changes for v2: > > - Added this patch. > > --- > > Documentation/devicetree/bindings/mmc/fsl-esdhc.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > index dedfb02..b04b248 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > @@ -7,6 +7,7 @@ This file documents differences between the core > > properties described by mmc.txt and the properties used by the sdhci- > esdhc driver. > > > > Required properties: > > + - compatible : should be "fsl,esdhc", or "fsl,<chip>-esdhc". > > I think either supported <chip> or the compatible should be listed > explicitly. > [Lu Yangbo-B47093] I think the reason we use <chip> is to avoid listing too much chips, and to avoid doc updating if new chips are added. The checkpatch script also had considered that. Currently there're about 20 platforms with "fsl,<chip>-esdhc" compatible in kernel dts. And the doc also provide an example. Example: sdhci at 2e000 { compatible = "fsl,mpc8378-esdhc", "fsl,esdhc"; Should we still need to list all ? Thanks. > Shawn > > > - interrupt-parent : interrupt source phandle. > > - clock-frequency : specifies eSDHC base clock frequency. > > > > -- > > 2.1.0.27.g96db324 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel at lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-05-05 3:01 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-04 10:48 [v2, 0/5] Add eSDHC UHS-I/HS200 mode support for ls1012a/ls1046a/ls208xa Yangbo Lu 2017-05-04 10:48 ` Yangbo Lu [not found] ` <1493894940-47452-1-git-send-email-yangbo.lu-3arQi8VN3Tc@public.gmane.org> 2017-05-04 10:48 ` [v2, 1/5] mmc: dt: add compatible into eSDHC required properties Yangbo Lu 2017-05-04 10:48 ` Yangbo Lu [not found] ` <1493894940-47452-2-git-send-email-yangbo.lu-3arQi8VN3Tc@public.gmane.org> 2017-05-05 2:36 ` Shawn Guo 2017-05-05 2:36 ` Shawn Guo 2017-05-05 3:01 ` Y.B. Lu [this message] 2017-05-05 3:01 ` Y.B. Lu [not found] ` <DB6PR0401MB2536CB3661070921AEA0C5B6F8EB0-2mNvjAGDOPkZcyyZo0JLBI3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> 2017-05-05 3:18 ` Shawn Guo 2017-05-05 3:18 ` Shawn Guo 2017-05-08 16:36 ` Rob Herring 2017-05-08 16:36 ` Rob Herring 2017-05-09 2:51 ` Y.B. Lu 2017-05-09 2:51 ` Y.B. Lu 2017-05-04 10:48 ` [v2, 2/5] arm64: dts: ls1046a: support SD UHS-I and eMMC HS200 on RDB Yangbo Lu 2017-05-04 10:48 ` Yangbo Lu 2017-05-04 10:48 ` [v2, 3/5] arm64: dts: ls208xa: support SD UHS-I on RDB and eMMC HS200 on QDS Yangbo Lu 2017-05-04 10:48 ` Yangbo Lu 2017-05-04 10:48 ` [v2, 4/5] arm64: dts: ls1012a: add eSDHC nodes Yangbo Lu 2017-05-04 10:48 ` Yangbo Lu 2017-05-04 10:49 ` [v2, 5/5] arm64: dts: ls1088a: add esdhc node Yangbo Lu 2017-05-04 10:49 ` Yangbo Lu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB6PR0401MB2536CB3661070921AEA0C5B6F8EB0@DB6PR0401MB2536.eurprd04.prod.outlook.com \ --to=yangbo.lu-3arqi8vn3tc@public.gmane.org \ --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=harninder.rai-3arQi8VN3Tc@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=xiaobo.xie-3arQi8VN3Tc@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.