From: Peng Fan <peng.fan@nxp.com> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com>, "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify code Date: Sat, 24 Oct 2020 07:39:47 +0000 [thread overview] Message-ID: <DB6PR0402MB276054D75742322A734DF638881B0@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CAJKOXPcPMRYmQURxAX5JPOR7k0JQmzoaX4xkmyZar_HHLX3dkA@mail.gmail.com> > Subject: Re: [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify > code > > On Fri, 23 Oct 2020 at 10:27, <peng.fan@nxp.com> wrote: > > > > From: Peng Fan <peng.fan@nxp.com> > > > > Use devm_request_threaded_irq to simplify code > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/i2c/busses/i2c-imx.c | 10 +++------- > > 1 file changed, 3 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-imx.c > > b/drivers/i2c/busses/i2c-imx.c index e6f8d6e45a15..ba9d639223ec 100644 > > --- a/drivers/i2c/busses/i2c-imx.c > > +++ b/drivers/i2c/busses/i2c-imx.c > > @@ -1216,8 +1216,8 @@ static int i2c_imx_probe(struct platform_device > *pdev) > > goto rpm_disable; > > > > /* Request IRQ */ > > - ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED, > > - pdev->name, i2c_imx); > > + ret = devm_request_threaded_irq(&pdev->dev, irq, i2c_imx_isr, > NULL, IRQF_SHARED, > > + pdev->name, i2c_imx); > > Really? You silently revert commit e50e4f0b85be ("i2c: imx: Fix external abort > on interrupt in exit paths"). This is not a simplification but serious change. NAK. > At least without proper reasoning of why this is suddenly safe. Oh, I need look at git history before. But Is it because i2c interrupt enabled too early? I'll try your case on i.MX8M platform. Regards, Peng. > > Best regards, > Krzysztof > Best regards, > Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org> Subject: RE: [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify code Date: Sat, 24 Oct 2020 07:39:47 +0000 [thread overview] Message-ID: <DB6PR0402MB276054D75742322A734DF638881B0@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CAJKOXPcPMRYmQURxAX5JPOR7k0JQmzoaX4xkmyZar_HHLX3dkA@mail.gmail.com> > Subject: Re: [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify > code > > On Fri, 23 Oct 2020 at 10:27, <peng.fan@nxp.com> wrote: > > > > From: Peng Fan <peng.fan@nxp.com> > > > > Use devm_request_threaded_irq to simplify code > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/i2c/busses/i2c-imx.c | 10 +++------- > > 1 file changed, 3 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-imx.c > > b/drivers/i2c/busses/i2c-imx.c index e6f8d6e45a15..ba9d639223ec 100644 > > --- a/drivers/i2c/busses/i2c-imx.c > > +++ b/drivers/i2c/busses/i2c-imx.c > > @@ -1216,8 +1216,8 @@ static int i2c_imx_probe(struct platform_device > *pdev) > > goto rpm_disable; > > > > /* Request IRQ */ > > - ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED, > > - pdev->name, i2c_imx); > > + ret = devm_request_threaded_irq(&pdev->dev, irq, i2c_imx_isr, > NULL, IRQF_SHARED, > > + pdev->name, i2c_imx); > > Really? You silently revert commit e50e4f0b85be ("i2c: imx: Fix external abort > on interrupt in exit paths"). This is not a simplification but serious change. NAK. > At least without proper reasoning of why this is suddenly safe. Oh, I need look at git history before. But Is it because i2c interrupt enabled too early? I'll try your case on i.MX8M platform. Regards, Peng. > > Best regards, > Krzysztof > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-24 7:39 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-23 8:18 [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify code peng.fan 2020-10-23 8:18 ` peng.fan 2020-10-23 8:18 ` [PATCH 2/2] i2c: imx: remove id_table entry peng.fan 2020-10-23 8:18 ` peng.fan 2020-10-23 15:28 ` Krzysztof Kozlowski 2020-10-23 15:28 ` Krzysztof Kozlowski 2020-10-24 7:47 ` Peng Fan 2020-10-24 7:47 ` Peng Fan 2020-10-24 19:25 ` Krzysztof Kozlowski 2020-10-24 19:25 ` Krzysztof Kozlowski 2020-10-26 1:41 ` Peng Fan 2020-10-26 1:41 ` Peng Fan 2020-10-26 23:53 ` Greg Ungerer 2020-10-26 23:53 ` Greg Ungerer 2020-10-23 15:23 ` [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify code Krzysztof Kozlowski 2020-10-23 15:23 ` Krzysztof Kozlowski 2020-10-24 7:39 ` Peng Fan [this message] 2020-10-24 7:39 ` Peng Fan 2020-10-24 19:28 ` Krzysztof Kozlowski 2020-10-24 19:28 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB6PR0402MB276054D75742322A734DF638881B0@DB6PR0402MB2760.eurprd04.prod.outlook.com \ --to=peng.fan@nxp.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.