From: Peng Fan <peng.fan@nxp.com> To: Rob Herring <robh@kernel.org> Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "festevam@gmail.com" <festevam@gmail.com>, "adrian.hunter@intel.com" <adrian.hunter@intel.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de> Subject: RE: [PATCH V2 2/4] dt-bindings: mmc: fsl-imx-esdhc: add clock bindings Date: Fri, 22 Jan 2021 00:55:00 +0000 [thread overview] Message-ID: <DB6PR0402MB27606B6ADC13EC6F889D9A9D88A00@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1611244918.545866.2814847.nullmailer@robh.at.kernel.org> Hi Rob, > Subject: Re: [PATCH V2 2/4] dt-bindings: mmc: fsl-imx-esdhc: add clock > bindings > > On Thu, 21 Jan 2021 11:09:51 +0800, peng.fan@nxp.com wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Add clock bindings for fsl-imx-esdhc yaml > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 11 > +++++++++++ > > 1 file changed, 11 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: Patch 3/4 addresses the dts, actually I think it is the dts not use correct clock order. Thanks, Peng. > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock > /imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: clock-names:1: 'ahb' was > expected > From schema: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc > /fsl-imx-esdhc.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock > /imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: clock-names:2: 'per' was > expected > From schema: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc > /fsl-imx-esdhc.yaml > > See > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch > work.ozlabs.org%2Fpatch%2F1429619&data=04%7C01%7Cpeng.fan%40 > nxp.com%7Cc543c002a0b54348d48408d8be25ec0b%7C686ea1d3bc2b4c6fa > 92cd99c5c301635%7C0%7C0%7C637468417375412086%7CUnknown%7CT > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC > JXVCI6Mn0%3D%7C1000&sdata=cISWAn3kYIoqvxr39Mu5NL6rwkebmk > VN1drRi%2BDNwAs%3D&reserved=0 > > This check can fail if there are any dependencies. The base for a patch series > is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com> To: Rob Herring <robh@kernel.org> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, "festevam@gmail.com" <festevam@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "adrian.hunter@intel.com" <adrian.hunter@intel.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH V2 2/4] dt-bindings: mmc: fsl-imx-esdhc: add clock bindings Date: Fri, 22 Jan 2021 00:55:00 +0000 [thread overview] Message-ID: <DB6PR0402MB27606B6ADC13EC6F889D9A9D88A00@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1611244918.545866.2814847.nullmailer@robh.at.kernel.org> Hi Rob, > Subject: Re: [PATCH V2 2/4] dt-bindings: mmc: fsl-imx-esdhc: add clock > bindings > > On Thu, 21 Jan 2021 11:09:51 +0800, peng.fan@nxp.com wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Add clock bindings for fsl-imx-esdhc yaml > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 11 > +++++++++++ > > 1 file changed, 11 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: Patch 3/4 addresses the dts, actually I think it is the dts not use correct clock order. Thanks, Peng. > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock > /imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: clock-names:1: 'ahb' was > expected > From schema: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc > /fsl-imx-esdhc.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock > /imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: clock-names:2: 'per' was > expected > From schema: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc > /fsl-imx-esdhc.yaml > > See > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch > work.ozlabs.org%2Fpatch%2F1429619&data=04%7C01%7Cpeng.fan%40 > nxp.com%7Cc543c002a0b54348d48408d8be25ec0b%7C686ea1d3bc2b4c6fa > 92cd99c5c301635%7C0%7C0%7C637468417375412086%7CUnknown%7CT > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC > JXVCI6Mn0%3D%7C1000&sdata=cISWAn3kYIoqvxr39Mu5NL6rwkebmk > VN1drRi%2BDNwAs%3D&reserved=0 > > This check can fail if there are any dependencies. The base for a patch series > is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-22 0:56 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-21 3:09 [PATCH V2 0/4] imx esdhc dt/driver update peng.fan 2021-01-21 3:09 ` peng.fan 2021-01-21 3:09 ` [PATCH V2 1/4] dt-bindings: mmc: fsl-imx-esdhc: add pinctrl bindings peng.fan 2021-01-21 3:09 ` peng.fan 2021-01-22 16:38 ` Rob Herring 2021-01-22 16:38 ` Rob Herring 2021-01-21 3:09 ` [PATCH V2 2/4] dt-bindings: mmc: fsl-imx-esdhc: add clock bindings peng.fan 2021-01-21 3:09 ` peng.fan 2021-01-21 16:01 ` Rob Herring 2021-01-21 16:01 ` Rob Herring 2021-01-22 0:55 ` Peng Fan [this message] 2021-01-22 0:55 ` Peng Fan 2021-01-22 14:33 ` Rob Herring 2021-01-22 14:33 ` Rob Herring 2021-01-21 3:09 ` [PATCH V2 3/4] arm64: dts: imx8qxp: correct usdhc clock-names sequence peng.fan 2021-01-21 3:09 ` peng.fan 2021-01-21 3:09 ` [PATCH V2 4/4] mmc: sdhci-esdhc-imx: validate pinctrl before use it peng.fan 2021-01-21 3:09 ` peng.fan 2021-02-07 13:10 ` [PATCH V2 0/4] imx esdhc dt/driver update Peng Fan 2021-02-07 13:10 ` Peng Fan 2021-02-08 12:05 ` Ulf Hansson 2021-02-08 12:05 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB6PR0402MB27606B6ADC13EC6F889D9A9D88A00@DB6PR0402MB2760.eurprd04.prod.outlook.com \ --to=peng.fan@nxp.com \ --cc=adrian.hunter@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.