From: Peng Fan <peng.fan@nxp.com> To: Mathieu Poirier <mathieu.poirier@linaro.org>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com> Cc: "ohad@wizery.com" <ohad@wizery.com>, "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>, "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH V5 7/8] remoteproc: imx_rproc: support i.MX7ULP Date: Thu, 6 May 2021 04:11:46 +0000 [thread overview] Message-ID: <DB6PR0402MB2760B8377D023ACFFED9F51988589@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20210503162935.GB1699665@xps15> > Subject: Re: [PATCH V5 7/8] remoteproc: imx_rproc: support i.MX7ULP > > On Wed, Apr 21, 2021 at 10:20:21AM +0800, peng.fan@oss.nxp.com wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > i.MX7ULP A7 core runs under control of M4 core, M4 core starts by ROM > > and powers most serivces used by A7 core, so A7 core has no power to > > s/serivces/services > > I pointed that out on V4 - why do I have to do so again? I forgot that comment, sorry. Thanks for your time. Thanks, Peng. > > With that: > > Reviwed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > > start and stop M4 core. And the M4 core's state is default > > RPROC_DETACHED and remoteproc framework not able to stop the M4 > core. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/remoteproc/imx_rproc.c | 49 > > ++++++++++++++++++++++++++-------- > > 1 file changed, 38 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > b/drivers/remoteproc/imx_rproc.c index e9d9860e4fce..d26254609a52 > > 100644 > > --- a/drivers/remoteproc/imx_rproc.c > > +++ b/drivers/remoteproc/imx_rproc.c > > @@ -136,6 +136,14 @@ static const struct imx_rproc_att > imx_rproc_att_imx8mq[] = { > > { 0x40000000, 0x40000000, 0x80000000, 0 }, }; > > > > +static const struct imx_rproc_att imx_rproc_att_imx7ulp[] = { > > + {0x1FFD0000, 0x1FFD0000, 0x30000, ATT_OWN}, > > + {0x20000000, 0x20000000, 0x10000, ATT_OWN}, > > + {0x2F000000, 0x2F000000, 0x20000, ATT_OWN}, > > + {0x2F020000, 0x2F020000, 0x20000, ATT_OWN}, > > + {0x60000000, 0x60000000, 0x40000000, 0} }; > > + > > static const struct imx_rproc_att imx_rproc_att_imx7d[] = { > > /* dev addr , sys addr , size , flags */ > > /* OCRAM_S (M4 Boot code) - alias */ @@ -196,6 +204,12 @@ static > > const struct imx_rproc_dcfg imx_rproc_cfg_imx8mq = { > > .method = IMX_RPROC_MMIO, > > }; > > > > +static const struct imx_rproc_dcfg imx_rproc_cfg_imx7ulp = { > > + .att = imx_rproc_att_imx7ulp, > > + .att_size = ARRAY_SIZE(imx_rproc_att_imx7ulp), > > + .method = IMX_RPROC_NONE, > > +}; > > + > > static const struct imx_rproc_dcfg imx_rproc_cfg_imx7d = { > > .src_reg = IMX7D_SRC_SCR, > > .src_mask = IMX7D_M4_RST_MASK, > > @@ -238,6 +252,9 @@ static int imx_rproc_stop(struct rproc *rproc) > > struct device *dev = priv->dev; > > int ret; > > > > + if (dcfg->method == IMX_RPROC_NONE) > > + return -EOPNOTSUPP; > > + > > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > > dcfg->src_mask, dcfg->src_stop); > > if (ret) > > @@ -573,12 +590,31 @@ static void imx_rproc_free_mbox(struct rproc > > *rproc) > > > > static int imx_rproc_detect_mode(struct imx_rproc *priv) { > > + struct regmap_config config = { .name = "imx-rproc" }; > > const struct imx_rproc_dcfg *dcfg = priv->dcfg; > > struct device *dev = priv->dev; > > + struct regmap *regmap; > > int ret; > > u32 val; > > > > - ret = regmap_read(priv->regmap, dcfg->src_reg, &val); > > + switch (dcfg->method) { > > + case IMX_RPROC_NONE: > > + priv->rproc->state = RPROC_DETACHED; > > + return 0; > > + default: > > + break; > > + } > > + > > + regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon"); > > + if (IS_ERR(regmap)) { > > + dev_err(dev, "failed to find syscon\n"); > > + return PTR_ERR(regmap); > > + } > > + > > + priv->regmap = regmap; > > + regmap_attach_dev(dev, regmap, &config); > > + > > + ret = regmap_read(regmap, dcfg->src_reg, &val); > > if (ret) { > > dev_err(dev, "Failed to read src\n"); > > return ret; > > @@ -625,18 +661,9 @@ static int imx_rproc_probe(struct platform_device > *pdev) > > struct device_node *np = dev->of_node; > > struct imx_rproc *priv; > > struct rproc *rproc; > > - struct regmap_config config = { .name = "imx-rproc" }; > > const struct imx_rproc_dcfg *dcfg; > > - struct regmap *regmap; > > int ret; > > > > - regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > > - if (IS_ERR(regmap)) { > > - dev_err(dev, "failed to find syscon\n"); > > - return PTR_ERR(regmap); > > - } > > - regmap_attach_dev(dev, regmap, &config); > > - > > /* set some other name then imx */ > > rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops, > > NULL, sizeof(*priv)); > > @@ -651,7 +678,6 @@ static int imx_rproc_probe(struct platform_device > > *pdev) > > > > priv = rproc->priv; > > priv->rproc = rproc; > > - priv->regmap = regmap; > > priv->dcfg = dcfg; > > priv->dev = dev; > > > > @@ -720,6 +746,7 @@ static int imx_rproc_remove(struct platform_device > > *pdev) } > > > > static const struct of_device_id imx_rproc_of_match[] = { > > + { .compatible = "fsl,imx7ulp-cm4", .data = &imx_rproc_cfg_imx7ulp }, > > { .compatible = "fsl,imx7d-cm4", .data = &imx_rproc_cfg_imx7d }, > > { .compatible = "fsl,imx6sx-cm4", .data = &imx_rproc_cfg_imx6sx }, > > { .compatible = "fsl,imx8mq-cm4", .data = &imx_rproc_cfg_imx8mq }, > > -- > > 2.30.0 > >
WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com> To: Mathieu Poirier <mathieu.poirier@linaro.org>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com> Cc: "ohad@wizery.com" <ohad@wizery.com>, "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>, "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH V5 7/8] remoteproc: imx_rproc: support i.MX7ULP Date: Thu, 6 May 2021 04:11:46 +0000 [thread overview] Message-ID: <DB6PR0402MB2760B8377D023ACFFED9F51988589@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20210503162935.GB1699665@xps15> > Subject: Re: [PATCH V5 7/8] remoteproc: imx_rproc: support i.MX7ULP > > On Wed, Apr 21, 2021 at 10:20:21AM +0800, peng.fan@oss.nxp.com wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > i.MX7ULP A7 core runs under control of M4 core, M4 core starts by ROM > > and powers most serivces used by A7 core, so A7 core has no power to > > s/serivces/services > > I pointed that out on V4 - why do I have to do so again? I forgot that comment, sorry. Thanks for your time. Thanks, Peng. > > With that: > > Reviwed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > > start and stop M4 core. And the M4 core's state is default > > RPROC_DETACHED and remoteproc framework not able to stop the M4 > core. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/remoteproc/imx_rproc.c | 49 > > ++++++++++++++++++++++++++-------- > > 1 file changed, 38 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > b/drivers/remoteproc/imx_rproc.c index e9d9860e4fce..d26254609a52 > > 100644 > > --- a/drivers/remoteproc/imx_rproc.c > > +++ b/drivers/remoteproc/imx_rproc.c > > @@ -136,6 +136,14 @@ static const struct imx_rproc_att > imx_rproc_att_imx8mq[] = { > > { 0x40000000, 0x40000000, 0x80000000, 0 }, }; > > > > +static const struct imx_rproc_att imx_rproc_att_imx7ulp[] = { > > + {0x1FFD0000, 0x1FFD0000, 0x30000, ATT_OWN}, > > + {0x20000000, 0x20000000, 0x10000, ATT_OWN}, > > + {0x2F000000, 0x2F000000, 0x20000, ATT_OWN}, > > + {0x2F020000, 0x2F020000, 0x20000, ATT_OWN}, > > + {0x60000000, 0x60000000, 0x40000000, 0} }; > > + > > static const struct imx_rproc_att imx_rproc_att_imx7d[] = { > > /* dev addr , sys addr , size , flags */ > > /* OCRAM_S (M4 Boot code) - alias */ @@ -196,6 +204,12 @@ static > > const struct imx_rproc_dcfg imx_rproc_cfg_imx8mq = { > > .method = IMX_RPROC_MMIO, > > }; > > > > +static const struct imx_rproc_dcfg imx_rproc_cfg_imx7ulp = { > > + .att = imx_rproc_att_imx7ulp, > > + .att_size = ARRAY_SIZE(imx_rproc_att_imx7ulp), > > + .method = IMX_RPROC_NONE, > > +}; > > + > > static const struct imx_rproc_dcfg imx_rproc_cfg_imx7d = { > > .src_reg = IMX7D_SRC_SCR, > > .src_mask = IMX7D_M4_RST_MASK, > > @@ -238,6 +252,9 @@ static int imx_rproc_stop(struct rproc *rproc) > > struct device *dev = priv->dev; > > int ret; > > > > + if (dcfg->method == IMX_RPROC_NONE) > > + return -EOPNOTSUPP; > > + > > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > > dcfg->src_mask, dcfg->src_stop); > > if (ret) > > @@ -573,12 +590,31 @@ static void imx_rproc_free_mbox(struct rproc > > *rproc) > > > > static int imx_rproc_detect_mode(struct imx_rproc *priv) { > > + struct regmap_config config = { .name = "imx-rproc" }; > > const struct imx_rproc_dcfg *dcfg = priv->dcfg; > > struct device *dev = priv->dev; > > + struct regmap *regmap; > > int ret; > > u32 val; > > > > - ret = regmap_read(priv->regmap, dcfg->src_reg, &val); > > + switch (dcfg->method) { > > + case IMX_RPROC_NONE: > > + priv->rproc->state = RPROC_DETACHED; > > + return 0; > > + default: > > + break; > > + } > > + > > + regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon"); > > + if (IS_ERR(regmap)) { > > + dev_err(dev, "failed to find syscon\n"); > > + return PTR_ERR(regmap); > > + } > > + > > + priv->regmap = regmap; > > + regmap_attach_dev(dev, regmap, &config); > > + > > + ret = regmap_read(regmap, dcfg->src_reg, &val); > > if (ret) { > > dev_err(dev, "Failed to read src\n"); > > return ret; > > @@ -625,18 +661,9 @@ static int imx_rproc_probe(struct platform_device > *pdev) > > struct device_node *np = dev->of_node; > > struct imx_rproc *priv; > > struct rproc *rproc; > > - struct regmap_config config = { .name = "imx-rproc" }; > > const struct imx_rproc_dcfg *dcfg; > > - struct regmap *regmap; > > int ret; > > > > - regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > > - if (IS_ERR(regmap)) { > > - dev_err(dev, "failed to find syscon\n"); > > - return PTR_ERR(regmap); > > - } > > - regmap_attach_dev(dev, regmap, &config); > > - > > /* set some other name then imx */ > > rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops, > > NULL, sizeof(*priv)); > > @@ -651,7 +678,6 @@ static int imx_rproc_probe(struct platform_device > > *pdev) > > > > priv = rproc->priv; > > priv->rproc = rproc; > > - priv->regmap = regmap; > > priv->dcfg = dcfg; > > priv->dev = dev; > > > > @@ -720,6 +746,7 @@ static int imx_rproc_remove(struct platform_device > > *pdev) } > > > > static const struct of_device_id imx_rproc_of_match[] = { > > + { .compatible = "fsl,imx7ulp-cm4", .data = &imx_rproc_cfg_imx7ulp }, > > { .compatible = "fsl,imx7d-cm4", .data = &imx_rproc_cfg_imx7d }, > > { .compatible = "fsl,imx6sx-cm4", .data = &imx_rproc_cfg_imx6sx }, > > { .compatible = "fsl,imx8mq-cm4", .data = &imx_rproc_cfg_imx8mq }, > > -- > > 2.30.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-06 4:11 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-21 2:20 [PATCH V5 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP peng.fan 2021-04-21 2:20 ` peng.fan 2021-04-21 2:20 ` [PATCH V5 1/8] dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot property peng.fan 2021-04-21 2:20 ` [PATCH V5 1/8] dt-bindings: remoteproc: imx_rproc: add fsl, auto-boot property peng.fan 2021-04-21 2:20 ` [PATCH V5 2/8] dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support peng.fan 2021-04-21 2:20 ` peng.fan 2021-04-21 2:20 ` [PATCH V5 3/8] dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P peng.fan 2021-04-21 2:20 ` peng.fan 2021-04-21 2:20 ` [PATCH V5 4/8] remoteproc: imx_rproc: parse fsl,auto-boot peng.fan 2021-04-21 2:20 ` peng.fan 2021-04-21 2:20 ` [PATCH V5 5/8] remoteproc: imx_rproc: initial support for mutilple start/stop method peng.fan 2021-04-21 2:20 ` peng.fan 2021-05-03 16:30 ` Mathieu Poirier 2021-05-03 16:30 ` Mathieu Poirier 2021-04-21 2:20 ` [PATCH V5 6/8] remoteproc: imx_rproc: make clk optional peng.fan 2021-04-21 2:20 ` peng.fan 2021-04-21 2:20 ` [PATCH V5 7/8] remoteproc: imx_rproc: support i.MX7ULP peng.fan 2021-04-21 2:20 ` peng.fan 2021-05-03 16:29 ` Mathieu Poirier 2021-05-03 16:29 ` Mathieu Poirier 2021-05-06 4:11 ` Peng Fan [this message] 2021-05-06 4:11 ` Peng Fan 2021-04-21 2:20 ` [PATCH V5 8/8] remoteproc: imx_rproc: support i.MX8MN/P peng.fan 2021-04-21 2:20 ` peng.fan 2021-05-03 16:25 ` Mathieu Poirier 2021-05-03 16:25 ` Mathieu Poirier 2021-04-22 16:56 ` [PATCH V5 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP Mathieu Poirier 2021-04-22 16:56 ` Mathieu Poirier 2021-04-23 1:01 ` Peng Fan 2021-04-23 1:01 ` Peng Fan 2021-04-23 14:50 ` Mathieu Poirier 2021-04-23 14:50 ` Mathieu Poirier 2021-04-23 23:28 ` Peng Fan 2021-04-23 23:28 ` Peng Fan 2021-04-26 15:46 ` Mathieu Poirier 2021-04-26 15:46 ` Mathieu Poirier 2021-04-26 23:45 ` Peng Fan 2021-04-26 23:45 ` Peng Fan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB6PR0402MB2760B8377D023ACFFED9F51988589@DB6PR0402MB2760.eurprd04.prod.outlook.com \ --to=peng.fan@nxp.com \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=o.rempel@pengutronix.de \ --cc=ohad@wizery.com \ --cc=peng.fan@oss.nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.