* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
@ 2020-12-21 18:40 Fabio Estevam
2020-12-21 22:04 ` ZHIZHIKIN Andrey
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Fabio Estevam @ 2020-12-21 18:40 UTC (permalink / raw)
To: u-boot
When booting imx8mp-evk the following allocation error
message is seen:
U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)
alloc space exhausted
Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it
is done on other i.MX8MM/8MN boards.
Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
configs/imx8mp_evk_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/imx8mp_evk_defconfig b/configs/imx8mp_evk_defconfig
index cd5724e811ab..c34a10c2d906 100644
--- a/configs/imx8mp_evk_defconfig
+++ b/configs/imx8mp_evk_defconfig
@@ -4,7 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x40200000
CONFIG_SPL_GPIO_SUPPORT=y
CONFIG_SPL_LIBCOMMON_SUPPORT=y
CONFIG_SPL_LIBGENERIC_SUPPORT=y
-CONFIG_SYS_MALLOC_F_LEN=0x8000
+CONFIG_SYS_MALLOC_F_LEN=0x10000
CONFIG_ENV_SIZE=0x1000
CONFIG_ENV_OFFSET=0x400000
CONFIG_SYS_I2C_MXC_I2C1=y
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
2020-12-21 18:40 [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN Fabio Estevam
@ 2020-12-21 22:04 ` ZHIZHIKIN Andrey
2020-12-21 22:09 ` Fabio Estevam
2020-12-22 6:01 ` Peng Fan
2020-12-26 15:54 ` sbabic at denx.de
2 siblings, 1 reply; 10+ messages in thread
From: ZHIZHIKIN Andrey @ 2020-12-21 22:04 UTC (permalink / raw)
To: u-boot
Hello Fabio,
> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: Monday, December 21, 2020 7:41 PM
> To: sbabic at denx.de
> Cc: peng.fan at nxp.com; u-boot at lists.denx.de; ZHIZHIKIN Andrey
> <andrey.zhizhikin@leica-geosystems.com>; uboot-imx at nxp.com; Fabio Estevam
> <festevam@gmail.com>
> Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
>
>
> When booting imx8mp-evk the following allocation error message is seen:
>
> U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)
>
> alloc space exhausted
>
> Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on
> other i.MX8MM/8MN boards.
It would be really great to get a review from Peng here, as his commit 28fff3fa1c
("imx: imx8mp_evk: fix boot issue") changed exactly this option from 0x10000 to 0x8000.
I've tested my local build with your patch and it boots OK, hence I cannot seem to find a
reasoning why the early malloc area size has been halved with above commit.
>
> Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> configs/imx8mp_evk_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/imx8mp_evk_defconfig b/configs/imx8mp_evk_defconfig
> index cd5724e811ab..c34a10c2d906 100644
> --- a/configs/imx8mp_evk_defconfig
> +++ b/configs/imx8mp_evk_defconfig
> @@ -4,7 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x40200000
> CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y
> CONFIG_SPL_LIBGENERIC_SUPPORT=y
> -CONFIG_SYS_MALLOC_F_LEN=0x8000
> +CONFIG_SYS_MALLOC_F_LEN=0x10000
> CONFIG_ENV_SIZE=0x1000
> CONFIG_ENV_OFFSET=0x400000
> CONFIG_SYS_I2C_MXC_I2C1=y
> --
> 2.17.1
Tested-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
2020-12-21 22:04 ` ZHIZHIKIN Andrey
@ 2020-12-21 22:09 ` Fabio Estevam
0 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2020-12-21 22:09 UTC (permalink / raw)
To: u-boot
Hi Andrey,
On Mon, Dec 21, 2020 at 7:04 PM ZHIZHIKIN Andrey
<andrey.zhizhikin@leica-geosystems.com> wrote:
> It would be really great to get a review from Peng here, as his commit 28fff3fa1c
> ("imx: imx8mp_evk: fix boot issue") changed exactly this option from 0x10000 to 0x8000.
Yes, agreed.
Peng,
Please let us know if you are happy with this change.
> I've tested my local build with your patch and it boots OK, hence I cannot seem to find a
> reasoning why the early malloc area size has been halved with above commit.
> Tested-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
Thanks for reporting and testing it.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
2020-12-21 18:40 [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN Fabio Estevam
2020-12-21 22:04 ` ZHIZHIKIN Andrey
@ 2020-12-22 6:01 ` Peng Fan
2020-12-22 10:59 ` Fabio Estevam
2020-12-23 7:29 ` Peng Fan
2020-12-26 15:54 ` sbabic at denx.de
2 siblings, 2 replies; 10+ messages in thread
From: Peng Fan @ 2020-12-22 6:01 UTC (permalink / raw)
To: u-boot
> Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
>
> When booting imx8mp-evk the following allocation error message is seen:
>
> U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)
>
> alloc space exhausted
>
> Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on
> other i.MX8MM/8MN boards.
>
> Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
I think it might be the DM clk exhausted the space, we need find a way to
improve that.
Thanks,
Peng.
> ---
> configs/imx8mp_evk_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/imx8mp_evk_defconfig b/configs/imx8mp_evk_defconfig
> index cd5724e811ab..c34a10c2d906 100644
> --- a/configs/imx8mp_evk_defconfig
> +++ b/configs/imx8mp_evk_defconfig
> @@ -4,7 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x40200000
> CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y
> CONFIG_SPL_LIBGENERIC_SUPPORT=y
> -CONFIG_SYS_MALLOC_F_LEN=0x8000
> +CONFIG_SYS_MALLOC_F_LEN=0x10000
> CONFIG_ENV_SIZE=0x1000
> CONFIG_ENV_OFFSET=0x400000
> CONFIG_SYS_I2C_MXC_I2C1=y
> --
> 2.17.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
2020-12-22 6:01 ` Peng Fan
@ 2020-12-22 10:59 ` Fabio Estevam
2020-12-22 11:00 ` Stefano Babic
2020-12-23 7:29 ` Peng Fan
1 sibling, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2020-12-22 10:59 UTC (permalink / raw)
To: u-boot
Hi Tom and Stefano,
On Tue, Dec 22, 2020 at 3:01 AM Peng Fan <peng.fan@nxp.com> wrote:
>
> > Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
> >
> > When booting imx8mp-evk the following allocation error message is seen:
> >
> > U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)
> >
> > alloc space exhausted
> >
> > Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on
> > other i.MX8MM/8MN boards.
> >
> > Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Please consider this one for 2021.01.
Thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
2020-12-22 10:59 ` Fabio Estevam
@ 2020-12-22 11:00 ` Stefano Babic
0 siblings, 0 replies; 10+ messages in thread
From: Stefano Babic @ 2020-12-22 11:00 UTC (permalink / raw)
To: u-boot
On 22.12.20 11:59, Fabio Estevam wrote:
> Hi Tom and Stefano,
>
> On Tue, Dec 22, 2020 at 3:01 AM Peng Fan <peng.fan@nxp.com> wrote:
>>
>>> Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
>>>
>>> When booting imx8mp-evk the following allocation error message is seen:
>>>
>>> U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)
>>>
>>> alloc space exhausted
>>>
>>> Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is done on
>>> other i.MX8MM/8MN boards.
>>>
>>> Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
>>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>>
>> Reviewed-by: Peng Fan <peng.fan@nxp.com>
>
> Please consider this one for 2021.01.
>
Yes, I pick it up.
Regards,
Stefano
> Thanks
>
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
2020-12-22 6:01 ` Peng Fan
2020-12-22 10:59 ` Fabio Estevam
@ 2020-12-23 7:29 ` Peng Fan
2020-12-23 11:58 ` Fabio Estevam
1 sibling, 1 reply; 10+ messages in thread
From: Peng Fan @ 2020-12-23 7:29 UTC (permalink / raw)
To: u-boot
All,
> Subject: RE: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
I am thinking to remove the CLK CCF support for i.MX8M, and use simple CLK
DM. Do you agree?
Thanks,
Peng.
>
> > Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
> >
> > When booting imx8mp-evk the following allocation error message is seen:
> >
> > U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)
> >
> > alloc space exhausted
> >
> > Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it is
> > done on other i.MX8MM/8MN boards.
> >
> > Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
>
> I think it might be the DM clk exhausted the space, we need find a way to
> improve that.
>
> Thanks,
> Peng.
>
> > ---
> > configs/imx8mp_evk_defconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configs/imx8mp_evk_defconfig
> > b/configs/imx8mp_evk_defconfig index cd5724e811ab..c34a10c2d906
> 100644
> > --- a/configs/imx8mp_evk_defconfig
> > +++ b/configs/imx8mp_evk_defconfig
> > @@ -4,7 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x40200000
> > CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y
> > CONFIG_SPL_LIBGENERIC_SUPPORT=y
> > -CONFIG_SYS_MALLOC_F_LEN=0x8000
> > +CONFIG_SYS_MALLOC_F_LEN=0x10000
> > CONFIG_ENV_SIZE=0x1000
> > CONFIG_ENV_OFFSET=0x400000
> > CONFIG_SYS_I2C_MXC_I2C1=y
> > --
> > 2.17.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
2020-12-23 7:29 ` Peng Fan
@ 2020-12-23 11:58 ` Fabio Estevam
2020-12-23 13:54 ` Peng Fan
0 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2020-12-23 11:58 UTC (permalink / raw)
To: u-boot
Hi Peng,
On Wed, Dec 23, 2020 at 4:29 AM Peng Fan <peng.fan@nxp.com> wrote:
> I am thinking to remove the CLK CCF support for i.MX8M, and use simple CLK
> DM. Do you agree?
As a minimal fix for 2021.01, I suggest that we go with my patch.
After 2021.01 is released we can consider using simple CLK DM.
Thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
2020-12-23 11:58 ` Fabio Estevam
@ 2020-12-23 13:54 ` Peng Fan
0 siblings, 0 replies; 10+ messages in thread
From: Peng Fan @ 2020-12-23 13:54 UTC (permalink / raw)
To: u-boot
> Subject: Re: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
>
> Hi Peng,
>
> On Wed, Dec 23, 2020 at 4:29 AM Peng Fan <peng.fan@nxp.com> wrote:
>
> > I am thinking to remove the CLK CCF support for i.MX8M, and use simple
> > CLK DM. Do you agree?
>
> As a minimal fix for 2021.01, I suggest that we go with my patch.
I agree.
>
> After 2021.01 is released we can consider using simple CLK DM.
Sure. I need people agree on this before action, then prepare the stuff.
Thanks,
Peng
>
> Thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN
2020-12-21 18:40 [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN Fabio Estevam
2020-12-21 22:04 ` ZHIZHIKIN Andrey
2020-12-22 6:01 ` Peng Fan
@ 2020-12-26 15:54 ` sbabic at denx.de
2 siblings, 0 replies; 10+ messages in thread
From: sbabic at denx.de @ 2020-12-26 15:54 UTC (permalink / raw)
To: u-boot
> When booting imx8mp-evk the following allocation error
> message is seen:
> U-Boot 2021.01-rc3-00200-ge668bec96a5f (Dec 21 2020 - 14:36:42 -0300)
> alloc space exhausted
> Fix it by increasing CONFIG_SYS_MALLOC_F_LEN to 0x10000 like it
> is done on other i.MX8MM/8MN boards.
> Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Tested-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-12-26 15:54 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 18:40 [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN Fabio Estevam
2020-12-21 22:04 ` ZHIZHIKIN Andrey
2020-12-21 22:09 ` Fabio Estevam
2020-12-22 6:01 ` Peng Fan
2020-12-22 10:59 ` Fabio Estevam
2020-12-22 11:00 ` Stefano Babic
2020-12-23 7:29 ` Peng Fan
2020-12-23 11:58 ` Fabio Estevam
2020-12-23 13:54 ` Peng Fan
2020-12-26 15:54 ` sbabic at denx.de
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.