Re: [PATCH v7 1/3] mmc: dw_mmc-bluefield: Add driver extension

[Liming Sun <lsun@mellanox.com>]

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

Thanks Thomas!


A code review has just been sent out to fix this license information. Please let me know if you still see issues.


Regards,

Liming


________________________________
From: Thomas Gleixner <tglx@linutronix.de>
Sent: Friday, January 18, 2019 5:06 AM
To: Liming Sun
Cc: Ulf Hansson; Rob Herring; Mark Rutland; Jaehoon Chung; Catalin Marinas; Will Deacon; linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; LKML; Greg KH; Kate Stewart
Subject: Re: [PATCH v7 1/3] mmc: dw_mmc-bluefield: Add driver extension

>Liming,
>
>On Tue, 8 May 2018, Liming Sun wrote:
>> index 0000000..54c3fbb
>> --- /dev/null
>> +++ b/drivers/mmc/host/dw_mmc-bluefield.c
>> @@ -0,0 +1,81 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2018 Mellanox Technologies.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
>
>This license information is broken. The SPDX license identifier and the
>boiler plate text are contradicting. The SPDX id is GPL v2 only and the
>boiler plate says v2 or later.
>
>Please decide which version you want and fix ASAP. If you fix that up
>please add a Fixes: tag and cc stable. While at it please remove the boiler
>plate text as the SPDX id is sufficient and the boiler plate is redundant
>information.
>
>See Documentation/process/license-rules.txt
>
>Thanks,
>
>        tglx

[-- Attachment #2: Type: text/html, Size: 4899 bytes --]