* [PATCH 01/11] ASoC: codecs: ak4458: fix 'set but not used' warning
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto, open list
fix warning with W=1
sound/soc/codecs/ak4458.c:408:16: warning: variable 'ret' set but not
used [-Wunused-but-set-variable]
408 | int nfs, ndt, ret, reg;
| ^~~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/ak4458.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
index f180cb5dfe4f..e8b4048fbbe4 100644
--- a/sound/soc/codecs/ak4458.c
+++ b/sound/soc/codecs/ak4458.c
@@ -427,7 +427,7 @@ static int ak4458_set_dai_mute(struct snd_soc_dai *dai, int mute)
mdelay(ndt);
}
- return 0;
+ return ret;
}
static int ak4458_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 01/11] ASoC: codecs: ak4458: fix 'set but not used' warning
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, Kuninori Morimoto, Liam Girdwood, tiwai,
open list, Takashi Iwai, broonie
fix warning with W=1
sound/soc/codecs/ak4458.c:408:16: warning: variable 'ret' set but not
used [-Wunused-but-set-variable]
408 | int nfs, ndt, ret, reg;
| ^~~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/ak4458.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
index f180cb5dfe4f..e8b4048fbbe4 100644
--- a/sound/soc/codecs/ak4458.c
+++ b/sound/soc/codecs/ak4458.c
@@ -427,7 +427,7 @@ static int ak4458_set_dai_mute(struct snd_soc_dai *dai, int mute)
mdelay(ndt);
}
- return 0;
+ return ret;
}
static int ak4458_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH 02/11] ASoC: codecs: cros_ec_codec: fix 'defined but not used' warning
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Cheng-Yi Chiang,
Enric Balletbo i Serra, Guenter Roeck, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Benson Leung, open list
fix W=1 warning
sound/soc/codecs/cros_ec_codec.c:1056:36: warning:
'cros_ec_codec_acpi_id' defined but not used
[-Wunused-const-variable=]
1056 | static const struct acpi_device_id cros_ec_codec_acpi_id[] = {
| ^~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/cros_ec_codec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index 8d45c628e988..f23956cf4ed8 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
@@ -1053,11 +1053,13 @@ static const struct of_device_id cros_ec_codec_of_match[] = {
MODULE_DEVICE_TABLE(of, cros_ec_codec_of_match);
#endif
+#ifdef CONFIG_ACPI
static const struct acpi_device_id cros_ec_codec_acpi_id[] = {
{ "GOOG0013", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, cros_ec_codec_acpi_id);
+#endif
static struct platform_driver cros_ec_codec_platform_driver = {
.driver = {
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 02/11] ASoC: codecs: cros_ec_codec: fix 'defined but not used' warning
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, open list, Takashi Iwai, Pierre-Louis Bossart,
Liam Girdwood, Guenter Roeck, broonie, Enric Balletbo i Serra,
Benson Leung, Cheng-Yi Chiang
fix W=1 warning
sound/soc/codecs/cros_ec_codec.c:1056:36: warning:
'cros_ec_codec_acpi_id' defined but not used
[-Wunused-const-variable=]
1056 | static const struct acpi_device_id cros_ec_codec_acpi_id[] = {
| ^~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/cros_ec_codec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index 8d45c628e988..f23956cf4ed8 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
@@ -1053,11 +1053,13 @@ static const struct of_device_id cros_ec_codec_of_match[] = {
MODULE_DEVICE_TABLE(of, cros_ec_codec_of_match);
#endif
+#ifdef CONFIG_ACPI
static const struct acpi_device_id cros_ec_codec_acpi_id[] = {
{ "GOOG0013", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, cros_ec_codec_acpi_id);
+#endif
static struct platform_driver cros_ec_codec_platform_driver = {
.driver = {
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH 03/11] ASoC: codecs: da7210: fix kernel-doc
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Support Opensource,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, open list
Fix W=1 warning, the kernel-doc syntax was probably from Doxygen?
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/da7210.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
index 0c99dcf242e4..2bb727dd3a20 100644
--- a/sound/soc/codecs/da7210.c
+++ b/sound/soc/codecs/da7210.c
@@ -971,14 +971,16 @@ static int da7210_set_dai_sysclk(struct snd_soc_dai *codec_dai,
/**
* da7210_set_dai_pll :Configure the codec PLL
- * @param codec_dai : pointer to codec DAI
- * @param pll_id : da7210 has only one pll, so pll_id is always zero
- * @param fref : MCLK frequency, should be < 20MHz
- * @param fout : FsDM value, Refer page 44 & 45 of datasheet
- * @return int : Zero for success, negative error code for error
+ * @codec_dai: pointer to codec DAI
+ * @pll_id: da7210 has only one pll, so pll_id is always zero
+ * @source: clock source
+ * @fref: MCLK frequency, should be < 20MHz
+ * @fout: FsDM value, Refer page 44 & 45 of datasheet
*
* Note: Supported PLL input frequencies are 12MHz, 13MHz, 13.5MHz, 14.4MHz,
* 19.2MHz, 19.6MHz and 19.8MHz
+ *
+ * Return: Zero for success, negative error code for error
*/
static int da7210_set_dai_pll(struct snd_soc_dai *codec_dai, int pll_id,
int source, unsigned int fref, unsigned int fout)
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 03/11] ASoC: codecs: da7210: fix kernel-doc
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, Support Opensource, tiwai, open list,
Takashi Iwai, Liam Girdwood, broonie
Fix W=1 warning, the kernel-doc syntax was probably from Doxygen?
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/da7210.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
index 0c99dcf242e4..2bb727dd3a20 100644
--- a/sound/soc/codecs/da7210.c
+++ b/sound/soc/codecs/da7210.c
@@ -971,14 +971,16 @@ static int da7210_set_dai_sysclk(struct snd_soc_dai *codec_dai,
/**
* da7210_set_dai_pll :Configure the codec PLL
- * @param codec_dai : pointer to codec DAI
- * @param pll_id : da7210 has only one pll, so pll_id is always zero
- * @param fref : MCLK frequency, should be < 20MHz
- * @param fout : FsDM value, Refer page 44 & 45 of datasheet
- * @return int : Zero for success, negative error code for error
+ * @codec_dai: pointer to codec DAI
+ * @pll_id: da7210 has only one pll, so pll_id is always zero
+ * @source: clock source
+ * @fref: MCLK frequency, should be < 20MHz
+ * @fout: FsDM value, Refer page 44 & 45 of datasheet
*
* Note: Supported PLL input frequencies are 12MHz, 13MHz, 13.5MHz, 14.4MHz,
* 19.2MHz, 19.6MHz and 19.8MHz
+ *
+ * Return: Zero for success, negative error code for error
*/
static int da7210_set_dai_pll(struct snd_soc_dai *codec_dai, int pll_id,
int source, unsigned int fref, unsigned int fout)
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* RE: [PATCH 03/11] ASoC: codecs: da7210: fix kernel-doc
2020-07-01 18:24 ` Pierre-Louis Bossart
@ 2020-07-03 9:22 ` Adam Thomson
-1 siblings, 0 replies; 29+ messages in thread
From: Adam Thomson @ 2020-07-03 9:22 UTC (permalink / raw)
To: Pierre-Louis Bossart, alsa-devel
Cc: tiwai, broonie, Support Opensource, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, open list
On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
> Fix W=1 warning, the kernel-doc syntax was probably from Doxygen?
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
So is the issue that the Kernel warning mechanism doesn't like Doxygen syntax?
If so then:
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> ---
> sound/soc/codecs/da7210.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
> index 0c99dcf242e4..2bb727dd3a20 100644
> --- a/sound/soc/codecs/da7210.c
> +++ b/sound/soc/codecs/da7210.c
> @@ -971,14 +971,16 @@ static int da7210_set_dai_sysclk(struct snd_soc_dai
> *codec_dai,
>
> /**
> * da7210_set_dai_pll :Configure the codec PLL
> - * @param codec_dai : pointer to codec DAI
> - * @param pll_id : da7210 has only one pll, so pll_id is always zero
> - * @param fref : MCLK frequency, should be < 20MHz
> - * @param fout : FsDM value, Refer page 44 & 45 of datasheet
> - * @return int : Zero for success, negative error code for error
> + * @codec_dai: pointer to codec DAI
> + * @pll_id: da7210 has only one pll, so pll_id is always zero
> + * @source: clock source
> + * @fref: MCLK frequency, should be < 20MHz
> + * @fout: FsDM value, Refer page 44 & 45 of datasheet
> *
> * Note: Supported PLL input frequencies are 12MHz, 13MHz, 13.5MHz, 14.4MHz,
> * 19.2MHz, 19.6MHz and 19.8MHz
> + *
> + * Return: Zero for success, negative error code for error
> */
> static int da7210_set_dai_pll(struct snd_soc_dai *codec_dai, int pll_id,
> int source, unsigned int fref, unsigned int fout)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE: [PATCH 03/11] ASoC: codecs: da7210: fix kernel-doc
@ 2020-07-03 9:22 ` Adam Thomson
0 siblings, 0 replies; 29+ messages in thread
From: Adam Thomson @ 2020-07-03 9:22 UTC (permalink / raw)
To: Pierre-Louis Bossart, alsa-devel
Cc: Support Opensource, Liam Girdwood, tiwai, open list,
Takashi Iwai, broonie
On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
> Fix W=1 warning, the kernel-doc syntax was probably from Doxygen?
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
So is the issue that the Kernel warning mechanism doesn't like Doxygen syntax?
If so then:
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> ---
> sound/soc/codecs/da7210.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
> index 0c99dcf242e4..2bb727dd3a20 100644
> --- a/sound/soc/codecs/da7210.c
> +++ b/sound/soc/codecs/da7210.c
> @@ -971,14 +971,16 @@ static int da7210_set_dai_sysclk(struct snd_soc_dai
> *codec_dai,
>
> /**
> * da7210_set_dai_pll :Configure the codec PLL
> - * @param codec_dai : pointer to codec DAI
> - * @param pll_id : da7210 has only one pll, so pll_id is always zero
> - * @param fref : MCLK frequency, should be < 20MHz
> - * @param fout : FsDM value, Refer page 44 & 45 of datasheet
> - * @return int : Zero for success, negative error code for error
> + * @codec_dai: pointer to codec DAI
> + * @pll_id: da7210 has only one pll, so pll_id is always zero
> + * @source: clock source
> + * @fref: MCLK frequency, should be < 20MHz
> + * @fout: FsDM value, Refer page 44 & 45 of datasheet
> *
> * Note: Supported PLL input frequencies are 12MHz, 13MHz, 13.5MHz, 14.4MHz,
> * 19.2MHz, 19.6MHz and 19.8MHz
> + *
> + * Return: Zero for success, negative error code for error
> */
> static int da7210_set_dai_pll(struct snd_soc_dai *codec_dai, int pll_id,
> int source, unsigned int fref, unsigned int fout)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used' warning
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Support Opensource,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, open list
fix W=1 warning
sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
defined but not used [-Wunused-const-variable=]
1711 | static const struct acpi_device_id da7219_acpi_match[] = {
| ^~~~~~~~~~~~~~~~~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/da7219.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index f2520a6c7875..153ea30b5a8f 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -1708,11 +1708,13 @@ static const struct of_device_id da7219_of_match[] = {
};
MODULE_DEVICE_TABLE(of, da7219_of_match);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id da7219_acpi_match[] = {
{ .id = "DLGS7219", },
{ }
};
MODULE_DEVICE_TABLE(acpi, da7219_acpi_match);
+#endif
static enum da7219_micbias_voltage
da7219_fw_micbias_lvl(struct device *dev, u32 val)
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used' warning
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, Support Opensource, tiwai, open list,
Takashi Iwai, Liam Girdwood, broonie
fix W=1 warning
sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
defined but not used [-Wunused-const-variable=]
1711 | static const struct acpi_device_id da7219_acpi_match[] = {
| ^~~~~~~~~~~~~~~~~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/da7219.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index f2520a6c7875..153ea30b5a8f 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -1708,11 +1708,13 @@ static const struct of_device_id da7219_of_match[] = {
};
MODULE_DEVICE_TABLE(of, da7219_of_match);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id da7219_acpi_match[] = {
{ .id = "DLGS7219", },
{ }
};
MODULE_DEVICE_TABLE(acpi, da7219_acpi_match);
+#endif
static enum da7219_micbias_voltage
da7219_fw_micbias_lvl(struct device *dev, u32 val)
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* RE: [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used' warning
2020-07-01 18:24 ` Pierre-Louis Bossart
@ 2020-07-03 9:33 ` Adam Thomson
-1 siblings, 0 replies; 29+ messages in thread
From: Adam Thomson @ 2020-07-03 9:33 UTC (permalink / raw)
To: Pierre-Louis Bossart, alsa-devel
Cc: tiwai, broonie, Support Opensource, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, open list
On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
> fix W=1 warning
>
> sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
> defined but not used [-Wunused-const-variable=]
> 1711 | static const struct acpi_device_id da7219_acpi_match[] = {
> | ^~~~~~~~~~~~~~~~~
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/codecs/da7219.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> index f2520a6c7875..153ea30b5a8f 100644
> --- a/sound/soc/codecs/da7219.c
> +++ b/sound/soc/codecs/da7219.c
> @@ -1708,11 +1708,13 @@ static const struct of_device_id da7219_of_match[] =
> {
> };
> MODULE_DEVICE_TABLE(of, da7219_of_match);
>
> +#ifdef CONFIG_ACPI
> static const struct acpi_device_id da7219_acpi_match[] = {
> { .id = "DLGS7219", },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, da7219_acpi_match);
> +#endif
I think this will break non-ACPI builds as this symbol is used in the
declaration of 'da7219_i2c_driver', without conditional compilation surrounding
it. Unless of course I'm missing something. Could we instead use
'__maybe_unused' to avoid this warning?
>
> static enum da7219_micbias_voltage
> da7219_fw_micbias_lvl(struct device *dev, u32 val)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 29+ messages in thread* RE: [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used' warning
@ 2020-07-03 9:33 ` Adam Thomson
0 siblings, 0 replies; 29+ messages in thread
From: Adam Thomson @ 2020-07-03 9:33 UTC (permalink / raw)
To: Pierre-Louis Bossart, alsa-devel
Cc: Support Opensource, Liam Girdwood, tiwai, open list,
Takashi Iwai, broonie
On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
> fix W=1 warning
>
> sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
> defined but not used [-Wunused-const-variable=]
> 1711 | static const struct acpi_device_id da7219_acpi_match[] = {
> | ^~~~~~~~~~~~~~~~~
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/codecs/da7219.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> index f2520a6c7875..153ea30b5a8f 100644
> --- a/sound/soc/codecs/da7219.c
> +++ b/sound/soc/codecs/da7219.c
> @@ -1708,11 +1708,13 @@ static const struct of_device_id da7219_of_match[] =
> {
> };
> MODULE_DEVICE_TABLE(of, da7219_of_match);
>
> +#ifdef CONFIG_ACPI
> static const struct acpi_device_id da7219_acpi_match[] = {
> { .id = "DLGS7219", },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, da7219_acpi_match);
> +#endif
I think this will break non-ACPI builds as this symbol is used in the
declaration of 'da7219_i2c_driver', without conditional compilation surrounding
it. Unless of course I'm missing something. Could we instead use
'__maybe_unused' to avoid this warning?
>
> static enum da7219_micbias_voltage
> da7219_fw_micbias_lvl(struct device *dev, u32 val)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 29+ messages in thread* RE: [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used' warning
2020-07-03 9:33 ` Adam Thomson
@ 2020-07-03 9:57 ` Adam Thomson
-1 siblings, 0 replies; 29+ messages in thread
From: Adam Thomson @ 2020-07-03 9:57 UTC (permalink / raw)
To: Adam Thomson, Pierre-Louis Bossart, alsa-devel
Cc: tiwai, broonie, Support Opensource, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, open list
On 03 July 2020 10:33, Adam Thomson wrote
> On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
>
> > fix W=1 warning
> >
> > sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
> > defined but not used [-Wunused-const-variable=]
> > 1711 | static const struct acpi_device_id da7219_acpi_match[] = {
> > | ^~~~~~~~~~~~~~~~~
> >
> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > ---
> > sound/soc/codecs/da7219.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> > index f2520a6c7875..153ea30b5a8f 100644
> > --- a/sound/soc/codecs/da7219.c
> > +++ b/sound/soc/codecs/da7219.c
> > @@ -1708,11 +1708,13 @@ static const struct of_device_id da7219_of_match[]
> =
> > {
> > };
> > MODULE_DEVICE_TABLE(of, da7219_of_match);
> >
> > +#ifdef CONFIG_ACPI
> > static const struct acpi_device_id da7219_acpi_match[] = {
> > { .id = "DLGS7219", },
> > { }
> > };
> > MODULE_DEVICE_TABLE(acpi, da7219_acpi_match);
> > +#endif
>
> I think this will break non-ACPI builds as this symbol is used in the
> declaration of 'da7219_i2c_driver', without conditional compilation surrounding
> it. Unless of course I'm missing something. Could we instead use
> '__maybe_unused' to avoid this warning?
Obviously a slow start to the day for my brain. You've obviously built test this
given the intention behind this is for non-ACPI builds. Will get more coffee
shortly.
Still wonder if '__maybe_unused' might be nicer as per suspend/resume functions
on platforms which don't include PM_OPS. Either way though:
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
>
> >
> > static enum da7219_micbias_voltage
> > da7219_fw_micbias_lvl(struct device *dev, u32 val)
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 29+ messages in thread* RE: [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used' warning
@ 2020-07-03 9:57 ` Adam Thomson
0 siblings, 0 replies; 29+ messages in thread
From: Adam Thomson @ 2020-07-03 9:57 UTC (permalink / raw)
To: Adam Thomson, Pierre-Louis Bossart, alsa-devel
Cc: Support Opensource, Liam Girdwood, tiwai, open list,
Takashi Iwai, broonie
On 03 July 2020 10:33, Adam Thomson wrote
> On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
>
> > fix W=1 warning
> >
> > sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
> > defined but not used [-Wunused-const-variable=]
> > 1711 | static const struct acpi_device_id da7219_acpi_match[] = {
> > | ^~~~~~~~~~~~~~~~~
> >
> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > ---
> > sound/soc/codecs/da7219.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> > index f2520a6c7875..153ea30b5a8f 100644
> > --- a/sound/soc/codecs/da7219.c
> > +++ b/sound/soc/codecs/da7219.c
> > @@ -1708,11 +1708,13 @@ static const struct of_device_id da7219_of_match[]
> =
> > {
> > };
> > MODULE_DEVICE_TABLE(of, da7219_of_match);
> >
> > +#ifdef CONFIG_ACPI
> > static const struct acpi_device_id da7219_acpi_match[] = {
> > { .id = "DLGS7219", },
> > { }
> > };
> > MODULE_DEVICE_TABLE(acpi, da7219_acpi_match);
> > +#endif
>
> I think this will break non-ACPI builds as this symbol is used in the
> declaration of 'da7219_i2c_driver', without conditional compilation surrounding
> it. Unless of course I'm missing something. Could we instead use
> '__maybe_unused' to avoid this warning?
Obviously a slow start to the day for my brain. You've obviously built test this
given the intention behind this is for non-ACPI builds. Will get more coffee
shortly.
Still wonder if '__maybe_unused' might be nicer as per suspend/resume functions
on platforms which don't include PM_OPS. Either way though:
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
>
> >
> > static enum da7219_micbias_voltage
> > da7219_fw_micbias_lvl(struct device *dev, u32 val)
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH 05/11] ASoC: codecs: es8316: fix 'defined but not used' warning
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Katsuhiro Suzuki, Daniel Drake,
open list
Fix W=1 warning
sound/soc/codecs/es8316.c:842:36: warning: 'es8316_acpi_match' defined
but not used [-Wunused-const-variable=]
842 | static const struct acpi_device_id es8316_acpi_match[] = {
| ^~~~~~~~~~~~~~~~~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/es8316.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
index 36eef1fb3d18..70af35c5f727 100644
--- a/sound/soc/codecs/es8316.c
+++ b/sound/soc/codecs/es8316.c
@@ -839,11 +839,13 @@ static const struct of_device_id es8316_of_match[] = {
};
MODULE_DEVICE_TABLE(of, es8316_of_match);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id es8316_acpi_match[] = {
{"ESSX8316", 0},
{},
};
MODULE_DEVICE_TABLE(acpi, es8316_acpi_match);
+#endif
static struct i2c_driver es8316_i2c_driver = {
.driver = {
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 05/11] ASoC: codecs: es8316: fix 'defined but not used' warning
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, Liam Girdwood, tiwai, open list,
Takashi Iwai, Katsuhiro Suzuki, broonie, Daniel Drake
Fix W=1 warning
sound/soc/codecs/es8316.c:842:36: warning: 'es8316_acpi_match' defined
but not used [-Wunused-const-variable=]
842 | static const struct acpi_device_id es8316_acpi_match[] = {
| ^~~~~~~~~~~~~~~~~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/es8316.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
index 36eef1fb3d18..70af35c5f727 100644
--- a/sound/soc/codecs/es8316.c
+++ b/sound/soc/codecs/es8316.c
@@ -839,11 +839,13 @@ static const struct of_device_id es8316_of_match[] = {
};
MODULE_DEVICE_TABLE(of, es8316_of_match);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id es8316_acpi_match[] = {
{"ESSX8316", 0},
{},
};
MODULE_DEVICE_TABLE(acpi, es8316_acpi_match);
+#endif
static struct i2c_driver es8316_i2c_driver = {
.driver = {
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH 06/11] ASoC: codecs: max98390: fix 'defined but not used' warning
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Steve Lee, open list
Fix W=1 warning and removed unused table. In this case this a
duplicate of
static const struct of_device_id max98390_of_match[] = {
{ .compatible = "maxim,max98390", },
{}
};
MODULE_DEVICE_TABLE(of, max98390_of_match);
already used in the rest of the code.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/max98390.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
index b345e626956d..3e8094241645 100644
--- a/sound/soc/codecs/max98390.c
+++ b/sound/soc/codecs/max98390.c
@@ -944,14 +944,6 @@ static const struct regmap_config max98390_regmap = {
.cache_type = REGCACHE_RBTREE,
};
-#ifdef CONFIG_OF
-static const struct of_device_id max98390_dt_ids[] = {
- { .compatible = "maxim,max98390", },
- { }
-};
-MODULE_DEVICE_TABLE(of, max98390_dt_ids);
-#endif
-
static int max98390_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 06/11] ASoC: codecs: max98390: fix 'defined but not used' warning
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, Steve Lee, Liam Girdwood, tiwai, open list,
Takashi Iwai, broonie
Fix W=1 warning and removed unused table. In this case this a
duplicate of
static const struct of_device_id max98390_of_match[] = {
{ .compatible = "maxim,max98390", },
{}
};
MODULE_DEVICE_TABLE(of, max98390_of_match);
already used in the rest of the code.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/max98390.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
index b345e626956d..3e8094241645 100644
--- a/sound/soc/codecs/max98390.c
+++ b/sound/soc/codecs/max98390.c
@@ -944,14 +944,6 @@ static const struct regmap_config max98390_regmap = {
.cache_type = REGCACHE_RBTREE,
};
-#ifdef CONFIG_OF
-static const struct of_device_id max98390_dt_ids[] = {
- { .compatible = "maxim,max98390", },
- { }
-};
-MODULE_DEVICE_TABLE(of, max98390_dt_ids);
-#endif
-
static int max98390_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH 07/11] ASoC: codecs: rt*: fix 'defined but not used' warning
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Oder Chiou, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, open list
Fix W=1 warning when ACPI is not defined
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/rt274.c | 2 ++
sound/soc/codecs/rt286.c | 2 ++
sound/soc/codecs/rt298.c | 2 ++
sound/soc/codecs/rt5660.c | 2 ++
sound/soc/codecs/rt5677-spi.c | 2 ++
5 files changed, 10 insertions(+)
diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c
index cbb5e176d11a..40a28fb4fd09 100644
--- a/sound/soc/codecs/rt274.c
+++ b/sound/soc/codecs/rt274.c
@@ -1105,12 +1105,14 @@ static const struct i2c_device_id rt274_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, rt274_i2c_id);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt274_acpi_match[] = {
{ "10EC0274", 0 },
{ "INT34C2", 0 },
{},
};
MODULE_DEVICE_TABLE(acpi, rt274_acpi_match);
+#endif
static int rt274_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index 9593a9a27bf8..89b1c8b68004 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -1079,11 +1079,13 @@ static const struct i2c_device_id rt286_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, rt286_i2c_id);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt286_acpi_match[] = {
{ "INT343A", 0 },
{},
};
MODULE_DEVICE_TABLE(acpi, rt286_acpi_match);
+#endif
static const struct dmi_system_id force_combo_jack_table[] = {
{
diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c
index 7fc7d6181630..dc0273a5a11f 100644
--- a/sound/soc/codecs/rt298.c
+++ b/sound/soc/codecs/rt298.c
@@ -1145,11 +1145,13 @@ static const struct i2c_device_id rt298_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, rt298_i2c_id);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt298_acpi_match[] = {
{ "INT343A", 0 },
{},
};
MODULE_DEVICE_TABLE(acpi, rt298_acpi_match);
+#endif
static const struct dmi_system_id force_combo_jack_table[] = {
{
diff --git a/sound/soc/codecs/rt5660.c b/sound/soc/codecs/rt5660.c
index 78371e51bc34..9e3813f7583d 100644
--- a/sound/soc/codecs/rt5660.c
+++ b/sound/soc/codecs/rt5660.c
@@ -1241,12 +1241,14 @@ static const struct of_device_id rt5660_of_match[] = {
};
MODULE_DEVICE_TABLE(of, rt5660_of_match);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt5660_acpi_match[] = {
{ "10EC5660", 0 },
{ "10EC3277", 0 },
{ },
};
MODULE_DEVICE_TABLE(acpi, rt5660_acpi_match);
+#endif
static int rt5660_parse_dt(struct rt5660_priv *rt5660, struct device *dev)
{
diff --git a/sound/soc/codecs/rt5677-spi.c b/sound/soc/codecs/rt5677-spi.c
index 7bfade8b3d6e..95ac12a5cc6b 100644
--- a/sound/soc/codecs/rt5677-spi.c
+++ b/sound/soc/codecs/rt5677-spi.c
@@ -614,11 +614,13 @@ static int rt5677_spi_probe(struct spi_device *spi)
return ret;
}
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt5677_spi_acpi_id[] = {
{ "RT5677AA", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, rt5677_spi_acpi_id);
+#endif
static struct spi_driver rt5677_spi_driver = {
.driver = {
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 07/11] ASoC: codecs: rt*: fix 'defined but not used' warning
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Oder Chiou, Liam Girdwood, tiwai, open list, Takashi Iwai,
Pierre-Louis Bossart, broonie
Fix W=1 warning when ACPI is not defined
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/rt274.c | 2 ++
sound/soc/codecs/rt286.c | 2 ++
sound/soc/codecs/rt298.c | 2 ++
sound/soc/codecs/rt5660.c | 2 ++
sound/soc/codecs/rt5677-spi.c | 2 ++
5 files changed, 10 insertions(+)
diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c
index cbb5e176d11a..40a28fb4fd09 100644
--- a/sound/soc/codecs/rt274.c
+++ b/sound/soc/codecs/rt274.c
@@ -1105,12 +1105,14 @@ static const struct i2c_device_id rt274_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, rt274_i2c_id);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt274_acpi_match[] = {
{ "10EC0274", 0 },
{ "INT34C2", 0 },
{},
};
MODULE_DEVICE_TABLE(acpi, rt274_acpi_match);
+#endif
static int rt274_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index 9593a9a27bf8..89b1c8b68004 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -1079,11 +1079,13 @@ static const struct i2c_device_id rt286_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, rt286_i2c_id);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt286_acpi_match[] = {
{ "INT343A", 0 },
{},
};
MODULE_DEVICE_TABLE(acpi, rt286_acpi_match);
+#endif
static const struct dmi_system_id force_combo_jack_table[] = {
{
diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c
index 7fc7d6181630..dc0273a5a11f 100644
--- a/sound/soc/codecs/rt298.c
+++ b/sound/soc/codecs/rt298.c
@@ -1145,11 +1145,13 @@ static const struct i2c_device_id rt298_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, rt298_i2c_id);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt298_acpi_match[] = {
{ "INT343A", 0 },
{},
};
MODULE_DEVICE_TABLE(acpi, rt298_acpi_match);
+#endif
static const struct dmi_system_id force_combo_jack_table[] = {
{
diff --git a/sound/soc/codecs/rt5660.c b/sound/soc/codecs/rt5660.c
index 78371e51bc34..9e3813f7583d 100644
--- a/sound/soc/codecs/rt5660.c
+++ b/sound/soc/codecs/rt5660.c
@@ -1241,12 +1241,14 @@ static const struct of_device_id rt5660_of_match[] = {
};
MODULE_DEVICE_TABLE(of, rt5660_of_match);
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt5660_acpi_match[] = {
{ "10EC5660", 0 },
{ "10EC3277", 0 },
{ },
};
MODULE_DEVICE_TABLE(acpi, rt5660_acpi_match);
+#endif
static int rt5660_parse_dt(struct rt5660_priv *rt5660, struct device *dev)
{
diff --git a/sound/soc/codecs/rt5677-spi.c b/sound/soc/codecs/rt5677-spi.c
index 7bfade8b3d6e..95ac12a5cc6b 100644
--- a/sound/soc/codecs/rt5677-spi.c
+++ b/sound/soc/codecs/rt5677-spi.c
@@ -614,11 +614,13 @@ static int rt5677_spi_probe(struct spi_device *spi)
return ret;
}
+#ifdef CONFIG_ACPI
static const struct acpi_device_id rt5677_spi_acpi_id[] = {
{ "RT5677AA", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, rt5677_spi_acpi_id);
+#endif
static struct spi_driver rt5677_spi_driver = {
.driver = {
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH 08/11] ASoC: codecs: rt5659: add _maybe_unused as needed
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Oder Chiou, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, open list
Fix W=1 warning by adding __maybe_unused. Maintainers for this file
may want to double-check if those definitions are necessary.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/rt5659.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c
index 541fc6f1089b..40a954e480a5 100644
--- a/sound/soc/codecs/rt5659.c
+++ b/sound/soc/codecs/rt5659.c
@@ -1204,31 +1204,31 @@ static unsigned int rt5659_asrc_clk_map_values[] = {
0, 1, 2, 3, 5, 6,
};
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_da_sto_asrc_enum, RT5659_ASRC_2, RT5659_DA_STO_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_da_monol_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_L_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_da_monor_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_R_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_ad_sto1_asrc_enum, RT5659_ASRC_2, RT5659_AD_STO1_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_ad_sto2_asrc_enum, RT5659_ASRC_3, RT5659_AD_STO2_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_ad_monol_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_L_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_ad_monor_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_R_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 08/11] ASoC: codecs: rt5659: add _maybe_unused as needed
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Oder Chiou, Liam Girdwood, tiwai, open list, Takashi Iwai,
Pierre-Louis Bossart, broonie
Fix W=1 warning by adding __maybe_unused. Maintainers for this file
may want to double-check if those definitions are necessary.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/rt5659.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c
index 541fc6f1089b..40a954e480a5 100644
--- a/sound/soc/codecs/rt5659.c
+++ b/sound/soc/codecs/rt5659.c
@@ -1204,31 +1204,31 @@ static unsigned int rt5659_asrc_clk_map_values[] = {
0, 1, 2, 3, 5, 6,
};
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_da_sto_asrc_enum, RT5659_ASRC_2, RT5659_DA_STO_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_da_monol_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_L_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_da_monor_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_R_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_ad_sto1_asrc_enum, RT5659_ASRC_2, RT5659_AD_STO1_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_ad_sto2_asrc_enum, RT5659_ASRC_3, RT5659_AD_STO2_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_ad_monol_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_L_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
-static SOC_VALUE_ENUM_SINGLE_DECL(
+static __maybe_unused SOC_VALUE_ENUM_SINGLE_DECL(
rt5659_ad_monor_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_R_T_SFT, 0x7,
rt5659_asrc_clk_src, rt5659_asrc_clk_map_values);
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH 09/11] ASoC: codecs: rt5631: fix kernel-doc
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Oder Chiou, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, open list
Fix W=1 warning, spurious kernel-doc start and missing arguments
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/rt5631.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
index b5184f0e10e3..653da3eaf355 100644
--- a/sound/soc/codecs/rt5631.c
+++ b/sound/soc/codecs/rt5631.c
@@ -64,7 +64,7 @@ static const struct reg_default rt5631_reg[] = {
{ RT5631_PSEUDO_SPATL_CTRL, 0x0553 },
};
-/**
+/*
* rt5631_write_index - write index register of 2nd layer
*/
static void rt5631_write_index(struct snd_soc_component *component,
@@ -74,7 +74,7 @@ static void rt5631_write_index(struct snd_soc_component *component,
snd_soc_component_write(component, RT5631_INDEX_DATA, value);
}
-/**
+/*
* rt5631_read_index - read index register of 2nd layer
*/
static unsigned int rt5631_read_index(struct snd_soc_component *component,
@@ -359,6 +359,7 @@ static int check_adcr_select(struct snd_soc_dapm_widget *source,
/**
* onebit_depop_power_stage - auto depop in power stage.
+ * @component: ASoC component
* @enable: power on/off
*
* When power on/off headphone, the depop sequence is done by hardware.
@@ -397,6 +398,7 @@ static void onebit_depop_power_stage(struct snd_soc_component *component, int en
/**
* onebit_depop_mute_stage - auto depop in mute stage.
+ * @component: ASoC component
* @enable: mute/unmute
*
* When mute/unmute headphone, the depop sequence is done by hardware.
@@ -435,6 +437,7 @@ static void onebit_depop_mute_stage(struct snd_soc_component *component, int ena
/**
* onebit_depop_power_stage - step by step depop sequence in power stage.
+ * @component: ASoC component
* @enable: power on/off
*
* When power on/off headphone, the depop sequence is done in step by step.
@@ -507,6 +510,7 @@ static void depop_seq_power_stage(struct snd_soc_component *component, int enabl
/**
* depop_seq_mute_stage - step by step depop sequence in mute stage.
+ * @component: ASoC component
* @enable: mute/unmute
*
* When mute/unmute headphone, the depop sequence is done in step by step.
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 09/11] ASoC: codecs: rt5631: fix kernel-doc
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Oder Chiou, Liam Girdwood, tiwai, open list, Takashi Iwai,
Pierre-Louis Bossart, broonie
Fix W=1 warning, spurious kernel-doc start and missing arguments
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/rt5631.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
index b5184f0e10e3..653da3eaf355 100644
--- a/sound/soc/codecs/rt5631.c
+++ b/sound/soc/codecs/rt5631.c
@@ -64,7 +64,7 @@ static const struct reg_default rt5631_reg[] = {
{ RT5631_PSEUDO_SPATL_CTRL, 0x0553 },
};
-/**
+/*
* rt5631_write_index - write index register of 2nd layer
*/
static void rt5631_write_index(struct snd_soc_component *component,
@@ -74,7 +74,7 @@ static void rt5631_write_index(struct snd_soc_component *component,
snd_soc_component_write(component, RT5631_INDEX_DATA, value);
}
-/**
+/*
* rt5631_read_index - read index register of 2nd layer
*/
static unsigned int rt5631_read_index(struct snd_soc_component *component,
@@ -359,6 +359,7 @@ static int check_adcr_select(struct snd_soc_dapm_widget *source,
/**
* onebit_depop_power_stage - auto depop in power stage.
+ * @component: ASoC component
* @enable: power on/off
*
* When power on/off headphone, the depop sequence is done by hardware.
@@ -397,6 +398,7 @@ static void onebit_depop_power_stage(struct snd_soc_component *component, int en
/**
* onebit_depop_mute_stage - auto depop in mute stage.
+ * @component: ASoC component
* @enable: mute/unmute
*
* When mute/unmute headphone, the depop sequence is done by hardware.
@@ -435,6 +437,7 @@ static void onebit_depop_mute_stage(struct snd_soc_component *component, int ena
/**
* onebit_depop_power_stage - step by step depop sequence in power stage.
+ * @component: ASoC component
* @enable: power on/off
*
* When power on/off headphone, the depop sequence is done in step by step.
@@ -507,6 +510,7 @@ static void depop_seq_power_stage(struct snd_soc_component *component, int enabl
/**
* depop_seq_mute_stage - step by step depop sequence in mute stage.
+ * @component: ASoC component
* @enable: mute/unmute
*
* When mute/unmute headphone, the depop sequence is done in step by step.
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH 10/11] ASoC: codecs: tlv320aic26: fix kernel-doc warning
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto, open list
Fix W=1 warning. Remove spurious /** since there isn't any kernel-doc
comment in this file.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/tlv320aic26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c
index 032b39735643..4569bbc08acb 100644
--- a/sound/soc/codecs/tlv320aic26.c
+++ b/sound/soc/codecs/tlv320aic26.c
@@ -131,7 +131,7 @@ static int aic26_hw_params(struct snd_pcm_substream *substream,
return 0;
}
-/**
+/*
* aic26_mute - Mute control to reduce noise when changing audio format
*/
static int aic26_mute(struct snd_soc_dai *dai, int mute)
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 10/11] ASoC: codecs: tlv320aic26: fix kernel-doc warning
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, Kuninori Morimoto, Liam Girdwood, tiwai,
open list, Takashi Iwai, broonie
Fix W=1 warning. Remove spurious /** since there isn't any kernel-doc
comment in this file.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/tlv320aic26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c
index 032b39735643..4569bbc08acb 100644
--- a/sound/soc/codecs/tlv320aic26.c
+++ b/sound/soc/codecs/tlv320aic26.c
@@ -131,7 +131,7 @@ static int aic26_hw_params(struct snd_pcm_substream *substream,
return 0;
}
-/**
+/*
* aic26_mute - Mute control to reduce noise when changing audio format
*/
static int aic26_mute(struct snd_soc_dai *dai, int mute)
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH 11/11] ASoC: codecs: jz4770: add _maybe_unused as needed
2020-07-01 18:24 [PATCH 00/11] ASoC: codecs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
2020-07-01 18:24 ` Pierre-Louis Bossart
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Pierre-Louis Bossart, Paul Cercueil,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, open list
Fix W=1 warning by adding __maybe_unused. Maintainers for this file
may want to double-check if those definitions are necessary.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/jz4770.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c
index 34775aa62402..049a3022b130 100644
--- a/sound/soc/codecs/jz4770.c
+++ b/sound/soc/codecs/jz4770.c
@@ -303,7 +303,7 @@ static int jz4770_codec_digital_mute(struct snd_soc_dai *dai, int mute)
static const DECLARE_TLV_DB_MINMAX_MUTE(dac_tlv, -3100, 0);
static const DECLARE_TLV_DB_SCALE(adc_tlv, 0, 100, 0);
static const DECLARE_TLV_DB_MINMAX(out_tlv, -2500, 600);
-static const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0);
+static __maybe_unused const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0);
static const DECLARE_TLV_DB_SCALE(linein_tlv, -2500, 100, 0);
/* Unconditional controls. */
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PATCH 11/11] ASoC: codecs: jz4770: add _maybe_unused as needed
@ 2020-07-01 18:24 ` Pierre-Louis Bossart
0 siblings, 0 replies; 29+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-01 18:24 UTC (permalink / raw)
To: alsa-devel
Cc: Liam Girdwood, tiwai, open list, Takashi Iwai,
Pierre-Louis Bossart, Paul Cercueil, broonie
Fix W=1 warning by adding __maybe_unused. Maintainers for this file
may want to double-check if those definitions are necessary.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/jz4770.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c
index 34775aa62402..049a3022b130 100644
--- a/sound/soc/codecs/jz4770.c
+++ b/sound/soc/codecs/jz4770.c
@@ -303,7 +303,7 @@ static int jz4770_codec_digital_mute(struct snd_soc_dai *dai, int mute)
static const DECLARE_TLV_DB_MINMAX_MUTE(dac_tlv, -3100, 0);
static const DECLARE_TLV_DB_SCALE(adc_tlv, 0, 100, 0);
static const DECLARE_TLV_DB_MINMAX(out_tlv, -2500, 600);
-static const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0);
+static __maybe_unused const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0);
static const DECLARE_TLV_DB_SCALE(linein_tlv, -2500, 100, 0);
/* Unconditional controls. */
--
2.25.1
^ permalink raw reply related [flat|nested] 29+ messages in thread