All of lore.kernel.org
 help / color / mirror / Atom feed
* Missing BMP 565RGB video support
@ 2020-08-28 10:44 Trommel, Kees
  2020-09-01 11:07 ` Anatolij Gustschin
  0 siblings, 1 reply; 3+ messages in thread
From: Trommel, Kees @ 2020-08-28 10:44 UTC (permalink / raw)
  To: u-boot

Hi Agust,

The latest version of the U-Boot does not support conversion from 24BPP BMP to a 16BPP 565RGB encoded frame buffer. It uses always 555RGB encoding (see function video_bmp_display in video_bmp.c). Older versions of the U-Boot (e.g. 2015.04) supported this because the platform specific device driver passed not only the BPP but also the encoding.

Do you know whether this lost support was done on purpose or lost by accident?

I encountered this issue when trying to display a 24BPP BMP splash screen at an i.MX6 platform.

Kees.

---
This communication contains confidential information. If you are not the intended recipient please return this email to the sender and delete it from your records.

Diese Nachricht enthaelt vertrauliche Informationen. Sollten Sie nicht der beabsichtigte Empfaenger dieser E-mail sein, senden Sie bitte diese an den Absender zurueck und loeschen Sie die E-mail aus Ihrem System.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Missing BMP 565RGB video support
  2020-08-28 10:44 Missing BMP 565RGB video support Trommel, Kees
@ 2020-09-01 11:07 ` Anatolij Gustschin
  2020-09-02  8:29   ` Trommel, Kees
  0 siblings, 1 reply; 3+ messages in thread
From: Anatolij Gustschin @ 2020-09-01 11:07 UTC (permalink / raw)
  To: u-boot

Hi,

On Fri, 28 Aug 2020 10:44:55 +0000
Trommel, Kees (Contractor) kees.trommel.contractor at draeger.com wrote:

> Hi Agust,
> 
> The latest version of the U-Boot does not support conversion from
> 24BPP BMP to a 16BPP 565RGB encoded frame buffer. It uses always
> 555RGB encoding (see function video_bmp_display in video_bmp.c).
> Older versions of the U-Boot (e.g. 2015.04) supported this because
> the platform specific device driver passed not only the BPP but
> also the encoding.

in recent U-Boot we do not use old cfb_console driver which
supported 24bpp bitmaps. The DM video console driver still
dosn't support some framebuffer/bitmap BPP combinations, or
maybe your board config file does not define CONFIG_BMP_24BPP.
 
> Do you know whether this lost support was done on purpose
> or lost by accident?

This is probably due to DM video conversion, not all BPP
variants have been implemented with this yet.
 
> I encountered this issue when trying to display a 24BPP BMP
> splash screen at an i.MX6 platform.

Did you define CONFIG_BMP_24BPP in your board config file?
If not, could you do so and test the result? Thanks.

--
Anatolij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Missing BMP 565RGB video support
  2020-09-01 11:07 ` Anatolij Gustschin
@ 2020-09-02  8:29   ` Trommel, Kees
  0 siblings, 0 replies; 3+ messages in thread
From: Trommel, Kees @ 2020-09-02  8:29 UTC (permalink / raw)
  To: u-boot

Anatolij,

> Did you define CONFIG_BMP_24BPP in your board config file?

Yes. Without this define the command "bmp display <addr>" does not do anything if the given BMP is a 24BPP BMP. With this define the a 24 BPP BMP I displayed but with wrong colors because the framebuffer of my (i.MX6) board expects 56RGB encoded colors.

The issue is that the video_priv struct  does not have sufficient information to describe all the properties of the associated framebuffer. Current it only knows the BPP (defined by the field bpix) but not the required encoding. This could be fixe to the video_fb.h "gdfIndex" rather than the video.h "bpix" in the video_priv struct.

Kees.

-----Original Message-----
From: Anatolij Gustschin [mailto:agust at denx.de]
Sent: 01 September 2020 13:08
To: Trommel, Kees (Contractor) <kees.trommel.contractor@draeger.com>
Cc: u-boot at lists.denx.de
Subject: Re: Missing BMP 565RGB video support

Hi,

On Fri, 28 Aug 2020 10:44:55 +0000
Trommel, Kees (Contractor) kees.trommel.contractor at draeger.com wrote:

> Hi Agust,
>
> The latest version of the U-Boot does not support conversion from
> 24BPP BMP to a 16BPP 565RGB encoded frame buffer. It uses always
> 555RGB encoding (see function video_bmp_display in video_bmp.c).
> Older versions of the U-Boot (e.g. 2015.04) supported this because the
> platform specific device driver passed not only the BPP but also the
> encoding.

in recent U-Boot we do not use old cfb_console driver which supported 24bpp bitmaps. The DM video console driver still dosn't support some framebuffer/bitmap BPP combinations, or maybe your board config file does not define CONFIG_BMP_24BPP.

> Do you know whether this lost support was done on purpose or lost by
> accident?

This is probably due to DM video conversion, not all BPP variants have been implemented with this yet.

> I encountered this issue when trying to display a 24BPP BMP splash
> screen at an i.MX6 platform.

Did you define CONFIG_BMP_24BPP in your board config file?
If not, could you do so and test the result? Thanks.

--
Anatolij
---
This communication contains confidential information. If you are not the intended recipient please return this email to the sender and delete it from your records.

Diese Nachricht enthaelt vertrauliche Informationen. Sollten Sie nicht der beabsichtigte Empfaenger dieser E-mail sein, senden Sie bitte diese an den Absender zurueck und loeschen Sie die E-mail aus Ihrem System.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-02  8:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 10:44 Missing BMP 565RGB video support Trommel, Kees
2020-09-01 11:07 ` Anatolij Gustschin
2020-09-02  8:29   ` Trommel, Kees

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.