[PATCH RFC 0/3] perf/imx_ddr: Add system PMU support

[PATCH RFC 0/3] perf/imx_ddr: Add system PMU support

[Joakim Zhang]

Hi John,

The sysfs location for userspace to get the PMU identifier has chenged a
bit, this could be more formal.
	/sys/bus/event_source/devices/<PMU DEVICE>/identifier
Small update shoud be done from userspace :-)

Hi Will, Mark,

As we discussed before, this patch set intends to expose system PMU
identifier for userspace. Anyone wants to support system PMU must expose
this "identifier" property, since John will always read this file to get
system PMU's identifier.

Any comments?

Regards,
Joakim

Joakim Zhang (3):
  perf/imx_ddr: Add system PMU identifier for userspace
  bindings/perf/imx-ddr: update compatible string
  arch: arm64: imx8mq/m/n: remove unused compatible string

 .../devicetree/bindings/perf/fsl-imx-ddr.txt  |  4 +-
 arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  2 +-
 arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  2 +-
 arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  2 +-
 drivers/perf/fsl_imx8_ddr_perf.c              | 45 +++++++++++++++++--
 5 files changed, 48 insertions(+), 7 deletions(-)

-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH RFC 1/3] perf/imx_ddr: Add system PMU identifier for userspace

[Joakim Zhang]

The DDR Perf for i.MX8 is a system PMU whose axi id would different from
SoC to SoC. Need expose system PMU identifier for userspace which refer
to /sys/bus/event_source/devices/<PMU DEVICE>/identifier.

Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
 drivers/perf/fsl_imx8_ddr_perf.c | 45 +++++++++++++++++++++++++++++---
 1 file changed, 42 insertions(+), 3 deletions(-)

diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
index 95dca2cb5265..88addbffbbd0 100644
--- a/drivers/perf/fsl_imx8_ddr_perf.c
+++ b/drivers/perf/fsl_imx8_ddr_perf.c
@@ -50,21 +50,38 @@ static DEFINE_IDA(ddr_ida);
 
 struct fsl_ddr_devtype_data {
 	unsigned int quirks;    /* quirks needed for different DDR Perf core */
+	const char *identifier;	/* system PMU identifier for userspace */
 };
 
-static const struct fsl_ddr_devtype_data imx8_devtype_data;
+static const struct fsl_ddr_devtype_data imx8_devtype_data = {
+	.identifier = "i.MX8",
+};
+
+static const struct fsl_ddr_devtype_data imx8mq_devtype_data = {
+	.quirks = DDR_CAP_AXI_ID_FILTER,
+	.identifier = "i.MX8MQ",
+};
+
+static const struct fsl_ddr_devtype_data imx8mm_devtype_data = {
+	.quirks = DDR_CAP_AXI_ID_FILTER,
+	.identifier = "i.MX8MM",
+};
 
-static const struct fsl_ddr_devtype_data imx8m_devtype_data = {
+static const struct fsl_ddr_devtype_data imx8mn_devtype_data = {
 	.quirks = DDR_CAP_AXI_ID_FILTER,
+	.identifier = "i.MX8MN",
 };
 
 static const struct fsl_ddr_devtype_data imx8mp_devtype_data = {
 	.quirks = DDR_CAP_AXI_ID_FILTER_ENHANCED,
+	.identifier = "i.MX8MP",
 };
 
 static const struct of_device_id imx_ddr_pmu_dt_ids[] = {
 	{ .compatible = "fsl,imx8-ddr-pmu", .data = &imx8_devtype_data},
-	{ .compatible = "fsl,imx8m-ddr-pmu", .data = &imx8m_devtype_data},
+	{ .compatible = "fsl,imx8mq-ddr-pmu", .data = &imx8mq_devtype_data},
+	{ .compatible = "fsl,imx8mm-ddr-pmu", .data = &imx8mm_devtype_data},
+	{ .compatible = "fsl,imx8mn-ddr-pmu", .data = &imx8mn_devtype_data},
 	{ .compatible = "fsl,imx8mp-ddr-pmu", .data = &imx8mp_devtype_data},
 	{ /* sentinel */ }
 };
@@ -84,6 +101,27 @@ struct ddr_pmu {
 	int id;
 };
 
+static ssize_t ddr_perf_identifier_show(struct device *dev,
+					struct device_attribute *attr,
+					char *page)
+{
+	struct ddr_pmu *pmu = dev_get_drvdata(dev);
+
+	return sprintf(page, "%s\n", pmu->devtype_data->identifier);
+}
+
+static struct device_attribute ddr_perf_identifier_attr =
+	__ATTR(identifier, 0444, ddr_perf_identifier_show, NULL);
+
+static struct attribute *ddr_perf_identifier_attrs[] = {
+	&ddr_perf_identifier_attr.attr,
+	NULL,
+};
+
+static struct attribute_group ddr_perf_identifier_attr_group = {
+	.attrs = ddr_perf_identifier_attrs,
+};
+
 enum ddr_perf_filter_capabilities {
 	PERF_CAP_AXI_ID_FILTER = 0,
 	PERF_CAP_AXI_ID_FILTER_ENHANCED,
@@ -237,6 +275,7 @@ static const struct attribute_group *attr_groups[] = {
 	&ddr_perf_format_attr_group,
 	&ddr_perf_cpumask_attr_group,
 	&ddr_perf_filter_cap_attr_group,
+	&ddr_perf_identifier_attr_group,
 	NULL,
 };
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH RFC 2/3] bindings/perf/imx-ddr: update compatible string

[Joakim Zhang]

Update compatible string according to driver change.`

Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
 Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
index 7822a806ea0a..b27a1d4fec78 100644
--- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
+++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
@@ -4,7 +4,9 @@ Required properties:
 
 - compatible: should be one of:
 	"fsl,imx8-ddr-pmu"
-	"fsl,imx8m-ddr-pmu"
+	"fsl,imx8mq-ddr-pmu"
+	"fsl,imx8mm-ddr-pmu"
+	"fsl,imx8mn-ddr-pmu"
 	"fsl,imx8mp-ddr-pmu"
 
 - reg: physical address and size
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH RFC 3/3] arch: arm64: imx8mq/m/n: remove unused compatible string

[Joakim Zhang]

Remove the unused compatible string.

Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
 arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 1e5e11592f7b..136a6653252c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -894,7 +894,7 @@
 		};
 
 		ddr-pmu@3d800000 {
-			compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu";
+			compatible = "fsl,imx8mm-ddr-pmu";
 			reg = <0x3d800000 0x400000>;
 			interrupt-parent = <&gic>;
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index a44b5438e842..76c8db04b4f7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -793,7 +793,7 @@
 		};
 
 		ddr-pmu@3d800000 {
-			compatible = "fsl,imx8mn-ddr-pmu", "fsl,imx8m-ddr-pmu";
+			compatible = "fsl,imx8mn-ddr-pmu";
 			reg = <0x3d800000 0x400000>;
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
 		};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 6a1e83922c71..970ffcc664b8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1213,7 +1213,7 @@
 		};
 
 		ddr-pmu@3d800000 {
-			compatible = "fsl,imx8mq-ddr-pmu", "fsl,imx8m-ddr-pmu";
+			compatible = "fsl,imx8mq-ddr-pmu";
 			reg = <0x3d800000 0x400000>;
 			interrupt-parent = <&gic>;
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH RFC 2/3] bindings/perf/imx-ddr: update compatible string

[John Garry]

On 26/02/2020 07:34, Joakim Zhang wrote:
> Update compatible string according to driver change.`
> 
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> ---
>   Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> index 7822a806ea0a..b27a1d4fec78 100644
> --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> @@ -4,7 +4,9 @@ Required properties:
>   
>   - compatible: should be one of:
>   	"fsl,imx8-ddr-pmu"
> -	"fsl,imx8m-ddr-pmu"
> +	"fsl,imx8mq-ddr-pmu"
> +	"fsl,imx8mm-ddr-pmu"
> +	"fsl,imx8mn-ddr-pmu"
>   	"fsl,imx8mp-ddr-pmu"
>   

You need to ensure that you're not loosing backwards compatibility such 
that old firmware still works with a new kernel.

I see that the dts files use the generic "fsl,imx8m-ddr-pmu" and the 
per-Soc string as well, so looks ok, but I don't know about DT files out 
of mainline...

Thanks,
John

>   - reg: physical address and size
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH RFC 0/3] perf/imx_ddr: Add system PMU support

[Joakim Zhang]

Kindly Ping...

Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Joakim Zhang <qiangqing.zhang@nxp.com>
> Sent: 2020年2月26日 15:35
> To: john.garry@huawei.com; will@kernel.org; mark.rutland@arm.com
> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH RFC 0/3] perf/imx_ddr: Add system PMU support
> 
> Hi John,
> 
> The sysfs location for userspace to get the PMU identifier has chenged a bit,
> this could be more formal.
> 	/sys/bus/event_source/devices/<PMU DEVICE>/identifier Small update
> shoud be done from userspace :-)
> 
> Hi Will, Mark,
> 
> As we discussed before, this patch set intends to expose system PMU identifier
> for userspace. Anyone wants to support system PMU must expose this
> "identifier" property, since John will always read this file to get system PMU's
> identifier.
> 
> Any comments?
> 
> Regards,
> Joakim
> 
> Joakim Zhang (3):
>   perf/imx_ddr: Add system PMU identifier for userspace
>   bindings/perf/imx-ddr: update compatible string
>   arch: arm64: imx8mq/m/n: remove unused compatible string
> 
>  .../devicetree/bindings/perf/fsl-imx-ddr.txt  |  4 +-
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  2 +-
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  2 +-
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  2 +-
>  drivers/perf/fsl_imx8_ddr_perf.c              | 45 +++++++++++++++++--
>  5 files changed, 48 insertions(+), 7 deletions(-)
> 
> --
> 2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH RFC 0/3] perf/imx_ddr: Add system PMU support

[John Garry]

On 11/03/2020 08:52, Joakim Zhang wrote:
> 
> Kindly Ping...
> 
> Best Regards,
> Joakim Zhang
> 
>> -----Original Message-----
>> From: Joakim Zhang <qiangqing.zhang@nxp.com>
>> Sent: 2020年2月26日 15:35
>> To: john.garry@huawei.com; will@kernel.org; mark.rutland@arm.com
>> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org
>> Subject: [PATCH RFC 0/3] perf/imx_ddr: Add system PMU support
>>
>> Hi John,
>>
>> The sysfs location for userspace to get the PMU identifier has chenged a bit,
>> this could be more formal.
>> 	/sys/bus/event_source/devices/<PMU DEVICE>/identifier Small update
>> shoud be done from userspace :-)

To me, that looks ok. Maybe Mark or Will would like the file 
renamed/relocated.

And I already gave a comment on " [PATCH RFC 2/3] bindings/perf/imx-ddr: 
update compatible string"

Thanks,
John

>>
>> Hi Will, Mark,
>>
>> As we discussed before, this patch set intends to expose system PMU identifier
>> for userspace. Anyone wants to support system PMU must expose this
>> "identifier" property, since John will always read this file to get system PMU's
>> identifier.
>>
>> Any comments?
>>
>> Regards,
>> Joakim
>>
>> Joakim Zhang (3):
>>    perf/imx_ddr: Add system PMU identifier for userspace
>>    bindings/perf/imx-ddr: update compatible string
>>    arch: arm64: imx8mq/m/n: remove unused compatible string
>>
>>   .../devicetree/bindings/perf/fsl-imx-ddr.txt  |  4 +-
>>   arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  2 +-
>>   arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  2 +-
>>   arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  2 +-
>>   drivers/perf/fsl_imx8_ddr_perf.c              | 45 +++++++++++++++++--
>>   5 files changed, 48 insertions(+), 7 deletions(-)
>>
>> --
>> 2.17.1
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH RFC 2/3] bindings/perf/imx-ddr: update compatible string

[Joakim Zhang]

> -----Original Message-----
> From: John Garry <john.garry@huawei.com>
> Sent: 2020年3月3日 20:04
> To: Joakim Zhang <qiangqing.zhang@nxp.com>; will@kernel.org;
> mark.rutland@arm.com
> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH RFC 2/3] bindings/perf/imx-ddr: update compatible string
> 
> On 26/02/2020 07:34, Joakim Zhang wrote:
> > Update compatible string according to driver change.`
> >
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> > ---
> >   Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > index 7822a806ea0a..b27a1d4fec78 100644
> > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > @@ -4,7 +4,9 @@ Required properties:
> >
> >   - compatible: should be one of:
> >   	"fsl,imx8-ddr-pmu"
> > -	"fsl,imx8m-ddr-pmu"
> > +	"fsl,imx8mq-ddr-pmu"
> > +	"fsl,imx8mm-ddr-pmu"
> > +	"fsl,imx8mn-ddr-pmu"
> >   	"fsl,imx8mp-ddr-pmu"
> >
> 
> You need to ensure that you're not loosing backwards compatibility such that
> old firmware still works with a new kernel.
> 
> I see that the dts files use the generic "fsl,imx8m-ddr-pmu" and the per-Soc
> string as well, so looks ok, but I don't know about DT files out of mainline...
This was ignored, sorry for that. This change is in .dtsi file, per soc only have one, so it's safe for .dts out of mainline.
Or retain "fsl,imx8m-ddr-pmu" as a backwards compatibility without identifier setting? It's may be unnecessary.

Best Regards,
Joakim Zhang
> Thanks,
> John
> 
> >   - reg: physical address and size
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel