From: Sandor Yu <sandor.yu@nxp.com> To: Neil Armstrong <narmstrong@baylibre.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "andrzej.hajda@intel.com" <andrzej.hajda@intel.com>, "robert.foss@linaro.org" <robert.foss@linaro.org>, "Laurent.pinchart@ideasonboard.com" <Laurent.pinchart@ideasonboard.com>, "jonas@kwiboo.se" <jonas@kwiboo.se>, "jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com> Cc: "S.J. Wang" <shengjiu.wang@nxp.com>, "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>, "maxime@cerno.tech" <maxime@cerno.tech>, "harry.wentland@amd.com" <harry.wentland@amd.com>, "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>, "amuel@sholland.org" <amuel@sholland.org> Subject: RE: [EXT] Re: [PATCH v1 3/5] drm: bridge: dw_hdmi: Enable GCP only for Deep Color Date: Thu, 7 Apr 2022 08:31:31 +0000 [thread overview] Message-ID: <DB7PR04MB54508F0ACD00B482201D7916F4E69@DB7PR04MB5450.eurprd04.prod.outlook.com> (raw) In-Reply-To: <203a2b93-a842-8cf2-b265-864f520c16a6@baylibre.com> Hi, > -----Original Message----- > From: Neil Armstrong <narmstrong@baylibre.com> > Sent: 2022年4月6日 17:20 > To: Sandor Yu <sandor.yu@nxp.com>; dri-devel@lists.freedesktop.org; > linux-kernel@vger.kernel.org; andrzej.hajda@intel.com; > robert.foss@linaro.org; Laurent.pinchart@ideasonboard.com; > jonas@kwiboo.se; jernej.skrabec@gmail.com > Cc: S.J. Wang <shengjiu.wang@nxp.com>; cai.huoqing@linux.dev; > maxime@cerno.tech; harry.wentland@amd.com; hverkuil-cisco@xs4all.nl; > amuel@sholland.org > Subject: [EXT] Re: [PATCH v1 3/5] drm: bridge: dw_hdmi: Enable GCP only for > Deep Color > > Caution: EXT Email > > On 06/04/2022 10:48, Sandor.yu@nxp.com wrote: > > From: Sandor Yu <Sandor.yu@nxp.com> > > > > HDMI1.4b specification section 6.5.3: > > Source shall only send GCPs with non-zero CD to sinks that indicate > > support for Deep Color. > > > > DW HDMI GPC default enabled, clear gpc_auto bit for bpp 24. > > > > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > > --- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > index b11577de4836..c7b11582529e 100644 > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > @@ -1160,6 +1160,14 @@ static void hdmi_video_packetize(struct > dw_hdmi *hdmi) > > HDMI_VP_PR_CD_DESIRED_PR_FACTOR_MASK); > > hdmi_writeb(hdmi, val, HDMI_VP_PR_CD); > > > > + val = hdmi_readb(hdmi, HDMI_FC_DATAUTO3); > > + if (color_depth == 4) > > + /* disable Auto GCP when bpp 24 */ > > + val &= ~0x4; > > + else > > + val |= 0x4; > > + hdmi_writeb(hdmi, val, HDMI_FC_DATAUTO3); > > + > > hdmi_modb(hdmi, > HDMI_VP_STUFF_PR_STUFFING_STUFFING_MODE, > > HDMI_VP_STUFF_PR_STUFFING_MASK, > HDMI_VP_STUFF); > > > > Do you handle the case when color_depth == 0 when output is YUV422 ? For YUV422 color depth 8, the gcp_auto bit need clear too, I will add it. > > Neil Thanks, Sandor
WARNING: multiple messages have this Message-ID (diff)
From: Sandor Yu <sandor.yu@nxp.com> To: Neil Armstrong <narmstrong@baylibre.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "andrzej.hajda@intel.com" <andrzej.hajda@intel.com>, "robert.foss@linaro.org" <robert.foss@linaro.org>, "Laurent.pinchart@ideasonboard.com" <Laurent.pinchart@ideasonboard.com>, "jonas@kwiboo.se" <jonas@kwiboo.se>, "jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com> Cc: "S.J. Wang" <shengjiu.wang@nxp.com>, "amuel@sholland.org" <amuel@sholland.org>, "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>, "maxime@cerno.tech" <maxime@cerno.tech>, "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl> Subject: RE: [EXT] Re: [PATCH v1 3/5] drm: bridge: dw_hdmi: Enable GCP only for Deep Color Date: Thu, 7 Apr 2022 08:31:31 +0000 [thread overview] Message-ID: <DB7PR04MB54508F0ACD00B482201D7916F4E69@DB7PR04MB5450.eurprd04.prod.outlook.com> (raw) In-Reply-To: <203a2b93-a842-8cf2-b265-864f520c16a6@baylibre.com> Hi, > -----Original Message----- > From: Neil Armstrong <narmstrong@baylibre.com> > Sent: 2022年4月6日 17:20 > To: Sandor Yu <sandor.yu@nxp.com>; dri-devel@lists.freedesktop.org; > linux-kernel@vger.kernel.org; andrzej.hajda@intel.com; > robert.foss@linaro.org; Laurent.pinchart@ideasonboard.com; > jonas@kwiboo.se; jernej.skrabec@gmail.com > Cc: S.J. Wang <shengjiu.wang@nxp.com>; cai.huoqing@linux.dev; > maxime@cerno.tech; harry.wentland@amd.com; hverkuil-cisco@xs4all.nl; > amuel@sholland.org > Subject: [EXT] Re: [PATCH v1 3/5] drm: bridge: dw_hdmi: Enable GCP only for > Deep Color > > Caution: EXT Email > > On 06/04/2022 10:48, Sandor.yu@nxp.com wrote: > > From: Sandor Yu <Sandor.yu@nxp.com> > > > > HDMI1.4b specification section 6.5.3: > > Source shall only send GCPs with non-zero CD to sinks that indicate > > support for Deep Color. > > > > DW HDMI GPC default enabled, clear gpc_auto bit for bpp 24. > > > > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> > > --- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > index b11577de4836..c7b11582529e 100644 > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > @@ -1160,6 +1160,14 @@ static void hdmi_video_packetize(struct > dw_hdmi *hdmi) > > HDMI_VP_PR_CD_DESIRED_PR_FACTOR_MASK); > > hdmi_writeb(hdmi, val, HDMI_VP_PR_CD); > > > > + val = hdmi_readb(hdmi, HDMI_FC_DATAUTO3); > > + if (color_depth == 4) > > + /* disable Auto GCP when bpp 24 */ > > + val &= ~0x4; > > + else > > + val |= 0x4; > > + hdmi_writeb(hdmi, val, HDMI_FC_DATAUTO3); > > + > > hdmi_modb(hdmi, > HDMI_VP_STUFF_PR_STUFFING_STUFFING_MODE, > > HDMI_VP_STUFF_PR_STUFFING_MASK, > HDMI_VP_STUFF); > > > > Do you handle the case when color_depth == 0 when output is YUV422 ? For YUV422 color depth 8, the gcp_auto bit need clear too, I will add it. > > Neil Thanks, Sandor
next prev parent reply other threads:[~2022-04-07 8:31 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-06 8:48 [PATCH v1 0/5] DRM: Bridge: DW_HDMI: Add new features and bug fix Sandor.yu 2022-04-06 8:48 ` Sandor.yu 2022-04-06 8:48 ` [PATCH v1 1/5] drm: bridge: dw_hdmi: cec: Add cec suspend/resume function Sandor.yu 2022-04-06 8:48 ` Sandor.yu 2022-04-06 9:46 ` Hans Verkuil 2022-04-06 9:46 ` Hans Verkuil 2022-04-07 8:30 ` [EXT] " Sandor Yu 2022-04-07 8:30 ` Sandor Yu 2022-04-06 8:48 ` [PATCH v1 2/5] drm: bridge: dw_hdmi: enable overflow workaround for v2.13a Sandor.yu 2022-04-06 8:48 ` Sandor.yu 2022-04-06 9:17 ` Neil Armstrong 2022-04-06 9:17 ` Neil Armstrong 2022-04-07 8:30 ` [EXT] " Sandor Yu 2022-04-07 8:30 ` Sandor Yu 2022-04-06 8:48 ` [PATCH v1 3/5] drm: bridge: dw_hdmi: Enable GCP only for Deep Color Sandor.yu 2022-04-06 8:48 ` Sandor.yu 2022-04-06 9:20 ` Neil Armstrong 2022-04-06 9:20 ` Neil Armstrong 2022-04-07 8:31 ` Sandor Yu [this message] 2022-04-07 8:31 ` [EXT] " Sandor Yu 2022-04-06 8:48 ` [PATCH v1 4/5] drm: bridge: dw_hdmi: add reset function for PHY GEN1 Sandor.yu 2022-04-06 8:48 ` Sandor.yu 2022-04-06 8:48 ` [PATCH v1 5/5] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver Sandor.yu 2022-04-06 8:48 ` Sandor.yu 2022-04-06 9:27 ` Neil Armstrong 2022-04-06 9:27 ` Neil Armstrong 2022-04-07 8:31 ` [EXT] " Sandor Yu 2022-04-07 8:31 ` Sandor Yu 2022-04-07 8:43 ` [PATCH v1 0/5] DRM: Bridge: DW_HDMI: Add new features and bug fix Philipp Zabel 2022-04-07 8:43 ` Philipp Zabel 2022-04-07 11:46 ` [EXT] " Sandor Yu 2022-04-07 11:46 ` Sandor Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB7PR04MB54508F0ACD00B482201D7916F4E69@DB7PR04MB5450.eurprd04.prod.outlook.com \ --to=sandor.yu@nxp.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=amuel@sholland.org \ --cc=andrzej.hajda@intel.com \ --cc=cai.huoqing@linux.dev \ --cc=dri-devel@lists.freedesktop.org \ --cc=harry.wentland@amd.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime@cerno.tech \ --cc=narmstrong@baylibre.com \ --cc=robert.foss@linaro.org \ --cc=shengjiu.wang@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.