All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
@ 2020-06-22 14:17 Khasim Mohammed
  2020-06-22 14:17 ` [PATCH 2/2] arm-bsp/scp-firmware: Build SCP MCP firmware for N1SDP Khasim Mohammed
  2020-06-23  7:05 ` [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN Diego Sueiro
  0 siblings, 2 replies; 13+ messages in thread
From: Khasim Mohammed @ 2020-06-22 14:17 UTC (permalink / raw)
  To: meta-arm; +Cc: nd, Khasim Syed Mohammed

SCP code has been updated with new logging framework. The patch
is to allow setting of log level parameter to INFO or WARN.

Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
Issue-Id: PLATFORMS-3134
Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
---
 meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
 meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
index 1873848..2db59d3 100644
--- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
+++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
@@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
 SCP_COMPILE_VERBOSE ?= "0"
 SCP_PLATFORM        ?= "invalid"
 SCP_COMPILER        ?= "arm-none-eabi"
+SCP_LOG_LEVEL       ?= "WARN"
 
 DEPENDS += "virtual/arm-none-eabi-gcc-native"
 
@@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
                 BUILD_PATH='${B}' \
                 PRODUCT='${SCP_PLATFORM}' \
                 MODE='${SCP_BUILD_STR}' \
+                LOG_LEVEL='${SCP_LOG_LEVEL}' \
                 CC='${SCP_COMPILER}-gcc' \
                 AR='${SCP_COMPILER}-ar' \
                 SIZE='${SCP_COMPILER}-size' \
diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
index 5ff5859..9cb8b64 100644
--- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
+++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
@@ -13,7 +13,7 @@ SRC_URI = "\
     git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1 \
 "
 
-SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
+SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
 SRCREV_cmsis  = "refs/tags/5.2.0"
 SRCREV_FORMAT = "scp_cmsis"
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 2/2] arm-bsp/scp-firmware: Build SCP MCP firmware for N1SDP
  2020-06-22 14:17 [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN Khasim Mohammed
@ 2020-06-22 14:17 ` Khasim Mohammed
  2020-06-23  7:05   ` Diego Sueiro
  2020-06-23  7:05 ` [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN Diego Sueiro
  1 sibling, 1 reply; 13+ messages in thread
From: Khasim Mohammed @ 2020-06-22 14:17 UTC (permalink / raw)
  To: meta-arm; +Cc: nd, Khasim Syed Mohammed, Patrik Berglund

- Add bbappend recipe to build SCP and MCP firmware
  for N1SDP.
- Use fiptool to package the binary images
- Update machine conf to add image dependency
  for SCP-firmware components

Issue-Id: PLATFORMS-3134

Change-Id: I24bb427179f2fdee0a8351257c9088d8024ca6b8
Signed-off-by: Patrik Berglund <patrik.berglund@arm.com>
Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
---
 meta-arm-bsp/conf/machine/n1sdp.conf          |  1 +
 .../scp-firmware/scp-firmware-n1sdp.inc       | 32 +++++++++++++++++++
 .../scp-firmware/scp-firmware_git.bbappend    |  7 ++++
 3 files changed, 40 insertions(+)
 create mode 100644 meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
 create mode 100644 meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend

diff --git a/meta-arm-bsp/conf/machine/n1sdp.conf b/meta-arm-bsp/conf/machine/n1sdp.conf
index 20eaf27..755bb09 100644
--- a/meta-arm-bsp/conf/machine/n1sdp.conf
+++ b/meta-arm-bsp/conf/machine/n1sdp.conf
@@ -27,6 +27,7 @@ PREFERRED_PROVIDER_virtual/trusted-firmware-a ?= "trusted-firmware-a"
 PREFERRED_VERSION_trusted-firmware-a ?= "2.2%"
 
 EXTRA_IMAGEDEPENDS += "virtual/trusted-firmware-a"
+EXTRA_IMAGEDEPENDS += "virtual/control-processor-firmware"
 
 #UEFI EDK2 firmware
 EXTRA_IMAGEDEPENDS += "virtual/uefi-firmware"
diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
new file mode 100644
index 0000000..ddbaac4
--- /dev/null
+++ b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
@@ -0,0 +1,32 @@
+# N1SDP specific SCP configurations and build instructions
+
+SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
+SRCREV_cmsis  = "refs/tags/5.2.0"
+SCP_PLATFORM  = "n1sdp"
+SCP_LOG_LEVEL = "INFO"
+
+COMPATIBLE_MACHINE_n1sdp = "n1sdp"
+
+PV = "2.6+git${SRCPV}"
+
+DEPENDS += "fiptool-native"
+DEPENDS += "virtual/trusted-firmware-a"
+
+do_install_append() {
+   fiptool \
+       create \
+       --scp-fw "${D}/firmware/scp_ramfw.bin" \
+       --soc-fw "${RECIPE_SYSROOT}/firmware/bl31.bin" \
+       "scp_fw.bin"
+
+   fiptool \
+       create \
+       --blob uuid=54464222-a4cf-4bf8-b1b6-cee7dade539e,file="${D}/firmware/mcp_ramfw.bin" \
+       "mcp_fw.bin"
+
+   install "scp_fw.bin" "${D}/firmware/scp_fw.bin"
+   install "mcp_fw.bin" "${D}/firmware/mcp_fw.bin"
+
+   ln -sf "scp_romfw.bin" "${D}/firmware/scp_rom.bin"
+   ln -sf "mcp_romfw.bin" "${D}/firmware/mcp_rom.bin"
+}
diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
new file mode 100644
index 0000000..53bd022
--- /dev/null
+++ b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
@@ -0,0 +1,7 @@
+# Include machine specific SCP configurations
+
+MACHINE_SCP_REQUIRE ?= ""
+
+MACHINE_SCP_REQUIRE_n1sdp = "scp-firmware-n1sdp.inc"
+
+require ${MACHINE_SCP_REQUIRE}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
  2020-06-22 14:17 [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN Khasim Mohammed
  2020-06-22 14:17 ` [PATCH 2/2] arm-bsp/scp-firmware: Build SCP MCP firmware for N1SDP Khasim Mohammed
@ 2020-06-23  7:05 ` Diego Sueiro
  2020-06-24 18:40   ` [meta-arm] " Jon Mason
  1 sibling, 1 reply; 13+ messages in thread
From: Diego Sueiro @ 2020-06-23  7:05 UTC (permalink / raw)
  To: meta-arm

On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:

>
> SCP code has been updated with new logging framework. The patch
> is to allow setting of log level parameter to INFO or WARN.
> 
> Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
> Issue-Id: PLATFORMS-3134
> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>

Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> ---
>  meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
>  meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> index 1873848..2db59d3 100644
> --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> @@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
>  SCP_COMPILE_VERBOSE ?= "0"
>  SCP_PLATFORM        ?= "invalid"
>  SCP_COMPILER        ?= "arm-none-eabi"
> +SCP_LOG_LEVEL       ?= "WARN"
>
>  DEPENDS += "virtual/arm-none-eabi-gcc-native"
>
> @@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
>                  BUILD_PATH='${B}' \
>                  PRODUCT='${SCP_PLATFORM}' \
>                  MODE='${SCP_BUILD_STR}' \
> +                LOG_LEVEL='${SCP_LOG_LEVEL}' \
>                  CC='${SCP_COMPILER}-gcc' \
>                  AR='${SCP_COMPILER}-ar' \
>                  SIZE='${SCP_COMPILER}-size' \
> diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> index 5ff5859..9cb8b64 100644
> --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> @@ -13,7 +13,7 @@ SRC_URI = "\
>     
> git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1
> \
>  "
>
> -SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
> +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
>  SRCREV_cmsis  = "refs/tags/5.2.0"
>  SRCREV_FORMAT = "scp_cmsis"
>
> -- 
> 2.17.1
> 
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 2/2] arm-bsp/scp-firmware: Build SCP MCP firmware for N1SDP
  2020-06-22 14:17 ` [PATCH 2/2] arm-bsp/scp-firmware: Build SCP MCP firmware for N1SDP Khasim Mohammed
@ 2020-06-23  7:05   ` Diego Sueiro
  2020-06-24 18:40     ` [meta-arm] " Jon Mason
  0 siblings, 1 reply; 13+ messages in thread
From: Diego Sueiro @ 2020-06-23  7:05 UTC (permalink / raw)
  To: meta-arm

On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:

>
> - Add bbappend recipe to build SCP and MCP firmware
>   for N1SDP.
> - Use fiptool to package the binary images
> - Update machine conf to add image dependency
>   for SCP-firmware components
> 
> Issue-Id: PLATFORMS-3134
> 
> Change-Id: I24bb427179f2fdee0a8351257c9088d8024ca6b8
> Signed-off-by: Patrik Berglund <patrik.berglund@arm.com>
> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>

Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> ---
>  meta-arm-bsp/conf/machine/n1sdp.conf          |  1 +
>  .../scp-firmware/scp-firmware-n1sdp.inc       | 32 +++++++++++++++++++
>  .../scp-firmware/scp-firmware_git.bbappend    |  7 ++++
>  3 files changed, 40 insertions(+)
>  create mode 100644
> meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
>  create mode 100644
> meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
> 
> diff --git a/meta-arm-bsp/conf/machine/n1sdp.conf
> b/meta-arm-bsp/conf/machine/n1sdp.conf
> index 20eaf27..755bb09 100644
> --- a/meta-arm-bsp/conf/machine/n1sdp.conf
> +++ b/meta-arm-bsp/conf/machine/n1sdp.conf
> @@ -27,6 +27,7 @@ PREFERRED_PROVIDER_virtual/trusted-firmware-a ?=
> "trusted-firmware-a"
>  PREFERRED_VERSION_trusted-firmware-a ?= "2.2%"
>
>  EXTRA_IMAGEDEPENDS += "virtual/trusted-firmware-a"
> +EXTRA_IMAGEDEPENDS += "virtual/control-processor-firmware"
>
>  #UEFI EDK2 firmware
>  EXTRA_IMAGEDEPENDS += "virtual/uefi-firmware"
> diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> new file mode 100644
> index 0000000..ddbaac4
> --- /dev/null
> +++ b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> @@ -0,0 +1,32 @@
> +# N1SDP specific SCP configurations and build instructions
> +
> +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> +SRCREV_cmsis  = "refs/tags/5.2.0"
> +SCP_PLATFORM  = "n1sdp"
> +SCP_LOG_LEVEL = "INFO"
> +
> +COMPATIBLE_MACHINE_n1sdp = "n1sdp"
> +
> +PV = "2.6+git${SRCPV}"
> +
> +DEPENDS += "fiptool-native"
> +DEPENDS += "virtual/trusted-firmware-a"
> +
> +do_install_append() {
> +   fiptool \
> +       create \
> +       --scp-fw "${D}/firmware/scp_ramfw.bin" \
> +       --soc-fw "${RECIPE_SYSROOT}/firmware/bl31.bin" \
> +       "scp_fw.bin"
> +
> +   fiptool \
> +       create \
> +       --blob
> uuid=54464222-a4cf-4bf8-b1b6-cee7dade539e,file="${D}/firmware/mcp_ramfw.bin" \
> +       "mcp_fw.bin"
> +
> +   install "scp_fw.bin" "${D}/firmware/scp_fw.bin"
> +   install "mcp_fw.bin" "${D}/firmware/mcp_fw.bin"
> +
> +   ln -sf "scp_romfw.bin" "${D}/firmware/scp_rom.bin"
> +   ln -sf "mcp_romfw.bin" "${D}/firmware/mcp_rom.bin"
> +}
> diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
> b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
> new file mode 100644
> index 0000000..53bd022
> --- /dev/null
> +++ b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
> @@ -0,0 +1,7 @@
> +# Include machine specific SCP configurations
> +
> +MACHINE_SCP_REQUIRE ?= ""
> +
> +MACHINE_SCP_REQUIRE_n1sdp = "scp-firmware-n1sdp.inc"
> +
> +require ${MACHINE_SCP_REQUIRE}
> -- 
> 2.17.1
> 
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [meta-arm] [PATCH 2/2] arm-bsp/scp-firmware: Build SCP MCP firmware for N1SDP
  2020-06-23  7:05   ` Diego Sueiro
@ 2020-06-24 18:40     ` Jon Mason
  0 siblings, 0 replies; 13+ messages in thread
From: Jon Mason @ 2020-06-24 18:40 UTC (permalink / raw)
  To: Diego Sueiro; +Cc: meta-arm

On Tue, Jun 23, 2020 at 12:05:47AM -0700, Diego Sueiro wrote:
> On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:
> 
> >
> > - Add bbappend recipe to build SCP and MCP firmware
> >   for N1SDP.
> > - Use fiptool to package the binary images
> > - Update machine conf to add image dependency
> >   for SCP-firmware components
> > 
> > Issue-Id: PLATFORMS-3134
> > 
> > Change-Id: I24bb427179f2fdee0a8351257c9088d8024ca6b8
> > Signed-off-by: Patrik Berglund <patrik.berglund@arm.com>
> > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> 
> Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

Pulled into master.

Thanks,
Jon

> 
> > ---
> >  meta-arm-bsp/conf/machine/n1sdp.conf          |  1 +
> >  .../scp-firmware/scp-firmware-n1sdp.inc       | 32 +++++++++++++++++++
> >  .../scp-firmware/scp-firmware_git.bbappend    |  7 ++++
> >  3 files changed, 40 insertions(+)
> >  create mode 100644
> > meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> >  create mode 100644
> > meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
> > 
> > diff --git a/meta-arm-bsp/conf/machine/n1sdp.conf
> > b/meta-arm-bsp/conf/machine/n1sdp.conf
> > index 20eaf27..755bb09 100644
> > --- a/meta-arm-bsp/conf/machine/n1sdp.conf
> > +++ b/meta-arm-bsp/conf/machine/n1sdp.conf
> > @@ -27,6 +27,7 @@ PREFERRED_PROVIDER_virtual/trusted-firmware-a ?=
> > "trusted-firmware-a"
> >  PREFERRED_VERSION_trusted-firmware-a ?= "2.2%"
> >
> >  EXTRA_IMAGEDEPENDS += "virtual/trusted-firmware-a"
> > +EXTRA_IMAGEDEPENDS += "virtual/control-processor-firmware"
> >
> >  #UEFI EDK2 firmware
> >  EXTRA_IMAGEDEPENDS += "virtual/uefi-firmware"
> > diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> > b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> > new file mode 100644
> > index 0000000..ddbaac4
> > --- /dev/null
> > +++ b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware-n1sdp.inc
> > @@ -0,0 +1,32 @@
> > +# N1SDP specific SCP configurations and build instructions
> > +
> > +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> > +SRCREV_cmsis  = "refs/tags/5.2.0"
> > +SCP_PLATFORM  = "n1sdp"
> > +SCP_LOG_LEVEL = "INFO"
> > +
> > +COMPATIBLE_MACHINE_n1sdp = "n1sdp"
> > +
> > +PV = "2.6+git${SRCPV}"
> > +
> > +DEPENDS += "fiptool-native"
> > +DEPENDS += "virtual/trusted-firmware-a"
> > +
> > +do_install_append() {
> > +   fiptool \
> > +       create \
> > +       --scp-fw "${D}/firmware/scp_ramfw.bin" \
> > +       --soc-fw "${RECIPE_SYSROOT}/firmware/bl31.bin" \
> > +       "scp_fw.bin"
> > +
> > +   fiptool \
> > +       create \
> > +       --blob
> > uuid=54464222-a4cf-4bf8-b1b6-cee7dade539e,file="${D}/firmware/mcp_ramfw.bin" \
> > +       "mcp_fw.bin"
> > +
> > +   install "scp_fw.bin" "${D}/firmware/scp_fw.bin"
> > +   install "mcp_fw.bin" "${D}/firmware/mcp_fw.bin"
> > +
> > +   ln -sf "scp_romfw.bin" "${D}/firmware/scp_rom.bin"
> > +   ln -sf "mcp_romfw.bin" "${D}/firmware/mcp_rom.bin"
> > +}
> > diff --git a/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
> > b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
> > new file mode 100644
> > index 0000000..53bd022
> > --- /dev/null
> > +++ b/meta-arm-bsp/recipes-bsp/scp-firmware/scp-firmware_git.bbappend
> > @@ -0,0 +1,7 @@
> > +# Include machine specific SCP configurations
> > +
> > +MACHINE_SCP_REQUIRE ?= ""
> > +
> > +MACHINE_SCP_REQUIRE_n1sdp = "scp-firmware-n1sdp.inc"
> > +
> > +require ${MACHINE_SCP_REQUIRE}
> > -- 
> > 2.17.1
> > 
> >

> 


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
  2020-06-23  7:05 ` [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN Diego Sueiro
@ 2020-06-24 18:40   ` Jon Mason
  2020-06-24 18:52     ` Khasim Mohammed
       [not found]     ` <161B8F8F11B0E6F1.591@lists.yoctoproject.org>
  0 siblings, 2 replies; 13+ messages in thread
From: Jon Mason @ 2020-06-24 18:40 UTC (permalink / raw)
  To: Diego Sueiro; +Cc: meta-arm

On Tue, Jun 23, 2020 at 12:05:43AM -0700, Diego Sueiro wrote:
> On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:
> 
> >
> > SCP code has been updated with new logging framework. The patch
> > is to allow setting of log level parameter to INFO or WARN.
> > 
> > Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
> > Issue-Id: PLATFORMS-3134
> > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> 
> Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

Pulled into master.

Thanks,
Jon

> 
> > ---
> >  meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
> >  meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > index 1873848..2db59d3 100644
> > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > @@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
> >  SCP_COMPILE_VERBOSE ?= "0"
> >  SCP_PLATFORM        ?= "invalid"
> >  SCP_COMPILER        ?= "arm-none-eabi"
> > +SCP_LOG_LEVEL       ?= "WARN"
> >
> >  DEPENDS += "virtual/arm-none-eabi-gcc-native"
> >
> > @@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
> >                  BUILD_PATH='${B}' \
> >                  PRODUCT='${SCP_PLATFORM}' \
> >                  MODE='${SCP_BUILD_STR}' \
> > +                LOG_LEVEL='${SCP_LOG_LEVEL}' \
> >                  CC='${SCP_COMPILER}-gcc' \
> >                  AR='${SCP_COMPILER}-ar' \
> >                  SIZE='${SCP_COMPILER}-size' \
> > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > index 5ff5859..9cb8b64 100644
> > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > @@ -13,7 +13,7 @@ SRC_URI = "\
> >     
> > git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1
> > \
> >  "
> >
> > -SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
> > +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> >  SRCREV_cmsis  = "refs/tags/5.2.0"
> >  SRCREV_FORMAT = "scp_cmsis"
> >
> > -- 
> > 2.17.1
> > 
> >

> 


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
  2020-06-24 18:40   ` [meta-arm] " Jon Mason
@ 2020-06-24 18:52     ` Khasim Mohammed
  2020-06-25  3:11       ` Jon Mason
       [not found]     ` <161B8F8F11B0E6F1.591@lists.yoctoproject.org>
  1 sibling, 1 reply; 13+ messages in thread
From: Khasim Mohammed @ 2020-06-24 18:52 UTC (permalink / raw)
  To: Diego Sueiro, jdmason; +Cc: meta-arm

Hi Jon,

________________________________________
From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org> on behalf of Jon Mason via lists.yoctoproject.org <jdmason=kudzu.us@lists.yoctoproject.org>
Sent: Thursday, June 25, 2020 12:10 AM
To: Diego Sueiro
Cc: meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN

On Tue, Jun 23, 2020 at 12:05:43AM -0700, Diego Sueiro wrote:
> On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:
>
> >
> > SCP code has been updated with new logging framework. The patch
> > is to allow setting of log level parameter to INFO or WARN.
> >
> > Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
> > Issue-Id: PLATFORMS-3134
> > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
>
> Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> Pulled into master.

Can you please apply these three patches to dunfell branch as well ?

https://lists.yoctoproject.org/g/meta-arm/topic/patch_2_2/75039153?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039153
https://lists.yoctoproject.org/g/meta-arm/topic/patch_1_2_arm_scp_firmware/75039137?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039137
https://lists.yoctoproject.org/g/meta-arm/topic/patch_arm_fiptool/75039113?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039113


Thanks

Khasim

> Thanks,
> Jon

>
> > ---
> >  meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
> >  meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > index 1873848..2db59d3 100644
> > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > @@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
> >  SCP_COMPILE_VERBOSE ?= "0"
> >  SCP_PLATFORM        ?= "invalid"
> >  SCP_COMPILER        ?= "arm-none-eabi"
> > +SCP_LOG_LEVEL       ?= "WARN"
> >
> >  DEPENDS += "virtual/arm-none-eabi-gcc-native"
> >
> > @@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
> >                  BUILD_PATH='${B}' \
> >                  PRODUCT='${SCP_PLATFORM}' \
> >                  MODE='${SCP_BUILD_STR}' \
> > +                LOG_LEVEL='${SCP_LOG_LEVEL}' \
> >                  CC='${SCP_COMPILER}-gcc' \
> >                  AR='${SCP_COMPILER}-ar' \
> >                  SIZE='${SCP_COMPILER}-size' \
> > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > index 5ff5859..9cb8b64 100644
> > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > @@ -13,7 +13,7 @@ SRC_URI = "\
> >
> > git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1
> > \
> >  "
> >
> > -SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
> > +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> >  SRCREV_cmsis  = "refs/tags/5.2.0"
> >  SRCREV_FORMAT = "scp_cmsis"
> >
> > --
> > 2.17.1
> >
> >

>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
       [not found]     ` <161B8F8F11B0E6F1.591@lists.yoctoproject.org>
@ 2020-06-24 18:55       ` Khasim Mohammed
  0 siblings, 0 replies; 13+ messages in thread
From: Khasim Mohammed @ 2020-06-24 18:55 UTC (permalink / raw)
  To: Diego Sueiro, jdmason, Khasim Mohammed; +Cc: meta-arm

And before that

________________________________________
From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org> on behalf of Khasim Mohammed via lists.yoctoproject.org <khasim.mohammed=arm.com@lists.yoctoproject.org>
Sent: Thursday, June 25, 2020 12:22 AM
To: Diego Sueiro; jdmason@kudzu.us
Cc: meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN

Hi Jon,

________________________________________
From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org> on behalf of Jon Mason via lists.yoctoproject.org <jdmason=kudzu.us@lists.yoctoproject.org>
Sent: Thursday, June 25, 2020 12:10 AM
To: Diego Sueiro
Cc: meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN

On Tue, Jun 23, 2020 at 12:05:43AM -0700, Diego Sueiro wrote:
> On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:
>
> >
> > SCP code has been updated with new logging framework. The patch
> > is to allow setting of log level parameter to INFO or WARN.
> >
> > Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
> > Issue-Id: PLATFORMS-3134
> > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
>
> Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> Pulled into master.

> Can you please apply these three patches to dunfell branch as well ?

> https://lists.yoctoproject.org/g/meta-arm/topic/patch_2_2/75039153?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039153
> https://lists.yoctoproject.org/g/meta-arm/topic/patch_1_2_arm_scp_firmware/75039137?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039137
> https://lists.yoctoproject.org/g/meta-arm/topic/patch_arm_fiptool/75039113?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039113

Apply these to dunfell as well,

http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/?id=4f8f8eae7f89ae4f36e97d1ad417e889b926b5a4
http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/?id=24cbd0e702a87537cf0d6b8482ab06cb60be0cc4
http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/?id=47b276bc3da087ad402158b7e6e9fdd38ba1eb0a
http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/?id=150fdcc8621008f9a0532c119df922266e5d89f9

Regards,
Khasim


> Thanks,
> Jon

>
> > ---
> >  meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
> >  meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > index 1873848..2db59d3 100644
> > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > @@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
> >  SCP_COMPILE_VERBOSE ?= "0"
> >  SCP_PLATFORM        ?= "invalid"
> >  SCP_COMPILER        ?= "arm-none-eabi"
> > +SCP_LOG_LEVEL       ?= "WARN"
> >
> >  DEPENDS += "virtual/arm-none-eabi-gcc-native"
> >
> > @@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
> >                  BUILD_PATH='${B}' \
> >                  PRODUCT='${SCP_PLATFORM}' \
> >                  MODE='${SCP_BUILD_STR}' \
> > +                LOG_LEVEL='${SCP_LOG_LEVEL}' \
> >                  CC='${SCP_COMPILER}-gcc' \
> >                  AR='${SCP_COMPILER}-ar' \
> >                  SIZE='${SCP_COMPILER}-size' \
> > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > index 5ff5859..9cb8b64 100644
> > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > @@ -13,7 +13,7 @@ SRC_URI = "\
> >
> > git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1
> > \
> >  "
> >
> > -SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
> > +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> >  SRCREV_cmsis  = "refs/tags/5.2.0"
> >  SRCREV_FORMAT = "scp_cmsis"
> >
> > --
> > 2.17.1
> >
> >

>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
  2020-06-24 18:52     ` Khasim Mohammed
@ 2020-06-25  3:11       ` Jon Mason
  2020-06-25  3:51         ` Khasim Mohammed
  0 siblings, 1 reply; 13+ messages in thread
From: Jon Mason @ 2020-06-25  3:11 UTC (permalink / raw)
  To: Khasim Mohammed; +Cc: Diego Sueiro, meta-arm

On Wed, Jun 24, 2020 at 06:52:05PM +0000, Khasim Mohammed wrote:
> Hi Jon,
> 
> ________________________________________
> From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org> on behalf of Jon Mason via lists.yoctoproject.org <jdmason=kudzu.us@lists.yoctoproject.org>
> Sent: Thursday, June 25, 2020 12:10 AM
> To: Diego Sueiro
> Cc: meta-arm@lists.yoctoproject.org
> Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
> 
> On Tue, Jun 23, 2020 at 12:05:43AM -0700, Diego Sueiro wrote:
> > On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:
> >
> > >
> > > SCP code has been updated with new logging framework. The patch
> > > is to allow setting of log level parameter to INFO or WARN.
> > >
> > > Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
> > > Issue-Id: PLATFORMS-3134
> > > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> >
> > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> 
> > Pulled into master.
> 
> Can you please apply these three patches to dunfell branch as well ?
> 
> https://lists.yoctoproject.org/g/meta-arm/topic/patch_2_2/75039153?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039153
> https://lists.yoctoproject.org/g/meta-arm/topic/patch_1_2_arm_scp_firmware/75039137?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039137
> https://lists.yoctoproject.org/g/meta-arm/topic/patch_arm_fiptool/75039113?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039113

Looks like there is a problem on dunfell.  When compiling for n1sdp, I
get the following error:

ERROR: Nothing PROVIDES 'virtual/arm-none-eabi-gcc-native' (but /home/jdm/yocto/meta-arm/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb DEPENDS on or otherwise requires it). Close matches:
  virtual/mesa-native
ERROR: Required build target 'core-image-sato' has no buildable providers.
Missing or unbuildable dependency chain was: ['core-image-sato', 'virtual/control-processor-firmware', 'virtual/arm-none-eabi-gcc-native']

Can you confirm it compiles for you?

Thanks,
Jon

> 
> 
> Thanks
> 
> Khasim
> 
> > Thanks,
> > Jon
> 
> >
> > > ---
> > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
> > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
> > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > index 1873848..2db59d3 100644
> > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > @@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
> > >  SCP_COMPILE_VERBOSE ?= "0"
> > >  SCP_PLATFORM        ?= "invalid"
> > >  SCP_COMPILER        ?= "arm-none-eabi"
> > > +SCP_LOG_LEVEL       ?= "WARN"
> > >
> > >  DEPENDS += "virtual/arm-none-eabi-gcc-native"
> > >
> > > @@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
> > >                  BUILD_PATH='${B}' \
> > >                  PRODUCT='${SCP_PLATFORM}' \
> > >                  MODE='${SCP_BUILD_STR}' \
> > > +                LOG_LEVEL='${SCP_LOG_LEVEL}' \
> > >                  CC='${SCP_COMPILER}-gcc' \
> > >                  AR='${SCP_COMPILER}-ar' \
> > >                  SIZE='${SCP_COMPILER}-size' \
> > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > index 5ff5859..9cb8b64 100644
> > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > @@ -13,7 +13,7 @@ SRC_URI = "\
> > >
> > > git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1
> > > \
> > >  "
> > >
> > > -SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
> > > +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> > >  SRCREV_cmsis  = "refs/tags/5.2.0"
> > >  SRCREV_FORMAT = "scp_cmsis"
> > >
> > > --
> > > 2.17.1
> > >
> > >
> 
> >
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
  2020-06-25  3:11       ` Jon Mason
@ 2020-06-25  3:51         ` Khasim Mohammed
  2020-06-25 16:34           ` Jon Mason
  0 siblings, 1 reply; 13+ messages in thread
From: Khasim Mohammed @ 2020-06-25  3:51 UTC (permalink / raw)
  To: Jon Mason; +Cc: Diego Sueiro, meta-arm

Hi Jon,

<reply inline>
________________________________________
From: Jon Mason <jdmason@kudzu.us>
Sent: Thursday, June 25, 2020 8:41 AM
To: Khasim Mohammed
Cc: Diego Sueiro; meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN

On Wed, Jun 24, 2020 at 06:52:05PM +0000, Khasim Mohammed wrote:
> Hi Jon,
>
> ________________________________________
> From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org> on behalf of Jon Mason via lists.yoctoproject.org <jdmason=kudzu.us@lists.yoctoproject.org>
> Sent: Thursday, June 25, 2020 12:10 AM
> To: Diego Sueiro
> Cc: meta-arm@lists.yoctoproject.org
> Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
>
> On Tue, Jun 23, 2020 at 12:05:43AM -0700, Diego Sueiro wrote:
> > On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:
> >
> > >
> > > SCP code has been updated with new logging framework. The patch
> > > is to allow setting of log level parameter to INFO or WARN.
> > >
> > > Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
> > > Issue-Id: PLATFORMS-3134
> > > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> >
> > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
>
> > Pulled into master.
>
> Can you please apply these three patches to dunfell branch as well ?
>
> https://lists.yoctoproject.org/g/meta-arm/topic/patch_2_2/75039153?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039153
> https://lists.yoctoproject.org/g/meta-arm/topic/patch_1_2_arm_scp_firmware/75039137?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039137
> https://lists.yoctoproject.org/g/meta-arm/topic/patch_arm_fiptool/75039113?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039113

> Looks like there is a problem on dunfell.  When compiling for n1sdp, I
> get the following error:

>ERROR: Nothing PROVIDES 'virtual/arm-none-eabi-gcc-native' (but /home/jdm/yocto/meta-arm/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb DEPENDS on or otherwise requires it). Close matches:
>  virtual/mesa-native
>ERROR: Required build target 'core-image-sato' has no buildable providers.
> Missing or unbuildable dependency chain was: ['core-image-sato', 'virtual/control-processor-firmware', 'virtual/arm-none-eabi-gcc-native']

> Can you confirm it compiles for you?

You seem to have missed pushing your gcc patches to dunfell branch :

http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb?id=f9ece576ad476e6ed069dfdfc376eb422c1c511c

http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb?id=04eb583c4be5e7c36d457eb2d0dec35fef89ae52

Can you please push these to dunfell as well ?

Regards,
Khasim

>
>
> Thanks
>
> Khasim
>
> > Thanks,
> > Jon
>
> >
> > > ---
> > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
> > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
> > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > index 1873848..2db59d3 100644
> > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > @@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
> > >  SCP_COMPILE_VERBOSE ?= "0"
> > >  SCP_PLATFORM        ?= "invalid"
> > >  SCP_COMPILER        ?= "arm-none-eabi"
> > > +SCP_LOG_LEVEL       ?= "WARN"
> > >
> > >  DEPENDS += "virtual/arm-none-eabi-gcc-native"
> > >
> > > @@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
> > >                  BUILD_PATH='${B}' \
> > >                  PRODUCT='${SCP_PLATFORM}' \
> > >                  MODE='${SCP_BUILD_STR}' \
> > > +                LOG_LEVEL='${SCP_LOG_LEVEL}' \
> > >                  CC='${SCP_COMPILER}-gcc' \
> > >                  AR='${SCP_COMPILER}-ar' \
> > >                  SIZE='${SCP_COMPILER}-size' \
> > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > index 5ff5859..9cb8b64 100644
> > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > @@ -13,7 +13,7 @@ SRC_URI = "\
> > >
> > > git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1
> > > \
> > >  "
> > >
> > > -SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
> > > +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> > >  SRCREV_cmsis  = "refs/tags/5.2.0"
> > >  SRCREV_FORMAT = "scp_cmsis"
> > >
> > > --
> > > 2.17.1
> > >
> > >
>
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
  2020-06-25  3:51         ` Khasim Mohammed
@ 2020-06-25 16:34           ` Jon Mason
  2020-06-25 17:00             ` Khasim Mohammed
  0 siblings, 1 reply; 13+ messages in thread
From: Jon Mason @ 2020-06-25 16:34 UTC (permalink / raw)
  To: Khasim Mohammed; +Cc: Diego Sueiro, meta-arm

On Thu, Jun 25, 2020 at 03:51:53AM +0000, Khasim Mohammed wrote:
> Hi Jon,
> 
> <reply inline>
> ________________________________________
> From: Jon Mason <jdmason@kudzu.us>
> Sent: Thursday, June 25, 2020 8:41 AM
> To: Khasim Mohammed
> Cc: Diego Sueiro; meta-arm@lists.yoctoproject.org
> Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
> 
> On Wed, Jun 24, 2020 at 06:52:05PM +0000, Khasim Mohammed wrote:
> > Hi Jon,
> >
> > ________________________________________
> > From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org> on behalf of Jon Mason via lists.yoctoproject.org <jdmason=kudzu.us@lists.yoctoproject.org>
> > Sent: Thursday, June 25, 2020 12:10 AM
> > To: Diego Sueiro
> > Cc: meta-arm@lists.yoctoproject.org
> > Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
> >
> > On Tue, Jun 23, 2020 at 12:05:43AM -0700, Diego Sueiro wrote:
> > > On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:
> > >
> > > >
> > > > SCP code has been updated with new logging framework. The patch
> > > > is to allow setting of log level parameter to INFO or WARN.
> > > >
> > > > Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
> > > > Issue-Id: PLATFORMS-3134
> > > > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> > >
> > > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> >
> > > Pulled into master.
> >
> > Can you please apply these three patches to dunfell branch as well ?
> >
> > https://lists.yoctoproject.org/g/meta-arm/topic/patch_2_2/75039153?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039153
> > https://lists.yoctoproject.org/g/meta-arm/topic/patch_1_2_arm_scp_firmware/75039137?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039137
> > https://lists.yoctoproject.org/g/meta-arm/topic/patch_arm_fiptool/75039113?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039113
> 
> > Looks like there is a problem on dunfell.  When compiling for n1sdp, I
> > get the following error:
> 
> >ERROR: Nothing PROVIDES 'virtual/arm-none-eabi-gcc-native' (but /home/jdm/yocto/meta-arm/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb DEPENDS on or otherwise requires it). Close matches:
> >  virtual/mesa-native
> >ERROR: Required build target 'core-image-sato' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['core-image-sato', 'virtual/control-processor-firmware', 'virtual/arm-none-eabi-gcc-native']
> 
> > Can you confirm it compiles for you?
> 
> You seem to have missed pushing your gcc patches to dunfell branch :
> 
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb?id=f9ece576ad476e6ed069dfdfc376eb422c1c511c
> 
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb?id=04eb583c4be5e7c36d457eb2d0dec35fef89ae52
> 
> Can you please push these to dunfell as well ?

Exclusively the above doesn't apply cleanly.  I think we need the
following:


commit 9af4348fa0b83b2f5b318692c745716de5de0545 (HEAD)
Author: Denys Dmytriyenko <denys@ti.com>
Date:   Fri Jun 5 18:57:10 2020 -0400

    gcc-x86host.inc: properly link triplet-prefixed binaries

    Use the correct path for the binaries in ${datadir}, otherwise it results in a
    single incorrect symlink like gcc-arm-none-eabi-*

    Signed-off-by: Denys Dmytriyenko <denys@ti.com>
    Signed-off-by: Jon Mason <jon.mason@arm.com>

commit d5bc2633f2c203aebf372fc80f7cb87d7621bed9
Author: Denys Dmytriyenko <denys@ti.com>
Date:   Fri Jun 5 18:57:09 2020 -0400

    gcc-aarch64-none-elf: properly set ${S} that is different from default

    Also use ${BINNAME} and ${PV} variables for automatic substitution.

    Signed-off-by: Denys Dmytriyenko <denys@ti.com>
    Signed-off-by: Jon Mason <jon.mason@arm.com>

commit dfafcf9ec274330ad8ae5d602e208ac35aba4139
Author: Jon Mason <jdmason@kudzu.us>
Date:   Thu May 28 09:33:17 2020 -0400

    arm-toolchain: merge binary toolchain recipes

    Merge the majority of the binary toolchain recipes for building on an
    x86 host into a common include file.

    Also, found and fixed an error with both install commands where the name
    was double nested on the copy.  For example,
    /usr/share/arm-none-eabi/arm-none-eabi/ due to the way it was being
    copied.

    Signed-off-by: Jon Mason <jdmason@kudzu.us>
    Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

commit 24181d47084cef34a794dfd88056fa9bc5583913
Author: Denys Dmytriyenko <denys@ti.com>
Date:   Wed May 20 04:47:18 2020 -0400

    arm-toolchain: gcc-aarch64-none-elf: Add recipe

    Adds a recipe to pull down the prebuilt GCC for compiling bare-metal targets
    for Aarch64 processors from ARM.

    Signed-off-by: Denys Dmytriyenko <denys@ti.com>
    Signed-off-by: Jon Mason <jon.mason@arm.com>

commit e6ff4eb1d6683e967e4ef81bf5b42a087a47f6d5
Author: Jon Mason <jdmason@kudzu.us>
Date:   Thu May 14 21:36:20 2020 -0400

    arm-toolchain: gcc-arm-none-eabi-native: Add recipe

    Adds a recipe to pull down the prebuilt GCC for compiling on Cortex-R
    and Cortex-M processors from ARM. This toolchain is required to build
    Arm Trusted Firmware for the Rockchip rk3399 SoC, since it must compile
    some firmware for the M0 coprocessor.

    This was originally taken from meta-rockchip, but has been modified from
    mailing list feedback.

    Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
    Signed-off-by: Jon Mason <jdmason@kudzu.us>
    Signed-off-by: Denys Dmytriyenko <denys@ti.com>
    Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
    Signed-off-by: Jon Mason <jon.mason@arm.com>


Please ack and I'll pull all 5 into dunfell.

Thanks,
Jon


> 
> Regards,
> Khasim
> 
> >
> >
> > Thanks
> >
> > Khasim
> >
> > > Thanks,
> > > Jon
> >
> > >
> > > > ---
> > > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
> > > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
> > > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > index 1873848..2db59d3 100644
> > > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > @@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
> > > >  SCP_COMPILE_VERBOSE ?= "0"
> > > >  SCP_PLATFORM        ?= "invalid"
> > > >  SCP_COMPILER        ?= "arm-none-eabi"
> > > > +SCP_LOG_LEVEL       ?= "WARN"
> > > >
> > > >  DEPENDS += "virtual/arm-none-eabi-gcc-native"
> > > >
> > > > @@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
> > > >                  BUILD_PATH='${B}' \
> > > >                  PRODUCT='${SCP_PLATFORM}' \
> > > >                  MODE='${SCP_BUILD_STR}' \
> > > > +                LOG_LEVEL='${SCP_LOG_LEVEL}' \
> > > >                  CC='${SCP_COMPILER}-gcc' \
> > > >                  AR='${SCP_COMPILER}-ar' \
> > > >                  SIZE='${SCP_COMPILER}-size' \
> > > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > index 5ff5859..9cb8b64 100644
> > > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > @@ -13,7 +13,7 @@ SRC_URI = "\
> > > >
> > > > git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1
> > > > \
> > > >  "
> > > >
> > > > -SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
> > > > +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> > > >  SRCREV_cmsis  = "refs/tags/5.2.0"
> > > >  SRCREV_FORMAT = "scp_cmsis"
> > > >
> > > > --
> > > > 2.17.1
> > > >
> > > >
> >
> > >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
  2020-06-25 16:34           ` Jon Mason
@ 2020-06-25 17:00             ` Khasim Mohammed
  2020-06-25 19:34               ` Jon Mason
  0 siblings, 1 reply; 13+ messages in thread
From: Khasim Mohammed @ 2020-06-25 17:00 UTC (permalink / raw)
  To: Jon Mason; +Cc: Diego Sueiro, meta-arm

Hi Jon,

Ack'ed ,

________________________________________
From: Jon Mason <jdmason@kudzu.us>
Sent: Thursday, June 25, 2020 10:04 PM
To: Khasim Mohammed
Cc: Diego Sueiro; meta-arm@lists.yoctoproject.org
Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN

On Thu, Jun 25, 2020 at 03:51:53AM +0000, Khasim Mohammed wrote:
> Hi Jon,
>
> <reply inline>
> ________________________________________
> From: Jon Mason <jdmason@kudzu.us>
> Sent: Thursday, June 25, 2020 8:41 AM
> To: Khasim Mohammed
> Cc: Diego Sueiro; meta-arm@lists.yoctoproject.org
> Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
>
> On Wed, Jun 24, 2020 at 06:52:05PM +0000, Khasim Mohammed wrote:
> > Hi Jon,
> >
> > ________________________________________
> > From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org> on behalf of Jon Mason via lists.yoctoproject.org <jdmason=kudzu.us@lists.yoctoproject.org>
> > Sent: Thursday, June 25, 2020 12:10 AM
> > To: Diego Sueiro
> > Cc: meta-arm@lists.yoctoproject.org
> > Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
> >
> > On Tue, Jun 23, 2020 at 12:05:43AM -0700, Diego Sueiro wrote:
> > > On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:
> > >
> > > >
> > > > SCP code has been updated with new logging framework. The patch
> > > > is to allow setting of log level parameter to INFO or WARN.
> > > >
> > > > Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
> > > > Issue-Id: PLATFORMS-3134
> > > > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> > >
> > > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> >
> > > Pulled into master.
> >
> > Can you please apply these three patches to dunfell branch as well ?
> >
> > https://lists.yoctoproject.org/g/meta-arm/topic/patch_2_2/75039153?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039153
> > https://lists.yoctoproject.org/g/meta-arm/topic/patch_1_2_arm_scp_firmware/75039137?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039137
> > https://lists.yoctoproject.org/g/meta-arm/topic/patch_arm_fiptool/75039113?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039113
>
> > Looks like there is a problem on dunfell.  When compiling for n1sdp, I
> > get the following error:
>
> >ERROR: Nothing PROVIDES 'virtual/arm-none-eabi-gcc-native' (but /home/jdm/yocto/meta-arm/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb DEPENDS on or otherwise requires it). Close matches:
> >  virtual/mesa-native
> >ERROR: Required build target 'core-image-sato' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['core-image-sato', 'virtual/control-processor-firmware', 'virtual/arm-none-eabi-gcc-native']
>
> > Can you confirm it compiles for you?
>
> You seem to have missed pushing your gcc patches to dunfell branch :
>
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb?id=f9ece576ad476e6ed069dfdfc376eb422c1c511c
>
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb?id=04eb583c4be5e7c36d457eb2d0dec35fef89ae52
>
> Can you please push these to dunfell as well ?

> Exclusively the above doesn't apply cleanly.  I think we need the
> following:


commit 9af4348fa0b83b2f5b318692c745716de5de0545 (HEAD)
Author: Denys Dmytriyenko <denys@ti.com>
Date:   Fri Jun 5 18:57:10 2020 -0400

    gcc-x86host.inc: properly link triplet-prefixed binaries

    Use the correct path for the binaries in ${datadir}, otherwise it results in a
    single incorrect symlink like gcc-arm-none-eabi-*

    Signed-off-by: Denys Dmytriyenko <denys@ti.com>
    Signed-off-by: Jon Mason <jon.mason@arm.com>

commit d5bc2633f2c203aebf372fc80f7cb87d7621bed9
Author: Denys Dmytriyenko <denys@ti.com>
Date:   Fri Jun 5 18:57:09 2020 -0400

    gcc-aarch64-none-elf: properly set ${S} that is different from default

    Also use ${BINNAME} and ${PV} variables for automatic substitution.

    Signed-off-by: Denys Dmytriyenko <denys@ti.com>
    Signed-off-by: Jon Mason <jon.mason@arm.com>

commit dfafcf9ec274330ad8ae5d602e208ac35aba4139
Author: Jon Mason <jdmason@kudzu.us>
Date:   Thu May 28 09:33:17 2020 -0400

    arm-toolchain: merge binary toolchain recipes

    Merge the majority of the binary toolchain recipes for building on an
    x86 host into a common include file.

    Also, found and fixed an error with both install commands where the name
    was double nested on the copy.  For example,
    /usr/share/arm-none-eabi/arm-none-eabi/ due to the way it was being
    copied.

    Signed-off-by: Jon Mason <jdmason@kudzu.us>
    Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

commit 24181d47084cef34a794dfd88056fa9bc5583913
Author: Denys Dmytriyenko <denys@ti.com>
Date:   Wed May 20 04:47:18 2020 -0400

    arm-toolchain: gcc-aarch64-none-elf: Add recipe

    Adds a recipe to pull down the prebuilt GCC for compiling bare-metal targets
    for Aarch64 processors from ARM.

    Signed-off-by: Denys Dmytriyenko <denys@ti.com>
    Signed-off-by: Jon Mason <jon.mason@arm.com>

commit e6ff4eb1d6683e967e4ef81bf5b42a087a47f6d5
Author: Jon Mason <jdmason@kudzu.us>
Date:   Thu May 14 21:36:20 2020 -0400

    arm-toolchain: gcc-arm-none-eabi-native: Add recipe

    Adds a recipe to pull down the prebuilt GCC for compiling on Cortex-R
    and Cortex-M processors from ARM. This toolchain is required to build
    Arm Trusted Firmware for the Rockchip rk3399 SoC, since it must compile
    some firmware for the M0 coprocessor.

    This was originally taken from meta-rockchip, but has been modified from
    mailing list feedback.

    Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
    Signed-off-by: Jon Mason <jdmason@kudzu.us>
    Signed-off-by: Denys Dmytriyenko <denys@ti.com>
    Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
    Signed-off-by: Jon Mason <jon.mason@arm.com>


> Please ack and I'll pull all 5 into dunfell.

Please consider these patches for dunfell branch.

Thanks,
Jon

Regards,
Khasim

>
> Regards,
> Khasim
>
> >
> >
> > Thanks
> >
> > Khasim
> >
> > > Thanks,
> > > Jon
> >
> > >
> > > > ---
> > > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
> > > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
> > > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > index 1873848..2db59d3 100644
> > > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > @@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
> > > >  SCP_COMPILE_VERBOSE ?= "0"
> > > >  SCP_PLATFORM        ?= "invalid"
> > > >  SCP_COMPILER        ?= "arm-none-eabi"
> > > > +SCP_LOG_LEVEL       ?= "WARN"
> > > >
> > > >  DEPENDS += "virtual/arm-none-eabi-gcc-native"
> > > >
> > > > @@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
> > > >                  BUILD_PATH='${B}' \
> > > >                  PRODUCT='${SCP_PLATFORM}' \
> > > >                  MODE='${SCP_BUILD_STR}' \
> > > > +                LOG_LEVEL='${SCP_LOG_LEVEL}' \
> > > >                  CC='${SCP_COMPILER}-gcc' \
> > > >                  AR='${SCP_COMPILER}-ar' \
> > > >                  SIZE='${SCP_COMPILER}-size' \
> > > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > index 5ff5859..9cb8b64 100644
> > > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > @@ -13,7 +13,7 @@ SRC_URI = "\
> > > >
> > > > git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1
> > > > \
> > > >  "
> > > >
> > > > -SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
> > > > +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> > > >  SRCREV_cmsis  = "refs/tags/5.2.0"
> > > >  SRCREV_FORMAT = "scp_cmsis"
> > > >
> > > > --
> > > > 2.17.1
> > > >
> > > >
> >
> > >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
  2020-06-25 17:00             ` Khasim Mohammed
@ 2020-06-25 19:34               ` Jon Mason
  0 siblings, 0 replies; 13+ messages in thread
From: Jon Mason @ 2020-06-25 19:34 UTC (permalink / raw)
  To: Khasim Mohammed; +Cc: Diego Sueiro, meta-arm

On Thu, Jun 25, 2020 at 05:00:57PM +0000, Khasim Mohammed wrote:
> Hi Jon,
> 
> Ack'ed ,

Done.

> 
> ________________________________________
> From: Jon Mason <jdmason@kudzu.us>
> Sent: Thursday, June 25, 2020 10:04 PM
> To: Khasim Mohammed
> Cc: Diego Sueiro; meta-arm@lists.yoctoproject.org
> Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
> 
> On Thu, Jun 25, 2020 at 03:51:53AM +0000, Khasim Mohammed wrote:
> > Hi Jon,
> >
> > <reply inline>
> > ________________________________________
> > From: Jon Mason <jdmason@kudzu.us>
> > Sent: Thursday, June 25, 2020 8:41 AM
> > To: Khasim Mohammed
> > Cc: Diego Sueiro; meta-arm@lists.yoctoproject.org
> > Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
> >
> > On Wed, Jun 24, 2020 at 06:52:05PM +0000, Khasim Mohammed wrote:
> > > Hi Jon,
> > >
> > > ________________________________________
> > > From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org> on behalf of Jon Mason via lists.yoctoproject.org <jdmason=kudzu.us@lists.yoctoproject.org>
> > > Sent: Thursday, June 25, 2020 12:10 AM
> > > To: Diego Sueiro
> > > Cc: meta-arm@lists.yoctoproject.org
> > > Subject: Re: [meta-arm] [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN
> > >
> > > On Tue, Jun 23, 2020 at 12:05:43AM -0700, Diego Sueiro wrote:
> > > > On Mon, Jun 22, 2020 at 03:18 PM, Khasim Mohammed wrote:
> > > >
> > > > >
> > > > > SCP code has been updated with new logging framework. The patch
> > > > > is to allow setting of log level parameter to INFO or WARN.
> > > > >
> > > > > Change-Id: I20ec19a9aa1bdb7f59c067d2344c299c057a088b
> > > > > Issue-Id: PLATFORMS-3134
> > > > > Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@arm.com>
> > > >
> > > > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> > >
> > > > Pulled into master.
> > >
> > > Can you please apply these three patches to dunfell branch as well ?
> > >
> > > https://lists.yoctoproject.org/g/meta-arm/topic/patch_2_2/75039153?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039153
> > > https://lists.yoctoproject.org/g/meta-arm/topic/patch_1_2_arm_scp_firmware/75039137?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039137
> > > https://lists.yoctoproject.org/g/meta-arm/topic/patch_arm_fiptool/75039113?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,75039113
> >
> > > Looks like there is a problem on dunfell.  When compiling for n1sdp, I
> > > get the following error:
> >
> > >ERROR: Nothing PROVIDES 'virtual/arm-none-eabi-gcc-native' (but /home/jdm/yocto/meta-arm/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb DEPENDS on or otherwise requires it). Close matches:
> > >  virtual/mesa-native
> > >ERROR: Required build target 'core-image-sato' has no buildable providers.
> > > Missing or unbuildable dependency chain was: ['core-image-sato', 'virtual/control-processor-firmware', 'virtual/arm-none-eabi-gcc-native']
> >
> > > Can you confirm it compiles for you?
> >
> > You seem to have missed pushing your gcc patches to dunfell branch :
> >
> > http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb?id=f9ece576ad476e6ed069dfdfc376eb422c1c511c
> >
> > http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb?id=04eb583c4be5e7c36d457eb2d0dec35fef89ae52
> >
> > Can you please push these to dunfell as well ?
> 
> > Exclusively the above doesn't apply cleanly.  I think we need the
> > following:
> 
> 
> commit 9af4348fa0b83b2f5b318692c745716de5de0545 (HEAD)
> Author: Denys Dmytriyenko <denys@ti.com>
> Date:   Fri Jun 5 18:57:10 2020 -0400
> 
>     gcc-x86host.inc: properly link triplet-prefixed binaries
> 
>     Use the correct path for the binaries in ${datadir}, otherwise it results in a
>     single incorrect symlink like gcc-arm-none-eabi-*
> 
>     Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>     Signed-off-by: Jon Mason <jon.mason@arm.com>
> 
> commit d5bc2633f2c203aebf372fc80f7cb87d7621bed9
> Author: Denys Dmytriyenko <denys@ti.com>
> Date:   Fri Jun 5 18:57:09 2020 -0400
> 
>     gcc-aarch64-none-elf: properly set ${S} that is different from default
> 
>     Also use ${BINNAME} and ${PV} variables for automatic substitution.
> 
>     Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>     Signed-off-by: Jon Mason <jon.mason@arm.com>
> 
> commit dfafcf9ec274330ad8ae5d602e208ac35aba4139
> Author: Jon Mason <jdmason@kudzu.us>
> Date:   Thu May 28 09:33:17 2020 -0400
> 
>     arm-toolchain: merge binary toolchain recipes
> 
>     Merge the majority of the binary toolchain recipes for building on an
>     x86 host into a common include file.
> 
>     Also, found and fixed an error with both install commands where the name
>     was double nested on the copy.  For example,
>     /usr/share/arm-none-eabi/arm-none-eabi/ due to the way it was being
>     copied.
> 
>     Signed-off-by: Jon Mason <jdmason@kudzu.us>
>     Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> 
> commit 24181d47084cef34a794dfd88056fa9bc5583913
> Author: Denys Dmytriyenko <denys@ti.com>
> Date:   Wed May 20 04:47:18 2020 -0400
> 
>     arm-toolchain: gcc-aarch64-none-elf: Add recipe
> 
>     Adds a recipe to pull down the prebuilt GCC for compiling bare-metal targets
>     for Aarch64 processors from ARM.
> 
>     Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>     Signed-off-by: Jon Mason <jon.mason@arm.com>
> 
> commit e6ff4eb1d6683e967e4ef81bf5b42a087a47f6d5
> Author: Jon Mason <jdmason@kudzu.us>
> Date:   Thu May 14 21:36:20 2020 -0400
> 
>     arm-toolchain: gcc-arm-none-eabi-native: Add recipe
> 
>     Adds a recipe to pull down the prebuilt GCC for compiling on Cortex-R
>     and Cortex-M processors from ARM. This toolchain is required to build
>     Arm Trusted Firmware for the Rockchip rk3399 SoC, since it must compile
>     some firmware for the M0 coprocessor.
> 
>     This was originally taken from meta-rockchip, but has been modified from
>     mailing list feedback.
> 
>     Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
>     Signed-off-by: Jon Mason <jdmason@kudzu.us>
>     Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>     Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
>     Signed-off-by: Jon Mason <jon.mason@arm.com>
> 
> 
> > Please ack and I'll pull all 5 into dunfell.
> 
> Please consider these patches for dunfell branch.
> 
> Thanks,
> Jon
> 
> Regards,
> Khasim
> 
> >
> > Regards,
> > Khasim
> >
> > >
> > >
> > > Thanks
> > >
> > > Khasim
> > >
> > > > Thanks,
> > > > Jon
> > >
> > > >
> > > > > ---
> > > > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc    | 2 ++
> > > > >  meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb | 2 +-
> > > > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > > index 1873848..2db59d3 100644
> > > > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware.inc
> > > > > @@ -6,6 +6,7 @@ SCP_BUILD_RELEASE   ?= "1"
> > > > >  SCP_COMPILE_VERBOSE ?= "0"
> > > > >  SCP_PLATFORM        ?= "invalid"
> > > > >  SCP_COMPILER        ?= "arm-none-eabi"
> > > > > +SCP_LOG_LEVEL       ?= "WARN"
> > > > >
> > > > >  DEPENDS += "virtual/arm-none-eabi-gcc-native"
> > > > >
> > > > > @@ -39,6 +40,7 @@ EXTRA_OEMAKE = "${SCP_COMP_STR} \
> > > > >                  BUILD_PATH='${B}' \
> > > > >                  PRODUCT='${SCP_PLATFORM}' \
> > > > >                  MODE='${SCP_BUILD_STR}' \
> > > > > +                LOG_LEVEL='${SCP_LOG_LEVEL}' \
> > > > >                  CC='${SCP_COMPILER}-gcc' \
> > > > >                  AR='${SCP_COMPILER}-ar' \
> > > > >                  SIZE='${SCP_COMPILER}-size' \
> > > > > diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > > b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > > index 5ff5859..9cb8b64 100644
> > > > > --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > > +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_git.bb
> > > > > @@ -13,7 +13,7 @@ SRC_URI = "\
> > > > >
> > > > > git://github.com/ARM-software/CMSIS_5.git;protocol=https;name=cmsis;destsuffix=src/cmsis;lfs=0;nobranch=1
> > > > > \
> > > > >  "
> > > > >
> > > > > -SRCREV_scp    = "db19910aca6d1032eb0329e5fbb70a92b997f6f2"
> > > > > +SRCREV_scp    = "fd7c83561a7d76c7681d5d017fb23aa3664c028c"
> > > > >  SRCREV_cmsis  = "refs/tags/5.2.0"
> > > > >  SRCREV_FORMAT = "scp_cmsis"
> > > > >
> > > > > --
> > > > > 2.17.1
> > > > >
> > > > >
> > >
> > > >
> > >
> > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2020-06-25 19:34 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 14:17 [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN Khasim Mohammed
2020-06-22 14:17 ` [PATCH 2/2] arm-bsp/scp-firmware: Build SCP MCP firmware for N1SDP Khasim Mohammed
2020-06-23  7:05   ` Diego Sueiro
2020-06-24 18:40     ` [meta-arm] " Jon Mason
2020-06-23  7:05 ` [PATCH 1/2] arm/scp-firmware : allow setting scp log level to INFO or WARN Diego Sueiro
2020-06-24 18:40   ` [meta-arm] " Jon Mason
2020-06-24 18:52     ` Khasim Mohammed
2020-06-25  3:11       ` Jon Mason
2020-06-25  3:51         ` Khasim Mohammed
2020-06-25 16:34           ` Jon Mason
2020-06-25 17:00             ` Khasim Mohammed
2020-06-25 19:34               ` Jon Mason
     [not found]     ` <161B8F8F11B0E6F1.591@lists.yoctoproject.org>
2020-06-24 18:55       ` Khasim Mohammed

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.