All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] regulator: ad5398: Fix min/max current limit boundary checking
@ 2012-07-04  3:55 Axel Lin
  2012-07-04  4:12 ` Zhang, Sonic
  2012-07-04 11:39 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-07-04  3:55 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-kernel, Sonic Zhang, Lars-Peter Clausen, Liam Girdwood

It is ok to request current limit with min_uA < chip->min_uA and
max_uA > chip->max_uA.

We need to set min_uA = chip->min_uA if (min_uA < chip->min_uA),
this ensures the equation to calcuate selator does not return negative number.

Also set max_uA = chip->max_uA if (max_uA > chip->max_uA), as suggested by
Sonic.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/regulator/ad5398.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
index 46d05f3..f123f7e 100644
--- a/drivers/regulator/ad5398.c
+++ b/drivers/regulator/ad5398.c
@@ -89,9 +89,12 @@ static int ad5398_set_current_limit(struct regulator_dev *rdev, int min_uA, int
 	unsigned short data;
 	int ret;
 
-	if (min_uA > chip->max_uA || min_uA < chip->min_uA)
-		return -EINVAL;
-	if (max_uA > chip->max_uA || max_uA < chip->min_uA)
+	if (min_uA < chip->min_uA)
+		min_uA = chip->min_uA;
+	if (max_uA > chip->max_uA)
+		max_uA = chip->max_uA;
+
+	if (min_uA > chip->max_uA || max_uA < chip->min_uA)
 		return -EINVAL;
 
 	selector = DIV_ROUND_UP((min_uA - chip->min_uA) * chip->current_level,
-- 
1.7.9.5




^ permalink raw reply related	[flat|nested] 3+ messages in thread
* RE: [PATCH v3] regulator: ad5398: Fix min/max current limit boundary checking
  2012-07-04  3:55 [PATCH v3] regulator: ad5398: Fix min/max current limit boundary checking Axel Lin
@ 2012-07-04  4:12 ` Zhang, Sonic
  2012-07-04 11:39 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Sonic @ 2012-07-04  4:12 UTC (permalink / raw)
  To: Axel Lin, Mark Brown; +Cc: linux-kernel, Lars-Peter Clausen, Liam Girdwood

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1797 bytes --]

Acked-by: Sonic Zhang <sonic.zhang@analog.com>

>-----Original Message-----
>From: Axel Lin [mailto:axel.lin@gmail.com]
>Sent: Wednesday, July 04, 2012 11:55 AM
>To: Mark Brown
>Cc: linux-kernel@vger.kernel.org; Zhang, Sonic; Lars-Peter Clausen; Liam
>Girdwood
>Subject: [PATCH v3] regulator: ad5398: Fix min/max current limit boundary
>checking
>
>It is ok to request current limit with min_uA < chip->min_uA and
>max_uA > chip->max_uA.
>
>We need to set min_uA = chip->min_uA if (min_uA < chip->min_uA),
>this ensures the equation to calcuate selator does not return negative number.
>
>Also set max_uA = chip->max_uA if (max_uA > chip->max_uA), as suggested by
>Sonic.
>
>Signed-off-by: Axel Lin <axel.lin@gmail.com>
>---
> drivers/regulator/ad5398.c |    9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
>index 46d05f3..f123f7e 100644
>--- a/drivers/regulator/ad5398.c
>+++ b/drivers/regulator/ad5398.c
>@@ -89,9 +89,12 @@ static int ad5398_set_current_limit(struct regulator_dev
>*rdev, int min_uA, int
>       unsigned short data;
>       int ret;
>
>-      if (min_uA > chip->max_uA || min_uA < chip->min_uA)
>-              return -EINVAL;
>-      if (max_uA > chip->max_uA || max_uA < chip->min_uA)
>+      if (min_uA < chip->min_uA)
>+              min_uA = chip->min_uA;
>+      if (max_uA > chip->max_uA)
>+              max_uA = chip->max_uA;
>+
>+      if (min_uA > chip->max_uA || max_uA < chip->min_uA)
>               return -EINVAL;
>
>       selector = DIV_ROUND_UP((min_uA - chip->min_uA) * chip->current_level,
>--
>1.7.9.5
>
>
>

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH v3] regulator: ad5398: Fix min/max current limit boundary checking
  2012-07-04  3:55 [PATCH v3] regulator: ad5398: Fix min/max current limit boundary checking Axel Lin
  2012-07-04  4:12 ` Zhang, Sonic
@ 2012-07-04 11:39 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-07-04 11:39 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Sonic Zhang, Lars-Peter Clausen, Liam Girdwood

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

On Wed, Jul 04, 2012 at 11:55:07AM +0800, Axel Lin wrote:
> It is ok to request current limit with min_uA < chip->min_uA and
> max_uA > chip->max_uA.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-04 11:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-04  3:55 [PATCH v3] regulator: ad5398: Fix min/max current limit boundary checking Axel Lin
2012-07-04  4:12 ` Zhang, Sonic
2012-07-04 11:39 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.