All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Fang <wei.fang@nxp.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 1/2] dt: ar803x: Document disable-hibernation property
Date: Thu, 18 Aug 2022 01:29:18 +0000	[thread overview]
Message-ID: <DB9PR04MB8106FF32F683295860D4939F886D9@DB9PR04MB8106.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <Yv2TwkThceuU+m5l@lunn.ch>



> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: 2022年8月18日 9:20
> To: Wei Fang <wei.fang@nxp.com>
> Cc: hkallweit1@gmail.com; linux@armlinux.org.uk; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; f.fainelli@gmail.com;
> netdev@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net 1/2] dt: ar803x: Document disable-hibernation
> property
> 
> > Hi Andrew,
> >
> > 	Your suggestion is indeed an effective solution, but I checked both
> > the datasheet and the driver of AR803x PHYs and found that the
> > qca,clk-out-frequency and the qca,keep-pll-enabled properties are associated
> with the CLK_25M pin of AR803x PHYs.
> > But there is a case that CLK_25M pin is not used on some platforms.
> > Taking our i.MX8DXL platform as an example, the stmmac and AR8031 PHY
> > are applied on this platform, but the CLK_25M pin of AR8031 is not
> > used. So when I used the method you mentioned above, it did not work
> > as expected. In this case, we can only disable the hibernation mode of
> > AR803x PHYs and keep the RX_CLK always outputting a valid clock so that the
> stmmac can complete the software reset operation.
> 
> What happens to the RX_CLK when you unplug the cable? It is no longer
> receiving anything, so i would expect the RX_CLK to stop ticking. Does that
> cause problems for the MAC?
> 
Yes, after the PHY enters hibernation mode that the RX_CLK stop ticking, but
for stmmac, it is essential that RX_CLK of PHY is present for software reset
completion. Otherwise, the stmmac is failed to complete the software reset
and can not init DMA.

>      Andrew

  reply	other threads:[~2022-08-18  1:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 14:50 [PATCH net 0/2] Add DT property to disable hibernation mode wei.fang
2022-08-12 14:50 ` [PATCH net 1/2] dt: ar803x: Document disable-hibernation property wei.fang
2022-08-12  7:27   ` Krzysztof Kozlowski
2022-08-12  9:02     ` Wei Fang
2022-08-12 11:25       ` Krzysztof Kozlowski
2022-08-12 11:36         ` Russell King (Oracle)
2022-08-12 12:04           ` Krzysztof Kozlowski
2022-08-12 12:30             ` Russell King (Oracle)
2022-08-12 12:36               ` Krzysztof Kozlowski
2022-08-12 14:34                 ` Russell King (Oracle)
2022-08-15  8:51         ` Wei Fang
2022-08-15  9:19           ` Russell King (Oracle)
2022-08-12 14:15   ` Andrew Lunn
2022-08-15  6:49     ` Wei Fang
2022-08-18  1:20       ` Andrew Lunn
2022-08-18  1:29         ` Wei Fang [this message]
2022-08-18  1:44           ` Andrew Lunn
2022-08-18  1:50             ` Wei Fang
2022-08-18  2:01             ` Wei Fang
2022-08-12 15:13   ` Rob Herring
2022-08-12 15:36   ` Andrew Lunn
2022-08-12 14:50 ` [PATCH net 2/2] net: phy: at803x: Add disable hibernation mode support wei.fang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB9PR04MB8106FF32F683295860D4939F886D9@DB9PR04MB8106.eurprd04.prod.outlook.com \
    --to=wei.fang@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.