* [PATCH 1/2] pinctrl: imx8mn: Constify imx_pinctrl_soc_info
@ 2021-07-13 12:25 Fabio Estevam
2021-07-13 12:25 ` [PATCH 2/2] pinctrl: imx8qxp: " Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2021-07-13 12:25 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-gpio, shawnguo, linux-imx, kernel, Fabio Estevam
The imx_pinctrl_soc_info structure content is never changed, so it can be
declared as 'const', like it is done on all other i.MX pinctrl drivers.
Make it 'const' in this driver too.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/pinctrl/freescale/pinctrl-imx8mn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx8mn.c b/drivers/pinctrl/freescale/pinctrl-imx8mn.c
index 448a79eb4568..dbf89cfba477 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx8mn.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx8mn.c
@@ -317,7 +317,7 @@ static const struct pinctrl_pin_desc imx8mn_pinctrl_pads[] = {
IMX_PINCTRL_PIN(MX8MN_IOMUXC_UART4_TXD),
};
-static struct imx_pinctrl_soc_info imx8mn_pinctrl_info = {
+static const struct imx_pinctrl_soc_info imx8mn_pinctrl_info = {
.pins = imx8mn_pinctrl_pads,
.npins = ARRAY_SIZE(imx8mn_pinctrl_pads),
.gpr_compatible = "fsl,imx8mn-iomuxc-gpr",
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] pinctrl: imx8qxp: Constify imx_pinctrl_soc_info
2021-07-13 12:25 [PATCH 1/2] pinctrl: imx8mn: Constify imx_pinctrl_soc_info Fabio Estevam
@ 2021-07-13 12:25 ` Fabio Estevam
2021-07-16 3:49 ` Aisheng Dong
2021-07-16 3:46 ` [PATCH 1/2] pinctrl: imx8mn: " Aisheng Dong
2021-07-30 10:04 ` Linus Walleij
2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2021-07-13 12:25 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-gpio, shawnguo, linux-imx, kernel, Fabio Estevam
The imx_pinctrl_soc_info structure content is never changed, so it can be
declared as 'const', like it is done on all other i.MX pinctrl drivers.
Make it 'const' in this driver too.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/pinctrl/freescale/pinctrl-imx8qxp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx8qxp.c b/drivers/pinctrl/freescale/pinctrl-imx8qxp.c
index 4f97813ba8b7..0a0acc0038d0 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx8qxp.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx8qxp.c
@@ -194,7 +194,7 @@ static const struct pinctrl_pin_desc imx8qxp_pinctrl_pads[] = {
IMX_PINCTRL_PIN(IMX8QXP_COMP_CTL_GPIO_1V8_3V3_QSPI0B),
};
-static struct imx_pinctrl_soc_info imx8qxp_pinctrl_info = {
+static const struct imx_pinctrl_soc_info imx8qxp_pinctrl_info = {
.pins = imx8qxp_pinctrl_pads,
.npins = ARRAY_SIZE(imx8qxp_pinctrl_pads),
.flags = IMX_USE_SCU,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH 2/2] pinctrl: imx8qxp: Constify imx_pinctrl_soc_info
2021-07-13 12:25 ` [PATCH 2/2] pinctrl: imx8qxp: " Fabio Estevam
@ 2021-07-16 3:49 ` Aisheng Dong
0 siblings, 0 replies; 5+ messages in thread
From: Aisheng Dong @ 2021-07-16 3:49 UTC (permalink / raw)
To: Fabio Estevam, linus.walleij; +Cc: linux-gpio, shawnguo, dl-linux-imx, kernel
> From: Fabio Estevam <festevam@gmail.com>
> Sent: Tuesday, July 13, 2021 8:25 PM
>
> The imx_pinctrl_soc_info structure content is never changed, so it can be
> declared as 'const', like it is done on all other i.MX pinctrl drivers.
>
> Make it 'const' in this driver too.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
BTW, you missed pinctrl-imx8dxl.c. Can you change that one too?
Regards
Aisheng
> ---
> drivers/pinctrl/freescale/pinctrl-imx8qxp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx8qxp.c
> b/drivers/pinctrl/freescale/pinctrl-imx8qxp.c
> index 4f97813ba8b7..0a0acc0038d0 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx8qxp.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx8qxp.c
> @@ -194,7 +194,7 @@ static const struct pinctrl_pin_desc
> imx8qxp_pinctrl_pads[] = {
> IMX_PINCTRL_PIN(IMX8QXP_COMP_CTL_GPIO_1V8_3V3_QSPI0B),
> };
>
> -static struct imx_pinctrl_soc_info imx8qxp_pinctrl_info = {
> +static const struct imx_pinctrl_soc_info imx8qxp_pinctrl_info = {
> .pins = imx8qxp_pinctrl_pads,
> .npins = ARRAY_SIZE(imx8qxp_pinctrl_pads),
> .flags = IMX_USE_SCU,
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/2] pinctrl: imx8mn: Constify imx_pinctrl_soc_info
2021-07-13 12:25 [PATCH 1/2] pinctrl: imx8mn: Constify imx_pinctrl_soc_info Fabio Estevam
2021-07-13 12:25 ` [PATCH 2/2] pinctrl: imx8qxp: " Fabio Estevam
@ 2021-07-16 3:46 ` Aisheng Dong
2021-07-30 10:04 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Aisheng Dong @ 2021-07-16 3:46 UTC (permalink / raw)
To: Fabio Estevam, linus.walleij; +Cc: linux-gpio, shawnguo, dl-linux-imx, kernel
> From: Fabio Estevam <festevam@gmail.com>
> Sent: Tuesday, July 13, 2021 8:25 PM
> Subject: [PATCH 1/2] pinctrl: imx8mn: Constify imx_pinctrl_soc_info
>
> The imx_pinctrl_soc_info structure content is never changed, so it can be
> declared as 'const', like it is done on all other i.MX pinctrl drivers.
>
> Make it 'const' in this driver too.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
> ---
> drivers/pinctrl/freescale/pinctrl-imx8mn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> b/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> index 448a79eb4568..dbf89cfba477 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx8mn.c
> @@ -317,7 +317,7 @@ static const struct pinctrl_pin_desc
> imx8mn_pinctrl_pads[] = {
> IMX_PINCTRL_PIN(MX8MN_IOMUXC_UART4_TXD),
> };
>
> -static struct imx_pinctrl_soc_info imx8mn_pinctrl_info = {
> +static const struct imx_pinctrl_soc_info imx8mn_pinctrl_info = {
> .pins = imx8mn_pinctrl_pads,
> .npins = ARRAY_SIZE(imx8mn_pinctrl_pads),
> .gpr_compatible = "fsl,imx8mn-iomuxc-gpr",
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] pinctrl: imx8mn: Constify imx_pinctrl_soc_info
2021-07-13 12:25 [PATCH 1/2] pinctrl: imx8mn: Constify imx_pinctrl_soc_info Fabio Estevam
2021-07-13 12:25 ` [PATCH 2/2] pinctrl: imx8qxp: " Fabio Estevam
2021-07-16 3:46 ` [PATCH 1/2] pinctrl: imx8mn: " Aisheng Dong
@ 2021-07-30 10:04 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2021-07-30 10:04 UTC (permalink / raw)
To: Fabio Estevam
Cc: open list:GPIO SUBSYSTEM, Shawn Guo, NXP Linux Team, Sascha Hauer
On Tue, Jul 13, 2021 at 2:25 PM Fabio Estevam <festevam@gmail.com> wrote:
> The imx_pinctrl_soc_info structure content is never changed, so it can be
> declared as 'const', like it is done on all other i.MX pinctrl drivers.
>
> Make it 'const' in this driver too.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Both patches applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-30 10:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13 12:25 [PATCH 1/2] pinctrl: imx8mn: Constify imx_pinctrl_soc_info Fabio Estevam
2021-07-13 12:25 ` [PATCH 2/2] pinctrl: imx8qxp: " Fabio Estevam
2021-07-16 3:49 ` Aisheng Dong
2021-07-16 3:46 ` [PATCH 1/2] pinctrl: imx8mn: " Aisheng Dong
2021-07-30 10:04 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.