* [PATCH v2] net: tipc: resize nlattr array to correct size
@ 2023-06-14 12:06 Lin Ma
2023-06-14 12:49 ` Florian Westphal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lin Ma @ 2023-06-14 12:06 UTC (permalink / raw)
To: davem, netdev, tipc-discussion, tung.q.nguyen; +Cc: Lin Ma
According to nla_parse_nested_deprecated(), the tb[] is supposed to the
destination array with maxtype+1 elements. In current
tipc_nl_media_get() and __tipc_nl_media_set(), a larger array is used
which is unnecessary. This patch resize them to a proper size.
Fixes: 1e55417d8fc6 ("tipc: add media set to new netlink api")
Fixes: 46f15c6794fb ("tipc: add media get/dump to new netlink api")
Signed-off-by: Lin Ma <linma@zju.edu.cn>
---
V1 -> V2: add net in title, also add Fixes tag
net/tipc/bearer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 53881406e200..cdcd2731860b 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -1258,7 +1258,7 @@ int tipc_nl_media_get(struct sk_buff *skb, struct genl_info *info)
struct tipc_nl_msg msg;
struct tipc_media *media;
struct sk_buff *rep;
- struct nlattr *attrs[TIPC_NLA_BEARER_MAX + 1];
+ struct nlattr *attrs[TIPC_NLA_MEDIA_MAX + 1];
if (!info->attrs[TIPC_NLA_MEDIA])
return -EINVAL;
@@ -1307,7 +1307,7 @@ int __tipc_nl_media_set(struct sk_buff *skb, struct genl_info *info)
int err;
char *name;
struct tipc_media *m;
- struct nlattr *attrs[TIPC_NLA_BEARER_MAX + 1];
+ struct nlattr *attrs[TIPC_NLA_MEDIA_MAX + 1];
if (!info->attrs[TIPC_NLA_MEDIA])
return -EINVAL;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net: tipc: resize nlattr array to correct size
2023-06-14 12:06 [PATCH v2] net: tipc: resize nlattr array to correct size Lin Ma
@ 2023-06-14 12:49 ` Florian Westphal
2023-06-15 2:44 ` Tung Quang Nguyen
2023-06-15 22:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Florian Westphal @ 2023-06-14 12:49 UTC (permalink / raw)
To: Lin Ma; +Cc: davem, netdev, tipc-discussion, tung.q.nguyen
Lin Ma <linma@zju.edu.cn> wrote:
> According to nla_parse_nested_deprecated(), the tb[] is supposed to the
> destination array with maxtype+1 elements. In current
> tipc_nl_media_get() and __tipc_nl_media_set(), a larger array is used
> which is unnecessary. This patch resize them to a proper size.
Reviewed-by: Florian Westphal <fw@strlen.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] net: tipc: resize nlattr array to correct size
2023-06-14 12:06 [PATCH v2] net: tipc: resize nlattr array to correct size Lin Ma
2023-06-14 12:49 ` Florian Westphal
@ 2023-06-15 2:44 ` Tung Quang Nguyen
2023-06-15 22:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Tung Quang Nguyen @ 2023-06-15 2:44 UTC (permalink / raw)
To: Lin Ma, davem, netdev, tipc-discussion
>Subject: [PATCH v2] net: tipc: resize nlattr array to correct size
>
>According to nla_parse_nested_deprecated(), the tb[] is supposed to the
>destination array with maxtype+1 elements. In current
>tipc_nl_media_get() and __tipc_nl_media_set(), a larger array is used
>which is unnecessary. This patch resize them to a proper size.
>
>Fixes: 1e55417d8fc6 ("tipc: add media set to new netlink api")
>Fixes: 46f15c6794fb ("tipc: add media get/dump to new netlink api")
>Signed-off-by: Lin Ma <linma@zju.edu.cn>
>---
>V1 -> V2: add net in title, also add Fixes tag
Reviewed-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
>
> net/tipc/bearer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
>index 53881406e200..cdcd2731860b 100644
>--- a/net/tipc/bearer.c
>+++ b/net/tipc/bearer.c
>@@ -1258,7 +1258,7 @@ int tipc_nl_media_get(struct sk_buff *skb, struct genl_info *info)
> struct tipc_nl_msg msg;
> struct tipc_media *media;
> struct sk_buff *rep;
>- struct nlattr *attrs[TIPC_NLA_BEARER_MAX + 1];
>+ struct nlattr *attrs[TIPC_NLA_MEDIA_MAX + 1];
>
> if (!info->attrs[TIPC_NLA_MEDIA])
> return -EINVAL;
>@@ -1307,7 +1307,7 @@ int __tipc_nl_media_set(struct sk_buff *skb, struct genl_info *info)
> int err;
> char *name;
> struct tipc_media *m;
>- struct nlattr *attrs[TIPC_NLA_BEARER_MAX + 1];
>+ struct nlattr *attrs[TIPC_NLA_MEDIA_MAX + 1];
>
> if (!info->attrs[TIPC_NLA_MEDIA])
> return -EINVAL;
>--
>2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net: tipc: resize nlattr array to correct size
2023-06-14 12:06 [PATCH v2] net: tipc: resize nlattr array to correct size Lin Ma
2023-06-14 12:49 ` Florian Westphal
2023-06-15 2:44 ` Tung Quang Nguyen
@ 2023-06-15 22:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-15 22:10 UTC (permalink / raw)
To: Lin Ma; +Cc: davem, netdev, tipc-discussion, tung.q.nguyen
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 14 Jun 2023 20:06:04 +0800 you wrote:
> According to nla_parse_nested_deprecated(), the tb[] is supposed to the
> destination array with maxtype+1 elements. In current
> tipc_nl_media_get() and __tipc_nl_media_set(), a larger array is used
> which is unnecessary. This patch resize them to a proper size.
>
> Fixes: 1e55417d8fc6 ("tipc: add media set to new netlink api")
> Fixes: 46f15c6794fb ("tipc: add media get/dump to new netlink api")
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
>
> [...]
Here is the summary with links:
- [v2] net: tipc: resize nlattr array to correct size
https://git.kernel.org/netdev/net/c/44194cb1b604
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-15 22:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 12:06 [PATCH v2] net: tipc: resize nlattr array to correct size Lin Ma
2023-06-14 12:49 ` Florian Westphal
2023-06-15 2:44 ` Tung Quang Nguyen
2023-06-15 22:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.