How to replace set_fs(KERNEL_DS) for a kernel 5.10.x module driver version

* How to replace set_fs(KERNEL_DS) for a kernel 5.10.x module driver version
@ 2021-01-12  7:21 Jorge Fernandez Monteagudo
  2021-01-12  7:29 ` Greg KH
  0 siblings, 1 reply; 10+ messages in thread
From: Jorge Fernandez Monteagudo @ 2021-01-12  7:21 UTC (permalink / raw)
  To: kernelnewbies

Hi all, this is my first post in this mailing list... I hope to find an answer. I've post the question in stackoverflow with the same tittle with no answers yet. Since then, I've been able to reduce the demo kernel module to minimum in order to show but I see. The minimum kernel module code is attached at the end.

My kernel module was working ok up to kernel 5.10.x. My kernel module adds a layer above the cdc-acm class driver to use all the infrastructure this driver because the hardware it controls has a ttyACMx device. The minimum kernel module code attached shows how I open the ttyACMx device and try to set the baudrate. Once the device is opened I use the unlocked_ioctl function with TCSETS to set the new device properties. 

		ret = fd->f_op->unlocked_ioctl(fd, TCSETS, (unsigned long int) &newtio);

I get an EFAULT (-14) error from this function. I've track down the error to drivers/tty/tty_ioctl.c, set_termios function in the next code:

#ifdef TCGETS2
    } else if (opt & TERMIOS_OLD) {
        if (user_termios_to_kernel_termios_1(&tmp_termios,
                        (struct termios __user *)arg))
            return -EFAULT;
    } else {

where 'user_termios_to_kernel_termios_1' is a macro to 'copy_from_user' then I think there is a problem with the parameter 'newtio'. To solve this in the previous kernel versions ( < 5.10.x) I had the code with get_fs()/set_fs() but now these functions and the KERNEL_DS definitions are gone... 

As a reference when I run this kernel module in a 4.15.0-128-generic I get when inserted and removed:

# dmesg
...
[431743.226926] cdc_acm 3-5.2:1.0: ttyACM0: USB ACM device
[431749.633030] testdrv:testdrv_init: testdrv_init
[431749.633351] testdrv:testdrv_init: fd      : 00000000e9327576
[431749.633355] testdrv:testdrv_init: fd->f_op: 00000000c761e065
[431749.633357] testdrv:testdrv_init: ioctl   : 00000000608ed60c
[431749.633517] testdrv:usbox_serial_baudrate_set: _unlocked_ioctl: 0
[431749.633519] testdrv:usbox_serial_baudrate_set: ret: 0
[431761.532905] testdrv:testdrv_exit: testdrv_exit

and the same driver with 5.10.0-1-amd64:

# dmesg
...
[    4.731179] cdc_acm 2-3:1.0: ttyACM0: USB ACM device
...
[  168.263871] testdrv: loading out-of-tree module taints kernel.
[  168.264337] testdrv:testdrv_init: testdrv_init
[  168.266360] testdrv:testdrv_init: fd      : 00000000bd0e50a3
[  168.266363] testdrv:testdrv_init: fd->f_op: 00000000dc488f77
[  168.266364] testdrv:testdrv_init: ioctl   : 00000000c31431c2
[  168.266370] testdrv:usbox_serial_baudrate_set: _unlocked_ioctl: -14
[  168.266371] testdrv:usbox_serial_baudrate_set: ret: -14
[  168.266372] testdrv:testdrv_init: errno: EINVAL

Anybody can help me to make it work the minimum kernel module attached?
Thank you!
Jorge

----
#define pr_fmt(fmt) "%s:%s: " fmt, KBUILD_MODNAME, __func__
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/file.h>
#include <linux/tty.h>
#include <linux/version.h>
#include <linux/uaccess.h>

/* ttyACM file descriptor */
static struct file *fd;

static int usbox_serial_baudrate_set(struct file *fd)
{
	int ret;
	mm_segment_t old_fs;
	struct termios newtio;
	//struct termios __user newtio;
	//void __user *unewtio = (void __user *) &newtio;

	memset(&newtio, 0, sizeof(newtio));
	newtio.c_cflag = (B115200 | CS8 | CLOCAL | CREAD);

#if LINUX_VERSION_CODE < KERNEL_VERSION(5,0,0)
	old_fs = get_fs();
	set_fs( get_ds() );
#elif LINUX_VERSION_CODE < KERNEL_VERSION(5,10,0)
	old_fs = get_fs();
	set_fs( KERNEL_DS );
#else
	old_fs = force_uaccess_begin();
#endif

	if (fd->f_op->unlocked_ioctl) {
		ret = fd->f_op->unlocked_ioctl(fd, TCSETS, (unsigned long int) &newtio);
		pr_info("_unlocked_ioctl: %d\n", ret);
	} else {
		ret = -ENOTTY;
	}

#if LINUX_VERSION_CODE < KERNEL_VERSION(5,10,0)
	set_fs(old_fs);
#else
	force_uaccess_end(old_fs);
#endif

	pr_info("ret: %d\n", ret );
	return ret;
}

static int __init testdrv_init(void)
{
	pr_info("testdrv_init\n");

	fd = filp_open( "/dev/ttyACM0", O_RDWR|O_NOCTTY, 0);
	if (IS_ERR(fd)) {
		pr_info("error from filp_open()\n");
		return -ENODEV;
	}

	pr_info ("fd      : %p\n", fd);
	pr_info ("fd->f_op: %p\n", fd->f_op);
	pr_info ("ioctl   : %p\n", fd->f_op->unlocked_ioctl);

	if ((fd->f_op == NULL) || (fd->f_op->unlocked_ioctl == NULL)) {
		pr_info("errno: ENODEV\n");
		return -ENODEV;
	}

	// Set baudrate.
	if (usbox_serial_baudrate_set(fd) != 0 ) {
		filp_close(fd, NULL);
		pr_info("errno: EINVAL\n");
		return -EINVAL;
	}

	return 0;
}

static void __exit testdrv_exit(void)
{
	pr_info("testdrv_exit\n");

	if (fd != NULL) {
		filp_close(fd, NULL);
		fd = NULL;
	}
}

module_init(testdrv_init);
module_exit(testdrv_exit);

MODULE_LICENSE("GPL");
MODULE_AUTHOR("Unknonw");
MODULE_DESCRIPTION("testdrv");
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

^ permalink raw reply	[flat|nested] 10+ messages in thread