* [PATCH 1/2] arm64: dts: imx8mp: Remove the reference to audio ipg clock on imx8mp
@ 2021-04-16 7:37 Jacky Bai
2021-04-16 7:37 ` [PATCH 2/2] clk: imx: Remove the audio ipg clock from imx8mp Jacky Bai
0 siblings, 1 reply; 4+ messages in thread
From: Jacky Bai @ 2021-04-16 7:37 UTC (permalink / raw)
To: shawnguo, robh+dt, abel.vesa, s.hauer
Cc: festevam, devicetree, linux-clk, linux-imx
On i.MX8MP, there is no audio ipg clock, so remove the wrong reference
to this clock in dts file.
Signed-off-by: Jacky Bai <ping.bai@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index c2d51a46cb3c..0283c22c2bd3 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -407,7 +407,6 @@ clk: clock-controller@30380000 {
<&clk IMX8MP_CLK_GIC>,
<&clk IMX8MP_CLK_AUDIO_AHB>,
<&clk IMX8MP_CLK_AUDIO_AXI_SRC>,
- <&clk IMX8MP_CLK_IPG_AUDIO_ROOT>,
<&clk IMX8MP_AUDIO_PLL1>,
<&clk IMX8MP_AUDIO_PLL2>;
assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
@@ -423,7 +422,6 @@ clk: clock-controller@30380000 {
<500000000>,
<400000000>,
<800000000>,
- <400000000>,
<393216000>,
<361267200>;
};
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] clk: imx: Remove the audio ipg clock from imx8mp
2021-04-16 7:37 [PATCH 1/2] arm64: dts: imx8mp: Remove the reference to audio ipg clock on imx8mp Jacky Bai
@ 2021-04-16 7:37 ` Jacky Bai
2021-04-16 23:57 ` Stephen Boyd
0 siblings, 1 reply; 4+ messages in thread
From: Jacky Bai @ 2021-04-16 7:37 UTC (permalink / raw)
To: shawnguo, robh+dt, abel.vesa, s.hauer
Cc: festevam, devicetree, linux-clk, linux-imx
There is no audio ipg clock on i.MX8MP, so remove this from
the clock driver.
Signed-off-by: Jacky Bai <ping.bai@nxp.com>
---
drivers/clk/imx/clk-imx8mp.c | 1 -
include/dt-bindings/clock/imx8mp-clock.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
index e39c9c907c38..12837304545d 100644
--- a/drivers/clk/imx/clk-imx8mp.c
+++ b/drivers/clk/imx/clk-imx8mp.c
@@ -556,7 +556,6 @@ static int imx8mp_clocks_probe(struct platform_device *pdev)
hws[IMX8MP_CLK_MIPI_DSI_ESC_RX] = imx8m_clk_hw_composite_bus("mipi_dsi_esc_rx", imx8mp_mipi_dsi_esc_rx_sels, ccm_base + 0x9200);
hws[IMX8MP_CLK_IPG_ROOT] = imx_clk_hw_divider2("ipg_root", "ahb_root", ccm_base + 0x9080, 0, 1);
- hws[IMX8MP_CLK_IPG_AUDIO_ROOT] = imx_clk_hw_divider2("ipg_audio_root", "audio_ahb", ccm_base + 0x9180, 0, 1);
hws[IMX8MP_CLK_DRAM_ALT] = imx8m_clk_hw_composite("dram_alt", imx8mp_dram_alt_sels, ccm_base + 0xa000);
hws[IMX8MP_CLK_DRAM_APB] = imx8m_clk_hw_composite_critical("dram_apb", imx8mp_dram_apb_sels, ccm_base + 0xa080);
diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h
index 43927a1b9e94..235c7a00d379 100644
--- a/include/dt-bindings/clock/imx8mp-clock.h
+++ b/include/dt-bindings/clock/imx8mp-clock.h
@@ -117,7 +117,6 @@
#define IMX8MP_CLK_AUDIO_AHB 108
#define IMX8MP_CLK_MIPI_DSI_ESC_RX 109
#define IMX8MP_CLK_IPG_ROOT 110
-#define IMX8MP_CLK_IPG_AUDIO_ROOT 111
#define IMX8MP_CLK_DRAM_ALT 112
#define IMX8MP_CLK_DRAM_APB 113
#define IMX8MP_CLK_VPU_G1 114
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] clk: imx: Remove the audio ipg clock from imx8mp
2021-04-16 7:37 ` [PATCH 2/2] clk: imx: Remove the audio ipg clock from imx8mp Jacky Bai
@ 2021-04-16 23:57 ` Stephen Boyd
2021-04-19 2:24 ` Jacky Bai
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2021-04-16 23:57 UTC (permalink / raw)
To: Jacky Bai, abel.vesa, robh+dt, s.hauer, shawnguo
Cc: festevam, devicetree, linux-clk, linux-imx
Quoting Jacky Bai (2021-04-16 00:37:03)
> diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h
> index 43927a1b9e94..235c7a00d379 100644
> --- a/include/dt-bindings/clock/imx8mp-clock.h
> +++ b/include/dt-bindings/clock/imx8mp-clock.h
> @@ -117,7 +117,6 @@
> #define IMX8MP_CLK_AUDIO_AHB 108
> #define IMX8MP_CLK_MIPI_DSI_ESC_RX 109
> #define IMX8MP_CLK_IPG_ROOT 110
> -#define IMX8MP_CLK_IPG_AUDIO_ROOT 111
Maybe just add a comment saying it isn't there? Or remove it in three
months time once DTS no longer references it?
Removing this here means that it has to merge whenever the DTS doesn't
reference it anymore which causes a cross tree dependency.
> #define IMX8MP_CLK_DRAM_ALT 112
> #define IMX8MP_CLK_DRAM_APB 113
> #define IMX8MP_CLK_VPU_G1 114
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 2/2] clk: imx: Remove the audio ipg clock from imx8mp
2021-04-16 23:57 ` Stephen Boyd
@ 2021-04-19 2:24 ` Jacky Bai
0 siblings, 0 replies; 4+ messages in thread
From: Jacky Bai @ 2021-04-19 2:24 UTC (permalink / raw)
To: Stephen Boyd, Abel Vesa, robh+dt, s.hauer, shawnguo
Cc: festevam, devicetree, linux-clk, dl-linux-imx
> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@kernel.org]
> Sent: Saturday, April 17, 2021 7:57 AM
> To: Jacky Bai <ping.bai@nxp.com>; Abel Vesa <abel.vesa@nxp.com>;
> robh+dt@kernel.org; s.hauer@pengutronix.de; shawnguo@kernel.org
> Cc: festevam@gmail.com; devicetree@vger.kernel.org;
> linux-clk@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH 2/2] clk: imx: Remove the audio ipg clock from imx8mp
>
> Quoting Jacky Bai (2021-04-16 00:37:03)
> > diff --git a/include/dt-bindings/clock/imx8mp-clock.h
> > b/include/dt-bindings/clock/imx8mp-clock.h
> > index 43927a1b9e94..235c7a00d379 100644
> > --- a/include/dt-bindings/clock/imx8mp-clock.h
> > +++ b/include/dt-bindings/clock/imx8mp-clock.h
> > @@ -117,7 +117,6 @@
> > #define IMX8MP_CLK_AUDIO_AHB 108
> > #define IMX8MP_CLK_MIPI_DSI_ESC_RX 109
> > #define IMX8MP_CLK_IPG_ROOT 110
> > -#define IMX8MP_CLK_IPG_AUDIO_ROOT 111
>
> Maybe just add a comment saying it isn't there? Or remove it in three months
> time once DTS no longer references it?
>
Ok, will resolve this comments in V2. I can add some comments and keep it here for a while.
> Removing this here means that it has to merge whenever the DTS doesn't
> reference it anymore which causes a cross tree dependency.
Right, this delete will lead to the dependency with the dts tree for now.
BR
Jacky Bai
>
> > #define IMX8MP_CLK_DRAM_ALT 112
> > #define IMX8MP_CLK_DRAM_APB 113
> > #define IMX8MP_CLK_VPU_G1 114
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-19 2:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 7:37 [PATCH 1/2] arm64: dts: imx8mp: Remove the reference to audio ipg clock on imx8mp Jacky Bai
2021-04-16 7:37 ` [PATCH 2/2] clk: imx: Remove the audio ipg clock from imx8mp Jacky Bai
2021-04-16 23:57 ` Stephen Boyd
2021-04-19 2:24 ` Jacky Bai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.