All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@nxp.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Pawel Laszczak <pawell@cadence.com>,
	Roger Quadros <rogerq@ti.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: RE: [PATCH -next] usb: cdns3: fix warning when USB_CDNS_HOST is not set
Date: Wed, 9 Dec 2020 02:40:58 +0000	[thread overview]
Message-ID: <DBBPR04MB7979502194410BB1AE96DF038BCC0@DBBPR04MB7979.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20201208195547.30076-1-rdunlap@infradead.org>

 
> In file included from ../drivers/usb/cdns3/core.c:23:0:
> ../drivers/usb/cdns3/host-export.h:27:51: warning: ‘struct usb_hcd’ declared
> inside parameter list will not be visible outside of this definition or declaration
> static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
>                                                    ^~~~~~~
> 

Applied both, thanks.

Peter

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Peter Chen <peter.chen@nxp.com>
> Cc: Pawel Laszczak <pawell@cadence.com>
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: linux-usb@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/usb/cdns3/host-export.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20201208.orig/drivers/usb/cdns3/host-export.h
> +++ linux-next-20201208/drivers/usb/cdns3/host-export.h
> @@ -9,10 +9,10 @@
>  #ifndef __LINUX_CDNS3_HOST_EXPORT
>  #define __LINUX_CDNS3_HOST_EXPORT
> 
> -#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
> -
>  struct usb_hcd;
> 
> +#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
> +
>  int cdns_host_init(struct cdns *cdns);
>  int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);
> 

      reply	other threads:[~2020-12-09  2:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 19:55 [PATCH -next] usb: cdns3: fix warning when USB_CDNS_HOST is not set Randy Dunlap
2020-12-09  2:40 ` Peter Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBBPR04MB7979502194410BB1AE96DF038BCC0@DBBPR04MB7979.eurprd04.prod.outlook.com \
    --to=peter.chen@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pawell@cadence.com \
    --cc=rdunlap@infradead.org \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.