* [PATCH -next] usb: cdns3: fix warning when USB_CDNS_HOST is not set
@ 2020-12-08 19:55 Randy Dunlap
2020-12-09 2:40 ` Peter Chen
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-12-08 19:55 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Peter Chen, Pawel Laszczak, Roger Quadros,
linux-usb, Greg Kroah-Hartman
Fix a build warning when USB_CDNS_HOST is not enabled:
In file included from ../drivers/usb/cdns3/core.c:23:0:
../drivers/usb/cdns3/host-export.h:27:51: warning: ‘struct usb_hcd’ declared inside parameter list will not be visible outside of this definition or declaration
static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
^~~~~~~
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Peter Chen <peter.chen@nxp.com>
Cc: Pawel Laszczak <pawell@cadence.com>
Cc: Roger Quadros <rogerq@ti.com>
Cc: linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/cdns3/host-export.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20201208.orig/drivers/usb/cdns3/host-export.h
+++ linux-next-20201208/drivers/usb/cdns3/host-export.h
@@ -9,10 +9,10 @@
#ifndef __LINUX_CDNS3_HOST_EXPORT
#define __LINUX_CDNS3_HOST_EXPORT
-#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
-
struct usb_hcd;
+#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
+
int cdns_host_init(struct cdns *cdns);
int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH -next] usb: cdns3: fix warning when USB_CDNS_HOST is not set
2020-12-08 19:55 [PATCH -next] usb: cdns3: fix warning when USB_CDNS_HOST is not set Randy Dunlap
@ 2020-12-09 2:40 ` Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2020-12-09 2:40 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Pawel Laszczak, Roger Quadros, linux-usb, Greg Kroah-Hartman
> In file included from ../drivers/usb/cdns3/core.c:23:0:
> ../drivers/usb/cdns3/host-export.h:27:51: warning: ‘struct usb_hcd’ declared
> inside parameter list will not be visible outside of this definition or declaration
> static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
> ^~~~~~~
>
Applied both, thanks.
Peter
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Peter Chen <peter.chen@nxp.com>
> Cc: Pawel Laszczak <pawell@cadence.com>
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: linux-usb@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/usb/cdns3/host-export.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20201208.orig/drivers/usb/cdns3/host-export.h
> +++ linux-next-20201208/drivers/usb/cdns3/host-export.h
> @@ -9,10 +9,10 @@
> #ifndef __LINUX_CDNS3_HOST_EXPORT
> #define __LINUX_CDNS3_HOST_EXPORT
>
> -#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
> -
> struct usb_hcd;
>
> +#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
> +
> int cdns_host_init(struct cdns *cdns);
> int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-09 2:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 19:55 [PATCH -next] usb: cdns3: fix warning when USB_CDNS_HOST is not set Randy Dunlap
2020-12-09 2:40 ` Peter Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.