RE: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Guillaume Gardet <Guillaume.Gardet@arm.com>]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 26 July 2019 12:40
> To: Guillaume Gardet <Guillaume.Gardet@arm.com>
> Cc: linux-samsung-soc@vger.kernel.org; Kukjin Kim <kgene@kernel.org>;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 1/2] arm: dts: exynos: Add GPU/Mali T604 node to
> exynos5250
>
> On Thu, 25 Jul 2019 at 14:37, Guillaume Gardet <Guillaume.Gardet@arm.com>
> wrote:
> > > No, regulator is not provided. On all Exynos boards Mali uses its
> > > own dedicated regulator (and sometimes additional one). It worked in
> > > your case because the regulator was set as always-on but this is a
> workaround for lack of consumers.
> > > Once there is a consumer, the regulator should not be always-on to
> > > save the energy when not used.
> >
> > I do not have the required info here. Do you have it, or could I skip the
> mali-supply for now?
>
> You can guess from regulator name :)
> For the Arndale, the schematics are saying it is buck4.

Thanks. This is buck4 as well for snow.

On Arndale board, buck4 has a fixed voltage of 1V contrary to snow, which leads to the following error:
[   21.131930] panfrost 11800000.gpu: Cannot set voltage 925000 uV

The following change fixes the previous error:
-                               regulator-min-microvolt = <1000000>;
-                               regulator-max-microvolt = <1000000>;
+                               regulator-min-microvolt = <850000>;
+                               regulator-max-microvolt = <1300000>;

Should I remove arndale enablement for now until this is fixed separately, or could I add this fixup in this patch serie, as it is related?

Regards,
Guillaume


>
> Best regards,
> Krzysztof
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.