All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: comedi: make comedi_internal.h self-reliant
@ 2015-03-27 15:58 ` Ian Abbott
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2015-03-27 15:58 UTC (permalink / raw)
  To: driverdev-devel
  Cc: Greg Kroah-Hartman, Ian Abbott, H Hartley Sweeten, linux-kernel

Add `#include`s and declare incomplete types to "comedi_internal.h" so
that .c files still compile when it is the first file included.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
---
 drivers/staging/comedi/comedi_internal.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/staging/comedi/comedi_internal.h b/drivers/staging/comedi/comedi_internal.h
index d57817c..3b91853 100644
--- a/drivers/staging/comedi/comedi_internal.h
+++ b/drivers/staging/comedi/comedi_internal.h
@@ -1,11 +1,21 @@
 #ifndef _COMEDI_INTERNAL_H
 #define _COMEDI_INTERNAL_H
 
+#include <linux/compiler.h>
 #include <linux/types.h>
 
 /*
  * various internal comedi stuff
  */
+
+struct comedi_buf_map;
+struct comedi_devconfig;
+struct comedi_device;
+struct comedi_insn;
+struct comedi_rangeinfo;
+struct comedi_subdevice;
+struct device;
+
 int do_rangeinfo_ioctl(struct comedi_device *dev,
 		       struct comedi_rangeinfo __user *arg);
 struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device);
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] staging: comedi: make comedi_internal.h self-reliant
@ 2015-03-27 15:58 ` Ian Abbott
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2015-03-27 15:58 UTC (permalink / raw)
  To: driverdev-devel; +Cc: Greg Kroah-Hartman, Ian Abbott, linux-kernel

Add `#include`s and declare incomplete types to "comedi_internal.h" so
that .c files still compile when it is the first file included.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
---
 drivers/staging/comedi/comedi_internal.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/staging/comedi/comedi_internal.h b/drivers/staging/comedi/comedi_internal.h
index d57817c..3b91853 100644
--- a/drivers/staging/comedi/comedi_internal.h
+++ b/drivers/staging/comedi/comedi_internal.h
@@ -1,11 +1,21 @@
 #ifndef _COMEDI_INTERNAL_H
 #define _COMEDI_INTERNAL_H
 
+#include <linux/compiler.h>
 #include <linux/types.h>
 
 /*
  * various internal comedi stuff
  */
+
+struct comedi_buf_map;
+struct comedi_devconfig;
+struct comedi_device;
+struct comedi_insn;
+struct comedi_rangeinfo;
+struct comedi_subdevice;
+struct device;
+
 int do_rangeinfo_ioctl(struct comedi_device *dev,
 		       struct comedi_rangeinfo __user *arg);
 struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device);
-- 
2.1.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* RE: [PATCH] staging: comedi: make comedi_internal.h self-reliant
  2015-03-27 15:58 ` Ian Abbott
@ 2015-03-30 17:20   ` Hartley Sweeten
  -1 siblings, 0 replies; 4+ messages in thread
From: Hartley Sweeten @ 2015-03-30 17:20 UTC (permalink / raw)
  To: Ian Abbott, driverdev-devel; +Cc: Greg Kroah-Hartman, linux-kernel

On Friday, March 27, 2015 8:58 AM, Ian Abbott wrote,
> Add `#include`s and declare incomplete types to "comedi_internal.h" so
> that .c files still compile when it is the first file included.
>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> ---
>  drivers/staging/comedi/comedi_internal.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/staging/comedi/comedi_internal.h b/drivers/staging/comedi/comedi_internal.h
> index d57817c..3b91853 100644
> --- a/drivers/staging/comedi/comedi_internal.h
> +++ b/drivers/staging/comedi/comedi_internal.h
> @@ -1,11 +1,21 @@
>  #ifndef _COMEDI_INTERNAL_H
>  #define _COMEDI_INTERNAL_H
>  
> +#include <linux/compiler.h>
>  #include <linux/types.h>
>  
>  /*
>   * various internal comedi stuff
>   */
> +
> +struct comedi_buf_map;
> +struct comedi_devconfig;
> +struct comedi_device;
> +struct comedi_insn;
> +struct comedi_rangeinfo;
> +struct comedi_subdevice;
> +struct device;
> +
>  int do_rangeinfo_ioctl(struct comedi_device *dev,
>  		       struct comedi_rangeinfo __user *arg);
>  struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device);

Seems sane. Just to be clear, the build isn't currently broken.
This just insures that it doesn't break... :-)

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] staging: comedi: make comedi_internal.h self-reliant
@ 2015-03-30 17:20   ` Hartley Sweeten
  0 siblings, 0 replies; 4+ messages in thread
From: Hartley Sweeten @ 2015-03-30 17:20 UTC (permalink / raw)
  To: Ian Abbott, driverdev-devel; +Cc: Greg Kroah-Hartman, linux-kernel

On Friday, March 27, 2015 8:58 AM, Ian Abbott wrote,
> Add `#include`s and declare incomplete types to "comedi_internal.h" so
> that .c files still compile when it is the first file included.
>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> ---
>  drivers/staging/comedi/comedi_internal.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/staging/comedi/comedi_internal.h b/drivers/staging/comedi/comedi_internal.h
> index d57817c..3b91853 100644
> --- a/drivers/staging/comedi/comedi_internal.h
> +++ b/drivers/staging/comedi/comedi_internal.h
> @@ -1,11 +1,21 @@
>  #ifndef _COMEDI_INTERNAL_H
>  #define _COMEDI_INTERNAL_H
>  
> +#include <linux/compiler.h>
>  #include <linux/types.h>
>  
>  /*
>   * various internal comedi stuff
>   */
> +
> +struct comedi_buf_map;
> +struct comedi_devconfig;
> +struct comedi_device;
> +struct comedi_insn;
> +struct comedi_rangeinfo;
> +struct comedi_subdevice;
> +struct device;
> +
>  int do_rangeinfo_ioctl(struct comedi_device *dev,
>  		       struct comedi_rangeinfo __user *arg);
>  struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device);

Seems sane. Just to be clear, the build isn't currently broken.
This just insures that it doesn't break... :-)

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-30 17:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-27 15:58 [PATCH] staging: comedi: make comedi_internal.h self-reliant Ian Abbott
2015-03-27 15:58 ` Ian Abbott
2015-03-30 17:20 ` Hartley Sweeten
2015-03-30 17:20   ` Hartley Sweeten

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.