[PATCH] gstreamer1.0-plugins-bad: Move EGL requirement for Wayland

[PATCH] gstreamer1.0-plugins-bad: Move EGL requirement for Wayland

[Otavio Salvador]

The EGL is used by the Wayland backend. When building using Software
Rendering and without Wayland support the EGL backend is not available
so we should not require EGL for GLES2 support.

This fixes following build error:

,----
| ...
| checking for bcm_host_init in -lbcm_host... no
| checking for WAYLAND_EGL... no
| configure: error: Could not find the required EGL libraries
| Configure failed. The contents of all config.log files follows to aid debugging
| ERROR: oe_runconf failed
`----

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
index e2752af..84a0a58 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
@@ -27,7 +27,7 @@ PACKAGECONFIG ??= " \
 # dash = Dynamic Adaptive Streaming over HTTP
 PACKAGECONFIG[assrender]       = "--enable-assrender,--disable-assrender,libass"
 PACKAGECONFIG[curl]            = "--enable-curl,--disable-curl,curl"
-PACKAGECONFIG[gles2]           = "--enable-gles2 --enable-egl,--disable-gles2 --disable-egl,virtual/libgles2 virtual/egl"
+PACKAGECONFIG[gles2]           = "--enable-gles2,--disable-gles2,virtual/libgles2"
 PACKAGECONFIG[opengl]          = "--enable-opengl,--disable-opengl,virtual/libgl libglu"
 PACKAGECONFIG[faac]            = "--enable-faac,--disable-faac,faac"
 PACKAGECONFIG[faad]            = "--enable-faad,--disable-faad,faad2"
@@ -37,7 +37,7 @@ PACKAGECONFIG[mpg123]          = "--enable-mpg123,--disable-mpg123,mpg123"
 PACKAGECONFIG[opus]            = "--enable-opus,--disable-opus,libopus"
 PACKAGECONFIG[flite]           = "--enable-flite,--disable-flite,flite-alsa"
 PACKAGECONFIG[opencv]          = "--enable-opencv,--disable-opencv,opencv"
-PACKAGECONFIG[wayland]         = "--enable-wayland,--disable-wayland,wayland"
+PACKAGECONFIG[wayland]         = "--enable-wayland --enable-egl,--disable-wayland --disable-egl,wayland virtual/egl"
 PACKAGECONFIG[uvch264]         = "--enable-uvch264,--disable-uvch264,libusb1 udev"
 PACKAGECONFIG[directfb]        = "--enable-directfb,--disable-directfb,directfb"
 PACKAGECONFIG[neon]            = "--enable-neon,--disable-neon,neon"
-- 
2.1.4

Re: [PATCH] gstreamer1.0-plugins-bad: Move EGL requirement for Wayland

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

On 11 May 2015 at 12:26, Otavio Salvador <otavio@ossystems.com.br> wrote:

> The EGL is used by the Wayland backend. When building using Software
> Rendering and without Wayland support the EGL backend is not available
> so we should not require EGL for GLES2 support.
>

I think we should make the PACKAGECONFIG block be more explicit, and add a
separate [egl] that is required to be enabled if you also enable a feature
that depends on it (such as gles or wayland).

Ross

[-- Attachment #2: Type: text/html, Size: 894 bytes --]

Re: [PATCH] gstreamer1.0-plugins-bad: Move EGL requirement for Wayland

[Otavio Salvador]

On Thu, May 14, 2015 at 7:33 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 11 May 2015 at 12:26, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>
>> The EGL is used by the Wayland backend. When building using Software
>> Rendering and without Wayland support the EGL backend is not available
>> so we should not require EGL for GLES2 support.
>
> I think we should make the PACKAGECONFIG block be more explicit, and add a
> separate [egl] that is required to be enabled if you also enable a feature
> that depends on it (such as gles or wayland).

I did this initially and ended with the patch I sent. The reason is
because the EGL is Wayland specific so I see no reason to split it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] gstreamer1.0-plugins-bad: Move EGL requirement for Wayland

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]


> On May 14, 2015, at 6:29 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> 
> On Thu, May 14, 2015 at 7:33 AM, Burton, Ross <ross.burton@intel.com> wrote:
>> 
>> On 11 May 2015 at 12:26, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>> 
>>> The EGL is used by the Wayland backend. When building using Software
>>> Rendering and without Wayland support the EGL backend is not available
>>> so we should not require EGL for GLES2 support.
>> 
>> I think we should make the PACKAGECONFIG block be more explicit, and add a
>> separate [egl] that is required to be enabled if you also enable a feature
>> that depends on it (such as gles or wayland).
> 
> I did this initially and ended with the patch I sent. The reason is
> because the EGL is Wayland specific so I see no reason to split it.

egl is not wayland specific, unless you are using it in different context


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH] gstreamer1.0-plugins-bad: Move EGL requirement for Wayland

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

On 19 May 2015 at 02:45, Khem Raj <raj.khem@gmail.com> wrote:

> > I did this initially and ended with the patch I sent. The reason is
> > because the EGL is Wayland specific so I see no reason to split it.
>
> egl is not wayland specific, unless you are using it in different context


In the context of this configure script it is.

Ross

[-- Attachment #2: Type: text/html, Size: 715 bytes --]