RE: [PATCH] powerpc/fsl: Update fman dt binding with pcs-phy and tbi-phy

[Liberman Igal <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]

Regards,
Igal Liberman

> -----Original Message-----
> From: Joakim Tjernlund [mailto:Joakim.Tjernlund-27rvihrghlNWk0Htik3J/w@public.gmane.org]
> Sent: Tuesday, December 22, 2015 5:57 PM
> To: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Liberman Igal-B31950
> <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Wood Scott-B07421 <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Xie Shaohui-B21989
> <Shaohui.Xie-KZfg59tc24xl57MIdRCFDg@public.gmane.org>; Bucur Madalin-Cristian-B32716
> <madalin.bucur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> Subject: Re: [PATCH] powerpc/fsl: Update fman dt binding with pcs-phy and
> tbi-phy
> 
> On Tue, 2015-12-22 at 06:18 +0200, igal.liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org wrote:
> > From: Igal Liberman <igal.liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >
> > Signed-off-by: Igal Liberman <igal.liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > ---
> >  .../devicetree/bindings/powerpc/fsl/fman.txt       |   39
> > ++++++++++++++++++++
> >  1 file changed, 39 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > index 1fc5328..7a6d7c3 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> > @@ -315,6 +315,16 @@ PROPERTIES
> >  		Value type: <phandle>
> >  		Definition: A phandle for 1EEE1588 timer.
> >
> > +- pcsphy-handle
> > +		Usage required for "fsl,fman-memac" MACs
> > +		Value type: <phandle>
> > +		Definition: A phandle for pcsphy.
> > +
> > +- tbi-handle
> > +		Usage required for "fsl,fman-dtsec" MACs
> > +		Value type: <phandle>
> > +		Definition: A phandle for tbiphy.
> > +
> >  EXAMPLE
> >
> >  fman1_tx28: port@a8000 {
> > @@ -340,6 +350,7 @@ ethernet@e0000 {
> >  	reg = <0xe0000 0x1000>;
> >  	fsl,fman-ports = <&fman1_rx8 &fman1_tx28>;
> >  	ptp-timer = <&ptp-timer>;
> > +	tbi-handle = <&tbi0>;
> >  };
> >
> >
> >
> ==========================================================
> ============
> > ======
> > @@ -415,6 +426,13 @@ PROPERTIES
> >  		The settings and programming routines for internal/external
> >  		MDIO are different. Must be included for internal MDIO.
> >
> > +For internal PHY device on internal mdio bus, a PHY node should be
> created.
> > +See the definition of the PHY node in booting-without-of.txt for an
> > +example of how to define a PHY (Internal PHY has no interrupt line).
> > +- For "fsl,fman-mdio" compatible internal mdio bus, the PHY is TBI PHY.
> > +- For "fsl,fman-memac-mdio" compatible internal mdio bus, the PHY is
> > +PCS PHY,
> > +  PCS PHY addr must be '0'.
> 
> Will this replace the need for fixed PHYs ?
> 

Hi Jocke,

No, this is internal PCS configuration which required for both types of links.
The configuration for fixed links is different, but we use the same method.

Igal

>    Jocke
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html