Question about power_restore_policy one time in phosphor-state-manager repo

Question about power_restore_policy one time in phosphor-state-manager repo

[Xie, Mei]

[-- Attachment #1.1: Type: text/plain, Size: 1107 bytes --]

Hi Geissler/all,

I am Xie Mei from intel. I am focus on OpenBMC development. I met some questions, hope you can help me to figure it out. Thanks. :)

I see the below patch in phosphor-state-manager repo.
We also need to auto power on after bios in-band update.
But I have below questions, could you please help to look at them?

  1.  Do you know where is the definition of /xyz/openbmc_project/control/host0/power_restore_policy/one_time? Because in my code, It doesn't have /xyz/openbmc_project/control/host0/power_restore_policy/one_time path.

[cid:image001.jpg@01D7C5E7.96C59F50]

  1.  I see your commit info, you use dbus to invoke one_time path. Where will invoke this one time function in code?
  2.  In /user/bin folder, I don't have phosphor-discover-system-state in my platform. So maybe phosphor-state-manager service isn't existed in my platform. There are several service in phosphor-state-manager repo?https://github.com/openbmc/phosphor-state-manager/commit/35ca2e34cd04b7288a5b659e4e7dcd4590056b7d

I am really appreciate if you can do me a favor.

Best Regards,
Mei


[-- Attachment #1.2: Type: text/html, Size: 5876 bytes --]

[-- Attachment #2: image001.jpg --]
[-- Type: image/jpeg, Size: 27145 bytes --]

Re: Question about power_restore_policy one time in phosphor-state-manager repo

[Andrew Geissler]

> On Oct 20, 2021, at 6:20 AM, Xie, Mei <mei.xie@intel.com> wrote:
> 
> Hi Geissler/all,
>  
> I am Xie Mei from intel. I am focus on OpenBMC development. I met some questions, hope you can help me to figure it out. Thanks. J
>  
> I see the below patch in phosphor-state-manager repo. 
> We also need to auto power on after bios in-band update. 
> But I have below questions, could you please help to look at them?
> 	• Do you know where is the definition of /xyz/openbmc_project/control/host0/power_restore_policy/one_time? Because in my code, It doesn’t have /xyz/openbmc_project/control/host0/power_restore_policy/one_time path.
> <image001.jpg>

Hi Mei, these are defined within the phosphor-settings app. They are pulled in via https://github.com/openbmc/openbmc/blob/master/meta-phosphor/recipes-phosphor/settings/phosphor-settings-defaults/defaults.yaml so you’d want to see if your system has some sort of override that’s not bringing this in.

> 	• I see your commit info, you use dbus to invoke one_time path. Where will invoke this one time function in code?

As you note below, support fro this function is in https://github.com/openbmc/phosphor-state-manager/blob/master/discover_system_state.cpp

> 	• In /user/bin folder, I don’t have phosphor-discover-system-state in my platform. So maybe phosphor-state-manager service isn’t existed in my platform. There are several service in phosphor-state-manager repo?https://github.com/openbmc/phosphor-state-manager/commit/35ca2e34cd04b7288a5b659e4e7dcd4590056b7d

x86-power-control is an alternative to phosphor-state-manager and implements a lot of the same interfaces. My guess would be that you have this installed on your system. I’m not sure where their support is of some of these “extra” features like one_time. It may be that if you need this one_time feature you’d need to submit some code to x86-power-control to support it similar to phosphor-state-manager.

>  
> I am really appreciate if you can do me a favor.
>  
> Best Regards,
> Mei

RE: Question about power_restore_policy one time in phosphor-state-manager repo

[Xie, Mei]

> x86-power-control is an alternative to phosphor-state-manager and implements a lot of the same interfaces. My guess would be that you have this installed on your system. I’m not sure where their support is of some of these “extra” features like one_time. It may be that if you need this one_time feature you’d need to submit some code to x86-power-control to support it similar to phosphor-state-manager

Yes, you are right, x86-power-control is installed in my system. Understood, so I don't need to pay more attention to the phosphor-state-manager repo, I can add the code to support the function like one time in x86-power-control repo. Thanks.


-----Original Message-----
From: Andrew Geissler <geissonator@gmail.com> 
Sent: Wednesday, October 20, 2021 10:33 PM
To: Xie, Mei <mei.xie@intel.com>
Cc: openbmc@lists.ozlabs.org
Subject: Re: Question about power_restore_policy one time in phosphor-state-manager repo



> On Oct 20, 2021, at 6:20 AM, Xie, Mei <mei.xie@intel.com> wrote:
> 
> Hi Geissler/all,
>  
> I am Xie Mei from intel. I am focus on OpenBMC development. I met some questions, hope you can help me to figure it out. Thanks. J
>  
> I see the below patch in phosphor-state-manager repo. 
> We also need to auto power on after bios in-band update. 
> But I have below questions, could you please help to look at them?
> 	• Do you know where is the definition of /xyz/openbmc_project/control/host0/power_restore_policy/one_time? Because in my code, It doesn’t have /xyz/openbmc_project/control/host0/power_restore_policy/one_time path.
> <image001.jpg>

Hi Mei, these are defined within the phosphor-settings app. They are pulled in via https://github.com/openbmc/openbmc/blob/master/meta-phosphor/recipes-phosphor/settings/phosphor-settings-defaults/defaults.yaml so you’d want to see if your system has some sort of override that’s not bringing this in.

> 	• I see your commit info, you use dbus to invoke one_time path. Where will invoke this one time function in code?

As you note below, support fro this function is in https://github.com/openbmc/phosphor-state-manager/blob/master/discover_system_state.cpp

> 	• In /user/bin folder, I don’t have phosphor-discover-system-state in my platform. So maybe phosphor-state-manager service isn’t existed in my platform. There are several service in phosphor-state-manager repo?https://github.com/openbmc/phosphor-state-manager/commit/35ca2e34cd04b7288a5b659e4e7dcd4590056b7d

x86-power-control is an alternative to phosphor-state-manager and implements a lot of the same interfaces. My guess would be that you have this installed on your system. I’m not sure where their support is of some of these “extra” features like one_time. It may be that if you need this one_time feature you’d need to submit some code to x86-power-control to support it similar to phosphor-state-manager.

>  
> I am really appreciate if you can do me a favor.
>  
> Best Regards,
> Mei