* [PATCH] drm/i915/ttm: don't leak the ccs state @ 2022-07-27 16:43 ` Matthew Auld 0 siblings, 0 replies; 10+ messages in thread From: Matthew Auld @ 2022-07-27 16:43 UTC (permalink / raw) To: intel-gfx; +Cc: Thomas Hellström, dri-devel The kernel only manages the ccs state with lmem-only objects, however the kernel should still take care not to leak the CCS state from the previous user. Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for Flat-ccs objects") Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Cc: Ramalingam C <ramalingam.c@intel.com> --- drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c index a69b244f14d0..9a0814422ba4 100644 --- a/drivers/gpu/drm/i915/gt/intel_migrate.c +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c @@ -708,7 +708,7 @@ intel_context_migrate_copy(struct intel_context *ce, u8 src_access, dst_access; struct i915_request *rq; int src_sz, dst_sz; - bool ccs_is_src; + bool ccs_is_src, overwrite_ccs; int err; GEM_BUG_ON(ce->vm != ce->engine->gt->migrate.context->vm); @@ -749,6 +749,8 @@ intel_context_migrate_copy(struct intel_context *ce, get_ccs_sg_sgt(&it_ccs, bytes_to_cpy); } + overwrite_ccs = HAS_FLAT_CCS(i915) && !ccs_bytes_to_cpy && dst_is_lmem; + src_offset = 0; dst_offset = CHUNK_SZ; if (HAS_64K_PAGES(ce->engine->i915)) { @@ -852,6 +854,25 @@ intel_context_migrate_copy(struct intel_context *ce, if (err) goto out_rq; ccs_bytes_to_cpy -= ccs_sz; + } else if (overwrite_ccs) { + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); + if (err) + goto out_rq; + + /* + * While we can't always restore/manage the CCS state, + * we still need to ensure we don't leak the CCS state + * from the previous user, so make sure we overwrite it + * with something. + */ + err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS, + dst_offset, DIRECT_ACCESS, len); + if (err) + goto out_rq; + + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); + if (err) + goto out_rq; } /* Arbitration is re-enabled between requests. */ -- 2.37.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/ttm: don't leak the ccs state @ 2022-07-27 16:43 ` Matthew Auld 0 siblings, 0 replies; 10+ messages in thread From: Matthew Auld @ 2022-07-27 16:43 UTC (permalink / raw) To: intel-gfx; +Cc: Thomas Hellström, dri-devel The kernel only manages the ccs state with lmem-only objects, however the kernel should still take care not to leak the CCS state from the previous user. Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for Flat-ccs objects") Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Cc: Ramalingam C <ramalingam.c@intel.com> --- drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c index a69b244f14d0..9a0814422ba4 100644 --- a/drivers/gpu/drm/i915/gt/intel_migrate.c +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c @@ -708,7 +708,7 @@ intel_context_migrate_copy(struct intel_context *ce, u8 src_access, dst_access; struct i915_request *rq; int src_sz, dst_sz; - bool ccs_is_src; + bool ccs_is_src, overwrite_ccs; int err; GEM_BUG_ON(ce->vm != ce->engine->gt->migrate.context->vm); @@ -749,6 +749,8 @@ intel_context_migrate_copy(struct intel_context *ce, get_ccs_sg_sgt(&it_ccs, bytes_to_cpy); } + overwrite_ccs = HAS_FLAT_CCS(i915) && !ccs_bytes_to_cpy && dst_is_lmem; + src_offset = 0; dst_offset = CHUNK_SZ; if (HAS_64K_PAGES(ce->engine->i915)) { @@ -852,6 +854,25 @@ intel_context_migrate_copy(struct intel_context *ce, if (err) goto out_rq; ccs_bytes_to_cpy -= ccs_sz; + } else if (overwrite_ccs) { + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); + if (err) + goto out_rq; + + /* + * While we can't always restore/manage the CCS state, + * we still need to ensure we don't leak the CCS state + * from the previous user, so make sure we overwrite it + * with something. + */ + err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS, + dst_offset, DIRECT_ACCESS, len); + if (err) + goto out_rq; + + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); + if (err) + goto out_rq; } /* Arbitration is re-enabled between requests. */ -- 2.37.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: don't leak the ccs state 2022-07-27 16:43 ` [Intel-gfx] " Matthew Auld (?) @ 2022-07-27 18:10 ` Patchwork -1 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2022-07-27 18:10 UTC (permalink / raw) To: Matthew Auld; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 11566 bytes --] == Series Details == Series: drm/i915/ttm: don't leak the ccs state URL : https://patchwork.freedesktop.org/series/106765/ State : success == Summary == CI Bug Log - changes from CI_DRM_11946 -> Patchwork_106765v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/index.html Participating hosts (38 -> 39) ------------------------------ Additional (3): fi-hsw-4770 bat-jsl-1 bat-adlp-4 Missing (2): fi-bdw-samus bat-jsl-3 Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_106765v1: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@i915_selftest@live@objects: - {bat-rpls-1}: NOTRUN -> [INCOMPLETE][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-rpls-1/igt@i915_selftest@live@objects.html Known issues ------------ Here are the changes found in Patchwork_106765v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_lmem_swapping@verify-random: - bat-adlp-4: NOTRUN -> [SKIP][2] ([i915#4613]) +3 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-adlp-4/igt@gem_lmem_swapping@verify-random.html * igt@gem_tiled_pread_basic: - bat-adlp-4: NOTRUN -> [SKIP][3] ([i915#3282]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-adlp-4/igt@gem_tiled_pread_basic.html * igt@i915_pm_backlight@basic-brightness: - fi-hsw-4770: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#3012]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html * igt@i915_selftest@live@hangcheck: - fi-hsw-4770: NOTRUN -> [INCOMPLETE][5] ([i915#4785]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html - fi-ivb-3770: [PASS][6] -> [INCOMPLETE][7] ([i915#3303] / [i915#5370]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/fi-ivb-3770/igt@i915_selftest@live@hangcheck.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-ivb-3770/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@requests: - fi-blb-e6850: [PASS][8] -> [DMESG-FAIL][9] ([i915#4528]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/fi-blb-e6850/igt@i915_selftest@live@requests.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-blb-e6850/igt@i915_selftest@live@requests.html * igt@i915_selftest@live@ring_submission: - fi-cfl-8109u: [PASS][10] -> [DMESG-WARN][11] ([i915#5904]) +29 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html * igt@i915_suspend@basic-s2idle-without-i915: - fi-cfl-8109u: [PASS][12] -> [DMESG-WARN][13] ([i915#5904] / [i915#62]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html * igt@i915_suspend@basic-s3-without-i915: - bat-adlp-4: NOTRUN -> [SKIP][14] ([i915#5903]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-adlp-4/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy: - fi-hsw-4770: NOTRUN -> [SKIP][15] ([fdo#109271]) +9 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html * igt@kms_chamelium@dp-crc-fast: - fi-hsw-4770: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +7 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-hsw-4770/igt@kms_chamelium@dp-crc-fast.html - bat-adlp-4: NOTRUN -> [SKIP][17] ([fdo#111827]) +8 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor: - bat-adlp-4: NOTRUN -> [SKIP][18] ([i915#4103]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-adlp-4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html * igt@kms_force_connector_basic@prune-stale-modes: - bat-adlp-4: NOTRUN -> [SKIP][19] ([i915#4093]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-adlp-4/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_frontbuffer_tracking@basic: - fi-cfl-8109u: [PASS][20] -> [DMESG-FAIL][21] ([i915#62]) +1 similar issue [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html * igt@kms_psr@sprite_plane_onoff: - fi-hsw-4770: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#1072]) +3 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html * igt@kms_setmode@basic-clone-single-crtc: - bat-adlp-4: NOTRUN -> [SKIP][23] ([i915#3555] / [i915#4579]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-adlp-4/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-fence-flip: - fi-cfl-8109u: [PASS][24] -> [DMESG-WARN][25] ([i915#62]) +10 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/fi-cfl-8109u/igt@prime_vgem@basic-fence-flip.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-cfl-8109u/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@basic-userptr: - bat-adlp-4: NOTRUN -> [SKIP][26] ([fdo#109295] / [i915#3301] / [i915#3708]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-adlp-4/igt@prime_vgem@basic-userptr.html * igt@prime_vgem@basic-write: - bat-adlp-4: NOTRUN -> [SKIP][27] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-adlp-4/igt@prime_vgem@basic-write.html * igt@runner@aborted: - fi-hsw-4770: NOTRUN -> [FAIL][28] ([fdo#109271] / [i915#4312] / [i915#5594] / [i915#6246]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-hsw-4770/igt@runner@aborted.html - fi-ivb-3770: NOTRUN -> [FAIL][29] ([fdo#109271] / [i915#4312]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-ivb-3770/igt@runner@aborted.html - fi-blb-e6850: NOTRUN -> [FAIL][30] ([fdo#109271] / [i915#2403] / [i915#4312]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-blb-e6850/igt@runner@aborted.html #### Possible fixes #### * igt@debugfs_test@read_all_entries: - fi-kbl-guc: [FAIL][31] ([i915#6253]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/fi-kbl-guc/igt@debugfs_test@read_all_entries.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/fi-kbl-guc/igt@debugfs_test@read_all_entries.html * igt@i915_selftest@live@gtt: - {bat-dg2-9}: [DMESG-WARN][33] ([i915#5763]) -> [PASS][34] +7 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/bat-dg2-9/igt@i915_selftest@live@gtt.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-dg2-9/igt@i915_selftest@live@gtt.html * igt@i915_selftest@live@requests: - {bat-rpls-1}: [INCOMPLETE][35] ([i915#6380]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/bat-rpls-1/igt@i915_selftest@live@requests.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/bat-rpls-1/igt@i915_selftest@live@requests.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5370]: https://gitlab.freedesktop.org/drm/intel/issues/5370 [i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594 [i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763 [i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828 [i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903 [i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#6246]: https://gitlab.freedesktop.org/drm/intel/issues/6246 [i915#6253]: https://gitlab.freedesktop.org/drm/intel/issues/6253 [i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380 [i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434 Build changes ------------- * Linux: CI_DRM_11946 -> Patchwork_106765v1 CI-20190529: 20190529 CI_DRM_11946: 0e9c43d76a145712da46e935d429ce2a3eea80e8 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6598: 97e103419021d0863db527e3f2cf39ccdd132db5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_106765v1: 0e9c43d76a145712da46e935d429ce2a3eea80e8 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits d4a0eb0338ee drm/i915/ttm: don't leak the ccs state == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/index.html [-- Attachment #2: Type: text/html, Size: 13194 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ttm: don't leak the ccs state 2022-07-27 16:43 ` [Intel-gfx] " Matthew Auld (?) (?) @ 2022-07-27 21:42 ` Patchwork -1 siblings, 0 replies; 10+ messages in thread From: Patchwork @ 2022-07-27 21:42 UTC (permalink / raw) To: Matthew Auld; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 39132 bytes --] == Series Details == Series: drm/i915/ttm: don't leak the ccs state URL : https://patchwork.freedesktop.org/series/106765/ State : success == Summary == CI Bug Log - changes from CI_DRM_11946_full -> Patchwork_106765v1_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (13 -> 13) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_106765v1_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_ctx_persistence@many-contexts: - {shard-dg1}: NOTRUN -> [DMESG-FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-dg1-13/igt@gem_ctx_persistence@many-contexts.html New tests --------- New tests have been introduced between CI_DRM_11946_full and Patchwork_106765v1_full: ### New IGT tests (4) ### * igt@kms_sequence@get-forked@hdmi-a-4-pipe-a: - Statuses : 1 pass(s) - Exec time: [2.35] s * igt@kms_sequence@get-forked@hdmi-a-4-pipe-b: - Statuses : 1 pass(s) - Exec time: [2.23] s * igt@kms_sequence@get-forked@hdmi-a-4-pipe-c: - Statuses : 1 pass(s) - Exec time: [2.22] s * igt@kms_sequence@get-forked@hdmi-a-4-pipe-d: - Statuses : 1 pass(s) - Exec time: [2.24] s Known issues ------------ Here are the changes found in Patchwork_106765v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@feature_discovery@psr2: - shard-iclb: [PASS][2] -> [SKIP][3] ([i915#658]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb2/igt@feature_discovery@psr2.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb7/igt@feature_discovery@psr2.html * igt@gem_create@create-massive: - shard-glk: NOTRUN -> [DMESG-WARN][4] ([i915#4991]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-glk9/igt@gem_create@create-massive.html - shard-kbl: NOTRUN -> [DMESG-WARN][5] ([i915#4991]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl1/igt@gem_create@create-massive.html * igt@gem_ctx_isolation@preservation-s3@rcs0: - shard-kbl: [PASS][6] -> [DMESG-WARN][7] ([i915#180]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@rcs0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@rcs0.html * igt@gem_eio@in-flight-contexts-immediate: - shard-tglb: [PASS][8] -> [TIMEOUT][9] ([i915#3063]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-tglb3/igt@gem_eio@in-flight-contexts-immediate.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-tglb5/igt@gem_eio@in-flight-contexts-immediate.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][10] -> [FAIL][11] ([i915#5784]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-tglb7/igt@gem_eio@unwedge-stress.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-tglb2/igt@gem_eio@unwedge-stress.html * igt@gem_exec_balancer@parallel-keep-submit-fence: - shard-iclb: [PASS][12] -> [SKIP][13] ([i915#4525]) +2 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb1/igt@gem_exec_balancer@parallel-keep-submit-fence.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb8/igt@gem_exec_balancer@parallel-keep-submit-fence.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-kbl: [PASS][14] -> [SKIP][15] ([fdo#109271]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl1/igt@gem_exec_fair@basic-none-share@rcs0.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl6/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-iclb: NOTRUN -> [FAIL][16] ([i915#2842]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][17] -> [SKIP][18] ([i915#2190]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-tglb2/igt@gem_huc_copy@huc-copy.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-tglb7/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@verify-ccs: - shard-kbl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#4613]) +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl1/igt@gem_lmem_swapping@verify-ccs.html * igt@gem_userptr_blits@input-checking: - shard-apl: NOTRUN -> [DMESG-WARN][20] ([i915#4991]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl4/igt@gem_userptr_blits@input-checking.html * igt@gen9_exec_parse@allowed-single: - shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#5566] / [i915#716]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-apl3/igt@gen9_exec_parse@allowed-single.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl4/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][23] -> [FAIL][24] ([i915#454]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb2/igt@i915_pm_dc@dc6-psr.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb6/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_rc6_residency@rc6-idle@vcs0: - shard-apl: [PASS][25] -> [WARN][26] ([i915#6405]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-apl1/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl2/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html - shard-glk: [PASS][27] -> [WARN][28] ([i915#6405]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-glk1/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-glk6/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html * igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#3886]) +3 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl7/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_chamelium@hdmi-crc-multiple: - shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl4/igt@kms_chamelium@hdmi-crc-multiple.html * igt@kms_color_chamelium@pipe-b-ctm-0-75: - shard-kbl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +4 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl7/igt@kms_color_chamelium@pipe-b-ctm-0-75.html * igt@kms_cursor_crc@cursor-suspend@pipe-a-edp-1: - shard-skl: [PASS][32] -> [INCOMPLETE][33] ([i915#4939]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-skl7/igt@kms_cursor_crc@cursor-suspend@pipe-a-edp-1.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl7/igt@kms_cursor_crc@cursor-suspend@pipe-a-edp-1.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions: - shard-glk: [PASS][34] -> [FAIL][35] ([i915#2346]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html * igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1: - shard-glk: NOTRUN -> [SKIP][36] ([fdo#109271]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-glk1/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][37] ([i915#6375]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][38] ([i915#2672]) +9 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode: - shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271]) +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl4/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][40] ([i915#2672] / [i915#3555]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-render: - shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271]) +7 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-render.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move: - shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271]) +78 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move.html * igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1: - shard-kbl: [PASS][43] -> [FAIL][44] ([i915#1188]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl6/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl7/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes: - shard-apl: [PASS][45] -> [DMESG-WARN][46] ([i915#180]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl8/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1: - shard-iclb: [PASS][47] -> [SKIP][48] ([i915#5235]) +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb5/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html * igt@kms_psr@psr2_sprite_blt: - shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#109441]) +3 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb7/igt@kms_psr@psr2_sprite_blt.html * igt@kms_psr_stress_test@invalidate-primary-flip-overlay: - shard-tglb: [PASS][51] -> [SKIP][52] ([i915#5519]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-tglb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-tglb1/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html * igt@perf@blocking: - shard-skl: [PASS][53] -> [FAIL][54] ([i915#1542]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-skl4/igt@perf@blocking.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl10/igt@perf@blocking.html * igt@perf_pmu@module-unload: - shard-skl: [PASS][55] -> [DMESG-WARN][56] ([i915#1982]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-skl1/igt@perf_pmu@module-unload.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl7/igt@perf_pmu@module-unload.html #### Possible fixes #### * igt@gem_ctx_exec@basic-nohangcheck: - shard-tglb: [FAIL][57] ([i915#6268]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-tglb5/igt@gem_ctx_exec@basic-nohangcheck.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-tglb2/igt@gem_ctx_exec@basic-nohangcheck.html * igt@gem_ctx_persistence@legacy-engines-hostile@vebox: - {shard-dg1}: [FAIL][59] ([i915#4883]) -> [PASS][60] +2 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-dg1-15/igt@gem_ctx_persistence@legacy-engines-hostile@vebox.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-dg1-15/igt@gem_ctx_persistence@legacy-engines-hostile@vebox.html * igt@gem_exec_balancer@fairslice: - {shard-rkl}: [SKIP][61] ([i915#6259]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-5/igt@gem_exec_balancer@fairslice.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-6/igt@gem_exec_balancer@fairslice.html * igt@gem_exec_balancer@parallel-bb-first: - shard-iclb: [SKIP][63] ([i915#4525]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb5/igt@gem_exec_balancer@parallel-bb-first.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb1/igt@gem_exec_balancer@parallel-bb-first.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-kbl: [FAIL][65] ([i915#2842]) -> [PASS][66] +2 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl1/igt@gem_exec_fair@basic-none-rrul@rcs0.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl6/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [FAIL][67] ([i915#2842]) -> [PASS][68] +1 similar issue [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_reloc@basic-write-read-noreloc: - {shard-rkl}: [SKIP][69] ([i915#3281]) -> [PASS][70] +7 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-2/igt@gem_exec_reloc@basic-write-read-noreloc.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-5/igt@gem_exec_reloc@basic-write-read-noreloc.html * igt@gem_readwrite@write-bad-handle: - {shard-rkl}: [SKIP][71] ([i915#3282]) -> [PASS][72] +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-1/igt@gem_readwrite@write-bad-handle.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-5/igt@gem_readwrite@write-bad-handle.html * igt@gen9_exec_parse@allowed-single: - shard-glk: [DMESG-WARN][73] ([i915#5566] / [i915#716]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-glk3/igt@gen9_exec_parse@allowed-single.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-glk9/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@bb-chained: - {shard-rkl}: [SKIP][75] ([i915#2527]) -> [PASS][76] +2 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-2/igt@gen9_exec_parse@bb-chained.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-5/igt@gen9_exec_parse@bb-chained.html * igt@i915_pm_dc@dc6-psr: - {shard-rkl}: [FAIL][77] ([i915#3989]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-6/igt@i915_pm_dc@dc6-psr.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-6/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_rpm@modeset-non-lpsp-stress: - {shard-dg1}: [SKIP][79] ([i915#1397]) -> [PASS][80] +2 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-dg1-17/igt@i915_pm_rpm@modeset-non-lpsp-stress.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp-stress.html * igt@i915_suspend@debugfs-reader: - shard-kbl: [INCOMPLETE][81] ([i915#3614] / [i915#4939]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl4/igt@i915_suspend@debugfs-reader.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl1/igt@i915_suspend@debugfs-reader.html * igt@i915_suspend@fence-restore-untiled: - shard-apl: [DMESG-WARN][83] ([i915#180]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-apl1/igt@i915_suspend@fence-restore-untiled.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl4/igt@i915_suspend@fence-restore-untiled.html * igt@kms_big_fb@yf-tiled-32bpp-rotate-90: - shard-skl: [TIMEOUT][85] ([i915#6371]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-skl7/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl7/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: - shard-glk: [FAIL][87] ([i915#2346]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled: - {shard-rkl}: [SKIP][89] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][90] +2 similar issues [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-5/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1: - shard-apl: [FAIL][91] ([i915#79]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html * igt@kms_flip@flip-vs-expired-vblank@a-edp1: - shard-skl: [FAIL][93] ([i915#79]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-kbl: [DMESG-WARN][95] ([i915#180]) -> [PASS][96] +2 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1: - shard-skl: [FAIL][97] ([i915#2122]) -> [PASS][98] +2 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: - {shard-rkl}: [SKIP][99] ([i915#1849] / [i915#4098]) -> [PASS][100] +7 similar issues [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary: - shard-skl: [DMESG-WARN][101] ([i915#1982]) -> [PASS][102] +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-skl9/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl9/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - {shard-rkl}: [SKIP][103] ([i915#1849] / [i915#3546] / [i915#4098]) -> [PASS][104] [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-5/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][105] ([fdo#108145] / [i915#265]) -> [PASS][106] [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_psr@cursor_render: - {shard-rkl}: [SKIP][107] ([i915#1072]) -> [PASS][108] [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-5/igt@kms_psr@cursor_render.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-6/igt@kms_psr@cursor_render.html * igt@kms_psr@psr2_suspend: - shard-iclb: [SKIP][109] ([fdo#109441]) -> [PASS][110] +1 similar issue [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb7/igt@kms_psr@psr2_suspend.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb2/igt@kms_psr@psr2_suspend.html * igt@kms_vblank@pipe-b-query-idle: - {shard-rkl}: [SKIP][111] ([i915#1845] / [i915#4098]) -> [PASS][112] +9 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-rkl-5/igt@kms_vblank@pipe-b-query-idle.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-rkl-6/igt@kms_vblank@pipe-b-query-idle.html * igt@perf@polling-parameterized: - shard-tglb: [FAIL][113] ([i915#5639]) -> [PASS][114] [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-tglb1/igt@perf@polling-parameterized.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-tglb7/igt@perf@polling-parameterized.html #### Warnings #### * igt@gem_exec_balancer@parallel-ordering: - shard-iclb: [FAIL][115] ([i915#6117]) -> [SKIP][116] ([i915#4525]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb6/igt@gem_exec_balancer@parallel-ordering.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [INCOMPLETE][117] ([i915#180] / [i915#4939]) -> [FAIL][118] ([i915#4767]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode: - shard-skl: [SKIP][119] ([fdo#109271] / [i915#1888]) -> [SKIP][120] ([fdo#109271]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-skl4/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-skl4/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode.html * igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf: - shard-iclb: [SKIP][121] ([i915#2920]) -> [SKIP][122] ([i915#658]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb7/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html * igt@kms_psr2_sf@plane-move-sf-dmg-area: - shard-iclb: [SKIP][123] ([fdo#111068] / [i915#658]) -> [SKIP][124] ([i915#2920]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb7/igt@kms_psr2_sf@plane-move-sf-dmg-area.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html * igt@kms_psr2_su@page_flip-nv12: - shard-iclb: [SKIP][125] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][126] ([i915#5939]) +1 similar issue [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-iclb7/igt@kms_psr2_su@page_flip-nv12.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html * igt@runner@aborted: - shard-apl: ([FAIL][127], [FAIL][128], [FAIL][129]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133]) ([fdo#109271] / [i915#3002] / [i915#4312] / [i915#5257]) [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-apl1/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-apl1/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-apl3/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl4/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl4/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl8/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-apl8/igt@runner@aborted.html - shard-kbl: ([FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92]) -> ([FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl1/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl6/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl6/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl4/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11946/shard-kbl1/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl1/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl6/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl4/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl6/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/shard-kbl6/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#160]: https://gitlab.freedesktop.org/drm/intel/issues/160 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410 [i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530 [i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3614]: https://gitlab.freedesktop.org/drm/intel/issues/3614 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989 [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4462]: https://gitlab.freedesktop.org/drm/intel/issues/4462 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883 [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885 [i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939 [i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941 [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287 [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251 [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6371]: https://gitlab.freedesktop.org/drm/intel/issues/6371 [i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375 [i915#6405]: https://gitlab.freedesktop.org/drm/intel/issues/6405 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 Build changes ------------- * Linux: CI_DRM_11946 -> Patchwork_106765v1 CI-20190529: 20190529 CI_DRM_11946: 0e9c43d76a145712da46e935d429ce2a3eea80e8 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6598: 97e103419021d0863db527e3f2cf39ccdd132db5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_106765v1: 0e9c43d76a145712da46e935d429ce2a3eea80e8 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106765v1/index.html [-- Attachment #2: Type: text/html, Size: 40081 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] drm/i915/ttm: don't leak the ccs state 2022-07-27 16:43 ` [Intel-gfx] " Matthew Auld @ 2022-07-27 23:16 ` C, Ramalingam -1 siblings, 0 replies; 10+ messages in thread From: C, Ramalingam @ 2022-07-27 23:16 UTC (permalink / raw) To: Auld, Matthew, intel-gfx; +Cc: Thomas Hellström, dri-devel > -----Original Message----- > From: Auld, Matthew <matthew.auld@intel.com> > Sent: Wednesday, July 27, 2022 10:14 PM > To: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Thomas Hellström <thomas.hellstrom@linux.intel.com>; C, > Ramalingam <ramalingam.c@intel.com> > Subject: [PATCH] drm/i915/ttm: don't leak the ccs state > > The kernel only manages the ccs state with lmem-only objects, however the kernel should still take > care not to leak the CCS state from the previous user. > > Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for Flat-ccs objects") > Signed-off-by: Matthew Auld <matthew.auld@intel.com> > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> > Cc: Ramalingam C <ramalingam.c@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c > index a69b244f14d0..9a0814422ba4 100644 > --- a/drivers/gpu/drm/i915/gt/intel_migrate.c > +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c > @@ -708,7 +708,7 @@ intel_context_migrate_copy(struct intel_context *ce, > u8 src_access, dst_access; > struct i915_request *rq; > int src_sz, dst_sz; > - bool ccs_is_src; > + bool ccs_is_src, overwrite_ccs; > int err; > > GEM_BUG_ON(ce->vm != ce->engine->gt->migrate.context->vm); > @@ -749,6 +749,8 @@ intel_context_migrate_copy(struct intel_context *ce, > get_ccs_sg_sgt(&it_ccs, bytes_to_cpy); > } > > + overwrite_ccs = HAS_FLAT_CCS(i915) && !ccs_bytes_to_cpy && > +dst_is_lmem; > + > src_offset = 0; > dst_offset = CHUNK_SZ; > if (HAS_64K_PAGES(ce->engine->i915)) { @@ -852,6 +854,25 @@ > intel_context_migrate_copy(struct intel_context *ce, > if (err) > goto out_rq; > ccs_bytes_to_cpy -= ccs_sz; > + } else if (overwrite_ccs) { > + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); > + if (err) > + goto out_rq; > + > + /* > + * While we can't always restore/manage the CCS state, > + * we still need to ensure we don't leak the CCS state > + * from the previous user, so make sure we overwrite it > + * with something. > + */ > + err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS, > + dst_offset, DIRECT_ACCESS, len); > + if (err) > + goto out_rq; > + > + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); > + if (err) > + goto out_rq; The change is looking good to the purpose. But shouldn't this be the part of lmem allocation itself? Ram. > } > > /* Arbitration is re-enabled between requests. */ > -- > 2.37.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/ttm: don't leak the ccs state @ 2022-07-27 23:16 ` C, Ramalingam 0 siblings, 0 replies; 10+ messages in thread From: C, Ramalingam @ 2022-07-27 23:16 UTC (permalink / raw) To: Auld, Matthew, intel-gfx; +Cc: Thomas Hellström, dri-devel > -----Original Message----- > From: Auld, Matthew <matthew.auld@intel.com> > Sent: Wednesday, July 27, 2022 10:14 PM > To: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Thomas Hellström <thomas.hellstrom@linux.intel.com>; C, > Ramalingam <ramalingam.c@intel.com> > Subject: [PATCH] drm/i915/ttm: don't leak the ccs state > > The kernel only manages the ccs state with lmem-only objects, however the kernel should still take > care not to leak the CCS state from the previous user. > > Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for Flat-ccs objects") > Signed-off-by: Matthew Auld <matthew.auld@intel.com> > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> > Cc: Ramalingam C <ramalingam.c@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c > index a69b244f14d0..9a0814422ba4 100644 > --- a/drivers/gpu/drm/i915/gt/intel_migrate.c > +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c > @@ -708,7 +708,7 @@ intel_context_migrate_copy(struct intel_context *ce, > u8 src_access, dst_access; > struct i915_request *rq; > int src_sz, dst_sz; > - bool ccs_is_src; > + bool ccs_is_src, overwrite_ccs; > int err; > > GEM_BUG_ON(ce->vm != ce->engine->gt->migrate.context->vm); > @@ -749,6 +749,8 @@ intel_context_migrate_copy(struct intel_context *ce, > get_ccs_sg_sgt(&it_ccs, bytes_to_cpy); > } > > + overwrite_ccs = HAS_FLAT_CCS(i915) && !ccs_bytes_to_cpy && > +dst_is_lmem; > + > src_offset = 0; > dst_offset = CHUNK_SZ; > if (HAS_64K_PAGES(ce->engine->i915)) { @@ -852,6 +854,25 @@ > intel_context_migrate_copy(struct intel_context *ce, > if (err) > goto out_rq; > ccs_bytes_to_cpy -= ccs_sz; > + } else if (overwrite_ccs) { > + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); > + if (err) > + goto out_rq; > + > + /* > + * While we can't always restore/manage the CCS state, > + * we still need to ensure we don't leak the CCS state > + * from the previous user, so make sure we overwrite it > + * with something. > + */ > + err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS, > + dst_offset, DIRECT_ACCESS, len); > + if (err) > + goto out_rq; > + > + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); > + if (err) > + goto out_rq; The change is looking good to the purpose. But shouldn't this be the part of lmem allocation itself? Ram. > } > > /* Arbitration is re-enabled between requests. */ > -- > 2.37.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/i915/ttm: don't leak the ccs state 2022-07-27 23:16 ` [Intel-gfx] " C, Ramalingam @ 2022-07-28 8:08 ` Matthew Auld -1 siblings, 0 replies; 10+ messages in thread From: Matthew Auld @ 2022-07-28 8:08 UTC (permalink / raw) To: C, Ramalingam, intel-gfx; +Cc: Thomas Hellström, dri-devel On 28/07/2022 00:16, C, Ramalingam wrote: >> -----Original Message----- >> From: Auld, Matthew <matthew.auld@intel.com> >> Sent: Wednesday, July 27, 2022 10:14 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org; Thomas Hellström <thomas.hellstrom@linux.intel.com>; C, >> Ramalingam <ramalingam.c@intel.com> >> Subject: [PATCH] drm/i915/ttm: don't leak the ccs state >> >> The kernel only manages the ccs state with lmem-only objects, however the kernel should still take >> care not to leak the CCS state from the previous user. >> >> Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for Flat-ccs objects") >> Signed-off-by: Matthew Auld <matthew.auld@intel.com> >> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> >> Cc: Ramalingam C <ramalingam.c@intel.com> >> --- >> drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++++++++++++++++++++++- >> 1 file changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c >> index a69b244f14d0..9a0814422ba4 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c >> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c >> @@ -708,7 +708,7 @@ intel_context_migrate_copy(struct intel_context *ce, >> u8 src_access, dst_access; >> struct i915_request *rq; >> int src_sz, dst_sz; >> - bool ccs_is_src; >> + bool ccs_is_src, overwrite_ccs; >> int err; >> >> GEM_BUG_ON(ce->vm != ce->engine->gt->migrate.context->vm); >> @@ -749,6 +749,8 @@ intel_context_migrate_copy(struct intel_context *ce, >> get_ccs_sg_sgt(&it_ccs, bytes_to_cpy); >> } >> >> + overwrite_ccs = HAS_FLAT_CCS(i915) && !ccs_bytes_to_cpy && >> +dst_is_lmem; >> + >> src_offset = 0; >> dst_offset = CHUNK_SZ; >> if (HAS_64K_PAGES(ce->engine->i915)) { @@ -852,6 +854,25 @@ >> intel_context_migrate_copy(struct intel_context *ce, >> if (err) >> goto out_rq; >> ccs_bytes_to_cpy -= ccs_sz; >> + } else if (overwrite_ccs) { >> + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); >> + if (err) >> + goto out_rq; >> + >> + /* >> + * While we can't always restore/manage the CCS state, >> + * we still need to ensure we don't leak the CCS state >> + * from the previous user, so make sure we overwrite it >> + * with something. >> + */ >> + err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS, >> + dst_offset, DIRECT_ACCESS, len); >> + if (err) >> + goto out_rq; >> + >> + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); >> + if (err) >> + goto out_rq; > The change is looking good to the purpose. But shouldn't this be the part of lmem allocation itself? Hmm, what do you mean by the lmem allocation itself? The scenarios I had in mind here were: - { lmem, smem } buffer, object is allocated in smem (like with initial mmap) and then moved to lmem (smem -> lmem). - { lmem, smem } buffer, object is allocated in lmem, but then evicted to smem. Object then moved back to lmem (smem -> lmem). - { lmem, smem} buffer with CPU_ACCESS flag on small-bar system, object is allocated in non-mappable lmem, and them moved to the mappable part of lmem on fault (lmem -> lmem). In all the above cases the CCS state is left uninitialised, AFAICT. > > Ram. >> } >> >> /* Arbitration is re-enabled between requests. */ >> -- >> 2.37.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/ttm: don't leak the ccs state @ 2022-07-28 8:08 ` Matthew Auld 0 siblings, 0 replies; 10+ messages in thread From: Matthew Auld @ 2022-07-28 8:08 UTC (permalink / raw) To: C, Ramalingam, intel-gfx; +Cc: Thomas Hellström, dri-devel On 28/07/2022 00:16, C, Ramalingam wrote: >> -----Original Message----- >> From: Auld, Matthew <matthew.auld@intel.com> >> Sent: Wednesday, July 27, 2022 10:14 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org; Thomas Hellström <thomas.hellstrom@linux.intel.com>; C, >> Ramalingam <ramalingam.c@intel.com> >> Subject: [PATCH] drm/i915/ttm: don't leak the ccs state >> >> The kernel only manages the ccs state with lmem-only objects, however the kernel should still take >> care not to leak the CCS state from the previous user. >> >> Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for Flat-ccs objects") >> Signed-off-by: Matthew Auld <matthew.auld@intel.com> >> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> >> Cc: Ramalingam C <ramalingam.c@intel.com> >> --- >> drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++++++++++++++++++++++- >> 1 file changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c >> index a69b244f14d0..9a0814422ba4 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c >> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c >> @@ -708,7 +708,7 @@ intel_context_migrate_copy(struct intel_context *ce, >> u8 src_access, dst_access; >> struct i915_request *rq; >> int src_sz, dst_sz; >> - bool ccs_is_src; >> + bool ccs_is_src, overwrite_ccs; >> int err; >> >> GEM_BUG_ON(ce->vm != ce->engine->gt->migrate.context->vm); >> @@ -749,6 +749,8 @@ intel_context_migrate_copy(struct intel_context *ce, >> get_ccs_sg_sgt(&it_ccs, bytes_to_cpy); >> } >> >> + overwrite_ccs = HAS_FLAT_CCS(i915) && !ccs_bytes_to_cpy && >> +dst_is_lmem; >> + >> src_offset = 0; >> dst_offset = CHUNK_SZ; >> if (HAS_64K_PAGES(ce->engine->i915)) { @@ -852,6 +854,25 @@ >> intel_context_migrate_copy(struct intel_context *ce, >> if (err) >> goto out_rq; >> ccs_bytes_to_cpy -= ccs_sz; >> + } else if (overwrite_ccs) { >> + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); >> + if (err) >> + goto out_rq; >> + >> + /* >> + * While we can't always restore/manage the CCS state, >> + * we still need to ensure we don't leak the CCS state >> + * from the previous user, so make sure we overwrite it >> + * with something. >> + */ >> + err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS, >> + dst_offset, DIRECT_ACCESS, len); >> + if (err) >> + goto out_rq; >> + >> + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); >> + if (err) >> + goto out_rq; > The change is looking good to the purpose. But shouldn't this be the part of lmem allocation itself? Hmm, what do you mean by the lmem allocation itself? The scenarios I had in mind here were: - { lmem, smem } buffer, object is allocated in smem (like with initial mmap) and then moved to lmem (smem -> lmem). - { lmem, smem } buffer, object is allocated in lmem, but then evicted to smem. Object then moved back to lmem (smem -> lmem). - { lmem, smem} buffer with CPU_ACCESS flag on small-bar system, object is allocated in non-mappable lmem, and them moved to the mappable part of lmem on fault (lmem -> lmem). In all the above cases the CCS state is left uninitialised, AFAICT. > > Ram. >> } >> >> /* Arbitration is re-enabled between requests. */ >> -- >> 2.37.1 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] drm/i915/ttm: don't leak the ccs state 2022-07-28 8:08 ` [Intel-gfx] " Matthew Auld @ 2022-07-28 9:36 ` C, Ramalingam -1 siblings, 0 replies; 10+ messages in thread From: C, Ramalingam @ 2022-07-28 9:36 UTC (permalink / raw) To: Auld, Matthew, C, Ramalingam, intel-gfx; +Cc: Thomas Hellström, dri-devel > -----Original Message----- > From: Auld, Matthew <matthew.auld@intel.com> > Sent: Thursday, July 28, 2022 1:38 PM > To: C, Ramalingam <ramalingam.c@intel.com>; intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Thomas Hellström <thomas.hellstrom@linux.intel.com> > Subject: Re: [PATCH] drm/i915/ttm: don't leak the ccs state > > On 28/07/2022 00:16, C, Ramalingam wrote: > >> -----Original Message----- > >> From: Auld, Matthew <matthew.auld@intel.com> > >> Sent: Wednesday, July 27, 2022 10:14 PM > >> To: intel-gfx@lists.freedesktop.org > >> Cc: dri-devel@lists.freedesktop.org; Thomas Hellström > >> <thomas.hellstrom@linux.intel.com>; C, Ramalingam > >> <ramalingam.c@intel.com> > >> Subject: [PATCH] drm/i915/ttm: don't leak the ccs state > >> > >> The kernel only manages the ccs state with lmem-only objects, however > >> the kernel should still take care not to leak the CCS state from the previous user. > >> > >> Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for > >> Flat-ccs objects") > >> Signed-off-by: Matthew Auld <matthew.auld@intel.com> > >> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> > >> Cc: Ramalingam C <ramalingam.c@intel.com> > >> --- > >> drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++++++++++++++++++++++- > >> 1 file changed, 22 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c > >> b/drivers/gpu/drm/i915/gt/intel_migrate.c > >> index a69b244f14d0..9a0814422ba4 100644 > >> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c > >> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c > >> @@ -708,7 +708,7 @@ intel_context_migrate_copy(struct intel_context *ce, > >> u8 src_access, dst_access; > >> struct i915_request *rq; > >> int src_sz, dst_sz; > >> - bool ccs_is_src; > >> + bool ccs_is_src, overwrite_ccs; > >> int err; > >> > >> GEM_BUG_ON(ce->vm != ce->engine->gt->migrate.context->vm); > >> @@ -749,6 +749,8 @@ intel_context_migrate_copy(struct intel_context *ce, > >> get_ccs_sg_sgt(&it_ccs, bytes_to_cpy); > >> } > >> > >> + overwrite_ccs = HAS_FLAT_CCS(i915) && !ccs_bytes_to_cpy && > >> +dst_is_lmem; > >> + > >> src_offset = 0; > >> dst_offset = CHUNK_SZ; > >> if (HAS_64K_PAGES(ce->engine->i915)) { @@ -852,6 +854,25 @@ > >> intel_context_migrate_copy(struct intel_context *ce, > >> if (err) > >> goto out_rq; > >> ccs_bytes_to_cpy -= ccs_sz; > >> + } else if (overwrite_ccs) { > >> + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); > >> + if (err) > >> + goto out_rq; > >> + > >> + /* > >> + * While we can't always restore/manage the CCS state, > >> + * we still need to ensure we don't leak the CCS state > >> + * from the previous user, so make sure we overwrite it > >> + * with something. > >> + */ > >> + err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS, > >> + dst_offset, DIRECT_ACCESS, len); > >> + if (err) > >> + goto out_rq; > >> + > >> + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); > >> + if (err) > >> + goto out_rq; > > The change is looking good to the purpose. But shouldn't this be the part of lmem allocation itself? > > Hmm, what do you mean by the lmem allocation itself? The scenarios I had in mind here were: > > - { lmem, smem } buffer, object is allocated in smem (like with initial > mmap) and then moved to lmem (smem -> lmem). > > - { lmem, smem } buffer, object is allocated in lmem, but then evicted to smem. Object then moved > back to lmem (smem -> lmem). > > - { lmem, smem} buffer with CPU_ACCESS flag on small-bar system, object is allocated in non- > mappable lmem, and them moved to the mappable part of lmem on fault (lmem -> lmem). > > In all the above cases the CCS state is left uninitialised, AFAICT. As we discussed offline, this will clear the ccs state(old) of the dst lmem in case of migration from smem to lmem of smem+lmem obj. this seems to be right place to fix the info leak of previous ccs state. Reviewed-by: Ramalingam C <ramalingam.c@intel.com> > > > > > Ram. > >> } > >> > >> /* Arbitration is re-enabled between requests. */ > >> -- > >> 2.37.1 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/ttm: don't leak the ccs state @ 2022-07-28 9:36 ` C, Ramalingam 0 siblings, 0 replies; 10+ messages in thread From: C, Ramalingam @ 2022-07-28 9:36 UTC (permalink / raw) To: Auld, Matthew, C, Ramalingam, intel-gfx; +Cc: Thomas Hellström, dri-devel > -----Original Message----- > From: Auld, Matthew <matthew.auld@intel.com> > Sent: Thursday, July 28, 2022 1:38 PM > To: C, Ramalingam <ramalingam.c@intel.com>; intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Thomas Hellström <thomas.hellstrom@linux.intel.com> > Subject: Re: [PATCH] drm/i915/ttm: don't leak the ccs state > > On 28/07/2022 00:16, C, Ramalingam wrote: > >> -----Original Message----- > >> From: Auld, Matthew <matthew.auld@intel.com> > >> Sent: Wednesday, July 27, 2022 10:14 PM > >> To: intel-gfx@lists.freedesktop.org > >> Cc: dri-devel@lists.freedesktop.org; Thomas Hellström > >> <thomas.hellstrom@linux.intel.com>; C, Ramalingam > >> <ramalingam.c@intel.com> > >> Subject: [PATCH] drm/i915/ttm: don't leak the ccs state > >> > >> The kernel only manages the ccs state with lmem-only objects, however > >> the kernel should still take care not to leak the CCS state from the previous user. > >> > >> Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for > >> Flat-ccs objects") > >> Signed-off-by: Matthew Auld <matthew.auld@intel.com> > >> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> > >> Cc: Ramalingam C <ramalingam.c@intel.com> > >> --- > >> drivers/gpu/drm/i915/gt/intel_migrate.c | 23 ++++++++++++++++++++++- > >> 1 file changed, 22 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c > >> b/drivers/gpu/drm/i915/gt/intel_migrate.c > >> index a69b244f14d0..9a0814422ba4 100644 > >> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c > >> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c > >> @@ -708,7 +708,7 @@ intel_context_migrate_copy(struct intel_context *ce, > >> u8 src_access, dst_access; > >> struct i915_request *rq; > >> int src_sz, dst_sz; > >> - bool ccs_is_src; > >> + bool ccs_is_src, overwrite_ccs; > >> int err; > >> > >> GEM_BUG_ON(ce->vm != ce->engine->gt->migrate.context->vm); > >> @@ -749,6 +749,8 @@ intel_context_migrate_copy(struct intel_context *ce, > >> get_ccs_sg_sgt(&it_ccs, bytes_to_cpy); > >> } > >> > >> + overwrite_ccs = HAS_FLAT_CCS(i915) && !ccs_bytes_to_cpy && > >> +dst_is_lmem; > >> + > >> src_offset = 0; > >> dst_offset = CHUNK_SZ; > >> if (HAS_64K_PAGES(ce->engine->i915)) { @@ -852,6 +854,25 @@ > >> intel_context_migrate_copy(struct intel_context *ce, > >> if (err) > >> goto out_rq; > >> ccs_bytes_to_cpy -= ccs_sz; > >> + } else if (overwrite_ccs) { > >> + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); > >> + if (err) > >> + goto out_rq; > >> + > >> + /* > >> + * While we can't always restore/manage the CCS state, > >> + * we still need to ensure we don't leak the CCS state > >> + * from the previous user, so make sure we overwrite it > >> + * with something. > >> + */ > >> + err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS, > >> + dst_offset, DIRECT_ACCESS, len); > >> + if (err) > >> + goto out_rq; > >> + > >> + err = rq->engine->emit_flush(rq, EMIT_INVALIDATE); > >> + if (err) > >> + goto out_rq; > > The change is looking good to the purpose. But shouldn't this be the part of lmem allocation itself? > > Hmm, what do you mean by the lmem allocation itself? The scenarios I had in mind here were: > > - { lmem, smem } buffer, object is allocated in smem (like with initial > mmap) and then moved to lmem (smem -> lmem). > > - { lmem, smem } buffer, object is allocated in lmem, but then evicted to smem. Object then moved > back to lmem (smem -> lmem). > > - { lmem, smem} buffer with CPU_ACCESS flag on small-bar system, object is allocated in non- > mappable lmem, and them moved to the mappable part of lmem on fault (lmem -> lmem). > > In all the above cases the CCS state is left uninitialised, AFAICT. As we discussed offline, this will clear the ccs state(old) of the dst lmem in case of migration from smem to lmem of smem+lmem obj. this seems to be right place to fix the info leak of previous ccs state. Reviewed-by: Ramalingam C <ramalingam.c@intel.com> > > > > > Ram. > >> } > >> > >> /* Arbitration is re-enabled between requests. */ > >> -- > >> 2.37.1 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-07-28 9:36 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-07-27 16:43 [PATCH] drm/i915/ttm: don't leak the ccs state Matthew Auld 2022-07-27 16:43 ` [Intel-gfx] " Matthew Auld 2022-07-27 18:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-07-27 21:42 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-07-27 23:16 ` [PATCH] " C, Ramalingam 2022-07-27 23:16 ` [Intel-gfx] " C, Ramalingam 2022-07-28 8:08 ` Matthew Auld 2022-07-28 8:08 ` [Intel-gfx] " Matthew Auld 2022-07-28 9:36 ` C, Ramalingam 2022-07-28 9:36 ` [Intel-gfx] " C, Ramalingam
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.