All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] Revert "drm/i915/uapi: expose GTT alignment"
@ 2022-10-24 10:19 Matthew Auld
  2022-10-24 11:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
                   ` (10 more replies)
  0 siblings, 11 replies; 19+ messages in thread
From: Matthew Auld @ 2022-10-24 10:19 UTC (permalink / raw)
  To: intel-gfx; +Cc: Thomas Hellström, Michal Mrozek, Nirmoy Das

The process for merging uAPI is to have UMD side ready and reviewed and
merged before merging. Revert for now until that is ready.

This reverts commit d54576a074a29d4901d0a693cd84e1a89057f694.

Reported-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Michal Mrozek <michal.mrozek@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Stuart Summers <stuart.summers@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Yang A Shi <yang.a.shi@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
---
 drivers/gpu/drm/i915/i915_query.c |  1 -
 include/uapi/drm/i915_drm.h       | 29 ++---------------------------
 2 files changed, 2 insertions(+), 28 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_query.c b/drivers/gpu/drm/i915/i915_query.c
index 111377f210ed..6ec9c9fb7b0d 100644
--- a/drivers/gpu/drm/i915/i915_query.c
+++ b/drivers/gpu/drm/i915/i915_query.c
@@ -498,7 +498,6 @@ static int query_memregion_info(struct drm_i915_private *i915,
 		info.region.memory_class = mr->type;
 		info.region.memory_instance = mr->instance;
 		info.probed_size = mr->total;
-		info.gtt_alignment = mr->min_page_size;
 
 		if (mr->type == INTEL_MEMORY_LOCAL)
 			info.probed_cpu_visible_size = mr->io_size;
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index c2dce8633005..9bf281ec1125 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -3466,33 +3466,8 @@ struct drm_i915_memory_region_info {
 	/** @region: The class:instance pair encoding */
 	struct drm_i915_gem_memory_class_instance region;
 
-	union {
-		/** @rsvd0: MBZ */
-		__u32 rsvd0;
-		/**
-		 * @gtt_alignment:
-		 *
-		 * The minimum required GTT alignment for this type of memory.
-		 * When allocating a GTT address it must be aligned to this
-		 * value or larger. On some platforms the kernel might opt to
-		 * using 64K pages for I915_MEMORY_CLASS_DEVICE, where 64K GTT
-		 * pages can then be used if we also use 64K GTT alignment.
-		 *
-		 * NOTE: If this is zero then this must be an older
-		 * kernel which lacks support for this field.
-		 *
-		 * Side note: For larger objects (especially for
-		 * I915_MEMORY_CLASS_DEVICE), like 2M+ in size, userspace should
-		 * consider potentially bumping the GTT alignment to say 2M,
-		 * which could potentially increase the likelihood of the kernel
-		 * being able to utilise 2M GTT pages underneath, if the layout
-		 * of the physical pages allows it.  On some configurations we
-		 * can then also use a more efficient page-table layout, if we
-		 * can't use the more desirable 2M GTT page, so long as we know
-		 * that the entire page-table will be used by this object.
-		 */
-		__u32 gtt_alignment;
-	};
+	/** @rsvd0: MBZ */
+	__u32 rsvd0;
 
 	/**
 	 * @probed_size: Memory probed by the driver
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 19+ messages in thread
end of thread, other threads:[~2022-10-26 19:23 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 10:19 [Intel-gfx] [PATCH] Revert "drm/i915/uapi: expose GTT alignment" Matthew Auld
2022-10-24 11:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2022-10-24 11:55 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-10-25  9:08   ` Matthew Auld
2022-10-25 19:29     ` Vudum, Lakshminarayana
2022-10-25  8:40 ` [Intel-gfx] [PATCH] " Das, Nirmoy
2022-10-25 15:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-10-25 16:11 ` Patchwork
2022-10-25 16:37 ` Patchwork
2022-10-25 17:12   ` Matthew Auld
2022-10-25 17:24 ` Patchwork
2022-10-25 18:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-26  7:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-26  8:52   ` Matthew Auld
2022-10-26 17:53     ` Vudum, Lakshminarayana
2022-10-26 18:01       ` Matthew Auld
2022-10-26 19:22         ` Vudum, Lakshminarayana
2022-10-26 16:40 ` Patchwork
2022-10-26 18:58 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.