* [PATCH] drm/amd/display: Update DCN302 SR Exit Latency
@ 2021-04-08 15:48 Aurabindo Pillai
2021-04-08 15:55 ` R, Bindu
0 siblings, 1 reply; 3+ messages in thread
From: Aurabindo Pillai @ 2021-04-08 15:48 UTC (permalink / raw)
To: amd-gfx; +Cc: Joshua Aberback, aurabindo.pillai, Bindu.R
From: Joshua Aberback <joshua.aberback@amd.com>
[Why]
Update SR Exit Latency to fix screen flickering caused due to OTG
underflow
Signed-off-by: Joshua Aberback <joshua.aberback@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
index a928c1d9a557..fc2dea243d1b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
@@ -164,7 +164,7 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_02_soc = {
.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
.num_states = 1,
- .sr_exit_time_us = 12,
+ .sr_exit_time_us = 15.5,
.sr_enter_plus_exit_time_us = 20,
.urgent_latency_us = 4.0,
.urgent_latency_pixel_data_only_us = 4.0,
--
2.31.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: Update DCN302 SR Exit Latency
2021-04-08 15:48 [PATCH] drm/amd/display: Update DCN302 SR Exit Latency Aurabindo Pillai
@ 2021-04-08 15:55 ` R, Bindu
2021-04-08 16:25 ` Pillai, Aurabindo
0 siblings, 1 reply; 3+ messages in thread
From: R, Bindu @ 2021-04-08 15:55 UTC (permalink / raw)
To: Pillai, Aurabindo, amd-gfx; +Cc: Aberback, Joshua
[-- Attachment #1.1: Type: text/plain, Size: 1658 bytes --]
[AMD Official Use Only - Internal Distribution Only]
Hi Jay,
Could you please add few details on the root cause, in the [Why/How] section?
Thanks,
Bindu
________________________________
From: Aurabindo Pillai <aurabindo.pillai@amd.com>
Sent: Thursday, April 8, 2021 11:48 AM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; R, Bindu <Bindu.R@amd.com>; Aberback, Joshua <Joshua.Aberback@amd.com>
Subject: [PATCH] drm/amd/display: Update DCN302 SR Exit Latency
From: Joshua Aberback <joshua.aberback@amd.com>
[Why]
Update SR Exit Latency to fix screen flickering caused due to OTG
underflow
Signed-off-by: Joshua Aberback <joshua.aberback@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
index a928c1d9a557..fc2dea243d1b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
@@ -164,7 +164,7 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_02_soc = {
.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
.num_states = 1,
- .sr_exit_time_us = 12,
+ .sr_exit_time_us = 15.5,
.sr_enter_plus_exit_time_us = 20,
.urgent_latency_us = 4.0,
.urgent_latency_pixel_data_only_us = 4.0,
--
2.31.1
[-- Attachment #1.2: Type: text/html, Size: 3348 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: Update DCN302 SR Exit Latency
2021-04-08 15:55 ` R, Bindu
@ 2021-04-08 16:25 ` Pillai, Aurabindo
0 siblings, 0 replies; 3+ messages in thread
From: Pillai, Aurabindo @ 2021-04-08 16:25 UTC (permalink / raw)
To: R, Bindu, amd-gfx; +Cc: Aberback, Joshua
[-- Attachment #1.1: Type: text/plain, Size: 2274 bytes --]
[AMD Official Use Only - Internal Distribution Only]
Hi Bindu,
The value is recommended by the hardware team. Since a non-recommended value was being used, that itself is the root cause. I will add this to commit message.
--
Thanks & Regards,
Aurabindo Pillai
________________________________
From: R, Bindu <Bindu.R@amd.com>
Sent: Thursday, April 8, 2021 11:55 AM
To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Aberback, Joshua <Joshua.Aberback@amd.com>
Subject: Re: [PATCH] drm/amd/display: Update DCN302 SR Exit Latency
[AMD Official Use Only - Internal Distribution Only]
Hi Jay,
Could you please add few details on the root cause, in the [Why/How] section?
Thanks,
Bindu
________________________________
From: Aurabindo Pillai <aurabindo.pillai@amd.com>
Sent: Thursday, April 8, 2021 11:48 AM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; R, Bindu <Bindu.R@amd.com>; Aberback, Joshua <Joshua.Aberback@amd.com>
Subject: [PATCH] drm/amd/display: Update DCN302 SR Exit Latency
From: Joshua Aberback <joshua.aberback@amd.com>
[Why]
Update SR Exit Latency to fix screen flickering caused due to OTG
underflow
Signed-off-by: Joshua Aberback <joshua.aberback@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
index a928c1d9a557..fc2dea243d1b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
@@ -164,7 +164,7 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_02_soc = {
.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
.num_states = 1,
- .sr_exit_time_us = 12,
+ .sr_exit_time_us = 15.5,
.sr_enter_plus_exit_time_us = 20,
.urgent_latency_us = 4.0,
.urgent_latency_pixel_data_only_us = 4.0,
--
2.31.1
[-- Attachment #1.2: Type: text/html, Size: 5572 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-08 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 15:48 [PATCH] drm/amd/display: Update DCN302 SR Exit Latency Aurabindo Pillai
2021-04-08 15:55 ` R, Bindu
2021-04-08 16:25 ` Pillai, Aurabindo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.