All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Liu, Zhan" <Zhan.Liu@amd.com>
To: "Liu, Zhan" <Zhan.Liu@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Liu, Charlene" <Charlene.Liu@amd.com>,
	"Cornij, Nikola" <Nikola.Cornij@amd.com>,
	"Gutierrez, Agustin" <Agustin.Gutierrez@amd.com>,
	Pierre-Loup Griffais <pgriffais@valvesoftware.com>,
	"Kotarac, Pavle" <Pavle.Kotarac@amd.com>
Subject: RE: [PATCH] drm/amd/display: Shorten delay time to 1us while resetting FIFO
Date: Wed, 19 Jan 2022 22:23:48 +0000	[thread overview]
Message-ID: <DM4PR12MB5214DD41D3E2E2271F732CBF9E599@DM4PR12MB5214.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM4PR12MB521400998515602D0F8AA6EA9E599@DM4PR12MB5214.namprd12.prod.outlook.com>

[Public]

Apologize for sending out the patch with the wrong sensitivity a few seconds ago. I've updated sensitivity policy to "Public" here.

Thanks,
Zhan

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Liu, Zhan
> Sent: 2022/January/19, Wednesday 5:19 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Charlene <Charlene.Liu@amd.com>; Kotarac, Pavle
> <Pavle.Kotarac@amd.com>; Pierre-Loup Griffais <pgriffais@valvesoftware.com>;
> Gutierrez, Agustin <Agustin.Gutierrez@amd.com>; Cornij, Nikola
> <Nikola.Cornij@amd.com>
> Subject: [PATCH] drm/amd/display: Shorten delay time to 1us while resetting FIFO
>
> [Why]
> Current FIFO reset delay for dcn10 is 100us, which is too long and will fail atomic
> flip. As a result, there will be no display on boot.
>
> [How]
> Shorten delay time to 1us. This also aligns with FIFO reset delay on other ASICs.
>
> Signed-off-by: Zhan Liu <zhan.liu@amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
> b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
> index bf4436d7aaab..2077c22befa5 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_stream_encoder.c
> @@ -909,7 +909,7 @@ void enc1_stream_encoder_reset_fifo(
>
>         /* set DIG_START to 0x1 to reset FIFO */
>         REG_UPDATE(DIG_FE_CNTL, DIG_START, 1);
> -       udelay(100);
> +       udelay(1);
>
>         /* write 0 to take the FIFO out of reset */
>         REG_UPDATE(DIG_FE_CNTL, DIG_START, 0);
> --
> 2.25.1

  parent reply	other threads:[~2022-01-19 22:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 22:18 [PATCH] drm/amd/display: Shorten delay time to 1us while resetting FIFO Liu, Zhan
2022-01-19 22:20 ` Alex Deucher
2022-01-19 22:23 ` Liu, Zhan [this message]
2022-01-20  2:37   ` Liu, Zhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB5214DD41D3E2E2271F732CBF9E599@DM4PR12MB5214.namprd12.prod.outlook.com \
    --to=zhan.liu@amd.com \
    --cc=Agustin.Gutierrez@amd.com \
    --cc=Charlene.Liu@amd.com \
    --cc=Nikola.Cornij@amd.com \
    --cc=Pavle.Kotarac@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=pgriffais@valvesoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.