All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: change FIFO reset condition to embedded display only
@ 2022-01-19 22:21 Liu, Zhan
  2022-01-19 22:45 ` Liu, Charlene
  0 siblings, 1 reply; 2+ messages in thread
From: Liu, Zhan @ 2022-01-19 22:21 UTC (permalink / raw)
  To: amd-gfx
  Cc: Liu, Charlene, Kotarac, Pavle, Pierre-Loup Griffais, Gutierrez,
	Agustin, Cornij, Nikola

[Public]

[Why]
FIFO reset is only necessary for fast boot sequence, where otg is disabled
and dig fe is enabled when changing dispclk. Fast boot is only enabled
on embedded displays.

[How]
Change FIFO reset condition to "embedded display only".

Signed-off-by: Zhan Liu <zhan.liu@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index f1593186e964..f3ff141b706a 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -1608,7 +1608,7 @@ static enum dc_status apply_single_controller_ctx_to_hw(
                        pipe_ctx->stream_res.stream_enc,
                        pipe_ctx->stream_res.tg->inst);

-       if (dc_is_dp_signal(pipe_ctx->stream->signal) &&
+       if (dc_is_embedded_signal(pipe_ctx->stream->signal) &&
                pipe_ctx->stream_res.stream_enc->funcs->reset_fifo)
                pipe_ctx->stream_res.stream_enc->funcs->reset_fifo(
                        pipe_ctx->stream_res.stream_enc);
--
2.25.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] drm/amd/display: change FIFO reset condition to embedded display only
  2022-01-19 22:21 [PATCH] drm/amd/display: change FIFO reset condition to embedded display only Liu, Zhan
@ 2022-01-19 22:45 ` Liu, Charlene
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Charlene @ 2022-01-19 22:45 UTC (permalink / raw)
  To: Liu, Zhan, amd-gfx
  Cc: Kotarac, Pavle, Pierre-Loup Griffais, Gutierrez, Agustin, Cornij, Nikola

[Public]



-----Original Message-----
From: Liu, Zhan <Zhan.Liu@amd.com> 
Sent: Wednesday, January 19, 2022 5:22 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Charlene <Charlene.Liu@amd.com>; Cornij, Nikola <Nikola.Cornij@amd.com>; Gutierrez, Agustin <Agustin.Gutierrez@amd.com>; Kotarac, Pavle <Pavle.Kotarac@amd.com>; Pierre-Loup Griffais <pgriffais@valvesoftware.com>
Subject: [PATCH] drm/amd/display: change FIFO reset condition to embedded display only

[Public]

[Why]
FIFO reset is only necessary for fast boot sequence, where otg is disabled and dig fe is enabled when changing dispclk. Fast boot is only enabled on embedded displays.

[How]
Change FIFO reset condition to "embedded display only".

Signed-off-by: Zhan Liu <zhan.liu@amd.com>
Reviewed-by: Charlene Liu <charlene.liu@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index f1593186e964..f3ff141b706a 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -1608,7 +1608,7 @@ static enum dc_status apply_single_controller_ctx_to_hw(
                        pipe_ctx->stream_res.stream_enc,
                        pipe_ctx->stream_res.tg->inst);

-       if (dc_is_dp_signal(pipe_ctx->stream->signal) &&
+       if (dc_is_embedded_signal(pipe_ctx->stream->signal) &&
                pipe_ctx->stream_res.stream_enc->funcs->reset_fifo)
                pipe_ctx->stream_res.stream_enc->funcs->reset_fifo(
                        pipe_ctx->stream_res.stream_enc);
--
2.25.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-19 22:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-19 22:21 [PATCH] drm/amd/display: change FIFO reset condition to embedded display only Liu, Zhan
2022-01-19 22:45 ` Liu, Charlene

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.