All of lore.kernel.org
 help / color / mirror / Atom feed
* RE: [PATCH] drm/amd/amdgpu: set the default value of noretry to 1 for some dGPUs
       [not found] <20201013043445.23648-1-Jack.Gui@amd.com>
@ 2020-10-13  7:45 ` Chen, Guchun
  2020-10-13  7:51   ` Gui, Jack
  0 siblings, 1 reply; 2+ messages in thread
From: Chen, Guchun @ 2020-10-13  7:45 UTC (permalink / raw)
  To: Gui, Jack, amd-gfx, Deucher, Alexander
  Cc: Kuehling, Felix, Zhou1, Tao, Huang,  Ray, Gui, Jack, Zhang, Hawking

[AMD Public Use]

Hi Jack,

How about improving the patch a bit like below? As the code for raven and default case is totally the same, maybe we could squash both together with adding the comment for RAVEN and other default ASICs for readiness.

switch (adev->asic_type) {
	case CHIP_VEGA20:
	case CHIP_NAVI10:
	case CHIP_NAVI14:
	case CHIP_ARCTURUS:
		/*
		 * noretry = 0 will cause kfd page fault tests fail
		 * for some ASICs, so set default to 1 for these ASICs.
		 */
		if (amdgpu_noretry == -1)
			gmc->noretry = 1;
		else
			gmc->noretry = amdgpu_noretry;
		break;
	case CHIP_RAVEN: 
	default:
	/* Raven currently has issues with noretry
	 * regardless of what we decide for other
	 * asics, we should leave raven with
	 * noretry = 0 until we root cause the
	 * issues. The same for other default ASICs.
	 */
		if (amdgpu_noretry == -1)
			gmc->noretry = 0;
		else
			gmc->noretry = amdgpu_noretry;
		break;
	
Regards,
Guchun

-----Original Message-----
From: Chengming Gui <Jack.Gui@amd.com> 
Sent: Tuesday, October 13, 2020 12:35 PM
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher@amd.com>
Cc: Gui, Jack <Jack.Gui@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Rui.Huang@amd.com; Chen, Guchun <Guchun.Chen@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Kuehling, Felix <Felix.Kuehling@amd.com>
Subject: [PATCH] drm/amd/amdgpu: set the default value of noretry to 1 for some dGPUs

noretry = 0 cause some dGPU's kfd page fault tests fail, so set noretry to 1 for these special ASICs:
vega20/navi10/navi14/ARCTURUS

Signed-off-by: Chengming Gui <Jack.Gui@amd.com>
Change-Id: I3be70f463a49b0cd5c56456431d6c2cb98b13872
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
index 36604d751d62..f317bdeffcb1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
@@ -437,6 +437,19 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev)
 		else
 			gmc->noretry = amdgpu_noretry;
 		break;
+	case CHIP_VEGA20:
+	case CHIP_NAVI10:
+	case CHIP_NAVI14:
+	case CHIP_ARCTURUS:
+		/*
+		 * noretry = 0 will cause kfd page fault tests fail
+		 * for some ASICs, so set default to 1 for these ASICs.
+		 */
+		if (amdgpu_noretry == -1)
+			gmc->noretry = 1;
+		else
+			gmc->noretry = amdgpu_noretry;
+		break;
 	default:
 		/* default this to 0 for now, but we may want
 		 * to change this in the future for certain
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* RE: [PATCH] drm/amd/amdgpu: set the default value of noretry to 1 for some dGPUs
  2020-10-13  7:45 ` [PATCH] drm/amd/amdgpu: set the default value of noretry to 1 for some dGPUs Chen, Guchun
@ 2020-10-13  7:51   ` Gui, Jack
  0 siblings, 0 replies; 2+ messages in thread
From: Gui, Jack @ 2020-10-13  7:51 UTC (permalink / raw)
  To: Chen, Guchun, amd-gfx, Deucher, Alexander
  Cc: Kuehling, Felix, Zhou1, Tao, Huang, Ray, Zhang, Hawking

[AMD Public Use]

Hi Guchun,

It's fine.
I will address the patch according to your suggestion.

BR,
Jack

-----Original Message-----
From: Chen, Guchun <Guchun.Chen@amd.com> 
Sent: Tuesday, October 13, 2020 3:45 PM
To: Gui, Jack <Jack.Gui@amd.com>; amd-gfx@lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher@amd.com>
Cc: Gui, Jack <Jack.Gui@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Kuehling, Felix <Felix.Kuehling@amd.com>
Subject: RE: [PATCH] drm/amd/amdgpu: set the default value of noretry to 1 for some dGPUs

[AMD Public Use]

Hi Jack,

How about improving the patch a bit like below? As the code for raven and default case is totally the same, maybe we could squash both together with adding the comment for RAVEN and other default ASICs for readiness.

switch (adev->asic_type) {
	case CHIP_VEGA20:
	case CHIP_NAVI10:
	case CHIP_NAVI14:
	case CHIP_ARCTURUS:
		/*
		 * noretry = 0 will cause kfd page fault tests fail
		 * for some ASICs, so set default to 1 for these ASICs.
		 */
		if (amdgpu_noretry == -1)
			gmc->noretry = 1;
		else
			gmc->noretry = amdgpu_noretry;
		break;
	case CHIP_RAVEN: 
	default:
	/* Raven currently has issues with noretry
	 * regardless of what we decide for other
	 * asics, we should leave raven with
	 * noretry = 0 until we root cause the
	 * issues. The same for other default ASICs.
	 */
		if (amdgpu_noretry == -1)
			gmc->noretry = 0;
		else
			gmc->noretry = amdgpu_noretry;
		break;
	
Regards,
Guchun

-----Original Message-----
From: Chengming Gui <Jack.Gui@amd.com> 
Sent: Tuesday, October 13, 2020 12:35 PM
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher@amd.com>
Cc: Gui, Jack <Jack.Gui@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Rui.Huang@amd.com; Chen, Guchun <Guchun.Chen@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Kuehling, Felix <Felix.Kuehling@amd.com>
Subject: [PATCH] drm/amd/amdgpu: set the default value of noretry to 1 for some dGPUs

noretry = 0 cause some dGPU's kfd page fault tests fail, so set noretry to 1 for these special ASICs:
vega20/navi10/navi14/ARCTURUS

Signed-off-by: Chengming Gui <Jack.Gui@amd.com>
Change-Id: I3be70f463a49b0cd5c56456431d6c2cb98b13872
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
index 36604d751d62..f317bdeffcb1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
@@ -437,6 +437,19 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev)
 		else
 			gmc->noretry = amdgpu_noretry;
 		break;
+	case CHIP_VEGA20:
+	case CHIP_NAVI10:
+	case CHIP_NAVI14:
+	case CHIP_ARCTURUS:
+		/*
+		 * noretry = 0 will cause kfd page fault tests fail
+		 * for some ASICs, so set default to 1 for these ASICs.
+		 */
+		if (amdgpu_noretry == -1)
+			gmc->noretry = 1;
+		else
+			gmc->noretry = amdgpu_noretry;
+		break;
 	default:
 		/* default this to 0 for now, but we may want
 		 * to change this in the future for certain
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-13  7:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20201013043445.23648-1-Jack.Gui@amd.com>
2020-10-13  7:45 ` [PATCH] drm/amd/amdgpu: set the default value of noretry to 1 for some dGPUs Chen, Guchun
2020-10-13  7:51   ` Gui, Jack

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.