Errant return in Carrizo SMU code

Errant return in Carrizo SMU code

[StDenis, Tom]

[-- Attachment #1.1: Type: text/plain, Size: 283 bytes --]

In the function


static int cz_check_fw_load_finish(struct pp_smumgr *smumgr,
  uint32_t firmware);

On line 198 of powerplay/smumgr/cz_smumgr.c there is an unconditional return in the middle of the function.  Is that an error or is the code after it truly dead code?

Tom

[-- Attachment #1.2: Type: text/html, Size: 850 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: Errant return in Carrizo SMU code

[Deucher, Alexander]

[-- Attachment #1.1: Type: text/plain, Size: 550 bytes --]

Yes, I think it should be removed.

Alex

From: amd-gfx [mailto:amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org] On Behalf Of StDenis, Tom
Sent: Friday, August 26, 2016 9:07 AM
To: amd-gfx list
Subject: Errant return in Carrizo SMU code


In the function


static int cz_check_fw_load_finish(struct pp_smumgr *smumgr,
  uint32_t firmware);

On line 198 of powerplay/smumgr/cz_smumgr.c there is an unconditional return in the middle of the function.  Is that an error or is the code after it truly dead code?

Tom

[-- Attachment #1.2: Type: text/html, Size: 4725 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx