* [PATCH] drm/amd/powerplay: drop the unnecessary uclk hard min setting
@ 2019-01-08 4:28 Evan Quan
[not found] ` <20190108042826.21031-1-evan.quan-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Evan Quan @ 2019-01-08 4:28 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Likun.Gao-5C7GfCeVMHo, Evan Quan, Kenneth.Feng-5C7GfCeVMHo
Since soft min setting is enough. Hard min setting is redundant.
Change-Id: I758386085f227bad94148ec0b38776312b6f5b25
Reported-by: Likun Gao <Likun.Gao@amd.com>
Signed-off-by: Evan Quan <evan.quan@amd.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
index c2061d351d04..82935a3bd950 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
@@ -1692,13 +1692,6 @@ static int vega20_upload_dpm_min_level(struct pp_hwmgr *hwmgr, uint32_t feature_
(PPCLK_UCLK << 16) | (min_freq & 0xffff))),
"Failed to set soft min memclk !",
return ret);
-
- min_freq = data->dpm_table.mem_table.dpm_state.hard_min_level;
- PP_ASSERT_WITH_CODE(!(ret = smum_send_msg_to_smc_with_parameter(
- hwmgr, PPSMC_MSG_SetHardMinByFreq,
- (PPCLK_UCLK << 16) | (min_freq & 0xffff))),
- "Failed to set hard min memclk !",
- return ret);
}
if (data->smu_features[GNLD_DPM_UVD].enabled &&
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/powerplay: drop the unnecessary uclk hard min setting
[not found] ` <20190108042826.21031-1-evan.quan-5C7GfCeVMHo@public.gmane.org>
@ 2019-01-08 4:32 ` Alex Deucher
2019-01-08 5:06 ` Gao, Likun
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2019-01-08 4:32 UTC (permalink / raw)
To: Evan Quan; +Cc: Likun Gao, Kenneth Feng, amd-gfx list
Acked-by: Alex Deucher <alexander.deucher@amd.com>
On Mon, Jan 7, 2019 at 11:28 PM Evan Quan <evan.quan@amd.com> wrote:
>
> Since soft min setting is enough. Hard min setting is redundant.
>
> Change-Id: I758386085f227bad94148ec0b38776312b6f5b25
> Reported-by: Likun Gao <Likun.Gao@amd.com>
> Signed-off-by: Evan Quan <evan.quan@amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> index c2061d351d04..82935a3bd950 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> @@ -1692,13 +1692,6 @@ static int vega20_upload_dpm_min_level(struct pp_hwmgr *hwmgr, uint32_t feature_
> (PPCLK_UCLK << 16) | (min_freq & 0xffff))),
> "Failed to set soft min memclk !",
> return ret);
> -
> - min_freq = data->dpm_table.mem_table.dpm_state.hard_min_level;
> - PP_ASSERT_WITH_CODE(!(ret = smum_send_msg_to_smc_with_parameter(
> - hwmgr, PPSMC_MSG_SetHardMinByFreq,
> - (PPCLK_UCLK << 16) | (min_freq & 0xffff))),
> - "Failed to set hard min memclk !",
> - return ret);
> }
>
> if (data->smu_features[GNLD_DPM_UVD].enabled &&
> --
> 2.20.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amd/powerplay: drop the unnecessary uclk hard min setting
[not found] ` <20190108042826.21031-1-evan.quan-5C7GfCeVMHo@public.gmane.org>
2019-01-08 4:32 ` Alex Deucher
@ 2019-01-08 5:06 ` Gao, Likun
1 sibling, 0 replies; 3+ messages in thread
From: Gao, Likun @ 2019-01-08 5:06 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Quan, Evan, Feng, Kenneth
Reviewed-by: Likun Gao <Likun.Gao@amd.com>
-----Original Message-----
From: Evan Quan <evan.quan@amd.com>
Sent: Tuesday, January 08, 2019 12:28 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun <Likun.Gao@amd.com>; Feng, Kenneth <Kenneth.Feng@amd.com>; Quan, Evan <Evan.Quan@amd.com>
Subject: [PATCH] drm/amd/powerplay: drop the unnecessary uclk hard min setting
Since soft min setting is enough. Hard min setting is redundant.
Change-Id: I758386085f227bad94148ec0b38776312b6f5b25
Reported-by: Likun Gao <Likun.Gao@amd.com>
Signed-off-by: Evan Quan <evan.quan@amd.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
index c2061d351d04..82935a3bd950 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
@@ -1692,13 +1692,6 @@ static int vega20_upload_dpm_min_level(struct pp_hwmgr *hwmgr, uint32_t feature_
(PPCLK_UCLK << 16) | (min_freq & 0xffff))),
"Failed to set soft min memclk !",
return ret);
-
- min_freq = data->dpm_table.mem_table.dpm_state.hard_min_level;
- PP_ASSERT_WITH_CODE(!(ret = smum_send_msg_to_smc_with_parameter(
- hwmgr, PPSMC_MSG_SetHardMinByFreq,
- (PPCLK_UCLK << 16) | (min_freq & 0xffff))),
- "Failed to set hard min memclk !",
- return ret);
}
if (data->smu_features[GNLD_DPM_UVD].enabled &&
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-08 5:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 4:28 [PATCH] drm/amd/powerplay: drop the unnecessary uclk hard min setting Evan Quan
[not found] ` <20190108042826.21031-1-evan.quan-5C7GfCeVMHo@public.gmane.org>
2019-01-08 4:32 ` Alex Deucher
2019-01-08 5:06 ` Gao, Likun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.