Making a GDS Allocation for NGG

Making a GDS Allocation for NGG

[Jakub Okoński]

Hi folks,

I was trying to play around with NGG on Vega using the open source AMDVLK stack.
After fetching all the code, I disabled an override in PAL, under
gfx9SettingsLoader.cpp
that disables the NGG setting. I've put a new option in my
amdPalSettings.cfg: `NggMode,7` and that was enough to enable it.

When I ran a small vulkan application, it crashed with a "Not implemented" error
in Pal::Linux::Device::AllocateGds. The comment there says:

    // TODO: implement it once amdgpu is ready.

I couldn't find anything specific to GDS allocation in upstream
kernel, so I looked at
agd5f/amd-staging-drm-next and found some code related to
AMDGPU_GEM_DOMAIN_GDS and allocating a bo object. This is in
amdgpu_gem_create_ioctl, so I think it's accessible to userspace, with
a small change
in libdrm, probably.

Is this what is needed to make a GDS allocation that NGG would accept, or is it
unrelated? Do you know if there are any other blockers for NGG besides this?

Regards,
Jakub
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: Making a GDS Allocation for NGG

[Jin, Jian-Rong]

Hi Jakub。
Both KMD and LLPC are not ready to support NGG for gfx9. We are going to support NGG in amdvlk for next generation GPU.

Thanks
Jian-Rong JIN

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Jakub Okoński
Sent: 2018年8月14日 21:31
To: amd-gfx@lists.freedesktop.org
Subject: Making a GDS Allocation for NGG

Hi folks,

I was trying to play around with NGG on Vega using the open source AMDVLK stack.
After fetching all the code, I disabled an override in PAL, under gfx9SettingsLoader.cpp that disables the NGG setting. I've put a new option in my
amdPalSettings.cfg: `NggMode,7` and that was enough to enable it.

When I ran a small vulkan application, it crashed with a "Not implemented" error in Pal::Linux::Device::AllocateGds. The comment there says:

    // TODO: implement it once amdgpu is ready.

I couldn't find anything specific to GDS allocation in upstream kernel, so I looked at agd5f/amd-staging-drm-next and found some code related to AMDGPU_GEM_DOMAIN_GDS and allocating a bo object. This is in amdgpu_gem_create_ioctl, so I think it's accessible to userspace, with a small change in libdrm, probably.

Is this what is needed to make a GDS allocation that NGG would accept, or is it unrelated? Do you know if there are any other blockers for NGG besides this?

Regards,
Jakub
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Making a GDS Allocation for NGG

[Jakub Okoński]

[-- Attachment #1.1: Type: text/plain, Size: 2060 bytes --]

Hey Jian-Rong,

Will gfx9 get support from KMD and LLPC by the time gfx10 releases, or is
it only going to be a gfx10-and-forward feature?

If not, is there something missing in gfx9 hardware? Are you allowed to say?

Thanks,
Jakub

On Wed, 15 Aug 2018 at 08:36 Jin, Jian-Rong <Jian-Rong.Jin-5C7GfCeVMHo@public.gmane.org> wrote:

> Hi Jakub。
> Both KMD and LLPC are not ready to support NGG for gfx9. We are going to
> support NGG in amdvlk for next generation GPU.
>
> Thanks
> Jian-Rong JIN
>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> On Behalf Of Jakub
> Okoński
> Sent: 2018年8月14日 21:31
> To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> Subject: Making a GDS Allocation for NGG
>
> Hi folks,
>
> I was trying to play around with NGG on Vega using the open source AMDVLK
> stack.
> After fetching all the code, I disabled an override in PAL, under
> gfx9SettingsLoader.cpp that disables the NGG setting. I've put a new option
> in my
> amdPalSettings.cfg: `NggMode,7` and that was enough to enable it.
>
> When I ran a small vulkan application, it crashed with a "Not implemented"
> error in Pal::Linux::Device::AllocateGds. The comment there says:
>
>     // TODO: implement it once amdgpu is ready.
>
> I couldn't find anything specific to GDS allocation in upstream kernel, so
> I looked at agd5f/amd-staging-drm-next and found some code related to
> AMDGPU_GEM_DOMAIN_GDS and allocating a bo object. This is in
> amdgpu_gem_create_ioctl, so I think it's accessible to userspace, with a
> small change in libdrm, probably.
>
> Is this what is needed to make a GDS allocation that NGG would accept, or
> is it unrelated? Do you know if there are any other blockers for NGG
> besides this?
>
> Regards,
> Jakub
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>

[-- Attachment #1.2: Type: text/html, Size: 2860 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Making a GDS Allocation for NGG

[Jin, Jian-Rong]

[-- Attachment #1.1: Type: text/plain, Size: 2177 bytes --]

GFX9 will not be supported.

Thanks,
Jian-Rong Jin

在 2018年8月15日，下午8:33，Jakub Okoński <jakub@okonski.org<mailto:jakub@okonski.org>> 写道：

Hey Jian-Rong,

Will gfx9 get support from KMD and LLPC by the time gfx10 releases, or is it only going to be a gfx10-and-forward feature?

If not, is there something missing in gfx9 hardware? Are you allowed to say?

Thanks,
Jakub

On Wed, 15 Aug 2018 at 08:36 Jin, Jian-Rong <Jian-Rong.Jin@amd.com<mailto:Jian-Rong.Jin@amd.com>> wrote:
Hi Jakub。
Both KMD and LLPC are not ready to support NGG for gfx9. We are going to support NGG in amdvlk for next generation GPU.

Thanks
Jian-Rong JIN

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org<mailto:amd-gfx-bounces@lists.freedesktop.org>> On Behalf Of Jakub Okoński
Sent: 2018年8月14日 21:31
To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Making a GDS Allocation for NGG

Hi folks,

I was trying to play around with NGG on Vega using the open source AMDVLK stack.
After fetching all the code, I disabled an override in PAL, under gfx9SettingsLoader.cpp that disables the NGG setting. I've put a new option in my
amdPalSettings.cfg: `NggMode,7` and that was enough to enable it.

When I ran a small vulkan application, it crashed with a "Not implemented" error in Pal::Linux::Device::AllocateGds. The comment there says:

    // TODO: implement it once amdgpu is ready.

I couldn't find anything specific to GDS allocation in upstream kernel, so I looked at agd5f/amd-staging-drm-next and found some code related to AMDGPU_GEM_DOMAIN_GDS and allocating a bo object. This is in amdgpu_gem_create_ioctl, so I think it's accessible to userspace, with a small change in libdrm, probably.

Is this what is needed to make a GDS allocation that NGG would accept, or is it unrelated? Do you know if there are any other blockers for NGG besides this?

Regards,
Jakub
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[-- Attachment #1.2: Type: text/html, Size: 3179 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx