[PATCH] drm:IB flag cleanups

[PATCH] drm:IB flag cleanups

[Monk Liu]

we don't use FLAG_GDS actually, and we need PREEMPT flag

Change-Id: I87f704e3fa97d7a7ffa956f0c94b77c333de380d
Signed-off-by: Monk Liu <Monk.Liu@amd.com>
---
 include/drm/amdgpu_drm.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
index 89a938a..624819c 100644
--- a/include/drm/amdgpu_drm.h
+++ b/include/drm/amdgpu_drm.h
@@ -375,11 +375,11 @@ union drm_amdgpu_cs {
 /* This IB should be submitted to CE */
 #define AMDGPU_IB_FLAG_CE	(1<<0)
 
-/* GDS is used by this IB */
-#define AMDGPU_IB_FLAG_GDS	(1<<1)
+/* Preamble */
+#define AMDGPU_IB_FLAG_PREAMBLE (1<<1)
 
-/* CE Preamble */
-#define AMDGPU_IB_FLAG_PREAMBLE (1<<2)
+/* Preemptible */
+#define AMDGPU_IB_FLAG_PREEMPT (1<<2)
 
 struct drm_amdgpu_cs_chunk_ib {
 	/**
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm:IB flag cleanups

[Christian König]

Please rebase that on the amd-staging-4.9 branch, the GDS flag never 
made it upstream.

Additional to that I would provide the implementation (e.g. forwarding 
it to the IB command) for the PREEMPT flag in the same patch.

Christian.

Am 08.03.2017 um 09:13 schrieb Monk Liu:
> we don't use FLAG_GDS actually, and we need PREEMPT flag
>
> Change-Id: I87f704e3fa97d7a7ffa956f0c94b77c333de380d
> Signed-off-by: Monk Liu <Monk.Liu@amd.com>
> ---
>   include/drm/amdgpu_drm.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
> index 89a938a..624819c 100644
> --- a/include/drm/amdgpu_drm.h
> +++ b/include/drm/amdgpu_drm.h
> @@ -375,11 +375,11 @@ union drm_amdgpu_cs {
>   /* This IB should be submitted to CE */
>   #define AMDGPU_IB_FLAG_CE	(1<<0)
>   
> -/* GDS is used by this IB */
> -#define AMDGPU_IB_FLAG_GDS	(1<<1)
> +/* Preamble */
> +#define AMDGPU_IB_FLAG_PREAMBLE (1<<1)
>   
> -/* CE Preamble */
> -#define AMDGPU_IB_FLAG_PREAMBLE (1<<2)
> +/* Preemptible */
> +#define AMDGPU_IB_FLAG_PREEMPT (1<<2)
>   
>   struct drm_amdgpu_cs_chunk_ib {
>   	/**


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm:IB flag cleanups

[Liu, Monk]

Rebase done: will send out another patch for review

>Additional to that I would provide the implementation (e.g. forwarding it to the IB command) for the PREEMPT flag in the same patch.

No, we don't have such imple, because this flag will be tagged by UMD, instead of by libdrm

BR Monk

-----Original Message-----
From: Christian König [mailto:deathsimple@vodafone.de] 
Sent: Wednesday, March 08, 2017 5:59 PM
To: Liu, Monk <Monk.Liu@amd.com>; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm:IB flag cleanups

Please rebase that on the amd-staging-4.9 branch, the GDS flag never made it upstream.

Additional to that I would provide the implementation (e.g. forwarding it to the IB command) for the PREEMPT flag in the same patch.

Christian.

Am 08.03.2017 um 09:13 schrieb Monk Liu:
> we don't use FLAG_GDS actually, and we need PREEMPT flag
>
> Change-Id: I87f704e3fa97d7a7ffa956f0c94b77c333de380d
> Signed-off-by: Monk Liu <Monk.Liu@amd.com>
> ---
>   include/drm/amdgpu_drm.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 
> 89a938a..624819c 100644
> --- a/include/drm/amdgpu_drm.h
> +++ b/include/drm/amdgpu_drm.h
> @@ -375,11 +375,11 @@ union drm_amdgpu_cs {
>   /* This IB should be submitted to CE */
>   #define AMDGPU_IB_FLAG_CE	(1<<0)
>   
> -/* GDS is used by this IB */
> -#define AMDGPU_IB_FLAG_GDS	(1<<1)
> +/* Preamble */
> +#define AMDGPU_IB_FLAG_PREAMBLE (1<<1)
>   
> -/* CE Preamble */
> -#define AMDGPU_IB_FLAG_PREAMBLE (1<<2)
> +/* Preemptible */
> +#define AMDGPU_IB_FLAG_PREEMPT (1<<2)
>   
>   struct drm_amdgpu_cs_chunk_ib {
>   	/**


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm:IB flag cleanups

[Christian König]

Am 08.03.2017 um 11:22 schrieb Liu, Monk:
> Rebase done: will send out another patch for review
>
>> Additional to that I would provide the implementation (e.g. forwarding it to the IB command) for the PREEMPT flag in the same patch.
> No, we don't have such imple, because this flag will be tagged by UMD, instead of by libdrm

Ups, my fault. Thought that this would be a kernel patch.

But we usually change the kernel side first, wait till that is upstream 
and then merge the changes back into libdrm.

And on the kernel side we should have the implementation to forward that 
bit from the IOCTL to the IB command. Should be a trivial one or two liner.

Christian.

>
> BR Monk
>
> -----Original Message-----
> From: Christian König [mailto:deathsimple@vodafone.de]
> Sent: Wednesday, March 08, 2017 5:59 PM
> To: Liu, Monk <Monk.Liu@amd.com>; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm:IB flag cleanups
>
> Please rebase that on the amd-staging-4.9 branch, the GDS flag never made it upstream.
>
> Additional to that I would provide the implementation (e.g. forwarding it to the IB command) for the PREEMPT flag in the same patch.
>
> Christian.
>
> Am 08.03.2017 um 09:13 schrieb Monk Liu:
>> we don't use FLAG_GDS actually, and we need PREEMPT flag
>>
>> Change-Id: I87f704e3fa97d7a7ffa956f0c94b77c333de380d
>> Signed-off-by: Monk Liu <Monk.Liu@amd.com>
>> ---
>>    include/drm/amdgpu_drm.h | 8 ++++----
>>    1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index
>> 89a938a..624819c 100644
>> --- a/include/drm/amdgpu_drm.h
>> +++ b/include/drm/amdgpu_drm.h
>> @@ -375,11 +375,11 @@ union drm_amdgpu_cs {
>>    /* This IB should be submitted to CE */
>>    #define AMDGPU_IB_FLAG_CE	(1<<0)
>>    
>> -/* GDS is used by this IB */
>> -#define AMDGPU_IB_FLAG_GDS	(1<<1)
>> +/* Preamble */
>> +#define AMDGPU_IB_FLAG_PREAMBLE (1<<1)
>>    
>> -/* CE Preamble */
>> -#define AMDGPU_IB_FLAG_PREAMBLE (1<<2)
>> +/* Preemptible */
>> +#define AMDGPU_IB_FLAG_PREEMPT (1<<2)
>>    
>>    struct drm_amdgpu_cs_chunk_ib {
>>    	/**
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx