From: "Ghannam, Yazen" <Yazen.Ghannam@amd.com> To: Borislav Petkov <bp@alien8.de> Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "bp@suse.de" <bp@suse.de>, "tony.luck@intel.com" <tony.luck@intel.com>, "x86@kernel.org" <x86@kernel.org> Subject: RE: [PATCH 2/3] x86/MCE/AMD, EDAC/mce_amd: Enumerate Reserved SMCA bank type Date: Wed, 14 Feb 2018 16:28:28 +0000 [thread overview] Message-ID: <DM5PR12MB1916FC8D126DD2926F44A80BF8F50@DM5PR12MB1916.namprd12.prod.outlook.com> (raw) In-Reply-To: <20180208151507.GE7964@pd.tnic> > -----Original Message----- > From: linux-edac-owner@vger.kernel.org [mailto:linux-edac- > owner@vger.kernel.org] On Behalf Of Borislav Petkov > Sent: Thursday, February 8, 2018 10:15 AM > To: Ghannam, Yazen <Yazen.Ghannam@amd.com> > Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; bp@suse.de; > tony.luck@intel.com; x86@kernel.org > Subject: Re: [PATCH 2/3] x86/MCE/AMD, EDAC/mce_amd: Enumerate Reserved > SMCA bank type > > On Thu, Feb 01, 2018 at 12:48:12PM -0600, Yazen Ghannam wrote: > > From: Yazen Ghannam <yazen.ghannam@amd.com> > > > > Currently, bank 4 is reserved on Fam17h, so we chose not to initialize > > bank 4 in the smca_banks array. This means that when we check if a bank > > is initialized, like during boot or resume, we will see that bank 4 is > > not initialized and try to initialize it. This may cause a call trace, > > when resuming from suspend, due to *on_cpu() calls in the init path. > > Please be more specific: the rdmsr_*_on_cpu() calls issue an IPI but we're > running with interrupts disabled, which triggers: > > WARNING: CPU: 0 PID: 11523 at kernel/smp.c:291 > smp_call_function_single+0xdc/0xe0 > Okay. ... > > @@ -433,6 +437,9 @@ static u32 get_block_address(unsigned int cpu, u32 > current_addr, u32 low, u32 hi > > u32 addr = 0, offset = 0; > > > > if (mce_flags.smca) { > > As a last patch in the series: please carve the code in this > if-statement into a smca_get_block_address() helper. And it doesn't need > the stable tag as it is only a cleanup. > Will do. Thanks, Yazen
WARNING: multiple messages have this Message-ID (diff)
From: Yazen Ghannam <yazen.ghannam@amd.com> To: Borislav Petkov <bp@alien8.de> Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "bp@suse.de" <bp@suse.de>, "tony.luck@intel.com" <tony.luck@intel.com>, "x86@kernel.org" <x86@kernel.org> Subject: [2/3] x86/MCE/AMD, EDAC/mce_amd: Enumerate Reserved SMCA bank type Date: Wed, 14 Feb 2018 16:28:28 +0000 [thread overview] Message-ID: <DM5PR12MB1916FC8D126DD2926F44A80BF8F50@DM5PR12MB1916.namprd12.prod.outlook.com> (raw) > -----Original Message----- > From: linux-edac-owner@vger.kernel.org [mailto:linux-edac- > owner@vger.kernel.org] On Behalf Of Borislav Petkov > Sent: Thursday, February 8, 2018 10:15 AM > To: Ghannam, Yazen <Yazen.Ghannam@amd.com> > Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; bp@suse.de; > tony.luck@intel.com; x86@kernel.org > Subject: Re: [PATCH 2/3] x86/MCE/AMD, EDAC/mce_amd: Enumerate Reserved > SMCA bank type > > On Thu, Feb 01, 2018 at 12:48:12PM -0600, Yazen Ghannam wrote: > > From: Yazen Ghannam <yazen.ghannam@amd.com> > > > > Currently, bank 4 is reserved on Fam17h, so we chose not to initialize > > bank 4 in the smca_banks array. This means that when we check if a bank > > is initialized, like during boot or resume, we will see that bank 4 is > > not initialized and try to initialize it. This may cause a call trace, > > when resuming from suspend, due to *on_cpu() calls in the init path. > > Please be more specific: the rdmsr_*_on_cpu() calls issue an IPI but we're > running with interrupts disabled, which triggers: > > WARNING: CPU: 0 PID: 11523 at kernel/smp.c:291 > smp_call_function_single+0xdc/0xe0 > Okay. ... > > @@ -433,6 +437,9 @@ static u32 get_block_address(unsigned int cpu, u32 > current_addr, u32 low, u32 hi > > u32 addr = 0, offset = 0; > > > > if (mce_flags.smca) { > > As a last patch in the series: please carve the code in this > if-statement into a smca_get_block_address() helper. And it doesn't need > the stable tag as it is only a cleanup. > Will do. Thanks, Yazen
next prev parent reply other threads:[~2018-02-14 16:28 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-01 18:48 [PATCH 1/3] x86/MCE/AMD: Redo function to get SMCA bank type Yazen Ghannam 2018-02-01 18:48 ` [1/3] " Yazen Ghannam 2018-02-01 18:48 ` [PATCH 2/3] x86/MCE/AMD, EDAC/mce_amd: Enumerate Reserved " Yazen Ghannam 2018-02-01 18:48 ` [2/3] " Yazen Ghannam 2018-02-08 15:15 ` [PATCH 2/3] " Borislav Petkov 2018-02-08 15:15 ` [2/3] " Borislav Petkov 2018-02-14 16:28 ` Ghannam, Yazen [this message] 2018-02-14 16:28 ` Yazen Ghannam 2018-02-01 18:48 ` [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block Yazen Ghannam 2018-02-01 18:48 ` [3/3] " Yazen Ghannam 2018-02-08 15:26 ` [PATCH 3/3] " Borislav Petkov 2018-02-08 15:26 ` [3/3] " Borislav Petkov 2018-04-14 0:42 ` [PATCH 3/3] " Johannes Hirte 2018-04-14 0:42 ` [3/3] " Johannes Hirte 2018-04-16 11:56 ` [PATCH 3/3] " Johannes Hirte 2018-04-16 11:56 ` [3/3] " Johannes Hirte 2018-04-17 13:31 ` [PATCH 3/3] " Ghannam, Yazen 2018-04-17 13:31 ` [3/3] " Yazen Ghannam 2018-05-15 9:39 ` [PATCH 3/3] " Johannes Hirte 2018-05-15 9:39 ` [3/3] " Johannes Hirte 2018-05-16 22:46 ` [PATCH 3/3] " Borislav Petkov 2018-05-16 22:46 ` [3/3] " Boris Petkov 2018-05-17 6:49 ` [PATCH 3/3] " Johannes Hirte 2018-05-17 6:49 ` [3/3] " Johannes Hirte 2018-05-17 10:41 ` [PATCH 3/3] " Borislav Petkov 2018-05-17 10:41 ` [3/3] " Boris Petkov 2018-05-17 13:04 ` [PATCH 3/3] " Ghannam, Yazen 2018-05-17 13:04 ` [3/3] " Yazen Ghannam 2018-05-17 13:44 ` [PATCH 3/3] " Borislav Petkov 2018-05-17 13:44 ` [3/3] " Boris Petkov 2018-05-17 14:05 ` [PATCH 3/3] " Ghannam, Yazen 2018-05-17 14:05 ` [3/3] " Yazen Ghannam 2018-05-17 18:30 ` [PATCH 1/2] x86/MCE/AMD: Cache SMCA MISC block addresses Borislav Petkov 2018-05-17 18:30 ` [1/2] " Boris Petkov 2018-05-17 18:31 ` [PATCH 2/2] x86/MCE/AMD: Read MCx_MISC block addresses on any CPU Borislav Petkov 2018-05-17 18:31 ` [2/2] " Boris Petkov 2018-05-17 19:29 ` [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block Johannes Hirte 2018-05-17 19:29 ` [3/3] " Johannes Hirte 2018-05-17 19:33 ` [PATCH 3/3] " Borislav Petkov 2018-05-17 19:33 ` [3/3] " Boris Petkov 2018-05-19 13:21 ` [tip:ras/urgent] x86/MCE/AMD: Cache SMCA MISC block addresses tip-bot for Borislav Petkov 2018-02-08 15:04 ` [PATCH 1/3] x86/MCE/AMD: Redo function to get SMCA bank type Borislav Petkov 2018-02-08 15:04 ` [1/3] " Borislav Petkov 2018-02-14 16:38 ` [PATCH 1/3] " Ghannam, Yazen 2018-02-14 16:38 ` [1/3] " Yazen Ghannam 2018-02-14 19:35 ` [PATCH 1/3] " Borislav Petkov 2018-02-14 19:35 ` [1/3] " Boris Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM5PR12MB1916FC8D126DD2926F44A80BF8F50@DM5PR12MB1916.namprd12.prod.outlook.com \ --to=yazen.ghannam@amd.com \ --cc=bp@alien8.de \ --cc=bp@suse.de \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tony.luck@intel.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.