* [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
@ 2022-09-22 1:27 ` Li Zhong
0 siblings, 0 replies; 6+ messages in thread
From: Li Zhong @ 2022-09-22 1:27 UTC (permalink / raw)
To: dri-devel, amd-gfx
Cc: jiapeng.chong, Xinhui.Pan, guchun.chen, airlied, lijo.lazar,
mario.limonciello, darren.powell, alexander.deucher, evan.quan,
christian.koenig, Li Zhong
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the
error check and propagate the error.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
index 1eb4e613b27a..ec055858eb95 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
@@ -1485,6 +1485,7 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
{
struct pp_hwmgr *hwmgr = handle;
struct amdgpu_device *adev = hwmgr->adev;
+ int err;
if (!addr || !size)
return -EINVAL;
@@ -1492,7 +1493,9 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
*addr = NULL;
*size = 0;
if (adev->pm.smu_prv_buffer) {
- amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+ err = amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+ if (err)
+ return err;
*size = adev->pm.smu_prv_buffer_size;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
@ 2022-09-22 1:27 ` Li Zhong
0 siblings, 0 replies; 6+ messages in thread
From: Li Zhong @ 2022-09-22 1:27 UTC (permalink / raw)
To: dri-devel, amd-gfx
Cc: jiapeng.chong, Xinhui.Pan, guchun.chen, airlied, lijo.lazar,
mario.limonciello, daniel, darren.powell, alexander.deucher,
evan.quan, christian.koenig, Li Zhong
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the
error check and propagate the error.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
index 1eb4e613b27a..ec055858eb95 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
@@ -1485,6 +1485,7 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
{
struct pp_hwmgr *hwmgr = handle;
struct amdgpu_device *adev = hwmgr->adev;
+ int err;
if (!addr || !size)
return -EINVAL;
@@ -1492,7 +1493,9 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
*addr = NULL;
*size = 0;
if (adev->pm.smu_prv_buffer) {
- amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+ err = amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+ if (err)
+ return err;
*size = adev->pm.smu_prv_buffer_size;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
2022-09-22 1:27 ` Li Zhong
@ 2022-09-22 2:11 ` Chen, Guchun
-1 siblings, 0 replies; 6+ messages in thread
From: Chen, Guchun @ 2022-09-22 2:11 UTC (permalink / raw)
To: Li Zhong, dri-devel, amd-gfx
Cc: jiapeng.chong, Pan, Xinhui, airlied, Lazar, Lijo, Limonciello,
Mario, Powell, Darren, Deucher, Alexander, Quan, Evan, Koenig,
Christian
Perhaps you need to update the prefix of patch subject to 'drm/amd/pm: check return value ...'.
With above addressed, it's: Acked-by: Guchun Chen <guchun.chen@amd.com>
Regards,
Guchun
-----Original Message-----
From: Li Zhong <floridsleeves@gmail.com>
Sent: Thursday, September 22, 2022 9:27 AM
To: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org
Cc: jiapeng.chong@linux.alibaba.com; Powell, Darren <Darren.Powell@amd.com>; Chen, Guchun <Guchun.Chen@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com>; daniel@ffwll.ch; airlied@linux.ie; Pan, Xinhui <Xinhui.Pan@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Li Zhong <floridsleeves@gmail.com>
Subject: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
index 1eb4e613b27a..ec055858eb95 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
@@ -1485,6 +1485,7 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size) {
struct pp_hwmgr *hwmgr = handle;
struct amdgpu_device *adev = hwmgr->adev;
+ int err;
if (!addr || !size)
return -EINVAL;
@@ -1492,7 +1493,9 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
*addr = NULL;
*size = 0;
if (adev->pm.smu_prv_buffer) {
- amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+ err = amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+ if (err)
+ return err;
*size = adev->pm.smu_prv_buffer_size;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
@ 2022-09-22 2:11 ` Chen, Guchun
0 siblings, 0 replies; 6+ messages in thread
From: Chen, Guchun @ 2022-09-22 2:11 UTC (permalink / raw)
To: Li Zhong, dri-devel, amd-gfx
Cc: jiapeng.chong, Pan, Xinhui, airlied, Lazar, Lijo, Limonciello,
Mario, daniel, Powell, Darren, Deucher, Alexander, Quan, Evan,
Koenig, Christian
Perhaps you need to update the prefix of patch subject to 'drm/amd/pm: check return value ...'.
With above addressed, it's: Acked-by: Guchun Chen <guchun.chen@amd.com>
Regards,
Guchun
-----Original Message-----
From: Li Zhong <floridsleeves@gmail.com>
Sent: Thursday, September 22, 2022 9:27 AM
To: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org
Cc: jiapeng.chong@linux.alibaba.com; Powell, Darren <Darren.Powell@amd.com>; Chen, Guchun <Guchun.Chen@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com>; daniel@ffwll.ch; airlied@linux.ie; Pan, Xinhui <Xinhui.Pan@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Li Zhong <floridsleeves@gmail.com>
Subject: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
index 1eb4e613b27a..ec055858eb95 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
@@ -1485,6 +1485,7 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size) {
struct pp_hwmgr *hwmgr = handle;
struct amdgpu_device *adev = hwmgr->adev;
+ int err;
if (!addr || !size)
return -EINVAL;
@@ -1492,7 +1493,9 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
*addr = NULL;
*size = 0;
if (adev->pm.smu_prv_buffer) {
- amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+ err = amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
+ if (err)
+ return err;
*size = adev->pm.smu_prv_buffer_size;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
2022-09-22 2:11 ` Chen, Guchun
@ 2022-09-22 4:18 ` Li Zhong
-1 siblings, 0 replies; 6+ messages in thread
From: Li Zhong @ 2022-09-22 4:18 UTC (permalink / raw)
To: Chen, Guchun
Cc: jiapeng.chong, Pan, Xinhui, airlied, dri-devel, Lazar, Lijo,
amd-gfx, Limonciello, Mario, Powell, Darren, Deucher, Alexander,
Quan, Evan, Koenig, Christian
On Wed, Sep 21, 2022 at 7:11 PM Chen, Guchun <Guchun.Chen@amd.com> wrote:
>
> Perhaps you need to update the prefix of patch subject to 'drm/amd/pm: check return value ...'.
>
> With above addressed, it's: Acked-by: Guchun Chen <guchun.chen@amd.com>
>
> Regards,
> Guchun
>
> -----Original Message-----
> From: Li Zhong <floridsleeves@gmail.com>
> Sent: Thursday, September 22, 2022 9:27 AM
> To: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org
> Cc: jiapeng.chong@linux.alibaba.com; Powell, Darren <Darren.Powell@amd.com>; Chen, Guchun <Guchun.Chen@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com>; daniel@ffwll.ch; airlied@linux.ie; Pan, Xinhui <Xinhui.Pan@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Li Zhong <floridsleeves@gmail.com>
> Subject: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
>
> amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error.
>
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> ---
> drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> index 1eb4e613b27a..ec055858eb95 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> @@ -1485,6 +1485,7 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size) {
> struct pp_hwmgr *hwmgr = handle;
> struct amdgpu_device *adev = hwmgr->adev;
> + int err;
>
> if (!addr || !size)
> return -EINVAL;
> @@ -1492,7 +1493,9 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
> *addr = NULL;
> *size = 0;
> if (adev->pm.smu_prv_buffer) {
> - amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
> + err = amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
> + if (err)
> + return err;
> *size = adev->pm.smu_prv_buffer_size;
> }
>
> --
> 2.25.1
>
Thanks for your reply! It's updated in the v2 patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
@ 2022-09-22 4:18 ` Li Zhong
0 siblings, 0 replies; 6+ messages in thread
From: Li Zhong @ 2022-09-22 4:18 UTC (permalink / raw)
To: Chen, Guchun
Cc: jiapeng.chong, Pan, Xinhui, airlied, dri-devel, Lazar, Lijo,
amd-gfx, Limonciello, Mario, daniel, Powell, Darren, Deucher,
Alexander, Quan, Evan, Koenig, Christian
On Wed, Sep 21, 2022 at 7:11 PM Chen, Guchun <Guchun.Chen@amd.com> wrote:
>
> Perhaps you need to update the prefix of patch subject to 'drm/amd/pm: check return value ...'.
>
> With above addressed, it's: Acked-by: Guchun Chen <guchun.chen@amd.com>
>
> Regards,
> Guchun
>
> -----Original Message-----
> From: Li Zhong <floridsleeves@gmail.com>
> Sent: Thursday, September 22, 2022 9:27 AM
> To: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org
> Cc: jiapeng.chong@linux.alibaba.com; Powell, Darren <Darren.Powell@amd.com>; Chen, Guchun <Guchun.Chen@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com>; daniel@ffwll.ch; airlied@linux.ie; Pan, Xinhui <Xinhui.Pan@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Li Zhong <floridsleeves@gmail.com>
> Subject: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap
>
> amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error.
>
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> ---
> drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> index 1eb4e613b27a..ec055858eb95 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> @@ -1485,6 +1485,7 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size) {
> struct pp_hwmgr *hwmgr = handle;
> struct amdgpu_device *adev = hwmgr->adev;
> + int err;
>
> if (!addr || !size)
> return -EINVAL;
> @@ -1492,7 +1493,9 @@ static int pp_get_prv_buffer_details(void *handle, void **addr, size_t *size)
> *addr = NULL;
> *size = 0;
> if (adev->pm.smu_prv_buffer) {
> - amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
> + err = amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr);
> + if (err)
> + return err;
> *size = adev->pm.smu_prv_buffer_size;
> }
>
> --
> 2.25.1
>
Thanks for your reply! It's updated in the v2 patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-22 7:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 1:27 [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap Li Zhong
2022-09-22 1:27 ` Li Zhong
2022-09-22 2:11 ` Chen, Guchun
2022-09-22 2:11 ` Chen, Guchun
2022-09-22 4:18 ` Li Zhong
2022-09-22 4:18 ` Li Zhong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.