* [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation
@ 2021-04-23 20:49 Alex Deucher
2021-04-23 20:49 ` [PATCH 2/2] drm/amdgpu/display: add documentation for dmcub_trace_event_en Alex Deucher
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alex Deucher @ 2021-04-23 20:49 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher
Add missing structure elements.
Fixes: 1ace37b873c2 ("drm/amdgpu/display: Implement functions to let DC allocate GPU memory")
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
index 77e338b3ab6b..d6a44b4fc472 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
@@ -135,6 +135,10 @@ struct amdgpu_dm_backlight_caps {
/**
* struct dal_allocation - Tracks mapped FB memory for SMU communication
+ * @list: list of dal allocations
+ * @bo: GPU buffer object
+ * @cpu_ptr: CPU virtual address of the GPU buffer object
+ * @gpu_addr: GPU virtual address of the GPU buffer object
*/
struct dal_allocation {
struct list_head list;
--
2.30.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] drm/amdgpu/display: add documentation for dmcub_trace_event_en
2021-04-23 20:49 [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation Alex Deucher
@ 2021-04-23 20:49 ` Alex Deucher
2021-04-23 21:25 ` Ma, Hanghong
2021-04-28 21:06 ` [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation Alex Deucher
2021-05-07 20:38 ` Alex Deucher
2 siblings, 1 reply; 6+ messages in thread
From: Alex Deucher @ 2021-04-23 20:49 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher
Was missing when this structure was updated.
Fixes: 4057828a1283 ("drm/amd/display: Add debugfs to control DMUB trace buffer events")
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
index d6a44b4fc472..fc13e8b6ea5c 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
@@ -168,6 +168,7 @@ struct dal_allocation {
* @compressor: Frame buffer compression buffer. See &struct dm_compressor_info
* @force_timing_sync: set via debugfs. When set, indicates that all connected
* displays will be forced to synchronize.
+ * @dmcub_trace_event_en: enable dmcub trace events
*/
struct amdgpu_display_manager {
--
2.30.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH 2/2] drm/amdgpu/display: add documentation for dmcub_trace_event_en
2021-04-23 20:49 ` [PATCH 2/2] drm/amdgpu/display: add documentation for dmcub_trace_event_en Alex Deucher
@ 2021-04-23 21:25 ` Ma, Hanghong
0 siblings, 0 replies; 6+ messages in thread
From: Ma, Hanghong @ 2021-04-23 21:25 UTC (permalink / raw)
To: Deucher, Alexander, amd-gfx; +Cc: Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only]
Hi Alex,
Thanks for adding this.
Reviewed-by: Leo (Hanghong) Ma <hanghong.ma@amd.com>
Thanks,
-Leo
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Friday, April 23, 2021 4:50 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>
Subject: [PATCH 2/2] drm/amdgpu/display: add documentation for dmcub_trace_event_en
Was missing when this structure was updated.
Fixes: 4057828a1283 ("drm/amd/display: Add debugfs to control DMUB trace buffer events")
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
index d6a44b4fc472..fc13e8b6ea5c 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
@@ -168,6 +168,7 @@ struct dal_allocation {
* @compressor: Frame buffer compression buffer. See &struct dm_compressor_info
* @force_timing_sync: set via debugfs. When set, indicates that all connected
* displays will be forced to synchronize.
+ * @dmcub_trace_event_en: enable dmcub trace events
*/
struct amdgpu_display_manager {
--
2.30.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Changhong.ma%40amd.com%7C3683db935c514d384c2508d906995b09%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637548078001885496%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=wolXr7Q7EXy6WxvDoyK5yFmPVHYZUcA27IqkS0Sli2k%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation
2021-04-23 20:49 [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation Alex Deucher
2021-04-23 20:49 ` [PATCH 2/2] drm/amdgpu/display: add documentation for dmcub_trace_event_en Alex Deucher
@ 2021-04-28 21:06 ` Alex Deucher
2021-05-07 20:38 ` Alex Deucher
2 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2021-04-28 21:06 UTC (permalink / raw)
To: Alex Deucher; +Cc: amd-gfx list
Ping?
On Fri, Apr 23, 2021 at 4:49 PM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> Add missing structure elements.
>
> Fixes: 1ace37b873c2 ("drm/amdgpu/display: Implement functions to let DC allocate GPU memory")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> index 77e338b3ab6b..d6a44b4fc472 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> @@ -135,6 +135,10 @@ struct amdgpu_dm_backlight_caps {
>
> /**
> * struct dal_allocation - Tracks mapped FB memory for SMU communication
> + * @list: list of dal allocations
> + * @bo: GPU buffer object
> + * @cpu_ptr: CPU virtual address of the GPU buffer object
> + * @gpu_addr: GPU virtual address of the GPU buffer object
> */
> struct dal_allocation {
> struct list_head list;
> --
> 2.30.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation
2021-04-23 20:49 [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation Alex Deucher
2021-04-23 20:49 ` [PATCH 2/2] drm/amdgpu/display: add documentation for dmcub_trace_event_en Alex Deucher
2021-04-28 21:06 ` [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation Alex Deucher
@ 2021-05-07 20:38 ` Alex Deucher
2021-05-10 21:48 ` Rodrigo Siqueira
2 siblings, 1 reply; 6+ messages in thread
From: Alex Deucher @ 2021-05-07 20:38 UTC (permalink / raw)
To: Alex Deucher; +Cc: amd-gfx list
Ping?
Alex
On Fri, Apr 23, 2021 at 4:49 PM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> Add missing structure elements.
>
> Fixes: 1ace37b873c2 ("drm/amdgpu/display: Implement functions to let DC allocate GPU memory")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> index 77e338b3ab6b..d6a44b4fc472 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> @@ -135,6 +135,10 @@ struct amdgpu_dm_backlight_caps {
>
> /**
> * struct dal_allocation - Tracks mapped FB memory for SMU communication
> + * @list: list of dal allocations
> + * @bo: GPU buffer object
> + * @cpu_ptr: CPU virtual address of the GPU buffer object
> + * @gpu_addr: GPU virtual address of the GPU buffer object
> */
> struct dal_allocation {
> struct list_head list;
> --
> 2.30.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation
2021-05-07 20:38 ` Alex Deucher
@ 2021-05-10 21:48 ` Rodrigo Siqueira
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira @ 2021-05-10 21:48 UTC (permalink / raw)
To: Alex Deucher; +Cc: Alex Deucher, amd-gfx list
[-- Attachment #1.1: Type: text/plain, Size: 2477 bytes --]
On 05/07, Alex Deucher wrote:
> Ping?
>
> Alex
>
> On Fri, Apr 23, 2021 at 4:49 PM Alex Deucher <alexander.deucher@amd.com> wrote:
> >
> > Add missing structure elements.
> >
> > Fixes: 1ace37b873c2 ("drm/amdgpu/display: Implement functions to let DC allocate GPU memory")
Do we need to add the Fixes tag for this patch?
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> > index 77e338b3ab6b..d6a44b4fc472 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> > @@ -135,6 +135,10 @@ struct amdgpu_dm_backlight_caps {
> >
> > /**
> > * struct dal_allocation - Tracks mapped FB memory for SMU communication
> > + * @list: list of dal allocations
> > + * @bo: GPU buffer object
> > + * @cpu_ptr: CPU virtual address of the GPU buffer object
> > + * @gpu_addr: GPU virtual address of the GPU buffer object
> > */
> > struct dal_allocation {
> > struct list_head list;
> > --
> > 2.30.2
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C85c3a4b96175482b593808d911981dde%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637560167304944436%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=UKiFJJEzAf%2BSwolov6%2Bjf51BXzqgUAV20JGdJdr%2FlDo%3D&reserved=0
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C85c3a4b96175482b593808d911981dde%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637560167304944436%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=UKiFJJEzAf%2BSwolov6%2Bjf51BXzqgUAV20JGdJdr%2FlDo%3D&reserved=0
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-10 21:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 20:49 [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation Alex Deucher
2021-04-23 20:49 ` [PATCH 2/2] drm/amdgpu/display: add documentation for dmcub_trace_event_en Alex Deucher
2021-04-23 21:25 ` Ma, Hanghong
2021-04-28 21:06 ` [PATCH 1/2] drm/amdgpu/display: fix dal_allocation documentation Alex Deucher
2021-05-07 20:38 ` Alex Deucher
2021-05-10 21:48 ` Rodrigo Siqueira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.