* [PATCH] misc: xilinx-sdfec: convert to module_platform_driver()
@ 2020-05-10 16:43 ` Harshal Chaudhari
0 siblings, 0 replies; 4+ messages in thread
From: Harshal Chaudhari @ 2020-05-10 16:43 UTC (permalink / raw)
To: gregkh
Cc: derek.kiernan, dragan.cvetic, arnd, michal.simek,
linux-arm-kernel, linux-kernel, harshalchau04
The driver init and exit function don't do anything besides registering
and unregistering the platform driver, so the module_platform_driver()
macro could just be used instead of having separate functions.
Signed-off-by: Harshal Chaudhari <harshalchau04@gmail.com>
---
drivers/misc/xilinx_sdfec.c | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
index 71bbaa56bdb5..db16a42c66f4 100644
--- a/drivers/misc/xilinx_sdfec.c
+++ b/drivers/misc/xilinx_sdfec.c
@@ -1484,25 +1484,7 @@ static struct platform_driver xsdfec_driver = {
.remove = xsdfec_remove,
};
-static int __init xsdfec_init(void)
-{
- int err;
-
- err = platform_driver_register(&xsdfec_driver);
- if (err < 0) {
- pr_err("%s Unabled to register SDFEC driver", __func__);
- return err;
- }
- return 0;
-}
-
-static void __exit xsdfec_exit(void)
-{
- platform_driver_unregister(&xsdfec_driver);
-}
-
-module_init(xsdfec_init);
-module_exit(xsdfec_exit);
+module_platform_driver(xsdfec_driver);
MODULE_AUTHOR("Xilinx, Inc");
MODULE_DESCRIPTION("Xilinx SD-FEC16 Driver");
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] misc: xilinx-sdfec: convert to module_platform_driver()
@ 2020-05-10 16:43 ` Harshal Chaudhari
0 siblings, 0 replies; 4+ messages in thread
From: Harshal Chaudhari @ 2020-05-10 16:43 UTC (permalink / raw)
To: gregkh
Cc: harshalchau04, arnd, dragan.cvetic, linux-kernel, michal.simek,
derek.kiernan, linux-arm-kernel
The driver init and exit function don't do anything besides registering
and unregistering the platform driver, so the module_platform_driver()
macro could just be used instead of having separate functions.
Signed-off-by: Harshal Chaudhari <harshalchau04@gmail.com>
---
drivers/misc/xilinx_sdfec.c | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
index 71bbaa56bdb5..db16a42c66f4 100644
--- a/drivers/misc/xilinx_sdfec.c
+++ b/drivers/misc/xilinx_sdfec.c
@@ -1484,25 +1484,7 @@ static struct platform_driver xsdfec_driver = {
.remove = xsdfec_remove,
};
-static int __init xsdfec_init(void)
-{
- int err;
-
- err = platform_driver_register(&xsdfec_driver);
- if (err < 0) {
- pr_err("%s Unabled to register SDFEC driver", __func__);
- return err;
- }
- return 0;
-}
-
-static void __exit xsdfec_exit(void)
-{
- platform_driver_unregister(&xsdfec_driver);
-}
-
-module_init(xsdfec_init);
-module_exit(xsdfec_exit);
+module_platform_driver(xsdfec_driver);
MODULE_AUTHOR("Xilinx, Inc");
MODULE_DESCRIPTION("Xilinx SD-FEC16 Driver");
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] misc: xilinx-sdfec: convert to module_platform_driver()
2020-05-10 16:43 ` Harshal Chaudhari
@ 2020-05-11 14:12 ` Dragan Cvetic
-1 siblings, 0 replies; 4+ messages in thread
From: Dragan Cvetic @ 2020-05-11 14:12 UTC (permalink / raw)
To: Harshal Chaudhari, gregkh
Cc: Derek Kiernan, arnd, Michal Simek, linux-arm-kernel, linux-kernel
> -----Original Message-----
> From: Harshal Chaudhari <harshalchau04@gmail.com>
> Sent: Sunday 10 May 2020 17:43
> To: gregkh@linuxfoundation.org
> Cc: Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic <draganc@xilinx.com>; arnd@arndb.de; Michal Simek
> <michals@xilinx.com>; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; harshalchau04@gmail.com
> Subject: [PATCH] misc: xilinx-sdfec: convert to module_platform_driver()
>
> The driver init and exit function don't do anything besides registering
> and unregistering the platform driver, so the module_platform_driver()
> macro could just be used instead of having separate functions.
>
> Signed-off-by: Harshal Chaudhari <harshalchau04@gmail.com>
> ---
> drivers/misc/xilinx_sdfec.c | 20 +-------------------
> 1 file changed, 1 insertion(+), 19 deletions(-)
>
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 71bbaa56bdb5..db16a42c66f4 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -1484,25 +1484,7 @@ static struct platform_driver xsdfec_driver = {
> .remove = xsdfec_remove,
> };
>
> -static int __init xsdfec_init(void)
> -{
> - int err;
> -
> - err = platform_driver_register(&xsdfec_driver);
> - if (err < 0) {
> - pr_err("%s Unabled to register SDFEC driver", __func__);
> - return err;
> - }
> - return 0;
> -}
> -
> -static void __exit xsdfec_exit(void)
> -{
> - platform_driver_unregister(&xsdfec_driver);
> -}
> -
> -module_init(xsdfec_init);
> -module_exit(xsdfec_exit);
> +module_platform_driver(xsdfec_driver);
>
> MODULE_AUTHOR("Xilinx, Inc");
> MODULE_DESCRIPTION("Xilinx SD-FEC16 Driver");
> --
> 2.17.1
Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Thanks
Dragan
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] misc: xilinx-sdfec: convert to module_platform_driver()
@ 2020-05-11 14:12 ` Dragan Cvetic
0 siblings, 0 replies; 4+ messages in thread
From: Dragan Cvetic @ 2020-05-11 14:12 UTC (permalink / raw)
To: Harshal Chaudhari, gregkh
Cc: Michal Simek, Derek Kiernan, linux-arm-kernel, arnd, linux-kernel
> -----Original Message-----
> From: Harshal Chaudhari <harshalchau04@gmail.com>
> Sent: Sunday 10 May 2020 17:43
> To: gregkh@linuxfoundation.org
> Cc: Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic <draganc@xilinx.com>; arnd@arndb.de; Michal Simek
> <michals@xilinx.com>; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; harshalchau04@gmail.com
> Subject: [PATCH] misc: xilinx-sdfec: convert to module_platform_driver()
>
> The driver init and exit function don't do anything besides registering
> and unregistering the platform driver, so the module_platform_driver()
> macro could just be used instead of having separate functions.
>
> Signed-off-by: Harshal Chaudhari <harshalchau04@gmail.com>
> ---
> drivers/misc/xilinx_sdfec.c | 20 +-------------------
> 1 file changed, 1 insertion(+), 19 deletions(-)
>
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 71bbaa56bdb5..db16a42c66f4 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -1484,25 +1484,7 @@ static struct platform_driver xsdfec_driver = {
> .remove = xsdfec_remove,
> };
>
> -static int __init xsdfec_init(void)
> -{
> - int err;
> -
> - err = platform_driver_register(&xsdfec_driver);
> - if (err < 0) {
> - pr_err("%s Unabled to register SDFEC driver", __func__);
> - return err;
> - }
> - return 0;
> -}
> -
> -static void __exit xsdfec_exit(void)
> -{
> - platform_driver_unregister(&xsdfec_driver);
> -}
> -
> -module_init(xsdfec_init);
> -module_exit(xsdfec_exit);
> +module_platform_driver(xsdfec_driver);
>
> MODULE_AUTHOR("Xilinx, Inc");
> MODULE_DESCRIPTION("Xilinx SD-FEC16 Driver");
> --
> 2.17.1
Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Thanks
Dragan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-11 14:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10 16:43 [PATCH] misc: xilinx-sdfec: convert to module_platform_driver() Harshal Chaudhari
2020-05-10 16:43 ` Harshal Chaudhari
2020-05-11 14:12 ` Dragan Cvetic
2020-05-11 14:12 ` Dragan Cvetic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.