[PATCH 1/1] Generate uevent on namespace AENs

[PATCH 1/1] Generate uevent on namespace AENs

[Martin Belanger]

From: Martin Belanger <martin.belanger@dell.com>

---
 drivers/nvme/host/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 2f45e8fcdd7c..bd37ddb172de 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1115,7 +1115,7 @@ EXPORT_SYMBOL_NS_GPL(nvme_execute_passthru_rq, NVME_TARGET_PASSTHRU);
 
 /*
  * Recommended frequency for KATO commands per NVMe 1.4 section 7.12.1:
- * 
+ *
  *   The host should send Keep Alive commands at half of the Keep Alive Timeout
  *   accounting for transport roundtrip times [..].
  */
@@ -4133,6 +4133,7 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
 	case NVME_AER_NOTICE_NS_CHANGED:
 		set_bit(NVME_AER_NOTICE_NS_CHANGED, &ctrl->events);
 		nvme_queue_scan(ctrl);
+		ctrl->aen_result = result;
 		break;
 	case NVME_AER_NOTICE_FW_ACT_STARTING:
 		/*
@@ -4148,6 +4149,7 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
 		if (!ctrl->ana_log_buf)
 			break;
 		queue_work(nvme_wq, &ctrl->ana_work);
+		ctrl->aen_result = result;
 		break;
 #endif
 	case NVME_AER_NOTICE_DISC_CHANGED:
-- 
2.25.1


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH 1/1] Generate uevent on namespace AENs

[Chaitanya Kulkarni]

On 4/26/21 13:41, Martin Belanger wrote:
> From: Martin Belanger <martin.belanger@dell.com>
>
> ---

Please resend the patch with proper commit description.



_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH 1/1] Generate uevent on namespace AENs

[Belanger, Martin]

Hi Chaitanya,

I'm sorry, but I'm not sure what you mean by "proper commit description". What is "improper" about the description I submitted.

Thanks,
Martin

________________________________________
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Sent: Monday, April 26, 2021 22:34
To: Martin Belanger; linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org; axboe@fb.com; hch@lst.de; sagi@grimberg.me; Belanger, Martin
Subject: Re: [PATCH 1/1] Generate uevent on namespace AENs


[EXTERNAL EMAIL]

On 4/26/21 13:41, Martin Belanger wrote:
> From: Martin Belanger <martin.belanger@dell.com>
>
> ---

Please resend the patch with proper commit description.



_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH 1/1] Generate uevent on namespace AENs

[Chaitanya Kulkarni]

On 4/27/21 05:03, Belanger, Martin wrote:
> Hi Chaitanya,
>
> I'm sorry, but I'm not sure what you mean by "proper commit description". What is "improper" about the description I submitted.
>
> Thanks,
> Martin

Commit log is as important as functionality :-

1. There is no commit log in the patch but in the cover letter.
2. Subject line doesn't involve subsystem prefix.

That is "improper" from maintainer's point of view.

For more examples see the git log and kernel documentation.



_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH 1/1] Generate uevent on namespace AENs

[Keith Busch]

On Wed, Apr 28, 2021 at 06:51:48PM +0000, Chaitanya Kulkarni wrote:
> On 4/27/21 05:03, Belanger, Martin wrote:
> > Hi Chaitanya,
> >
> > I'm sorry, but I'm not sure what you mean by "proper commit description". What is "improper" about the description I submitted.
> >
> > Thanks,
> > Martin
> 
> Commit log is as important as functionality :-
> 
> 1. There is no commit log in the patch but in the cover letter.
> 2. Subject line doesn't involve subsystem prefix.

Also need the author's "Signed-off-by:" tag on the commit.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH 1/1] Generate uevent on namespace AENs

[Chaitanya Kulkarni]

On 4/28/21 12:22, Keith Busch wrote:
> On Wed, Apr 28, 2021 at 06:51:48PM +0000, Chaitanya Kulkarni wrote:
>> On 4/27/21 05:03, Belanger, Martin wrote:
>>> Hi Chaitanya,
>>>
>>> I'm sorry, but I'm not sure what you mean by "proper commit description". What is "improper" about the description I submitted.
>>>
>>> Thanks,
>>> Martin
>> Commit log is as important as functionality :-
>>
>> 1. There is no commit log in the patch but in the cover letter.
>> 2. Subject line doesn't involve subsystem prefix.
> Also need the author's "Signed-off-by:" tag on the commit.
>

True, you need to run checkpatch.pl and make sure to fix all the warnings.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

[PATCH 1/1] Generate uevent on namespace AENs

[Martin Belanger]

From: Martin Belanger <martin.belanger@dell.com>

Generate uevent on NVMe Async Event Notifications for NS_CHANGED and ANA. Today
the uevent handler is not capturing on NVME_AER_NOTICE_NS_CHANGED
(Namespace Changed) and NVME_AER_NOTICE_ANA (Asymmetric Namespace Access).

Signed-off-by: Martin Belanger <Martin_Belanger@dell.com>


---
 drivers/nvme/host/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 2f45e8fcdd7c..bd37ddb172de 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1115,7 +1115,7 @@ EXPORT_SYMBOL_NS_GPL(nvme_execute_passthru_rq, NVME_TARGET_PASSTHRU);

 /*
  * Recommended frequency for KATO commands per NVMe 1.4 section 7.12.1:
- *
+ *
  *   The host should send Keep Alive commands at half of the Keep Alive Timeout
  *   accounting for transport roundtrip times [..].
  */
@@ -4133,6 +4133,7 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
 	case NVME_AER_NOTICE_NS_CHANGED:
 		set_bit(NVME_AER_NOTICE_NS_CHANGED, &ctrl->events);
 		nvme_queue_scan(ctrl);
+		ctrl->aen_result = result;
 		break;
 	case NVME_AER_NOTICE_FW_ACT_STARTING:
 		/*
@@ -4148,6 +4149,7 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
 		if (!ctrl->ana_log_buf)
 			break;
 		queue_work(nvme_wq, &ctrl->ana_work);
+		ctrl->aen_result = result;
 		break;
 #endif
 	case NVME_AER_NOTICE_DISC_CHANGED:
--
2.25.1


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme