* [PATCH] scsi: ufs: ufs-exynos: correct timeout value setting registers
[not found] <CGME20211018063117epcas2p28bfc50a5d793abadf37291942e139448@epcas2p2.samsung.com>
@ 2021-10-18 6:28 ` Chanho Park
2021-10-18 6:33 ` Avri Altman
2021-10-21 3:40 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Chanho Park @ 2021-10-18 6:28 UTC (permalink / raw)
To: Alim Akhtar, Avri Altman, James E . J . Bottomley,
Martin K . Petersen, Krzysztof Kozlowski
Cc: Bart Van Assche, Bean Huo, linux-scsi, linux-samsung-soc,
Chanho Park, Kiwoong Kim
PA_PWRMODEUSERDATA0 -> DL_FC0PROTTIMEOUTVAL
PA_PWRMODEUSERDATA1 -> DL_TC0REPLAYTIMEOUTVAL
PA_PWRMODEUSERDATA2 -> DL_AFC0REQTIMEOUTVAL
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Kiwoong Kim <kwmad.kim@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Fixes: a967ddb22d94 ("scsi: ufs: ufs-exynos: Apply vendor-specific values for three timeouts")
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
- Separated this patch from [1] as suggested by Avri Altman.
[1]: https://lore.kernel.org/linux-scsi/20211007080934.108804-1-chanho61.park@samsung.com/
drivers/scsi/ufs/ufs-exynos.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c
index d81a2eb894ad..226e7e64fad4 100644
--- a/drivers/scsi/ufs/ufs-exynos.c
+++ b/drivers/scsi/ufs/ufs-exynos.c
@@ -643,9 +643,9 @@ static int exynos_ufs_pre_pwr_mode(struct ufs_hba *hba,
}
/* setting for three timeout values for traffic class #0 */
- ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA0), 8064);
- ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA1), 28224);
- ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA2), 20160);
+ ufshcd_dme_set(hba, UIC_ARG_MIB(DL_FC0PROTTIMEOUTVAL), 8064);
+ ufshcd_dme_set(hba, UIC_ARG_MIB(DL_TC0REPLAYTIMEOUTVAL), 28224);
+ ufshcd_dme_set(hba, UIC_ARG_MIB(DL_AFC0REQTIMEOUTVAL), 20160);
return 0;
out:
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] scsi: ufs: ufs-exynos: correct timeout value setting registers
2021-10-18 6:28 ` [PATCH] scsi: ufs: ufs-exynos: correct timeout value setting registers Chanho Park
@ 2021-10-18 6:33 ` Avri Altman
2021-10-21 3:40 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Avri Altman @ 2021-10-18 6:33 UTC (permalink / raw)
To: Chanho Park, Alim Akhtar, James E . J . Bottomley,
Martin K . Petersen, Krzysztof Kozlowski
Cc: Bart Van Assche, Bean Huo, linux-scsi, linux-samsung-soc, Kiwoong Kim
>
> PA_PWRMODEUSERDATA0 -> DL_FC0PROTTIMEOUTVAL
> PA_PWRMODEUSERDATA1 -> DL_TC0REPLAYTIMEOUTVAL
> PA_PWRMODEUSERDATA2 -> DL_AFC0REQTIMEOUTVAL
>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Kiwoong Kim <kwmad.kim@samsung.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Fixes: a967ddb22d94 ("scsi: ufs: ufs-exynos: Apply vendor-specific values for
> three timeouts")
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
> ---
> - Separated this patch from [1] as suggested by Avri Altman.
> [1]: https://lore.kernel.org/linux-scsi/20211007080934.108804-1-
> chanho61.park@samsung.com/
>
> drivers/scsi/ufs/ufs-exynos.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index
> d81a2eb894ad..226e7e64fad4 100644
> --- a/drivers/scsi/ufs/ufs-exynos.c
> +++ b/drivers/scsi/ufs/ufs-exynos.c
> @@ -643,9 +643,9 @@ static int exynos_ufs_pre_pwr_mode(struct ufs_hba
> *hba,
> }
>
> /* setting for three timeout values for traffic class #0 */
> - ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA0), 8064);
> - ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA1),
> 28224);
> - ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA2),
> 20160);
> + ufshcd_dme_set(hba, UIC_ARG_MIB(DL_FC0PROTTIMEOUTVAL), 8064);
> + ufshcd_dme_set(hba, UIC_ARG_MIB(DL_TC0REPLAYTIMEOUTVAL),
> 28224);
> + ufshcd_dme_set(hba, UIC_ARG_MIB(DL_AFC0REQTIMEOUTVAL),
> 20160);
>
> return 0;
> out:
> --
> 2.33.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: ufs-exynos: correct timeout value setting registers
2021-10-18 6:28 ` [PATCH] scsi: ufs: ufs-exynos: correct timeout value setting registers Chanho Park
2021-10-18 6:33 ` Avri Altman
@ 2021-10-21 3:40 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-10-21 3:40 UTC (permalink / raw)
To: Krzysztof Kozlowski, Avri Altman, Alim Akhtar, Chanho Park,
James E . J . Bottomley
Cc: Martin K . Petersen, Bart Van Assche, Bean Huo,
linux-samsung-soc, linux-scsi, Kiwoong Kim
On Mon, 18 Oct 2021 15:28:41 +0900, Chanho Park wrote:
> PA_PWRMODEUSERDATA0 -> DL_FC0PROTTIMEOUTVAL
> PA_PWRMODEUSERDATA1 -> DL_TC0REPLAYTIMEOUTVAL
> PA_PWRMODEUSERDATA2 -> DL_AFC0REQTIMEOUTVAL
>
>
Applied to 5.15/scsi-fixes, thanks!
[1/1] scsi: ufs: ufs-exynos: correct timeout value setting registers
https://git.kernel.org/mkp/scsi/c/282da7cef078
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-21 3:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20211018063117epcas2p28bfc50a5d793abadf37291942e139448@epcas2p2.samsung.com>
2021-10-18 6:28 ` [PATCH] scsi: ufs: ufs-exynos: correct timeout value setting registers Chanho Park
2021-10-18 6:33 ` Avri Altman
2021-10-21 3:40 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.