[PATCH] clk: k210: Fix k210_clk_set_parent()

[PATCH] clk: k210: Fix k210_clk_set_parent()

[Damien Le Moal]

In k210_clk_set_parent(), add missing writel() call to update the mux
register of a clock to change its parent. This also fixes a compilation
warning with clang when compiling with W=1.

Fixes: c6ca7616f7d5 ("clk: Add RISC-V Canaan Kendryte K210 clock driver")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
 drivers/clk/clk-k210.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-k210.c b/drivers/clk/clk-k210.c
index 6c84abf5b2e3..67a7cb3503c3 100644
--- a/drivers/clk/clk-k210.c
+++ b/drivers/clk/clk-k210.c
@@ -722,6 +722,7 @@ static int k210_clk_set_parent(struct clk_hw *hw, u8 index)
 		reg |= BIT(cfg->mux_bit);
 	else
 		reg &= ~BIT(cfg->mux_bit);
+	writel(reg, ksc->regs + cfg->mux_reg);
 	spin_unlock_irqrestore(&ksc->clk_lock, flags);
 
 	return 0;
-- 
2.31.1

Re: [PATCH] clk: k210: Fix k210_clk_set_parent()

[Damien Le Moal]

On 2021/06/22 15:45, Damien Le Moal wrote:
> In k210_clk_set_parent(), add missing writel() call to update the mux
> register of a clock to change its parent. This also fixes a compilation
> warning with clang when compiling with W=1.
> 
> Fixes: c6ca7616f7d5 ("clk: Add RISC-V Canaan Kendryte K210 clock driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>  drivers/clk/clk-k210.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/clk-k210.c b/drivers/clk/clk-k210.c
> index 6c84abf5b2e3..67a7cb3503c3 100644
> --- a/drivers/clk/clk-k210.c
> +++ b/drivers/clk/clk-k210.c
> @@ -722,6 +722,7 @@ static int k210_clk_set_parent(struct clk_hw *hw, u8 index)
>  		reg |= BIT(cfg->mux_bit);
>  	else
>  		reg &= ~BIT(cfg->mux_bit);
> +	writel(reg, ksc->regs + cfg->mux_reg);
>  	spin_unlock_irqrestore(&ksc->clk_lock, flags);
>  
>  	return 0;
> 

Stephen,

Ping ?

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] clk: k210: Fix k210_clk_set_parent()

[Stephen Boyd]

Quoting Damien Le Moal (2021-06-21 23:45:02)
> In k210_clk_set_parent(), add missing writel() call to update the mux
> register of a clock to change its parent. This also fixes a compilation
> warning with clang when compiling with W=1.
> 
> Fixes: c6ca7616f7d5 ("clk: Add RISC-V Canaan Kendryte K210 clock driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---

Applied to clk-next

[PATCH] clk: k210: Fix k210_clk_set_parent()

[Damien Le Moal]

From: Damien Le Moal <damien.lemoal@wdc.com>

In k210_clk_set_parent(), add missing writel() call to update the mux
register of a clock to change its parent. This also fixes a compilation
warning with clang when compiling with W=1.

Fixes: c6ca7616f7d5 ("clk: Add RISC-V Canaan Kendryte K210 clock driver")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
 drivers/clk/clk-k210.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-k210.c b/drivers/clk/clk-k210.c
index 6c84abf5b2e3..67a7cb3503c3 100644
--- a/drivers/clk/clk-k210.c
+++ b/drivers/clk/clk-k210.c
@@ -722,6 +722,7 @@ static int k210_clk_set_parent(struct clk_hw *hw, u8 index)
 		reg |= BIT(cfg->mux_bit);
 	else
 		reg &= ~BIT(cfg->mux_bit);
+	writel(reg, ksc->regs + cfg->mux_reg);
 	spin_unlock_irqrestore(&ksc->clk_lock, flags);
 
 	return 0;
-- 
2.31.1