* [PATCH] libata: add horkage for ASMedia 1092
@ 2021-12-08 6:58 Hannes Reinecke
2021-12-08 10:57 ` Damien Le Moal
2021-12-09 2:22 ` Damien Le Moal
0 siblings, 2 replies; 5+ messages in thread
From: Hannes Reinecke @ 2021-12-08 6:58 UTC (permalink / raw)
To: Damien LeMoal; +Cc: linux-ide, Hannes Reinecke
The ASMedia 1092 has a configuration mode which will present a
dummy device; sadly the implementation falsely claims to provide
a device with 100M which doesn't actually exist.
So disable this device to avoid errors during boot.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/ata/libata-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 9c05177e09c2..f1a2f0a4ce05 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
{ "VRFDFC22048UCHC-TE*", NULL, ATA_HORKAGE_NODMA },
/* Odd clown on sil3726/4726 PMPs */
{ "Config Disk", NULL, ATA_HORKAGE_DISABLE },
+ /* Similar story with ASMedia 1092 */
+ { "ASMT109x- Config", NULL, ATA_HORKAGE_DISABLE },
/* Weird ATAPI devices */
{ "TORiSAN DVD-ROM DRD-N216", NULL, ATA_HORKAGE_MAX_SEC_128 },
--
2.29.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] libata: add horkage for ASMedia 1092
2021-12-08 6:58 [PATCH] libata: add horkage for ASMedia 1092 Hannes Reinecke
@ 2021-12-08 10:57 ` Damien Le Moal
2021-12-08 11:09 ` Hannes Reinecke
2021-12-09 2:22 ` Damien Le Moal
1 sibling, 1 reply; 5+ messages in thread
From: Damien Le Moal @ 2021-12-08 10:57 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: linux-ide
On 2021/12/08 15:59, Hannes Reinecke wrote:
> The ASMedia 1092 has a configuration mode which will present a
> dummy device; sadly the implementation falsely claims to provide
> a device with 100M which doesn't actually exist.
> So disable this device to avoid errors during boot.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/ata/libata-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 9c05177e09c2..f1a2f0a4ce05 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> { "VRFDFC22048UCHC-TE*", NULL, ATA_HORKAGE_NODMA },
> /* Odd clown on sil3726/4726 PMPs */
> { "Config Disk", NULL, ATA_HORKAGE_DISABLE },
> + /* Similar story with ASMedia 1092 */
> + { "ASMT109x- Config", NULL, ATA_HORKAGE_DISABLE },
>
> /* Weird ATAPI devices */
> { "TORiSAN DVD-ROM DRD-N216", NULL, ATA_HORKAGE_MAX_SEC_128 },
>
Doesn't this need a Cc stable ? I can add it.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] libata: add horkage for ASMedia 1092
2021-12-08 10:57 ` Damien Le Moal
@ 2021-12-08 11:09 ` Hannes Reinecke
0 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2021-12-08 11:09 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-ide
On 12/8/21 11:57 AM, Damien Le Moal wrote:
> On 2021/12/08 15:59, Hannes Reinecke wrote:
>> The ASMedia 1092 has a configuration mode which will present a
>> dummy device; sadly the implementation falsely claims to provide
>> a device with 100M which doesn't actually exist.
>> So disable this device to avoid errors during boot.
>>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>> ---
>> drivers/ata/libata-core.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 9c05177e09c2..f1a2f0a4ce05 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>> { "VRFDFC22048UCHC-TE*", NULL, ATA_HORKAGE_NODMA },
>> /* Odd clown on sil3726/4726 PMPs */
>> { "Config Disk", NULL, ATA_HORKAGE_DISABLE },
>> + /* Similar story with ASMedia 1092 */
>> + { "ASMT109x- Config", NULL, ATA_HORKAGE_DISABLE },
>>
>> /* Weird ATAPI devices */
>> { "TORiSAN DVD-ROM DRD-N216", NULL, ATA_HORKAGE_MAX_SEC_128 },
>>
>
> Doesn't this need a Cc stable ? I can add it.
>
Possibly; device has never worked properly.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libata: add horkage for ASMedia 1092
2021-12-08 6:58 [PATCH] libata: add horkage for ASMedia 1092 Hannes Reinecke
2021-12-08 10:57 ` Damien Le Moal
@ 2021-12-09 2:22 ` Damien Le Moal
1 sibling, 0 replies; 5+ messages in thread
From: Damien Le Moal @ 2021-12-09 2:22 UTC (permalink / raw)
To: Hannes Reinecke, Damien LeMoal; +Cc: linux-ide
On 2021/12/08 15:58, Hannes Reinecke wrote:
> The ASMedia 1092 has a configuration mode which will present a
> dummy device; sadly the implementation falsely claims to provide
> a device with 100M which doesn't actually exist.
> So disable this device to avoid errors during boot.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/ata/libata-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 9c05177e09c2..f1a2f0a4ce05 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> { "VRFDFC22048UCHC-TE*", NULL, ATA_HORKAGE_NODMA },
> /* Odd clown on sil3726/4726 PMPs */
> { "Config Disk", NULL, ATA_HORKAGE_DISABLE },
> + /* Similar story with ASMedia 1092 */
> + { "ASMT109x- Config", NULL, ATA_HORKAGE_DISABLE },
>
> /* Weird ATAPI devices */
> { "TORiSAN DVD-ROM DRD-N216", NULL, ATA_HORKAGE_MAX_SEC_128 },
>
Applied to for-5.16-fixes with CC stable added.
Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] libata: add horkage for ASMedia 1092
@ 2020-02-05 8:29 Hannes Reinecke
0 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2020-02-05 8:29 UTC (permalink / raw)
To: Jens Axboe
Cc: Bartolomiej Zolnierkiewicz, linux-ide, Linux Kernel Mailinglist,
Hannes Reinecke, Hannes Reinecke
The ASMedia 1092 has a configuration mode which will present a
dummy device; sadly the implementation falsely claims to provide
a device with 100M which doesn't actually exist.
So disable this device to avoid errors during boot.
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
drivers/ata/libata-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 9c05177e09c2..f1a2f0a4ce05 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4416,6 +4416,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
{ "VRFDFC22048UCHC-TE*", NULL, ATA_HORKAGE_NODMA },
/* Odd clown on sil3726/4726 PMPs */
{ "Config Disk", NULL, ATA_HORKAGE_DISABLE },
+ /* Similar story with ASMedia 1092 */
+ { "ASMT109x- Config", NULL, ATA_HORKAGE_DISABLE },
/* Weird ATAPI devices */
{ "TORiSAN DVD-ROM DRD-N216", NULL, ATA_HORKAGE_MAX_SEC_128 },
--
2.16.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-09 2:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08 6:58 [PATCH] libata: add horkage for ASMedia 1092 Hannes Reinecke
2021-12-08 10:57 ` Damien Le Moal
2021-12-08 11:09 ` Hannes Reinecke
2021-12-09 2:22 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2020-02-05 8:29 Hannes Reinecke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.