* [Intel-xe] [PATCH 0/3] drm/xe: Cleanup for addressing vga decode
@ 2023-10-05 13:59 Uma Shankar
2023-10-05 13:59 ` [Intel-xe] [PATCH 1/3] Revert "FIXME: drm/i915/vga: disable vga set decode for xe" Uma Shankar
` (6 more replies)
0 siblings, 7 replies; 12+ messages in thread
From: Uma Shankar @ 2023-10-05 13:59 UTC (permalink / raw)
To: intel-xe; +Cc: jani.nikula, arun.r.murthy
This series implements exclusive version of vga decode for i915
and xe. It reverts the FIXME with #ifdefs.
Currently the xe verison is a place holder, will be addressed
once the i915 display changes are re-worked in upstream.
Uma Shankar (3):
Revert "FIXME: drm/i915/vga: disable vga set decode for xe"
drm/i915/display: Created exclusive version of vga decode setup
drm/xe: Create a dummy version for vga decode
drivers/gpu/drm/i915/display/intel_vga.c | 22 +-------------------
drivers/gpu/drm/i915/soc/intel_gmch.c | 14 +++++++++++++
drivers/gpu/drm/i915/soc/intel_gmch.h | 2 ++
drivers/gpu/drm/xe/Makefile | 1 +
drivers/gpu/drm/xe/display/xe_display_misc.c | 13 ++++++++++++
5 files changed, 31 insertions(+), 21 deletions(-)
create mode 100644 drivers/gpu/drm/xe/display/xe_display_misc.c
--
2.42.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-xe] [PATCH 1/3] Revert "FIXME: drm/i915/vga: disable vga set decode for xe"
2023-10-05 13:59 [Intel-xe] [PATCH 0/3] drm/xe: Cleanup for addressing vga decode Uma Shankar
@ 2023-10-05 13:59 ` Uma Shankar
2023-10-06 3:20 ` Murthy, Arun R
2023-10-05 13:59 ` [Intel-xe] [PATCH 2/3] drm/i915/display: Created exclusive version of vga decode setup Uma Shankar
` (5 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: Uma Shankar @ 2023-10-05 13:59 UTC (permalink / raw)
To: intel-xe; +Cc: jani.nikula, arun.r.murthy
This reverts commit 28da6179478e3f29cb27df30b71f68b904dfff26.
This will be addressed with an exclusive version for xe.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/i915/display/intel_vga.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c
index 42da1a038042..286a0bdd28c6 100644
--- a/drivers/gpu/drm/i915/display/intel_vga.c
+++ b/drivers/gpu/drm/i915/display/intel_vga.c
@@ -102,7 +102,6 @@ void intel_vga_reset_io_mem(struct drm_i915_private *i915)
static unsigned int
intel_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
{
-#ifdef I915
struct drm_i915_private *i915 = pdev_to_i915(pdev);
intel_gmch_vga_set_state(i915, enable_decode);
@@ -112,9 +111,6 @@ intel_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
else
return VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
-#else
- return -EIO;
-#endif
}
int intel_vga_register(struct drm_i915_private *i915)
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-xe] [PATCH 2/3] drm/i915/display: Created exclusive version of vga decode setup
2023-10-05 13:59 [Intel-xe] [PATCH 0/3] drm/xe: Cleanup for addressing vga decode Uma Shankar
2023-10-05 13:59 ` [Intel-xe] [PATCH 1/3] Revert "FIXME: drm/i915/vga: disable vga set decode for xe" Uma Shankar
@ 2023-10-05 13:59 ` Uma Shankar
2023-10-06 3:21 ` Murthy, Arun R
2023-10-05 13:59 ` [Intel-xe] [PATCH 3/3] drm/xe: Create a dummy version for vga decode Uma Shankar
` (4 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: Uma Shankar @ 2023-10-05 13:59 UTC (permalink / raw)
To: intel-xe; +Cc: jani.nikula, arun.r.murthy
Current vga arbiter implementation in i915 needs a re-design.
The current approach would cause real problems if anyone actually
needs to talk another GPU using legacy VGA resources.
The main issue is that X becomes a slideshow if it thinks there
are multiple GPUs that have VGA decoding enabled as it insists
on adjusting the VGA routing pretty much for every little operation
involving any of the GPUs.
The cleanup will be planned for i915. Meanwhile to focus on Xe
upstreaming and have a cleaner separation, the said functionality
is being moved to a different file exclusive for i915. Xe driver
will re-use rest of the display code from i915.
v2: Addressed Jani Nikula's review comments.
v3: Dropped a duplicate function (Jani)
v4: Updated commit message with reasoning as sugested by Ville.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230929074306.1533859-1-uma.shankar@intel.com
(cherry picked from commit 5846cdfd3d58852cdc991e589de7535151a47a4e)
---
drivers/gpu/drm/i915/display/intel_vga.c | 18 +-----------------
drivers/gpu/drm/i915/soc/intel_gmch.c | 14 ++++++++++++++
drivers/gpu/drm/i915/soc/intel_gmch.h | 2 ++
3 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c
index 286a0bdd28c6..4b98833bfa8c 100644
--- a/drivers/gpu/drm/i915/display/intel_vga.c
+++ b/drivers/gpu/drm/i915/display/intel_vga.c
@@ -3,11 +3,9 @@
* Copyright © 2019 Intel Corporation
*/
-#include <linux/pci.h>
#include <linux/vgaarb.h>
#include <video/vga.h>
-
#include "soc/intel_gmch.h"
#include "i915_drv.h"
@@ -99,20 +97,6 @@ void intel_vga_reset_io_mem(struct drm_i915_private *i915)
vga_put(pdev, VGA_RSRC_LEGACY_IO);
}
-static unsigned int
-intel_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
-{
- struct drm_i915_private *i915 = pdev_to_i915(pdev);
-
- intel_gmch_vga_set_state(i915, enable_decode);
-
- if (enable_decode)
- return VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM |
- VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
- else
- return VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
-}
-
int intel_vga_register(struct drm_i915_private *i915)
{
@@ -127,7 +111,7 @@ int intel_vga_register(struct drm_i915_private *i915)
* then we do not take part in VGA arbitration and the
* vga_client_register() fails with -ENODEV.
*/
- ret = vga_client_register(pdev, intel_vga_set_decode);
+ ret = vga_client_register(pdev, intel_gmch_vga_set_decode);
if (ret && ret != -ENODEV)
return ret;
diff --git a/drivers/gpu/drm/i915/soc/intel_gmch.c b/drivers/gpu/drm/i915/soc/intel_gmch.c
index 49c7fb16e934..f32e9f78770a 100644
--- a/drivers/gpu/drm/i915/soc/intel_gmch.c
+++ b/drivers/gpu/drm/i915/soc/intel_gmch.c
@@ -5,6 +5,7 @@
#include <linux/pci.h>
#include <linux/pnp.h>
+#include <linux/vgaarb.h>
#include <drm/drm_managed.h>
#include <drm/i915_drm.h>
@@ -167,3 +168,16 @@ int intel_gmch_vga_set_state(struct drm_i915_private *i915, bool enable_decode)
return 0;
}
+
+unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
+{
+ struct drm_i915_private *i915 = pdev_to_i915(pdev);
+
+ intel_gmch_vga_set_state(i915, enable_decode);
+
+ if (enable_decode)
+ return VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM |
+ VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
+ else
+ return VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
+}
diff --git a/drivers/gpu/drm/i915/soc/intel_gmch.h b/drivers/gpu/drm/i915/soc/intel_gmch.h
index d0133eedc720..23be2d113afd 100644
--- a/drivers/gpu/drm/i915/soc/intel_gmch.h
+++ b/drivers/gpu/drm/i915/soc/intel_gmch.h
@@ -8,11 +8,13 @@
#include <linux/types.h>
+struct pci_dev;
struct drm_i915_private;
int intel_gmch_bridge_setup(struct drm_i915_private *i915);
void intel_gmch_bar_setup(struct drm_i915_private *i915);
void intel_gmch_bar_teardown(struct drm_i915_private *i915);
int intel_gmch_vga_set_state(struct drm_i915_private *i915, bool enable_decode);
+unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode);
#endif /* __INTEL_GMCH_H__ */
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-xe] [PATCH 3/3] drm/xe: Create a dummy version for vga decode
2023-10-05 13:59 [Intel-xe] [PATCH 0/3] drm/xe: Cleanup for addressing vga decode Uma Shankar
2023-10-05 13:59 ` [Intel-xe] [PATCH 1/3] Revert "FIXME: drm/i915/vga: disable vga set decode for xe" Uma Shankar
2023-10-05 13:59 ` [Intel-xe] [PATCH 2/3] drm/i915/display: Created exclusive version of vga decode setup Uma Shankar
@ 2023-10-05 13:59 ` Uma Shankar
2023-10-06 3:26 ` Murthy, Arun R
2023-10-05 14:31 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Cleanup for addressing " Patchwork
` (3 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: Uma Shankar @ 2023-10-05 13:59 UTC (permalink / raw)
To: intel-xe; +Cc: jani.nikula, arun.r.murthy
This implements an exclusive version of vga decode for xe.
Rest of the display changes will be re-used from i915.
Currently it adds just a dummy implementation. VGA decode
needs to be handled correctly in i915, proper implementation
will be adopted once the i915 changes are finalized and merged
upstream.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/xe/Makefile | 1 +
drivers/gpu/drm/xe/display/xe_display_misc.c | 13 +++++++++++++
2 files changed, 14 insertions(+)
create mode 100644 drivers/gpu/drm/xe/display/xe_display_misc.c
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index dff1386ee6b3..175a357366d9 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -150,6 +150,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
display/xe_hdcp_gsc.o \
display/xe_plane_initial.o \
display/xe_display_rps.o \
+ display/xe_display_misc.o \
display/ext/i915_irq.o \
display/ext/i915_utils.o
diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c b/drivers/gpu/drm/xe/display/xe_display_misc.c
new file mode 100644
index 000000000000..4f2392f911ce
--- /dev/null
+++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
@@ -0,0 +1,13 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#include "intel_display_types.h"
+
+struct pci_dev;
+
+unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
+{
+ return 0;
+}
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Cleanup for addressing vga decode
2023-10-05 13:59 [Intel-xe] [PATCH 0/3] drm/xe: Cleanup for addressing vga decode Uma Shankar
` (2 preceding siblings ...)
2023-10-05 13:59 ` [Intel-xe] [PATCH 3/3] drm/xe: Create a dummy version for vga decode Uma Shankar
@ 2023-10-05 14:31 ` Patchwork
2023-10-05 14:32 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-10-05 14:31 UTC (permalink / raw)
To: Uma Shankar; +Cc: intel-xe
== Series Details ==
Series: drm/xe: Cleanup for addressing vga decode
URL : https://patchwork.freedesktop.org/series/124660/
State : success
== Summary ==
=== Applying kernel patches on branch 'drm-xe-next' with base: ===
Base commit: 3d2b298aa fixup! FIXME: drm/i915/display: Remaining changes to make xe compile
=== git am output follows ===
Applying: Revert "FIXME: drm/i915/vga: disable vga set decode for xe"
Applying: drm/i915/display: Created exclusive version of vga decode setup
Applying: drm/xe: Create a dummy version for vga decode
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Cleanup for addressing vga decode
2023-10-05 13:59 [Intel-xe] [PATCH 0/3] drm/xe: Cleanup for addressing vga decode Uma Shankar
` (3 preceding siblings ...)
2023-10-05 14:31 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Cleanup for addressing " Patchwork
@ 2023-10-05 14:32 ` Patchwork
2023-10-05 14:33 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-05 15:19 ` [Intel-xe] ✓ CI.BAT: " Patchwork
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-10-05 14:32 UTC (permalink / raw)
To: Uma Shankar; +Cc: intel-xe
== Series Details ==
Series: drm/xe: Cleanup for addressing vga decode
URL : https://patchwork.freedesktop.org/series/124660/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 7d7d25bfc45d690033b2ca87fc0616cbacec0b92
Author: Uma Shankar <uma.shankar@intel.com>
Date: Thu Oct 5 19:29:17 2023 +0530
drm/xe: Create a dummy version for vga decode
This implements an exclusive version of vga decode for xe.
Rest of the display changes will be re-used from i915.
Currently it adds just a dummy implementation. VGA decode
needs to be handled correctly in i915, proper implementation
will be adopted once the i915 changes are finalized and merged
upstream.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
+ /mt/dim checkpatch 3d2b298aaf52e74d4e90470cd65de047362e4875 drm-intel
abfe54e02 Revert "FIXME: drm/i915/vga: disable vga set decode for xe"
-:6: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '28da6179478e3f29cb27df30b71f68b904dfff26', maybe rebased or not pulled?
#6:
This reverts commit 28da6179478e3f29cb27df30b71f68b904dfff26.
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
984b02774 drm/i915/display: Created exclusive version of vga decode setup
7d7d25bfc drm/xe: Create a dummy version for vga decode
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 20 lines checked
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-xe] ✓ CI.KUnit: success for drm/xe: Cleanup for addressing vga decode
2023-10-05 13:59 [Intel-xe] [PATCH 0/3] drm/xe: Cleanup for addressing vga decode Uma Shankar
` (4 preceding siblings ...)
2023-10-05 14:32 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
@ 2023-10-05 14:33 ` Patchwork
2023-10-05 15:19 ` [Intel-xe] ✓ CI.BAT: " Patchwork
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-10-05 14:33 UTC (permalink / raw)
To: Uma Shankar; +Cc: intel-xe
== Series Details ==
Series: drm/xe: Cleanup for addressing vga decode
URL : https://patchwork.freedesktop.org/series/124660/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
stty: 'standard input': Inappropriate ioctl for device
[14:32:09] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:32:13] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make ARCH=um O=.kunit --jobs=48
[14:32:33] Starting KUnit Kernel (1/1)...
[14:32:33] ============================================================
[14:32:34] ========================== xe_bo ==========================
[14:32:34] [SKIPPED] xe_ccs_migrate_kunit
[14:32:34] [SKIPPED] xe_bo_evict_kunit
[14:32:34] ===================== [SKIPPED] xe_bo ======================
[14:32:34] ======================= xe_dma_buf ========================
[14:32:34] [SKIPPED] xe_dma_buf_kunit
[14:32:34] =================== [SKIPPED] xe_dma_buf ===================
[14:32:34] ======================= xe_migrate ========================
[14:32:34] [SKIPPED] xe_migrate_sanity_kunit
[14:32:34] =================== [SKIPPED] xe_migrate ===================
[14:32:34] ========================= xe_pci ==========================
[14:32:34] [PASSED] xe_gmdid_graphics_ip
[14:32:34] [PASSED] xe_gmdid_media_ip
[14:32:34] ===================== [PASSED] xe_pci ======================
[14:32:34] ========================= xe_rtp ==========================
[14:32:34] ================== xe_rtp_process_tests ===================
[14:32:34] [PASSED] coalesce-same-reg
[14:32:34] [PASSED] no-match-no-add
[14:32:34] [PASSED] no-match-no-add-multiple-rules
[14:32:34] [PASSED] two-regs-two-entries
[14:32:34] [PASSED] clr-one-set-other
[14:32:34] [PASSED] set-field
[14:32:34] [PASSED] conflict-duplicate
[14:32:34] [PASSED] conflict-not-disjoint
[14:32:34] [PASSED] conflict-reg-type
[14:32:34] ============== [PASSED] xe_rtp_process_tests ===============
[14:32:34] ===================== [PASSED] xe_rtp ======================
[14:32:34] ========================== xe_wa ==========================
[14:32:34] ======================== xe_wa_gt =========================
[14:32:34] [PASSED] TIGERLAKE (B0)
[14:32:34] [PASSED] DG1 (A0)
[14:32:34] [PASSED] DG1 (B0)
[14:32:34] [PASSED] ALDERLAKE_S (A0)
[14:32:34] [PASSED] ALDERLAKE_S (B0)
[14:32:34] [PASSED] ALDERLAKE_S (C0)
[14:32:34] [PASSED] ALDERLAKE_S (D0)
[14:32:34] [PASSED] ALDERLAKE_P (A0)
[14:32:34] [PASSED] ALDERLAKE_P (B0)
[14:32:34] [PASSED] ALDERLAKE_P (C0)
[14:32:34] [PASSED] DG2_G10 (A0)
[14:32:34] [PASSED] DG2_G10 (A1)
[14:32:34] [PASSED] DG2_G10 (B0)
[14:32:34] [PASSED] DG2_G10 (C0)
[14:32:34] [PASSED] DG2_G11 (A0)
[14:32:34] [PASSED] DG2_G11 (B0)
[14:32:34] [PASSED] DG2_G11 (B1)
[14:32:34] [PASSED] DG2_G12 (A0)
[14:32:34] [PASSED] DG2_G12 (A1)
[14:32:34] [PASSED] PVC (B0)
[14:32:34] [PASSED] PVC (B1)
[14:32:34] [PASSED] PVC (C0)
[14:32:34] ==================== [PASSED] xe_wa_gt =====================
[14:32:34] ====================== [PASSED] xe_wa ======================
[14:32:34] ============================================================
[14:32:34] Testing complete. Ran 37 tests: passed: 33, skipped: 4
[14:32:34] Elapsed time: 24.651s total, 4.193s configuring, 20.339s building, 0.097s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[14:32:34] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:32:35] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make ARCH=um O=.kunit --jobs=48
[14:32:55] Starting KUnit Kernel (1/1)...
[14:32:55] ============================================================
[14:32:55] ================== drm_test_pick_cmdline ==================
[14:32:55] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[14:32:55] =============== drm_test_pick_cmdline_named ===============
[14:32:55] [PASSED] NTSC
[14:32:55] [PASSED] NTSC-J
[14:32:55] [PASSED] PAL
[14:32:55] [PASSED] PAL-M
[14:32:55] =========== [PASSED] drm_test_pick_cmdline_named ===========
[14:32:55] ============== [PASSED] drm_test_pick_cmdline ==============
[14:32:55] ======================== drm_buddy ========================
[14:32:55] [PASSED] drm_test_buddy_alloc_limit
[14:32:55] [PASSED] drm_test_buddy_alloc_range
[14:32:55] [PASSED] drm_test_buddy_alloc_optimistic
[14:32:55] [PASSED] drm_test_buddy_alloc_pessimistic
[14:32:55] [PASSED] drm_test_buddy_alloc_smoke
[14:32:55] [PASSED] drm_test_buddy_alloc_pathological
[14:32:55] ==================== [PASSED] drm_buddy ====================
[14:32:55] =================== drm_cmdline_parser ====================
[14:32:55] [PASSED] drm_test_cmdline_force_d_only
[14:32:55] [PASSED] drm_test_cmdline_force_D_only_dvi
[14:32:55] [PASSED] drm_test_cmdline_force_D_only_hdmi
[14:32:55] [PASSED] drm_test_cmdline_force_D_only_not_digital
[14:32:55] [PASSED] drm_test_cmdline_force_e_only
[14:32:55] [PASSED] drm_test_cmdline_res
[14:32:55] [PASSED] drm_test_cmdline_res_vesa
[14:32:55] [PASSED] drm_test_cmdline_res_vesa_rblank
[14:32:55] [PASSED] drm_test_cmdline_res_rblank
[14:32:55] [PASSED] drm_test_cmdline_res_bpp
[14:32:55] [PASSED] drm_test_cmdline_res_refresh
[14:32:55] [PASSED] drm_test_cmdline_res_bpp_refresh
[14:32:55] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[14:32:55] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[14:32:55] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[14:32:55] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[14:32:55] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[14:32:55] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[14:32:55] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[14:32:55] [PASSED] drm_test_cmdline_res_margins_force_on
[14:32:55] [PASSED] drm_test_cmdline_res_vesa_margins
[14:32:55] [PASSED] drm_test_cmdline_name
[14:32:55] [PASSED] drm_test_cmdline_name_bpp
[14:32:55] [PASSED] drm_test_cmdline_name_option
[14:32:55] [PASSED] drm_test_cmdline_name_bpp_option
[14:32:55] [PASSED] drm_test_cmdline_rotate_0
[14:32:55] [PASSED] drm_test_cmdline_rotate_90
[14:32:55] [PASSED] drm_test_cmdline_rotate_180
[14:32:55] [PASSED] drm_test_cmdline_rotate_270
[14:32:55] [PASSED] drm_test_cmdline_hmirror
[14:32:55] [PASSED] drm_test_cmdline_vmirror
[14:32:55] [PASSED] drm_test_cmdline_margin_options
[14:32:55] [PASSED] drm_test_cmdline_multiple_options
[14:32:55] [PASSED] drm_test_cmdline_bpp_extra_and_option
[14:32:55] [PASSED] drm_test_cmdline_extra_and_option
[14:32:55] [PASSED] drm_test_cmdline_freestanding_options
[14:32:55] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[14:32:55] [PASSED] drm_test_cmdline_panel_orientation
[14:32:55] ================ drm_test_cmdline_invalid =================
[14:32:55] [PASSED] margin_only
[14:32:55] [PASSED] interlace_only
[14:32:55] [PASSED] res_missing_x
[14:32:55] [PASSED] res_missing_y
[14:32:55] [PASSED] res_bad_y
[14:32:55] [PASSED] res_missing_y_bpp
[14:32:55] [PASSED] res_bad_bpp
[14:32:55] [PASSED] res_bad_refresh
[14:32:55] [PASSED] res_bpp_refresh_force_on_off
[14:32:55] [PASSED] res_invalid_mode
[14:32:55] [PASSED] res_bpp_wrong_place_mode
[14:32:55] [PASSED] name_bpp_refresh
[14:32:55] [PASSED] name_refresh
[14:32:55] [PASSED] name_refresh_wrong_mode
[14:32:55] [PASSED] name_refresh_invalid_mode
[14:32:55] [PASSED] rotate_multiple
[14:32:55] [PASSED] rotate_invalid_val
[14:32:55] [PASSED] rotate_truncated
[14:32:55] [PASSED] invalid_option
[14:32:55] [PASSED] invalid_tv_option
[14:32:55] [PASSED] truncated_tv_option
[14:32:55] ============ [PASSED] drm_test_cmdline_invalid =============
[14:32:55] =============== drm_test_cmdline_tv_options ===============
[14:32:55] [PASSED] NTSC
[14:32:55] [PASSED] NTSC_443
[14:32:55] [PASSED] NTSC_J
[14:32:55] [PASSED] PAL
[14:32:55] [PASSED] PAL_M
[14:32:55] [PASSED] PAL_N
[14:32:55] [PASSED] SECAM
[14:32:55] =========== [PASSED] drm_test_cmdline_tv_options ===========
[14:32:55] =============== [PASSED] drm_cmdline_parser ================
[14:32:55] ================ drm_get_tv_mode_from_name ================
[14:32:55] ========== drm_test_get_tv_mode_from_name_valid ===========
[14:32:55] [PASSED] NTSC
[14:32:55] [PASSED] NTSC-443
[14:32:55] [PASSED] NTSC-J
[14:32:55] [PASSED] PAL
[14:32:55] [PASSED] PAL-M
[14:32:55] [PASSED] PAL-N
[14:32:55] [PASSED] SECAM
[14:32:55] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[14:32:55] [PASSED] drm_test_get_tv_mode_from_name_truncated
[14:32:55] ============ [PASSED] drm_get_tv_mode_from_name ============
[14:32:55] ==================== drm_damage_helper ====================
[14:32:55] [PASSED] drm_test_damage_iter_no_damage
[14:32:55] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[14:32:55] [PASSED] drm_test_damage_iter_no_damage_src_moved
[14:32:55] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[14:32:55] [PASSED] drm_test_damage_iter_no_damage_not_visible
[14:32:55] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[14:32:55] [PASSED] drm_test_damage_iter_no_damage_no_fb
[14:32:55] [PASSED] drm_test_damage_iter_simple_damage
[14:32:55] [PASSED] drm_test_damage_iter_single_damage
[14:32:55] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[14:32:55] [PASSED] drm_test_damage_iter_single_damage_outside_src
[14:32:55] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[14:32:55] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[14:32:55] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[14:32:55] [PASSED] drm_test_damage_iter_single_damage_src_moved
[14:32:55] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[14:32:55] [PASSED] drm_test_damage_iter_damage
[14:32:55] [PASSED] drm_test_damage_iter_damage_one_intersect
[14:32:55] [PASSED] drm_test_damage_iter_damage_one_outside
[14:32:55] [PASSED] drm_test_damage_iter_damage_src_moved
[14:32:55] [PASSED] drm_test_damage_iter_damage_not_visible
[14:32:55] ================ [PASSED] drm_damage_helper ================
[14:32:55] ==================== drm_dp_mst_helper ====================
[14:32:55] ============== drm_test_dp_mst_calc_pbn_mode ==============
[14:32:55] [PASSED] Clock 154000 BPP 30 DSC disabled
[14:32:55] [PASSED] Clock 234000 BPP 30 DSC disabled
[14:32:55] [PASSED] Clock 297000 BPP 24 DSC disabled
[14:32:55] [PASSED] Clock 332880 BPP 24 DSC enabled
[14:32:55] [PASSED] Clock 324540 BPP 24 DSC enabled
[14:32:55] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[14:32:55] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[14:32:55] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[14:32:55] [PASSED] DP_POWER_UP_PHY with port number
[14:32:55] [PASSED] DP_POWER_DOWN_PHY with port number
[14:32:55] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[14:32:55] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[14:32:55] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[14:32:55] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[14:32:55] [PASSED] DP_QUERY_PAYLOAD with port number
[14:32:55] [PASSED] DP_QUERY_PAYLOAD with VCPI
[14:32:55] [PASSED] DP_REMOTE_DPCD_READ with port number
[14:32:55] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[14:32:55] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[14:32:55] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[14:32:55] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[14:32:55] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[14:32:55] [PASSED] DP_REMOTE_I2C_READ with port number
[14:32:55] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[14:32:55] [PASSED] DP_REMOTE_I2C_READ with transactions array
[14:32:55] [PASSED] DP_REMOTE_I2C_WRITE with port number
[14:32:55] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[14:32:55] [PASSED] DP_REMOTE_I2C_WRITE with data array
[14:32:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[14:32:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[14:32:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[14:32:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[14:32:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[14:32:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[14:32:55] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[14:32:55] ================ [PASSED] drm_dp_mst_helper ================
[14:32:55] ================= drm_format_helper_test ==================
[14:32:55] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[14:32:55] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[14:32:55] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[14:32:55] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[14:32:55] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[14:32:55] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[14:32:55] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[14:32:55] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[14:32:55] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[14:32:55] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[14:32:55] ============== drm_test_fb_xrgb8888_to_mono ===============
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[14:32:55] ==================== drm_test_fb_swab =====================
[14:32:55] [PASSED] single_pixel_source_buffer
[14:32:55] [PASSED] single_pixel_clip_rectangle
[14:32:55] [PASSED] well_known_colors
[14:32:55] [PASSED] destination_pitch
[14:32:55] ================ [PASSED] drm_test_fb_swab =================
[14:32:55] ================= drm_test_fb_clip_offset =================
[14:32:55] [PASSED] pass through
[14:32:55] [PASSED] horizontal offset
[14:32:55] [PASSED] vertical offset
[14:32:55] [PASSED] horizontal and vertical offset
[14:32:55] [PASSED] horizontal offset (custom pitch)
[14:32:55] [PASSED] vertical offset (custom pitch)
[14:32:55] [PASSED] horizontal and vertical offset (custom pitch)
[14:32:55] ============= [PASSED] drm_test_fb_clip_offset =============
[14:32:55] ============== drm_test_fb_build_fourcc_list ==============
[14:32:55] [PASSED] no native formats
[14:32:55] [PASSED] XRGB8888 as native format
[14:32:55] [PASSED] remove duplicates
[14:32:55] [PASSED] convert alpha formats
[14:32:55] [PASSED] random formats
[14:32:55] ========== [PASSED] drm_test_fb_build_fourcc_list ==========
[14:32:55] =================== drm_test_fb_memcpy ====================
[14:32:55] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[14:32:55] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[14:32:55] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[14:32:55] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[14:32:55] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[14:32:55] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[14:32:55] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[14:32:55] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[14:32:55] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[14:32:55] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[14:32:55] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[14:32:55] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[14:32:55] =============== [PASSED] drm_test_fb_memcpy ================
[14:32:55] ============= [PASSED] drm_format_helper_test ==============
[14:32:55] ======================= drm_format ========================
[14:32:55] [PASSED] drm_test_format_block_width_invalid
[14:32:55] [PASSED] drm_test_format_block_width_one_plane
[14:32:55] [PASSED] drm_test_format_block_width_two_plane
[14:32:55] [PASSED] drm_test_format_block_width_three_plane
[14:32:55] [PASSED] drm_test_format_block_width_tiled
[14:32:55] [PASSED] drm_test_format_block_height_invalid
[14:32:55] [PASSED] drm_test_format_block_height_one_plane
[14:32:55] [PASSED] drm_test_format_block_height_two_plane
[14:32:55] [PASSED] drm_test_format_block_height_three_plane
[14:32:55] [PASSED] drm_test_format_block_height_tiled
[14:32:55] [PASSED] drm_test_format_min_pitch_invalid
[14:32:55] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[14:32:55] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[14:32:55] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[14:32:55] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[14:32:55] [PASSED] drm_test_format_min_pitch_two_plane
[14:32:55] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[14:32:55] [PASSED] drm_test_format_min_pitch_tiled
[14:32:55] =================== [PASSED] drm_format ====================
[14:32:55] ===================== drm_framebuffer =====================
[14:32:55] =============== drm_test_framebuffer_create ===============
[14:32:55] [PASSED] ABGR8888 normal sizes
[14:32:55] [PASSED] ABGR8888 max sizes
[14:32:55] [PASSED] ABGR8888 pitch greater than min required
[14:32:55] [PASSED] ABGR8888 pitch less than min required
[14:32:55] [PASSED] ABGR8888 Invalid width
[14:32:55] [PASSED] ABGR8888 Invalid buffer handle
[14:32:55] [PASSED] No pixel format
[14:32:55] [PASSED] ABGR8888 Width 0
[14:32:55] [PASSED] ABGR8888 Height 0
[14:32:55] [PASSED] ABGR8888 Out of bound height * pitch combination
[14:32:55] [PASSED] ABGR8888 Large buffer offset
[14:32:55] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[14:32:55] [PASSED] ABGR8888 Valid buffer modifier
[14:32:55] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[14:32:55] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[14:32:55] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[14:32:55] [PASSED] NV12 Normal sizes
[14:32:55] [PASSED] NV12 Max sizes
[14:32:55] [PASSED] NV12 Invalid pitch
[14:32:55] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[14:32:55] [PASSED] NV12 different modifier per-plane
[14:32:55] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[14:32:55] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[14:32:55] [PASSED] NV12 Modifier for inexistent plane
[14:32:55] [PASSED] NV12 Handle for inexistent plane
[14:32:55] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[14:32:55] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[14:32:55] [PASSED] YVU420 Normal sizes
[14:32:55] [PASSED] YVU420 Max sizes
[14:32:55] [PASSED] YVU420 Invalid pitch
[14:32:55] [PASSED] YVU420 Different pitches
[14:32:55] [PASSED] YVU420 Different buffer offsets/pitches
[14:32:55] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[14:32:55] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[14:32:55] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[14:32:55] [PASSED] YVU420 Valid modifier
[14:32:55] [PASSED] YVU420 Different modifiers per plane
[14:32:55] [PASSED] YVU420 Modifier for inexistent plane
[14:32:55] [PASSED] X0L2 Normal sizes
[14:32:55] [PASSED] X0L2 Max sizes
[14:32:55] [PASSED] X0L2 Invalid pitch
[14:32:55] [PASSED] X0L2 Pitch greater than minimum required
[14:32:55] [PASSED] X0L2 Handle for inexistent plane
[14:32:55] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[14:32:55] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[14:32:55] [PASSED] X0L2 Valid modifier
[14:32:55] [PASSED] X0L2 Modifier for inexistent plane
[14:32:55] =========== [PASSED] drm_test_framebuffer_create ===========
[14:32:55] ================= [PASSED] drm_framebuffer =================
[14:32:55] ==================== drm-test-managed =====================
[14:32:55] [PASSED] drm_test_managed_run_action
[14:32:55] ================ [PASSED] drm-test-managed =================
[14:32:55] ========================= drm_mm ==========================
[14:32:55] [PASSED] drm_test_mm_init
[14:32:55] [PASSED] drm_test_mm_debug
[14:33:05] [PASSED] drm_test_mm_reserve
[14:33:15] [PASSED] drm_test_mm_insert
[14:33:16] [PASSED] drm_test_mm_replace
[14:33:16] [PASSED] drm_test_mm_insert_range
[14:33:16] [PASSED] drm_test_mm_frag
[14:33:16] [PASSED] drm_test_mm_align
[14:33:16] [PASSED] drm_test_mm_align32
[14:33:17] [PASSED] drm_test_mm_align64
[14:33:17] [PASSED] drm_test_mm_evict
[14:33:17] [PASSED] drm_test_mm_evict_range
[14:33:17] [PASSED] drm_test_mm_topdown
[14:33:17] [PASSED] drm_test_mm_bottomup
[14:33:17] [PASSED] drm_test_mm_lowest
[14:33:17] [PASSED] drm_test_mm_highest
[14:33:18] [PASSED] drm_test_mm_color
[14:33:18] [PASSED] drm_test_mm_color_evict
[14:33:18] [PASSED] drm_test_mm_color_evict_range
[14:33:18] ===================== [PASSED] drm_mm ======================
[14:33:18] =================== drm_modes_analog_tv ===================
[14:33:18] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[14:33:18] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[14:33:18] [PASSED] drm_test_modes_analog_tv_pal_576i
[14:33:18] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[14:33:18] =============== [PASSED] drm_modes_analog_tv ===============
[14:33:18] ==================== drm_plane_helper =====================
[14:33:18] =============== drm_test_check_plane_state ================
[14:33:18] [PASSED] clipping_simple
[14:33:18] [PASSED] clipping_rotate_reflect
[14:33:18] [PASSED] positioning_simple
[14:33:18] [PASSED] upscaling
[14:33:18] [PASSED] downscaling
[14:33:18] [PASSED] rounding1
[14:33:18] [PASSED] rounding2
[14:33:18] [PASSED] rounding3
[14:33:18] [PASSED] rounding4
[14:33:18] =========== [PASSED] drm_test_check_plane_state ============
[14:33:18] =========== drm_test_check_invalid_plane_state ============
[14:33:18] [PASSED] positioning_invalid
[14:33:18] [PASSED] upscaling_invalid
[14:33:18] [PASSED] downscaling_invalid
[14:33:18] ======= [PASSED] drm_test_check_invalid_plane_state ========
[14:33:18] ================ [PASSED] drm_plane_helper =================
[14:33:18] ============ drm_connector_helper_tv_get_modes ============
[14:33:18] ====== drm_test_connector_helper_tv_get_modes_check =======
[14:33:18] [PASSED] None
[14:33:18] [PASSED] PAL
[14:33:18] [PASSED] NTSC
[14:33:18] [PASSED] Both, NTSC Default
[14:33:18] [PASSED] Both, PAL Default
[14:33:18] [PASSED] Both, NTSC Default, with PAL on command-line
[14:33:18] [PASSED] Both, PAL Default, with NTSC on command-line
[14:33:18] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[14:33:18] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[14:33:18] ======================== drm_rect =========================
[14:33:18] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[14:33:18] [PASSED] drm_test_rect_clip_scaled_not_clipped
[14:33:18] [PASSED] drm_test_rect_clip_scaled_clipped
[14:33:18] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[14:33:18] ================= drm_test_rect_intersect =================
[14:33:18] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[14:33:18] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[14:33:18] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[14:33:18] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[14:33:18] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[14:33:18] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[14:33:18] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[14:33:18] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[14:33:18] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[14:33:18] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[14:33:18] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[14:33:18] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[14:33:18] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[14:33:18] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[14:33:18] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[14:33:18] ============= [PASSED] drm_test_rect_intersect =============
[14:33:18] ================ drm_test_rect_calc_hscale ================
[14:33:18] [PASSED] normal use
[14:33:18] [PASSED] out of max range
[14:33:18] [PASSED] out of min range
[14:33:18] [PASSED] zero dst
[14:33:18] [PASSED] negative src
[14:33:18] [PASSED] negative dst
[14:33:18] ============ [PASSED] drm_test_rect_calc_hscale ============
[14:33:18] ================ drm_test_rect_calc_vscale ================
[14:33:18] [PASSED] normal use
[14:33:18] [PASSED] out of max range
[14:33:18] [PASSED] out of min range
[14:33:18] [PASSED] zero dst
[14:33:18] [PASSED] negative src
[14:33:18] [PASSED] negative dst
[14:33:18] ============ [PASSED] drm_test_rect_calc_vscale ============
[14:33:18] ================== drm_test_rect_rotate ===================
[14:33:18] [PASSED] reflect-x
[14:33:18] [PASSED] reflect-y
[14:33:18] [PASSED] rotate-0
[14:33:18] [PASSED] rotate-90
[14:33:18] [PASSED] rotate-180
[14:33:18] [PASSED] rotate-270
[14:33:18] ============== [PASSED] drm_test_rect_rotate ===============
[14:33:18] ================ drm_test_rect_rotate_inv =================
[14:33:18] [PASSED] reflect-x
[14:33:18] [PASSED] reflect-y
[14:33:18] [PASSED] rotate-0
[14:33:18] [PASSED] rotate-90
[14:33:18] [PASSED] rotate-180
[14:33:18] [PASSED] rotate-270
[14:33:18] ============ [PASSED] drm_test_rect_rotate_inv =============
stty: 'standard input': Inappropriate ioctl for device
[14:33:18] ==================== [PASSED] drm_rect =====================
[14:33:18] ======================== drm_exec =========================
[14:33:18] [PASSED] sanitycheck
[14:33:18] [PASSED] test_lock
[14:33:18] [PASSED] test_lock_unlock
[14:33:18] [PASSED] test_duplicates
[14:33:18] [PASSED] test_prepare
[14:33:18] [PASSED] test_prepare_array
[14:33:18] [PASSED] test_multiple_loops
[14:33:18] ==================== [PASSED] drm_exec =====================
[14:33:18] ============================================================
[14:33:18] Testing complete. Ran 368 tests: passed: 368
[14:33:18] Elapsed time: 44.555s total, 1.685s configuring, 19.432s building, 23.410s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-xe] ✓ CI.BAT: success for drm/xe: Cleanup for addressing vga decode
2023-10-05 13:59 [Intel-xe] [PATCH 0/3] drm/xe: Cleanup for addressing vga decode Uma Shankar
` (5 preceding siblings ...)
2023-10-05 14:33 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
@ 2023-10-05 15:19 ` Patchwork
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-10-05 15:19 UTC (permalink / raw)
To: Uma Shankar; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 2761 bytes --]
== Series Details ==
Series: drm/xe: Cleanup for addressing vga decode
URL : https://patchwork.freedesktop.org/series/124660/
State : success
== Summary ==
CI Bug Log - changes from xe-415-3d2b298aaf52e74d4e90470cd65de047362e4875_BAT -> xe-pw-124660v1_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in xe-pw-124660v1_BAT that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- bat-adlp-7: [PASS][1] -> [FAIL][2] ([Intel XE#480])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-415-3d2b298aaf52e74d4e90470cd65de047362e4875/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-124660v1/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1:
- bat-adlp-7: [FAIL][3] ([Intel XE#480]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-415-3d2b298aaf52e74d4e90470cd65de047362e4875/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-124660v1/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html
* igt@xe_exec_store@basic-store:
- bat-adlp-7: [FAIL][5] ([Intel XE#761]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-415-3d2b298aaf52e74d4e90470cd65de047362e4875/bat-adlp-7/igt@xe_exec_store@basic-store.html
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-124660v1/bat-adlp-7/igt@xe_exec_store@basic-store.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
[Intel XE#524]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/524
[Intel XE#761]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/761
Build changes
-------------
* IGT: IGT_7512 -> IGT_7516
* Linux: xe-415-3d2b298aaf52e74d4e90470cd65de047362e4875 -> xe-pw-124660v1
IGT_7512: 2eb58faf82d3cd5e2e74154a7319cff56eb40762 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_7516: 40b5a184f6da0a3295ee429947696d254522bb22 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-415-3d2b298aaf52e74d4e90470cd65de047362e4875: 3d2b298aaf52e74d4e90470cd65de047362e4875
xe-pw-124660v1: 124660v1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-124660v1/index.html
[-- Attachment #2: Type: text/html, Size: 3409 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-xe] [PATCH 1/3] Revert "FIXME: drm/i915/vga: disable vga set decode for xe"
2023-10-05 13:59 ` [Intel-xe] [PATCH 1/3] Revert "FIXME: drm/i915/vga: disable vga set decode for xe" Uma Shankar
@ 2023-10-06 3:20 ` Murthy, Arun R
0 siblings, 0 replies; 12+ messages in thread
From: Murthy, Arun R @ 2023-10-06 3:20 UTC (permalink / raw)
To: Shankar, Uma, intel-xe; +Cc: Nikula, Jani
> -----Original Message-----
> From: Shankar, Uma <uma.shankar@intel.com>
> Sent: Thursday, October 5, 2023 7:29 PM
> To: intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; Murthy, Arun R
> <arun.r.murthy@intel.com>; Shankar, Uma <uma.shankar@intel.com>
> Subject: [PATCH 1/3] Revert "FIXME: drm/i915/vga: disable vga set decode for
> xe"
>
> This reverts commit 28da6179478e3f29cb27df30b71f68b904dfff26.
>
> This will be addressed with an exclusive version for xe.
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Thanks and Regards,
Arun R Murthy
--------------------
> drivers/gpu/drm/i915/display/intel_vga.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vga.c
> b/drivers/gpu/drm/i915/display/intel_vga.c
> index 42da1a038042..286a0bdd28c6 100644
> --- a/drivers/gpu/drm/i915/display/intel_vga.c
> +++ b/drivers/gpu/drm/i915/display/intel_vga.c
> @@ -102,7 +102,6 @@ void intel_vga_reset_io_mem(struct drm_i915_private
> *i915) static unsigned int intel_vga_set_decode(struct pci_dev *pdev, bool
> enable_decode) { -#ifdef I915
> struct drm_i915_private *i915 = pdev_to_i915(pdev);
>
> intel_gmch_vga_set_state(i915, enable_decode); @@ -112,9 +111,6
> @@ intel_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
> VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
> else
> return VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM; -
> #else
> - return -EIO;
> -#endif
> }
>
> int intel_vga_register(struct drm_i915_private *i915)
> --
> 2.42.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-xe] [PATCH 2/3] drm/i915/display: Created exclusive version of vga decode setup
2023-10-05 13:59 ` [Intel-xe] [PATCH 2/3] drm/i915/display: Created exclusive version of vga decode setup Uma Shankar
@ 2023-10-06 3:21 ` Murthy, Arun R
0 siblings, 0 replies; 12+ messages in thread
From: Murthy, Arun R @ 2023-10-06 3:21 UTC (permalink / raw)
To: Shankar, Uma, intel-xe; +Cc: Nikula, Jani
> -----Original Message-----
> From: Shankar, Uma <uma.shankar@intel.com>
> Sent: Thursday, October 5, 2023 7:29 PM
> To: intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; Murthy, Arun R
> <arun.r.murthy@intel.com>; Shankar, Uma <uma.shankar@intel.com>
> Subject: [PATCH 2/3] drm/i915/display: Created exclusive version of vga decode
> setup
>
> Current vga arbiter implementation in i915 needs a re-design.
> The current approach would cause real problems if anyone actually needs to
> talk another GPU using legacy VGA resources.
>
> The main issue is that X becomes a slideshow if it thinks there are multiple
> GPUs that have VGA decoding enabled as it insists on adjusting the VGA routing
> pretty much for every little operation involving any of the GPUs.
>
> The cleanup will be planned for i915. Meanwhile to focus on Xe upstreaming
> and have a cleaner separation, the said functionality is being moved to a
> different file exclusive for i915. Xe driver will re-use rest of the display code
> from i915.
>
> v2: Addressed Jani Nikula's review comments.
>
> v3: Dropped a duplicate function (Jani)
>
> v4: Updated commit message with reasoning as sugested by Ville.
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
> Link:
> https://patchwork.freedesktop.org/patch/msgid/20230929074306.1533859-1-
> uma.shankar@intel.com
> (cherry picked from commit 5846cdfd3d58852cdc991e589de7535151a47a4e)
> ---
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Thanks and Regards,
Arun R Murthy
--------------------
> drivers/gpu/drm/i915/display/intel_vga.c | 18 +-----------------
> drivers/gpu/drm/i915/soc/intel_gmch.c | 14 ++++++++++++++
> drivers/gpu/drm/i915/soc/intel_gmch.h | 2 ++
> 3 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vga.c
> b/drivers/gpu/drm/i915/display/intel_vga.c
> index 286a0bdd28c6..4b98833bfa8c 100644
> --- a/drivers/gpu/drm/i915/display/intel_vga.c
> +++ b/drivers/gpu/drm/i915/display/intel_vga.c
> @@ -3,11 +3,9 @@
> * Copyright © 2019 Intel Corporation
> */
>
> -#include <linux/pci.h>
> #include <linux/vgaarb.h>
>
> #include <video/vga.h>
> -
> #include "soc/intel_gmch.h"
>
> #include "i915_drv.h"
> @@ -99,20 +97,6 @@ void intel_vga_reset_io_mem(struct drm_i915_private
> *i915)
> vga_put(pdev, VGA_RSRC_LEGACY_IO);
> }
>
> -static unsigned int
> -intel_vga_set_decode(struct pci_dev *pdev, bool enable_decode) -{
> - struct drm_i915_private *i915 = pdev_to_i915(pdev);
> -
> - intel_gmch_vga_set_state(i915, enable_decode);
> -
> - if (enable_decode)
> - return VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM |
> - VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
> - else
> - return VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
> -}
> -
> int intel_vga_register(struct drm_i915_private *i915) {
>
> @@ -127,7 +111,7 @@ int intel_vga_register(struct drm_i915_private *i915)
> * then we do not take part in VGA arbitration and the
> * vga_client_register() fails with -ENODEV.
> */
> - ret = vga_client_register(pdev, intel_vga_set_decode);
> + ret = vga_client_register(pdev, intel_gmch_vga_set_decode);
> if (ret && ret != -ENODEV)
> return ret;
>
> diff --git a/drivers/gpu/drm/i915/soc/intel_gmch.c
> b/drivers/gpu/drm/i915/soc/intel_gmch.c
> index 49c7fb16e934..f32e9f78770a 100644
> --- a/drivers/gpu/drm/i915/soc/intel_gmch.c
> +++ b/drivers/gpu/drm/i915/soc/intel_gmch.c
> @@ -5,6 +5,7 @@
>
> #include <linux/pci.h>
> #include <linux/pnp.h>
> +#include <linux/vgaarb.h>
>
> #include <drm/drm_managed.h>
> #include <drm/i915_drm.h>
> @@ -167,3 +168,16 @@ int intel_gmch_vga_set_state(struct
> drm_i915_private *i915, bool enable_decode)
>
> return 0;
> }
> +
> +unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool
> +enable_decode) {
> + struct drm_i915_private *i915 = pdev_to_i915(pdev);
> +
> + intel_gmch_vga_set_state(i915, enable_decode);
> +
> + if (enable_decode)
> + return VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM |
> + VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM;
> + else
> + return VGA_RSRC_NORMAL_IO | VGA_RSRC_NORMAL_MEM; }
> diff --git a/drivers/gpu/drm/i915/soc/intel_gmch.h
> b/drivers/gpu/drm/i915/soc/intel_gmch.h
> index d0133eedc720..23be2d113afd 100644
> --- a/drivers/gpu/drm/i915/soc/intel_gmch.h
> +++ b/drivers/gpu/drm/i915/soc/intel_gmch.h
> @@ -8,11 +8,13 @@
>
> #include <linux/types.h>
>
> +struct pci_dev;
> struct drm_i915_private;
>
> int intel_gmch_bridge_setup(struct drm_i915_private *i915); void
> intel_gmch_bar_setup(struct drm_i915_private *i915); void
> intel_gmch_bar_teardown(struct drm_i915_private *i915); int
> intel_gmch_vga_set_state(struct drm_i915_private *i915, bool enable_decode);
> +unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool
> +enable_decode);
>
> #endif /* __INTEL_GMCH_H__ */
> --
> 2.42.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-xe] [PATCH 3/3] drm/xe: Create a dummy version for vga decode
2023-10-05 13:59 ` [Intel-xe] [PATCH 3/3] drm/xe: Create a dummy version for vga decode Uma Shankar
@ 2023-10-06 3:26 ` Murthy, Arun R
2023-10-06 10:21 ` Shankar, Uma
0 siblings, 1 reply; 12+ messages in thread
From: Murthy, Arun R @ 2023-10-06 3:26 UTC (permalink / raw)
To: Shankar, Uma, intel-xe; +Cc: Nikula, Jani
> -----Original Message-----
> From: Shankar, Uma <uma.shankar@intel.com>
> Sent: Thursday, October 5, 2023 7:29 PM
> To: intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; Murthy, Arun R
> <arun.r.murthy@intel.com>; Shankar, Uma <uma.shankar@intel.com>
> Subject: [PATCH 3/3] drm/xe: Create a dummy version for vga decode
>
> This implements an exclusive version of vga decode for xe.
> Rest of the display changes will be re-used from i915.
Implementation I yet to come in the follow up patches. Here we are just adding the function definitions.
>
> Currently it adds just a dummy implementation. VGA decode needs to be
> handled correctly in i915, proper implementation will be adopted once the i915
> changes are finalized and merged upstream.
Merged in upstream.
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
> drivers/gpu/drm/xe/Makefile | 1 +
> drivers/gpu/drm/xe/display/xe_display_misc.c | 13 +++++++++++++
> 2 files changed, 14 insertions(+)
> create mode 100644 drivers/gpu/drm/xe/display/xe_display_misc.c
>
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile index
> dff1386ee6b3..175a357366d9 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -150,6 +150,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
> display/xe_hdcp_gsc.o \
> display/xe_plane_initial.o \
> display/xe_display_rps.o \
> + display/xe_display_misc.o \
> display/ext/i915_irq.o \
> display/ext/i915_utils.o
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c
> b/drivers/gpu/drm/xe/display/xe_display_misc.c
> new file mode 100644
> index 000000000000..4f2392f911ce
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
> @@ -0,0 +1,13 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2023 Intel Corporation
> + */
> +
> +#include "intel_display_types.h"
> +
> +struct pci_dev;
> +
> +unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool
> +enable_decode) {
Is a TODO: required over here?
> + return 0;
> +}
> --
> 2.42.0
Thanks and Regards,
Arun R Murthy
--------------------
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-xe] [PATCH 3/3] drm/xe: Create a dummy version for vga decode
2023-10-06 3:26 ` Murthy, Arun R
@ 2023-10-06 10:21 ` Shankar, Uma
0 siblings, 0 replies; 12+ messages in thread
From: Shankar, Uma @ 2023-10-06 10:21 UTC (permalink / raw)
To: Murthy, Arun R, intel-xe; +Cc: Nikula, Jani
> -----Original Message-----
> From: Murthy, Arun R <arun.r.murthy@intel.com>
> Sent: Friday, October 6, 2023 8:57 AM
> To: Shankar, Uma <uma.shankar@intel.com>; intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>
> Subject: RE: [PATCH 3/3] drm/xe: Create a dummy version for vga decode
>
>
> > -----Original Message-----
> > From: Shankar, Uma <uma.shankar@intel.com>
> > Sent: Thursday, October 5, 2023 7:29 PM
> > To: intel-xe@lists.freedesktop.org
> > Cc: Nikula, Jani <jani.nikula@intel.com>; Murthy, Arun R
> > <arun.r.murthy@intel.com>; Shankar, Uma <uma.shankar@intel.com>
> > Subject: [PATCH 3/3] drm/xe: Create a dummy version for vga decode
> >
> > This implements an exclusive version of vga decode for xe.
> > Rest of the display changes will be re-used from i915.
> Implementation I yet to come in the follow up patches. Here we are just adding
> the function definitions.
Yeah, will re-phrase this.
> >
> > Currently it adds just a dummy implementation. VGA decode needs to be
> > handled correctly in i915, proper implementation will be adopted once
> > the i915 changes are finalized and merged upstream.
> Merged in upstream.
Sure, will correct it.
> >
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > ---
> > drivers/gpu/drm/xe/Makefile | 1 +
> > drivers/gpu/drm/xe/display/xe_display_misc.c | 13 +++++++++++++
> > 2 files changed, 14 insertions(+)
> > create mode 100644 drivers/gpu/drm/xe/display/xe_display_misc.c
> >
> > diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> > index
> > dff1386ee6b3..175a357366d9 100644
> > --- a/drivers/gpu/drm/xe/Makefile
> > +++ b/drivers/gpu/drm/xe/Makefile
> > @@ -150,6 +150,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
> > display/xe_hdcp_gsc.o \
> > display/xe_plane_initial.o \
> > display/xe_display_rps.o \
> > + display/xe_display_misc.o \
> > display/ext/i915_irq.o \
> > display/ext/i915_utils.o
> >
> > diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c
> > b/drivers/gpu/drm/xe/display/xe_display_misc.c
> > new file mode 100644
> > index 000000000000..4f2392f911ce
> > --- /dev/null
> > +++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
> > @@ -0,0 +1,13 @@
> > +// SPDX-License-Identifier: MIT
> > +/*
> > + * Copyright © 2023 Intel Corporation */
> > +
> > +#include "intel_display_types.h"
> > +
> > +struct pci_dev;
> > +
> > +unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool
> > +enable_decode) {
> Is a TODO: required over here?
Yes, will add it.
Thanks Arun for the feedback and reviews, will modify and send next version.
Regards,
Uma Shankar
> > + return 0;
> > +}
> > --
> > 2.42.0
>
> Thanks and Regards,
> Arun R Murthy
> --------------------
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-10-06 10:21 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-05 13:59 [Intel-xe] [PATCH 0/3] drm/xe: Cleanup for addressing vga decode Uma Shankar
2023-10-05 13:59 ` [Intel-xe] [PATCH 1/3] Revert "FIXME: drm/i915/vga: disable vga set decode for xe" Uma Shankar
2023-10-06 3:20 ` Murthy, Arun R
2023-10-05 13:59 ` [Intel-xe] [PATCH 2/3] drm/i915/display: Created exclusive version of vga decode setup Uma Shankar
2023-10-06 3:21 ` Murthy, Arun R
2023-10-05 13:59 ` [Intel-xe] [PATCH 3/3] drm/xe: Create a dummy version for vga decode Uma Shankar
2023-10-06 3:26 ` Murthy, Arun R
2023-10-06 10:21 ` Shankar, Uma
2023-10-05 14:31 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Cleanup for addressing " Patchwork
2023-10-05 14:32 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-10-05 14:33 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-05 15:19 ` [Intel-xe] ✓ CI.BAT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.