All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bhandare, KiranX" <kiranx.bhandare@intel.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Cc: "Mathew, Elza" <elza.mathew@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"Karlsson, Magnus" <magnus.karlsson@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH v2 intel-net 6/6] ice: xsk: fix cleaned_count setting
Date: Fri, 17 Dec 2021 15:23:42 +0000	[thread overview]
Message-ID: <DM6PR11MB32924BE7BB15755573E2BE80F1789@DM6PR11MB3292.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211213153111.110877-7-maciej.fijalkowski@intel.com>


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Maciej Fijalkowski
> Sent: Monday, December 13, 2021 9:01 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Mathew, Elza <elza.mathew@intel.com>; netdev@vger.kernel.org;
> kuba@kernel.org; bpf@vger.kernel.org; davem@davemloft.net; Karlsson,
> Magnus <magnus.karlsson@intel.com>
> Subject: [Intel-wired-lan] [PATCH v2 intel-net 6/6] ice: xsk: fix cleaned_count
> setting
> 
> Currently cleaned_count is initialized to ICE_DESC_UNUSED(rx_ring) and later
> on during the Rx processing it is incremented per each frame that driver
> consumed. This can result in excessive buffers requested from xsk pool
> based on that value.
> 
> To address this, just drop cleaned_count and pass
> ICE_DESC_UNUSED(rx_ring) directly as a function argument to
> ice_alloc_rx_bufs_zc(). Idea is to ask for buffers as many as consumed.
> 
> Let us also call ice_alloc_rx_bufs_zc unconditionally at the end of
> ice_clean_rx_irq_zc. This has been changed in that way for corresponding
> ice_clean_rx_irq, but not here.
> 
> Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.h | 1 -
> drivers/net/ethernet/intel/ice/ice_xsk.c  | 6 +-----
>  2 files changed, 1 insertion(+), 6 deletions(-)
> 

Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>  A Contingent Worker at Intel

WARNING: multiple messages have this Message-ID (diff)
From: Bhandare, KiranX <kiranx.bhandare@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 intel-net 6/6] ice: xsk: fix cleaned_count setting
Date: Fri, 17 Dec 2021 15:23:42 +0000	[thread overview]
Message-ID: <DM6PR11MB32924BE7BB15755573E2BE80F1789@DM6PR11MB3292.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211213153111.110877-7-maciej.fijalkowski@intel.com>


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Maciej Fijalkowski
> Sent: Monday, December 13, 2021 9:01 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Mathew, Elza <elza.mathew@intel.com>; netdev at vger.kernel.org;
> kuba at kernel.org; bpf at vger.kernel.org; davem at davemloft.net; Karlsson,
> Magnus <magnus.karlsson@intel.com>
> Subject: [Intel-wired-lan] [PATCH v2 intel-net 6/6] ice: xsk: fix cleaned_count
> setting
> 
> Currently cleaned_count is initialized to ICE_DESC_UNUSED(rx_ring) and later
> on during the Rx processing it is incremented per each frame that driver
> consumed. This can result in excessive buffers requested from xsk pool
> based on that value.
> 
> To address this, just drop cleaned_count and pass
> ICE_DESC_UNUSED(rx_ring) directly as a function argument to
> ice_alloc_rx_bufs_zc(). Idea is to ask for buffers as many as consumed.
> 
> Let us also call ice_alloc_rx_bufs_zc unconditionally at the end of
> ice_clean_rx_irq_zc. This has been changed in that way for corresponding
> ice_clean_rx_irq, but not here.
> 
> Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.h | 1 -
> drivers/net/ethernet/intel/ice/ice_xsk.c  | 6 +-----
>  2 files changed, 1 insertion(+), 6 deletions(-)
> 

Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>  A Contingent Worker at Intel

  reply	other threads:[~2021-12-17 15:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 15:31 [PATCH v2 intel-net 0/6] ice: xsk: Rx processing fixes Maciej Fijalkowski
2021-12-13 15:31 ` [Intel-wired-lan] " Maciej Fijalkowski
2021-12-13 15:31 ` [PATCH v2 intel-net 1/6] ice: xsk: return xsk buffers back to pool when cleaning the ring Maciej Fijalkowski
2021-12-13 15:31   ` [Intel-wired-lan] " Maciej Fijalkowski
2021-12-17 15:24   ` Bhandare, KiranX
2021-12-17 15:24     ` Bhandare, KiranX
2021-12-13 15:31 ` [PATCH v2 intel-net 2/6] ice: xsk: allocate separate memory for XDP SW ring Maciej Fijalkowski
2021-12-13 15:31   ` [Intel-wired-lan] " Maciej Fijalkowski
2021-12-17 15:24   ` Bhandare, KiranX
2021-12-17 15:24     ` Bhandare, KiranX
2021-12-13 15:31 ` [PATCH v2 intel-net 3/6] ice: remove dead store on XSK hotpath Maciej Fijalkowski
2021-12-13 15:31   ` [Intel-wired-lan] " Maciej Fijalkowski
2021-12-17 15:24   ` Bhandare, KiranX
2021-12-17 15:24     ` Bhandare, KiranX
2021-12-13 15:31 ` [PATCH v2 intel-net 4/6] ice: xsk: do not clear status_error0 for ntu + nb_buffs descriptor Maciej Fijalkowski
2021-12-13 15:31   ` [Intel-wired-lan] " Maciej Fijalkowski
2021-12-17 15:23   ` Bhandare, KiranX
2021-12-17 15:23     ` Bhandare, KiranX
2021-12-13 15:31 ` [PATCH v2 intel-net 5/6] ice: xsk: allow empty Rx descriptors on XSK ZC data path Maciej Fijalkowski
2021-12-13 15:31   ` [Intel-wired-lan] " Maciej Fijalkowski
2021-12-17 15:23   ` Bhandare, KiranX
2021-12-17 15:23     ` Bhandare, KiranX
2021-12-13 15:31 ` [PATCH v2 intel-net 6/6] ice: xsk: fix cleaned_count setting Maciej Fijalkowski
2021-12-13 15:31   ` [Intel-wired-lan] " Maciej Fijalkowski
2021-12-17 15:23   ` Bhandare, KiranX [this message]
2021-12-17 15:23     ` Bhandare, KiranX
2021-12-14 14:46 ` [Intel-wired-lan] [PATCH v2 intel-net 0/6] ice: xsk: Rx processing fixes Magnus Karlsson
2021-12-14 14:46   ` Magnus Karlsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB32924BE7BB15755573E2BE80F1789@DM6PR11MB3292.namprd11.prod.outlook.com \
    --to=kiranx.bhandare@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=elza.mathew@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.